bankocr 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 722d178bd4372da2e4cec0c87c005a617b396bb0
-  data.tar.gz: eb2ed4d90d0837e247f1fc5eef8b256eecf4356d
+  metadata.gz: 88a16391bafc7e1f8c59f0d1490d5ec75ddadb1a
+  data.tar.gz: 9cd73c8055978b7732ca36a0700077536ab03424
 SHA512:
-  metadata.gz: 1daa5a1d719c3a28941013a1185d6c76f1ef737afeee208705c3b83f539c8a9473f80f7e6dbe7bf7aa8812b6de4a512d7ccd5d70bec36119e267cabdaf345c59
-  data.tar.gz: a106a880bb7cf204ba731794be2295c936f1a4380809049bb7a65db2433d4421d6c78dbb7d4e614c405fcbf0ffacc8e1540a80730add2ae97ba2df1ca1138bcc
+  metadata.gz: ed392b2fce5cf57bea88fc1a57348d6743f793523685e7faabd6e7976fb1d5efc036c9c14bad397e07a80d1f367323cf860fcd2821914d2a33bbb4b7496a2e98
+  data.tar.gz: 41b514e56b802f7192291033b577e58a00697f57008ed44f16fe1777c23b28e7f1c9547e27713ec4fb0479a353916381d03f71305802d40bb3548bddaae4af75

data/Gemfile.lock

@@ -1,7 +1,8 @@
 PATH
   remote: .
   specs:
-    bankocr (0.0.1)
+    bankocr (0.0.3)
+      thor (~> 0.19)
 
 GEM
   remote: https://rubygems.org/
@@ -19,6 +20,7 @@ GEM
     rspec-mocks (3.0.2)
       rspec-support (~> 3.0.0)
     rspec-support (3.0.2)
+    thor (0.19.1)
 
 PLATFORMS
   ruby

data/README.md

@@ -15,7 +15,7 @@ Use the following commands:
 
 ```
 gem install backocr
-bankocr ./bin/input.in ./bin/output
+bankocr process ./bin/input.in ./bin/output
 ```
 
 * It will generate a file under /bin directory with results

data/bankocr.gemspec

@@ -20,4 +20,6 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 1.6'
   spec.add_development_dependency 'rspec', '~> 3.0'
+
+  spec.add_runtime_dependency 'thor', '~> 0.19'
 end

data/bin/bankocr

@@ -1,7 +1,22 @@
 #!/usr/bin/env ruby
 
+require 'thor'
 require 'bankocr'
 
-BankOCR.process(ARGV[0], ARGV[1])
+module BankOCR
+  class ProcessCommand < Thor
+    desc 'process input_path output_path',
+      'Generates a report for account numbers read from input'
 
-p 'OCR accounts report generated succesfully'
+    def process(input, output)
+      begin
+        BankOCR.process(input, output)
+        p 'OCR accounts report generated succesfully'
+      rescue Exception => ex
+        p ex.message
+      end
+    end
+  end
+end
+
+BankOCR::ProcessCommand.start

data/lib/bankocr/version.rb

@@ -1,3 +1,3 @@
 module BankOCR
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/lib/file_parser.rb

@@ -16,7 +16,7 @@ module BankOCR
 
       @entries
     rescue
-      []
+      raise 'Error reading input file, please validate'
     ensure
       file.close if file
     end

data/spec/lib/account_number_spec.rb

@@ -8,10 +8,6 @@ describe BankOCR::AccountNumber do
     let(:invalid_numbers) { %w(888888888 490067715 012345678) }
     let(:wrong_numbers)   { %w(86110?356) }
 
-    let(:wrong_accounts) do
-      [{ account_number: '86110??36', valid: false, message: 'ILL' }]
-    end
-
     it 'validates valid account numbers' do
       valid_numbers.each do |n|
         account = described_class.new(n)

data/spec/lib/file_parser_spec.rb

@@ -20,7 +20,7 @@ describe BankOCR::FileParser do
     it 'returns empty account_numbers if error reading file' do
       parser = described_class.new('invalid_path')
 
-      expect(parser.entries).to eq([])
+      expect{parser.entries}.to raise_error('Error reading input file, please validate')
     end
 
   end

data/spec/lib/report_generator_spec.rb

@@ -35,4 +35,5 @@ describe BankOCR::ReportGenerator do
 
     expect(generated_content).to eq(expected_content)
   end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bankocr
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Javier Cervantes
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: thor
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.19'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.19'
 description: '["Solution", "in", "ruby", "of", "BankOCR", "Kata:", "http://code.joejag.com/coding-dojo-bank-ocr/"]'
 email:
 - 1.27201@gmail.com