bankocr 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 51e9f6ed181fb6340334fb1d1aab02b63fef8ba1
-  data.tar.gz: 63b85e8d8dc37b40d8ff16bfde34cf6457276854
+  metadata.gz: 722d178bd4372da2e4cec0c87c005a617b396bb0
+  data.tar.gz: eb2ed4d90d0837e247f1fc5eef8b256eecf4356d
 SHA512:
-  metadata.gz: 52eb966fadec59720b6d2474dbffc5be72a784d4cdc701fbe62c45f1df28bc8f7c7336002f2d710b993d309b77d8b7035e1345e79995995792d5cf0644f147b4
-  data.tar.gz: 29b79b21203e50fce61e8c297efac31ae5c87868b03f45138358539c4578a84f7bd2ddb4d356631be1ffb003acc1819bd0c60381cdac25991a78bbe6e10b8f2d
+  metadata.gz: 1daa5a1d719c3a28941013a1185d6c76f1ef737afeee208705c3b83f539c8a9473f80f7e6dbe7bf7aa8812b6de4a512d7ccd5d70bec36119e267cabdaf345c59
+  data.tar.gz: a106a880bb7cf204ba731794be2295c936f1a4380809049bb7a65db2433d4421d6c78dbb7d4e614c405fcbf0ffacc8e1540a80730add2ae97ba2df1ca1138bcc

data/Gemfile

@@ -1,3 +1,3 @@
 source 'https://rubygems.org'
 
-gem 'rspec', '~> 3.0.0'
+gemspec

data/Gemfile.lock

@@ -1,3 +1,8 @@
+PATH
+  remote: .
+  specs:
+    bankocr (0.0.1)
+
 GEM
   remote: https://rubygems.org/
   specs:
@@ -19,4 +24,6 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  rspec (~> 3.0.0)
+  bankocr!
+  bundler (~> 1.6)
+  rspec (~> 3.0)

data/bankocr.gemspec

@@ -4,20 +4,20 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'bankocr/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "bankocr"
+  spec.name          = 'bankocr'
   spec.version       = BankOCR::VERSION
-  spec.authors       = ["Javier Cervantes"]
-  spec.email         = ["javier@hybridgroup.com"]
-  spec.summary       = %q{Solution to BankOCR Kata}
-  spec.description   = %q{Solution in ruby of BankOCR Kata: http://code.joejag.com/coding-dojo-bank-ocr/}
-  spec.homepage      = "https://github.com/solojavier/bankOCR"
-  spec.license       = "MIT"
+  spec.authors       = ['Javier Cervantes']
+  spec.email         = ['1.27201@gmail.com']
+  spec.summary       = %w(Solution to BankOCR Kata)
+  spec.description   = %w(Solution in ruby of BankOCR Kata: http://code.joejag.com/coding-dojo-bank-ocr/)
+  spec.homepage      = 'https://github.com/solojavier/bankOCR'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.executables   = ['bankocr']
+  spec.test_files    = spec.files.grep(/^(test|spec|features)/)
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency 'bundler', '~> 1.6'
+  spec.add_development_dependency 'rspec', '~> 3.0'
 end

data/lib/account_number.rb

@@ -1,6 +1,6 @@
 module BankOCR
+  # Object representing an account number
   class AccountNumber
-
     attr_reader :error_message, :digits
 
     def initialize(digits)
@@ -26,6 +26,5 @@ module BankOCR
     def sum(account_number)
       (0..8).map { |i| account_number[i].to_i * (i + 2) }.reduce(:+)
     end
-
   end
 end

data/lib/bankocr.rb

@@ -1,5 +1,7 @@
-require "bankocr/version"
+require 'bankocr/version'
 
+# Module with logic to process a OCR input file
+# and export a report with account numbers
 module BankOCR
   autoload :FileParser,      'file_parser'
   autoload :AccountNumber,   'account_number'

data/lib/bankocr/version.rb

@@ -1,3 +1,3 @@
 module BankOCR
-  VERSION = "0.0.1"
+  VERSION = '0.0.2'
 end

data/lib/file_parser.rb

@@ -1,6 +1,6 @@
 module BankOCR
+  # Reads a file from OCR and converts to digits
   class FileParser
-
     def initialize(input_path)
       @input_path = input_path
     end
@@ -54,6 +54,5 @@ module BankOCR
         ' _ |_||_|' => '8',
         ' _ |_| _|' => '9' }
     end
-
   end
 end

data/lib/report_generator.rb

@@ -1,6 +1,6 @@
 module BankOCR
+  # Creates a text file with generated report
   class ReportGenerator
-
     def initialize(output_path, account_numbers)
       @output_path     = output_path
       @account_numbers = account_numbers
@@ -11,12 +11,11 @@ module BankOCR
 
       @account_numbers.each do |account|
         file.write account.digits
-        file.write " #{account.error_message}" if !account.valid?
+        file.write " #{account.error_message}" unless account.valid?
         file.write "\n"
       end
 
       file.close
     end
-
   end
 end

data/spec/bin/bankocr_spec.rb

@@ -12,7 +12,7 @@ describe 'Application execution' do
   end
 
   before do
-    File.delete(output) if File.exists?(output)
+    File.delete(output) if File.exist?(output)
   end
 
   it 'parses file and creates report', integration: true do

data/spec/lib/account_number_spec.rb

@@ -9,7 +9,7 @@ describe BankOCR::AccountNumber do
     let(:wrong_numbers)   { %w(86110?356) }
 
     let(:wrong_accounts) do
-      [ { account_number: '86110??36', valid: false, message: 'ILL' } ]
+      [{ account_number: '86110??36', valid: false, message: 'ILL' }]
     end
 
     it 'validates valid account numbers' do

data/spec/lib/report_generator_spec.rb

@@ -21,7 +21,7 @@ describe BankOCR::ReportGenerator do
   end
 
   before do
-    File.delete(output_path) if File.exists?(output_path)
+    File.delete(output_path) if File.exist?(output_path)
   end
 
   it 'creates empty file if accounts are not sent' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bankocr
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Javier Cervantes
@@ -38,12 +38,11 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-description: 'Solution in ruby of BankOCR Kata: http://code.joejag.com/coding-dojo-bank-ocr/'
+description: '["Solution", "in", "ruby", "of", "BankOCR", "Kata:", "http://code.joejag.com/coding-dojo-bank-ocr/"]'
 email:
-- javier@hybridgroup.com
+- 1.27201@gmail.com
 executables:
 - bankocr
-- input.in
 extensions: []
 extra_rdoc_files: []
 files:
@@ -91,7 +90,7 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: Solution to BankOCR Kata
+summary: '["Solution", "to", "BankOCR", "Kata"]'
 test_files:
 - spec/bin/bankocr_spec.rb
 - spec/bin/input.in