bankgiro_inbetalningar 1.0.0 → 1.1.0

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012 Your Name
+Copyright (c) 2012 PugglePay.com
 
 MIT License
 

data/README.md

@@ -24,6 +24,10 @@ Use the convenience method `BankgiroInbetalningar.parse` to parse a file:
 
 ```ruby
 res = BankgiroInbetalningar.parse('BgMaxfil4.txt')
+# Or
+data = File.read("BgMaxfil4.txt")
+res = BankgiroInbetalningar.parse_data(data)
+
 raise "oops" unless res.valid?
 # You can process deposit by deposit...
 res.deposits.each do |d|
@@ -62,3 +66,9 @@ I'll be happy to add them if you don't want to do it yourself.
 3. Commit your changes (`git commit -am 'Added some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+### Contributors:
+
+* [David Vrensk](https://github.com/dvrensk)
+* [Petter Remen](https://github.com/remen)
+* [Henrik Nyh](https://github.com/henrik)

data/Rakefile

@@ -1,2 +1,6 @@
 #!/usr/bin/env rake
 require "bundler/gem_tasks"
+
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec)
+task :default => :spec

data/bankgiro_inbetalningar.gemspec

@@ -3,10 +3,10 @@ require File.expand_path('../lib/bankgiro_inbetalningar/version', __FILE__)
 
 Gem::Specification.new do |gem|
   gem.authors       = ["David Vrensk"]
-  gem.email         = ["david@spnab.com"]
+  gem.email         = ["david@vrensk.com"]
   gem.description   = %q{Parse BgMax transaction files from Bankgirot and return a simple data structure}
-  gem.summary       = %q{Bankgirot has changes its file format, making the +rbankgiro+ gem unusable for new clients.}
-  gem.homepage      = "https://github.com/icehouse/bankgiro_inbetalningar"
+  gem.summary       = %q{Bankgirot has changed its file format, making the +rbankgiro+ gem unusable for new clients.}
+  gem.homepage      = "https://github.com/spnab/bankgiro_inbetalningar"
 
   gem.add_development_dependency "rspec", '~> 2.9.0'
 

data/lib/bankgiro_inbetalningar.rb

@@ -4,7 +4,12 @@ require "bankgiro_inbetalningar/parser"
 
 module BankgiroInbetalningar
   def self.parse(filename)
-    parser = Parser.new(filename)
+    data = File.read(filename)
+    parse_data(data)
+  end
+
+  def self.parse_data(data)
+    parser = Parser.new(data)
     parser.run
     parser.result
   end

data/lib/bankgiro_inbetalningar/parser.rb

@@ -4,32 +4,23 @@ module BankgiroInbetalningar
   class Parser
     attr_accessor :result
 
-    def initialize(filename)
-      @filename = filename
+    def initialize(data)
+      @raw_data ||= data.encode('utf-8', 'iso-8859-1')
     end
 
     def run
       @result = Result.new
       parse_lines
-    ensure
-      @stream.close if @stream
     end
 
     def parse_lines
-      while @line = next_line
+      @raw_data.each_line do |line|
+        @line = line
         parse_line
         record_line
       end
     end
 
-    def next_line
-      stream.eof? ? nil : stream.readline
-    end
-
-    def stream
-      @stream ||= File.open(@filename, 'r:ISO-8859-1:UTF-8')
-    end
-
     def parse_line
       if line_parser_class
         line_parser = line_parser_class.new(@line)
@@ -220,7 +211,7 @@ module BankgiroInbetalningar
     end
 
     def payments
-      deposits.map { |d| d.payments }.flatten
+      deposits.map(&:payments).flatten
     end
 
     class Deposit

data/lib/bankgiro_inbetalningar/version.rb

@@ -1,3 +1,3 @@
 module BankgiroInbetalningar
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/spec/bankgiro_inbetalningar/parser_spec.rb

@@ -4,7 +4,8 @@ require_relative '../spec_helper'
 module BankgiroInbetalningar
   describe Parser do
     context "parsing sample file 4" do
-      let(:parser) { Parser.new(fixture_path('BgMaxfil4.txt')) }
+      let(:data) { File.read(fixture_path('BgMaxfil4.txt')) }
+      let(:parser) { Parser.new(data) }
       let(:result) { parser.run ; parser.result }
 
       it "returns valid results" do
@@ -73,7 +74,8 @@ module BankgiroInbetalningar
 
     end
     context "parsing a broken sample file 4" do
-      let(:parser) { Parser.new(fixture_path('BgMaxfil4_broken.txt')) }
+      let(:data) { File.read(fixture_path('BgMaxfil4_broken.txt')) }
+      let(:parser) { Parser.new(data) }
       let(:result) { parser.run ; parser.result }
 
       it "returns invalid results" do

data/spec/bankgiro_inbetalningar_spec.rb

@@ -1,6 +1,6 @@
 require_relative 'spec_helper'
 
-describe BankgiroInbetalningar do
+describe BankgiroInbetalningar, ".parse" do
   context "parsing a minimal file" do
     subject { BankgiroInbetalningar.parse(fixture_path('minimal.txt')) }
 
@@ -15,3 +15,20 @@ describe BankgiroInbetalningar do
     end
   end
 end
+
+describe BankgiroInbetalningar, ".parse_data" do
+  context "parsing a minimal file" do
+    let(:data) { File.read(fixture_path('minimal.txt')) }
+    subject { BankgiroInbetalningar.parse_data(data) }
+
+    it "finds the timestamp" do
+      subject.timestamp.should == "2004 05 25 173035 010331".gsub(' ','').to_i
+    end
+    it "finds 1 deposit" do
+      subject.deposits.count.should == 1
+    end
+    it "finds 1 payment" do
+      subject.deposits.first.payments.count.should == 1
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bankgiro_inbetalningar
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-23 00:00:00.000000000 Z
+date: 2012-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -30,7 +30,7 @@ dependencies:
 description: Parse BgMax transaction files from Bankgirot and return a simple data
   structure
 email:
-- david@spnab.com
+- david@vrensk.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -53,7 +53,7 @@ files:
 - spec/fixtures/BgMaxfil4_broken.txt
 - spec/fixtures/minimal.txt
 - spec/spec_helper.rb
-homepage: https://github.com/icehouse/bankgiro_inbetalningar
+homepage: https://github.com/spnab/bankgiro_inbetalningar
 licenses: []
 post_install_message: 
 rdoc_options: []
@@ -76,7 +76,7 @@ rubyforge_project:
 rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
-summary: Bankgirot has changes its file format, making the +rbankgiro+ gem unusable
+summary: Bankgirot has changed its file format, making the +rbankgiro+ gem unusable
   for new clients.
 test_files:
 - spec/bankgiro_inbetalningar/bgmax_line_spec.rb