banker 0.0.4 → 0.0.5

data/README.md

@@ -21,7 +21,7 @@ and transaction details.
 
 Add this line to your application's Gemfile:
 
-    gem 'squeegee'
+    gem 'banker'
 
 And then execute:
 
@@ -29,7 +29,7 @@ And then execute:
 
 Or install it yourself as:
 
-    $ gem install squeegee
+    $ gem install banker
 
 ## Example Usage
 

data/banker.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |gem|
   gem.summary     = gem.description
 
   gem.add_runtime_dependency 'mechanize'
-  gem.add_runtime_dependency 'ofx'
+  gem.add_runtime_dependency 'banker-ofx'
 
   gem.add_development_dependency "gem-release"
   gem.add_development_dependency 'rspec'

data/lib/banker/barclaycard_uk.rb

@@ -75,22 +75,15 @@ module Banker
       ofx = get(EXPORT_ENDPOINT)
       ofx = ofx.body.gsub('VERSION="202"','VERSION="200"')
 
-      @ofx = OFX(ofx)
-
-      resource = StringIO.new(ofx)
-      html = Nokogiri::HTML.parse(
-        Iconv.conv("UTF-8", "LATIN1//IGNORE",resource.read)
-      )
-      account_id = html.search("ccacctfrom > acctid").inner_text
-      currency = html.search("ccstmtrs > curdef").inner_text
-
-      uid = Digest::MD5.hexdigest("Barclayard#{@username}#{account_id}")
-      @accounts << Banker::Account.new(uid: uid,
-                          name: "Barclaycard",
-                          amount: @ofx.account.balance.amount_in_pennies,
-                          currency: currency,
-                          limit: @limit
-                         )
+      OFX(ofx).credit_cards.each_with_object(@accounts) do |account, accounts|
+        args = { uid: Digest::MD5.hexdigest("Barclayard#{@username}#{account.id}"),
+                 name: "Barclaycard #{account.id[-4,4]}",
+                 amount: account.balance.amount_in_pennies,
+                 currency: account.currency,
+                 limit: @limit }
+
+        accounts << Banker::Account.new(args)
+      end
     end
   end
 end

data/lib/banker/barclays.rb

@@ -76,13 +76,14 @@ module Banker
     end
 
     def delivery(ofx)
-      amount = ofx.account.balance.amount_in_pennies
-      uid = Digest::MD5.hexdigest("Barclays#{@membership_number}")
-
-      @accounts << Banker::Account.new(uid: uid,
-                                       name: "Barclays",
-                                       amount: amount
-                                      )
+      ofx.bank_accounts.each_with_object(@accounts) do |account, accounts|
+        args = { uid: Digest::MD5.hexdigest("Barclays#{@membership_number}#{account.id}"),
+                 name: "Barclays #{account.id[-4,4]}",
+                 amount: account.balance.amount_in_pennies,
+                 currency: account.currency }
+
+        accounts << Banker::Account.new(args)
+      end
     end
 
   end

data/lib/banker/version.rb

@@ -1,3 +1,3 @@
 module Banker
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/banker/barclaycard_uk_spec.rb

@@ -158,10 +158,6 @@ describe Banker::BarclaycardUK do
           and_return(stub(body: ofx))
         subject.new
       end
-      it "finds account balance" do
-
-      end
-      it "finds account limit"
     end
   end
 end

data/spec/banker/barclays_spec.rb

@@ -217,9 +217,10 @@ describe Banker::Barclays do
       subject.any_instance.stub(:download!).and_return(ofx)
     end
 
-    it { obj.uid.should == 'febcbc946e71cb09820c152c727b9b90' }
-    it { obj.name.should == 'Barclays' }
+    it { obj.uid.should == '077db20dce9425514828c5104b10df51' }
+    it { obj.name.should == 'Barclays 1111' }
     it { obj.amount.should == 410010 }
+    it { obj.currency.should == 'GBP' }
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: banker
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-29 00:00:00.000000000 Z
+date: 2012-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mechanize
-  requirement: &70275203406640 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70275203406640
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: ofx
-  requirement: &70275203405920 !ruby/object:Gem::Requirement
+  name: banker-ofx
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +38,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70275203405920
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: gem-release
-  requirement: &70275203405420 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +54,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70275203405420
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70275203421160 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +70,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70275203421160
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70275203420040 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,10 +86,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70275203420040
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70275203418820 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -77,7 +102,12 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70275203418820
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A collection of strategies to access online bank accounts to obtain balance
   and transaction details.
 email:
@@ -142,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.17
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: A collection of strategies to access online bank accounts to obtain balance