bank_card 0.0.2 → 0.0.3

data/.gitignore

@@ -2,3 +2,4 @@
 .bundle
 Gemfile.lock
 pkg/*
+.rvmrc

data/bank_card.gemspec

@@ -23,7 +23,9 @@ Gem::Specification.new do |s|
   s.add_development_dependency "guard-rspec"
   s.add_development_dependency "guard-bundler"
   s.add_development_dependency "ruby-debug19"
-  
+  s.add_development_dependency "shoulda-matchers"
+  s.add_development_dependency "timecop"
+
   s.add_runtime_dependency "activemodel"
   s.add_runtime_dependency "activesupport"
 end

data/lib/bank_card/validations/expiration_validator.rb

@@ -2,7 +2,7 @@ module BankCard
   module Validations
     class ExpirationValidator < ActiveModel::EachValidator
       def validate_each(record, attribute, value)
-        record.errors.add(attribute, :is_expired, options) unless value && value.end_of_month.future?
+        record.errors.add(attribute, :is_expired, options) unless value && value >= Date.today
       end
     end
 
@@ -13,4 +13,3 @@ module BankCard
     end
   end
 end
-

data/lib/bank_card/version.rb

@@ -1,3 +1,3 @@
 module BankCard
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/lib/validations_spec.rb

@@ -8,31 +8,41 @@ class CreditCard
 end
 
 describe CreditCard do
-  before do 
-    CreditCard.reset_callbacks(:validate)
-  end
+  before { CreditCard.reset_callbacks(:validate) }
 
-  it "should validate number with Luhn algorithm" do
-    CreditCard.validates :number, :luhn => true
-    card = CreditCard.new
+  describe "validation" do
+    subject { CreditCard.new }
 
-    card.number = '123'
-    card.should be_invalid
-    card.errors[:number].should include("is invalid")
+    describe "number with Luhn algorithm" do
+      before { CreditCard.validates :number, :luhn => true }
 
-    card.number = '4200000000000000'
-    card.should be_valid
-  end
+      it { should_not allow_value('123').for(:number) }
+      it { should allow_value('4200000000000000').for(:number) }
+    end
+
+    describe "card expiration" do
+      before { CreditCard.validates_expiration_of :date }
+
+      it { should_not allow_value(Date.today.prev_month).for(:date) }
+      it { should allow_value(Date.today.next_month).for(:date) }
 
-  it "should validate card expiration" do
-    CreditCard.validates_expiration_of :date
-    card = CreditCard.new
-  
-    card.date = Date.today.prev_month
-    card.should be_invalid
-    card.errors[:date].should include("is expired")
+      context "when the validity period expires in this month" do
+        context "when now is first day of month" do
+          before { Timecop.freeze(Date.today.beginning_of_month) }
+          after  { Timecop.return }
 
-    card.date = Date.today
-    card.should be_valid
+          it { should allow_value(Date.today).for(:date) }
+        end
+
+        context "when now is last day of month" do
+          before { Timecop.freeze(Date.today.end_of_month) }
+          after  { Timecop.return }
+
+          it { should allow_value(Date.today).for(:date) }
+        end
+      end
+
+    end
   end
+
 end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
 $:.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 
 require 'bank_card'
+require 'shoulda-matchers'
+require 'timecop'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bank_card
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,12 +9,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-09-16 00:00:00.000000000 +03:00
+date: 2011-09-30 00:00:00.000000000 +03:00
 default_executable: 
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2152518680 !ruby/object:Gem::Requirement
+  requirement: &2157467540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152518680
+  version_requirements: *2157467540
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &2152518260 !ruby/object:Gem::Requirement
+  requirement: &2157467120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +33,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152518260
+  version_requirements: *2157467120
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &2152517840 !ruby/object:Gem::Requirement
+  requirement: &2157466700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152517840
+  version_requirements: *2157466700
 - !ruby/object:Gem::Dependency
   name: guard-bundler
-  requirement: &2152517420 !ruby/object:Gem::Requirement
+  requirement: &2157466280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +55,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152517420
+  version_requirements: *2157466280
 - !ruby/object:Gem::Dependency
   name: ruby-debug19
-  requirement: &2152517000 !ruby/object:Gem::Requirement
+  requirement: &2157465860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,10 +66,32 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152517000
+  version_requirements: *2157465860
+- !ruby/object:Gem::Dependency
+  name: shoulda-matchers
+  requirement: &2157465440 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *2157465440
+- !ruby/object:Gem::Dependency
+  name: timecop
+  requirement: &2157465020 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *2157465020
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &2152516580 !ruby/object:Gem::Requirement
+  requirement: &2157464600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -77,10 +99,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152516580
+  version_requirements: *2157464600
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &2152516160 !ruby/object:Gem::Requirement
+  requirement: &2157495140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -88,7 +110,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152516160
+  version_requirements: *2157495140
 description: Gem includes validations, card brand detection method, etc.
 email:
 - alovak@gmail.com