bank_api 0.7.8 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1335701d3f92554757e257856cbb744be8005a34d74eda0b0f02ed955eeaaff1
-  data.tar.gz: 6be8e3449ea0240e6339a41cc90bb2c40c529a18cfca9525a09c50dad4686f15
+  metadata.gz: aaf7fef43650e6c6ca07c066219e92cedaf2602d38b880386abfe0576c60cb94
+  data.tar.gz: 117c566f6481736b51acbb71457e7c78261ba607a87f670cf29ce777f018514c
 SHA512:
-  metadata.gz: ae642f9e1658a102a69a8a0888c570f83026db90e0b843b19fa78e45ea5e33e0cb90256e46fc3fef4b06aa3d0486b3a14899b4865bef049d344d4c3a1641d54f
-  data.tar.gz: 8817140a5bc6a71d87efd589438a1c1f3d19e3786b4e12fba5ac46f53b0d7d62be9cca080266cdb52aa6e35722af008146965260abd0044c159c5c7f23121ae2
+  metadata.gz: 59869a54dbcf09da1d4f163686b0617564c107b43f4049e46bc1bad357eb3e953045fc670696f6077cffd36a4db15a1714ec5847d214e8b0ccbfa24e9cbcdb6c
+  data.tar.gz: 60cae0a659e8044abafea282b4761ed5aac0eee84c865c5ceaeba31e4d3aaab28292e3f99bfc35eb0ff442b3175981442f29ee7fc1fb803f52256a4b94faffdc

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bank_api (0.7.8)
+    bank_api (1.0.0)
       pincers
       rest-client
       timezone (~> 1.0)
@@ -65,7 +65,7 @@ GEM
       childprocess (~> 0.5)
       rubyzip (~> 1.0)
       websocket (~> 1.0)
-    timezone (1.2.12)
+    timezone (1.3.2)
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.7.5)

data/lib/bank_api.rb

@@ -25,13 +25,13 @@ module BankApi
     Clients::BancoDeChileCompanyClient.new(configuration).get_recent_deposits(options)
   end
 
-  def self.get_bdc_account_balance(account_number)
-    Clients::BancoDeChileCompanyClient.new(configuration).get_account_balance(account_number)
+  def self.get_bdc_account_balance(options = {})
+    Clients::BancoDeChileCompanyClient.new(configuration).get_account_balance(options)
   end
 
   module BancoSecurity
-    def self.get_account_balance(account_number)
-      company_instance.get_balance(account_number)
+    def self.get_account_balance(options = {})
+      company_instance.get_balance(options)
     end
 
     def self.get_recent_company_deposits(options = {})

data/lib/bank_api/clients/banco_de_chile_company_client.rb

@@ -34,13 +34,13 @@ module BankApi::Clients
       ].any?(&:nil?)
     end
 
-    def get_balance(account_number)
+    def get_balance(options)
       login
       goto_balance
-      select_account(account_number)
+      select_account(options[:account_number])
       click_fetch_balance_button
       {
-        account_number: account_number,
+        account_number: options[:account_number],
         available_balance: money_to_i(read_balance(:available)),
         countable_balance: money_to_i(read_balance(:countable))
       }

data/lib/bank_api/clients/banco_security/company_client.rb

@@ -30,11 +30,11 @@ module BankApi::Clients::BancoSecurity
       :security
     end
 
-    def get_balance(account_number)
+    def get_balance(options)
       login
-      goto_company_dashboard
+      goto_company_dashboard(options[:rut] || @company_rut)
       goto_balance
-      find_account_balance(account_number)
+      find_account_balance(options[:account_number])
     ensure
       browser.close
     end

data/lib/bank_api/clients/banco_security/concerns/balance.rb

@@ -7,6 +7,11 @@ module BankApi::Clients::BancoSecurity
     COUNTABLE_BALANCE_COLUMN = 2
 
     def find_account_balance(account_number)
+      return get_balance_from_accounts_list(account_number) if account_number
+      get_balance_from_account_summary
+    end
+
+    def get_balance_from_accounts_list(account_number)
       balance = browser.search(".cuentas-corrientes").search("tbody tr").map do |row|
         cells = row.search("td")
         {
@@ -17,19 +22,41 @@ module BankApi::Clients::BancoSecurity
       end.find do |row|
         row[:account_number] == account_number
       end
-      validate_balance(balance, account_number)
+      validate_account_balance(balance, account_number)
       balance
     end
 
-    def money_to_i(text)
-      text.delete(".").delete("$").delete(" ").to_i
+    def get_balance_from_account_summary
+      available_balance = extract_balance(1)
+      countable_balance = extract_balance(2)
+      validate_summary_balance(available_balance, countable_balance)
+
+      {
+        available_balance: available_balance,
+        countable_balance: countable_balance
+      }
     end
 
-    def validate_balance(balance, account_number)
+    def validate_account_balance(balance, account_number)
       if balance.nil?
         raise BankApi::Balance::InvalidAccountNumber, "Couldn't find balance of account " +
           account_number.to_s
       end
     end
+
+    def validate_summary_balance(available_balance, countable_balance)
+      if available_balance.zero? || countable_balance.zero?
+        raise BankApi::Balance::MissingAccountBalance, "Couldn't find balance"
+      end
+    end
+
+    def extract_balance(td_pos)
+      xp = "//*[@id=\"body\"]/div[1]/section/div/div/div[3]/div[2]/table/tbody/tr[1]/td[#{td_pos}]"
+      money_to_i(browser.search(xpath: xp).text)
+    end
+
+    def money_to_i(text)
+      text.to_s.delete(".").delete("$").delete(" ").to_i
+    end
   end
 end

data/lib/bank_api/clients/base_client.rb

@@ -16,9 +16,9 @@ module BankApi::Clients
       parse_entries(get_deposits(options))
     end
 
-    def get_account_balance(account_number)
+    def get_account_balance(options)
       validate_credentials
-      get_balance(account_number)
+      get_balance(options)
     end
 
     def transfer(transfer_data)
@@ -51,7 +51,7 @@ module BankApi::Clients
       raise NotImplementedError
     end
 
-    def get_balance
+    def get_balance(_options = {})
       raise NotImplementedError
     end
 

data/lib/bank_api/exceptions.rb

@@ -2,6 +2,7 @@ module BankApi
   class MissingCredentialsError < StandardError; end
   module Balance
     class InvalidAccountNumber < StandardError; end
+    class MissingAccountBalance < StandardError; end
   end
   module Deposit
     class FetchError < StandardError; end

data/lib/bank_api/version.rb

@@ -1,3 +1,3 @@
 module BankApi
-  VERSION = "0.7.8"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bank_api
 version: !ruby/object:Gem::Version
-  version: 0.7.8
+  version: 1.0.0
 platform: ruby
 authors:
 - oaestay
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-11-09 00:00:00.000000000 Z
+date: 2018-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pincers
@@ -194,7 +194,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Wrapper for chilean banks