bank_api 0.7.5 → 0.7.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc70b8079987a6546b3c751d9a6ccea444df15db21692c8e2ec2d368b8980448
-  data.tar.gz: 5485bf9ba86526a90c367e480b60f819addb6665184782383242a671879030f8
+  metadata.gz: 886af5ed1c68d928ae5d94d6e25ad64be7f5bd6b764e0077b1522dd9ba14776a
+  data.tar.gz: c9577fc968bac4ed8e6c5df548ac13ae44e3a4a9abc616a41c3b7e248989e1b2
 SHA512:
-  metadata.gz: d392430f0b30cd4035059fd3eb7b85c9510e4eedb1fccc237cb8a4be27d955df8820b202c1f12ec98c54c84ece8bf3a1e4dc3d41b379c2e3c2a8dc7fbc733973
-  data.tar.gz: 2a3440e68166aa74f3d859c1e66d1cf7ce5f18100ecdf84e2e7798da50a3ebc32ae6e24c7e3b8a3288c1e62258ef4ae05754b6125ca9e888bd49d7df09f12928
+  metadata.gz: 0f2beaff4e27168e47ba068470e0c181fcbdba91772c0ab690e780b2c2f7f2498a3790abc983c660ab5d98f538980d04397939aeffcb6fa8924ead05ccf2b523
+  data.tar.gz: 354ead4117bf1215be1f4fbf400e1c1f5db7602c527010df13245bc180799a02548721589ba8a52a2f5158d88d7e9c2b1865cb5eba3b1c651f9d6ad39c66b288

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bank_api (0.7.5)
+    bank_api (0.7.6)
       pincers
       rest-client
       timezone (~> 1.0)

data/lib/bank_api/clients/banco_de_chile_company_client.rb

@@ -147,7 +147,7 @@ module BankApi::Clients
       prepare_deposits
       response = RestClient::Request.execute(
         url: COMPANY_DEPOSITS_TXT_URL, method: :post, headers: session_headers,
-        payload: deposits_txt_payload(deposit_range[:start], deposit_range[:end]), verify_ssl: false
+        payload: deposits_txt_payload(deposit_range[:start], deposit_range[:end]), verify_ssl: true
       )
       raise "Banchile is down" if response.body.include? "no podemos atenderle"
 
@@ -162,7 +162,7 @@ module BankApi::Clients
       RestClient::Request.execute(
         url: COMPANY_PREPARE_DEPOSITS_URL, method: :post, headers: session_headers,
         payload: prepare_deposits_payload(deposit_range[:start], deposit_range[:end]),
-        verify_ssl: false
+        verify_ssl: true
       )
     end
 

data/lib/bank_api/clients/banco_security/concerns/deposits.rb

@@ -33,7 +33,8 @@ module BankApi::Clients::BancoSecurity
     end
 
     def deposits_from_txt
-      return [] unless any_deposits?
+      wait("") { any_deposits? }
+      raise BankApi::Deposit::FetchError, "Couldn't fetch deposits" unless any_deposits?
       download = browser.download(deposits_txt_url)
       transactions = download.content.split("\n").drop(1).map { |r| r.split("|") }
       format_transactions(transactions)
@@ -80,9 +81,7 @@ module BankApi::Clients::BancoSecurity
     end
 
     def extract_client_name(text)
-      parts = text.to_s.split(" De ")
-      parts = text.to_s.split(" DE ") if parts.count == 1
-      return text if parts.count > 2
+      parts = text.to_s.split(/\ DE | De | de /, 2)
       parts.last.to_s.strip
     end
 

data/lib/bank_api/exceptions.rb

@@ -4,6 +4,7 @@ module BankApi
     class InvalidAccountNumber < StandardError; end
   end
   module Deposit
+    class FetchError < StandardError; end
     class QuantityError < StandardError; end
     class PaginationError < StandardError; end
   end

data/lib/bank_api/version.rb

@@ -1,3 +1,3 @@
 module BankApi
-  VERSION = "0.7.5"
+  VERSION = "0.7.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bank_api
 version: !ruby/object:Gem::Version
-  version: 0.7.5
+  version: 0.7.6
 platform: ruby
 authors:
 - oaestay
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-11-07 00:00:00.000000000 Z
+date: 2018-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pincers