bank_account_number_validator 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23279b52e4ec9c0af8727a4f360d033dfef2cd57
-  data.tar.gz: 0e3f5dae5a24ec443271fae6a3a42a49705fcf47
+  metadata.gz: 332260d181f0a0a2a193fcdee03520e100531729
+  data.tar.gz: 2553d7f51e5397f6b37f4787784694b3d60a1a8d
 SHA512:
-  metadata.gz: 532fbdd8f1f471ed89eaa9cc5a5cf82256738a5cc957686d2d9962cfb1a9d5427335a0e3bbd766ac68973f64192a4bb0894c8c2a1b349f56f397f47de3985546
-  data.tar.gz: ed0ff7f92d1a935ea6701d6b8c24d88ab94c794bcc65b6785f679a1ae6f987d754fbbc20b2fc4b4fb3993099ed30f7ed5a29314e1cfd8ff222738e33b90638df
+  metadata.gz: 43a20251d77d74c81739b0277e788bc8c75e4c7893e632fbdd8b8fde58cf4da85e439a429ff54924d6a2327d572741a6fe4cddd12ddf5ef07d670dd620755807
+  data.tar.gz: 57a819bdcd0c6c5d5ca072f94f886a53b5bfd1932fcb90e2be4b3036961932553cb7a53156167216a7dc807caae8eabe2a5c5708de529d2754c61b074ef23da7

data/README.md

@@ -0,0 +1,17 @@
+#Bank account number validator
+
+In this version validations only POLISH bank account number validator
+
+## Installation
+```ruby
+gem install bank_account_number_validator
+```
+## Installation in GemFile
+```ruby
+gem 'bank_account_number_validator'
+```
+
+## Usage
+```ruby
+validates :number, bank_account_number: true
+```

data/bank_account_number_validator.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |gem|
   gem.name          = "bank_account_number_validator"
-  gem.version       = '0.0.2'
+  gem.version       = '0.0.3'
   gem.authors       = ["jacoobb"]
   gem.email         = ["mikrut.jakub@gmail.com"]
   gem.summary       = %q{Bank account number validator}

data/lib/bank_account_number_validator/validator.rb

@@ -1,24 +1,30 @@
 class BankAccountNumberValidator::Validator
   
   def initialize location: nil, value: nil
-    @validator = location_valid location, numbrt_only(value)
+    @value = remote_white_space value
+    @validator = location_valid location
   end
 
   def valid
+    return false unless only_numer?
     @validator.valid
   end
 
 
   private
 
-    def numbrt_only value
-      value.chars.map{|char| char.to_i if char =~ /\d/}.compact
+    def only_numer?
+      @value =~ /^(?<num>\d+)$/
     end
 
-    def location_valid location, value
+    def remote_white_space value
+      value.gsub(/\s+/, "")
+    end
+
+    def location_valid location
       case location
       when :pl
-        BankAccountNumberValidator::Validator::Pl.new value: value
+        BankAccountNumberValidator::Validator::Pl.new value: @value
       end
     end
 end

data/lib/bank_account_number_validator/validator/pl.rb

@@ -1,6 +1,6 @@
 class BankAccountNumberValidator::Validator::Pl < BankAccountNumberValidator::Validator
   def initialize value: nil
-    @value = value
+    @value = value_to_array value
     @weight = [1,10,3,30,9,90,27,76,81,34,49,5,50,15,53,45,62,38,89,17,73,51,25,56,75,71,31,19,93,57]
   end
 
@@ -13,6 +13,10 @@ class BankAccountNumberValidator::Validator::Pl < BankAccountNumberValidator::Va
 
   
   private
+  
+    def value_to_array value
+      value.chars.map{|char| char.to_i}
+    end
 
     def length_valid
       @value.size == 26

data/spec/lib/bank_account_number_validator/validator/pl_spec.rb

@@ -10,26 +10,38 @@ describe BankAccountNumberValidator::Validator::Pl do
     end
 
     it "return false if number is too short" do
-      validator = BankAccountNumberValidator::Validator::Pl.new value: [1,2,3]
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '123'
       expect(validator.valid).to be false 
     end
 
     it "return false if number is too long" do
-      validator = BankAccountNumberValidator::Validator::Pl.new value: (1..40).to_a
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '11111111111111111111111111111111'
       expect(validator.valid).to be false 
     end
 
     it 'call length_valid' do
       expect_any_instance_of(BankAccountNumberValidator::Validator::Pl).to receive(:length_valid)
-      validator = BankAccountNumberValidator::Validator::Pl.new value: [1,2,3]
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '123'
       validator.valid
     end
 
   end
 
+  describe "value_to_array" do
+    it "return array" do
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '123'
+      expect(validator.send(:value_to_array, '123')).to eq [1,2,3]
+    end 
+
+    it "call value_to_array" do
+      expect_any_instance_of(BankAccountNumberValidator::Validator::Pl).to receive(:value_to_array).with('123')
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '123'
+    end
+  end
+
   describe "set_pl_code" do
     it "add code to array" do
-      validator = BankAccountNumberValidator::Validator::Pl.new value: [1,2,3]
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '123'
       expect(validator.send(:set_pl_code)).to eq [1,2,3,2,5,2,1]
     end 
 
@@ -39,14 +51,14 @@ describe BankAccountNumberValidator::Validator::Pl do
       allow_any_instance_of(BankAccountNumberValidator::Validator::Pl).to receive(:remainder?)
 
       expect_any_instance_of(BankAccountNumberValidator::Validator::Pl).to receive(:set_pl_code)
-      validator = BankAccountNumberValidator::Validator::Pl.new value: [1,2,3]
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '123'
       validator.valid
     end
   end
 
   describe "set_first_to_end" do
     it "set first to end" do
-      validator = BankAccountNumberValidator::Validator::Pl.new value: [1,2,3]
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '123'
       expect(validator.send(:set_first_to_end)).to eq [3,1,2]
     end 
 
@@ -56,21 +68,21 @@ describe BankAccountNumberValidator::Validator::Pl do
       allow_any_instance_of(BankAccountNumberValidator::Validator::Pl).to receive(:remainder?)
 
       expect_any_instance_of(BankAccountNumberValidator::Validator::Pl).to receive(:set_first_to_end)
-      validator = BankAccountNumberValidator::Validator::Pl.new value: [1,2,3]
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '123'
       validator.valid
     end
   end
 
   describe "sum_up_the_weight" do
     it "set first to end" do
-      validator = BankAccountNumberValidator::Validator::Pl.new value: [8,3,1,0,1,0,1,0,2,3,0,0,0,0,2,6,1,3,9,5,1,0,0,0,0,0]
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '83101010230000261395100000'
       expect(validator.send(:sum_up_the_weight)).to eq 2669
     end 
 
     it "call sum_up_the_weight" do
       expect_any_instance_of(BankAccountNumberValidator::Validator::Pl).to receive(:sum_up_the_weight).and_return 97
 
-      validator = BankAccountNumberValidator::Validator::Pl.new value: [1,2,3]
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '123'
       validator.send :remainder?
     end
   end
@@ -78,13 +90,13 @@ describe BankAccountNumberValidator::Validator::Pl do
   describe 'remainder?' do
     it "return true " do
       allow_any_instance_of(BankAccountNumberValidator::Validator::Pl).to receive(:sum_up_the_weight).and_return 98
-      validator = BankAccountNumberValidator::Validator::Pl.new value: [8,3]
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '83'
       expect(validator.send(:remainder?)).to be true
     end
 
     it "return false" do
       allow_any_instance_of(BankAccountNumberValidator::Validator::Pl).to receive(:sum_up_the_weight).and_return 97
-      validator = BankAccountNumberValidator::Validator::Pl.new value: [8,3]
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '83'
       expect(validator.send(:remainder?)).to be false
     end
 
@@ -94,7 +106,7 @@ describe BankAccountNumberValidator::Validator::Pl do
       allow_any_instance_of(BankAccountNumberValidator::Validator::Pl).to receive(:set_first_to_end)
 
       expect_any_instance_of(BankAccountNumberValidator::Validator::Pl).to receive(:remainder?)
-      validator = BankAccountNumberValidator::Validator::Pl.new value: [1,2,3]
+      validator = BankAccountNumberValidator::Validator::Pl.new value: '123'
       validator.valid
     end
   end

data/spec/lib/bank_account_number_validator/validator_spec.rb

@@ -1,28 +1,56 @@
 require 'spec_helper'
 
 describe BankAccountNumberValidator::Validator do
-  before(:all) { @number = "IBAN PL83 1010 1023 0000 2613 9510 0000" }
-
-  describe 'numbrt_only' do 
-    it "should return array" do
-      validator = BankAccountNumberValidator::Validator.new(location: :pl, value: @number)
-      expect(validator.send(:numbrt_only, @number)).to eq [8, 3, 1, 0, 1, 0, 1, 0, 2, 3, 0, 0, 0, 0, 2, 6, 1, 3, 9, 5, 1, 0, 0, 0, 0, 0]
-    end
-  end
+  before(:all) { @number = "83" }
 
   describe 'location_valid' do
     it "should call location_valid in initialize" do
-      allow_any_instance_of(BankAccountNumberValidator::Validator).to receive(:numbrt_only).with(@number).and_return([1,2,3])
+      allow_any_instance_of(BankAccountNumberValidator::Validator).to receive(:remote_white_space).with(@number).and_return('123')
 
-      expect_any_instance_of(BankAccountNumberValidator::Validator).to receive(:location_valid).with(:pl, [1,2,3])
-      BankAccountNumberValidator::Validator.new(location: :pl, value: @number)
+      expect_any_instance_of(BankAccountNumberValidator::Validator).to receive(:location_valid).with(:pl)
+      BankAccountNumberValidator::Validator.new(location: :pl, value: @number )
     end
 
     it "should call PL validator" do
-      allow_any_instance_of(BankAccountNumberValidator::Validator).to receive(:numbrt_only).with(@number).and_return([1,2,3])
+      allow_any_instance_of(BankAccountNumberValidator::Validator).to receive(:remote_white_space).with(@number).and_return('123')
 
-      expect(BankAccountNumberValidator::Validator::Pl).to receive(:new).with(value: [1,2,3])
+      expect(BankAccountNumberValidator::Validator::Pl).to receive(:new).with(value: '123')
       BankAccountNumberValidator::Validator.new(location: :pl, value: @number)
     end
   end
+
+  describe 'remote_white_space' do 
+    before do 
+      allow_any_instance_of(BankAccountNumberValidator::Validator).to receive(:location_valid).with(:pl).and_return(@valid_pl)
+    end
+
+    it do
+      validator = BankAccountNumberValidator::Validator.new(location: :pl, value: @number)
+      expect(validator.send(:remote_white_space, ' 12 23 23    23')).to eq('12232323')
+    end
+  end
+
+  describe 'only_numer?' do
+
+    before (:all) do
+      ValidPL = Struct.new(:valid)
+      @valid_pl = ValidPL.new(true)
+    end
+
+    before do
+      allow_any_instance_of(BankAccountNumberValidator::Validator).to receive(:location_valid).with(:pl).and_return(@valid_pl)
+    end
+
+    it "return false" do
+      allow_any_instance_of(BankAccountNumberValidator::Validator).to receive(:remote_white_space).with(@number).and_return('123a')
+      validator = BankAccountNumberValidator::Validator.new(location: :pl, value: @number)
+      expect(validator.valid).to be false
+    end
+
+    it "return true" do
+      allow_any_instance_of(BankAccountNumberValidator::Validator).to receive(:remote_white_space).with(@number).and_return('123')
+      validator = BankAccountNumberValidator::Validator.new(location: :pl, value: @number)
+      expect(validator.valid).to be true
+    end
+  end
 end

data/spec/lib/bank_account_number_validator_spec.rb

@@ -6,12 +6,12 @@ describe BankAccountNumberValidator do
   describe "valid is false" do
 
     it "number is incorrect" do
-      dummy_class = DummyClass.new number: 'PL1234567890123456789012345444444535353453'
+      dummy_class = DummyClass.new number: '1234567890123456789012345444444535353453'
       expect(dummy_class.valid?).to be false 
     end
 
     it "should return errors" do
-      dummy_class = DummyClass.new number: 'IBAN PL83 1010 1023 0000 2613 9510 0001'
+      dummy_class = DummyClass.new number: '83 1010 1023 0000 2613 9510 0001'
       dummy_class.valid?
       expect(dummy_class.errors[:number]).to_not be_empty
     end
@@ -20,12 +20,12 @@ describe BankAccountNumberValidator do
   describe "valid is true" do
 
     it "number is correct" do
-      dummy_class = DummyClass.new number: 'IBAN PL83 1010 1023 0000 2613 9510 0000'
+      dummy_class = DummyClass.new number: '83 1010 1023 0000 2613 9510 0000'
       expect(dummy_class.valid?).to be true 
     end
 
     it "should not return errors" do
-      dummy_class = DummyClass.new number: 'IBAN PL83 1010 1023 0000 2613 9510 0000'
+      dummy_class = DummyClass.new number: '83 1010 1023 0000 2613 9510 0000'
       dummy_class.valid?
       expect(dummy_class.errors[:number]).to be_empty
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bank_account_number_validator
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - jacoobb