bank-validator 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2c14e9da0b53505c9756e5cafa8c02180b932912
-  data.tar.gz: 20f832a454a4f5ebfd0e2a333db90119fd97be2a
+  metadata.gz: 194a6aaded724df8793a2f9e51a4cd8bdb74c78a
+  data.tar.gz: 3c321814a1d8549e7cc7db980ee286bfeb0792c0
 SHA512:
-  metadata.gz: 699cbf55abc1bfea2a67436404e46a4dc9a8a05d7b1dfee241dc97cbe3ee010b49d6c3c8fe43059b5eb0fdebd53aaf21baf752a53e148fac0771ac554e550dc9
-  data.tar.gz: a7f936c57b827f58632ebb7774fa68dbf86e60fa3817499d0d9e90551a16e6cf73910e700bcc3c274b63026da584fb6f89c8cdae4dbd5570908f0cbe0f721e53
+  metadata.gz: eb2485213c20762ae815a365a2dac2d09b5cd5d2e20b394ea7ffdb64d8959f85be99a98174d9e62279266cb298776fcee2f79f3fd4d4f914f7aca25583a37ecc
+  data.tar.gz: 08966de96d54cb56706e400269de858a0db120c225277060c2263257b5b89050e9ef31ba46b0177b29c7ab8404a7270575973bec8c1d59e4d606c7484f43d9a0

data/VERSION

@@ -1 +1 @@
-0.3.1
+0.3.2

data/bank-validator.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: bank-validator 0.3.1 ruby lib
+# stub: bank-validator 0.3.2 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "bank-validator"
-  s.version = "0.3.1"
+  s.version = "0.3.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Adam Bahlke"]
-  s.date = "2016-02-08"
+  s.date = "2016-02-17"
   s.description = "Validates IBAN and BIC account numbers. Still a work in progress"
   s.email = "adam.bahlke@hitfoxgroup.com"
   s.extra_rdoc_files = [

data/lib/bank_validator/bic.rb

@@ -7,7 +7,7 @@ module BankValidator
     end
 
     def valid?
-      BankValidator::Bic.valid_format?(value)
+      BankValidator::Bic.valid_format?(value) && (value.length == 8 || value.length == 11)
     end
 
     def self.valid_format?(bic)

data/test/dummy/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ~/Workspace/bank-validator
   specs:
-    bank-validator (0.3.0)
+    bank-validator (0.3.1)
       activemodel (>= 3.0)
 
 GEM

data/test/dummy/spec/features/gem_testing_spec.rb

@@ -44,6 +44,9 @@ RSpec.describe 'testing the gem', type: :feature do
 
       @user.bic = 'D3UTDEBR'
       expect(@user.save).to be(false)
+
+      @user.bic = 'COBADEFXXX'
+      expect(@user.save).to be(false)
     end
 
     it 'validates a different bic types' do
@@ -55,7 +58,9 @@ RSpec.describe 'testing the gem', type: :feature do
     end
 
     it 'saves the bic' do
-      user = User.create(name: 'Adam', iban: 'BE62510007547061', bic: 'DEUTDEFF500')
+      user = User.create(name: 'Adam', iban: 'BE62510007547061', bic: 'DEUTDEFF500', routing_number: '226073523')
+      user.save
+      expect(user.valid?).to be(true)
       expect(user.bic).to eq('DEUTDEFF500')
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bank-validator
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Adam Bahlke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-08 00:00:00.000000000 Z
+date: 2016-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel