bank-validator 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f2c187846e8a80fc532597a56c5e710cd9d4ec9d
-  data.tar.gz: 5bc3fecb853c128ba0894b1a12453eab9427d926
+  metadata.gz: 3ce014a1251785320e4a3942f9509d9c5df8a167
+  data.tar.gz: 9434a9d5af76a0b4c6ca946b1a8b53b0a2eac0bc
 SHA512:
-  metadata.gz: 66d2b86b4f11e58494f18f71357ec69332ad6b908420dfba40566fd951cb73e4d45bea5a4ed94b80ee46ad3784999e800b9692272ef41793e69acb87dbc17381
-  data.tar.gz: 5edbbd0bcf9b03f54544c14fcb7f9a1650663e631fcdae2f50af93b2758c032c949357011ff41a6a220d8c5fab83585e6cc4054eb81571b2914050a7e6582d2b
+  metadata.gz: d683e2d10cdd64df4d0a0b37de9154abf5a5960d86ea50343bb8d8ab73a7786ca554a4dc0d970df0bdb66906b08d65115f78b4d611846ddee7db35cea6317e2e
+  data.tar.gz: e404e316bf5c14f03f3d6bafe9cd7387ec5de1d278894b1302b08824e1b70df9b1f65eb5dc968c96f0d1c5774271b3a4a4d0dae6bfacaeed62eb0851c29ba843

data/Gemfile

@@ -2,13 +2,13 @@ source "http://rubygems.org"
 # Add dependencies required to use your gem here.
 # Example:
 #   gem "activesupport", ">= 2.3.5"
-gem "activesupport"
-gem "activerecord"
-
+gem "activesupport", ">= 3.0"
+gem "activerecord", ">= 3.0"
 
 # Add dependencies to develop your gem here.
 # Include everything needed to run rake, tests, features, etc.
 group :development do
+  gem "rspec"
   gem "shoulda", "~> 3.5"
   gem "rdoc", "~> 3.12"
   gem "bundler", "~> 1.0"

data/Gemfile.lock

@@ -19,6 +19,7 @@ GEM
     builder (3.2.2)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
+    diff-lcs (1.2.5)
     docile (1.1.5)
     faraday (0.9.1)
       multipart-post (>= 1.2, < 3)
@@ -62,6 +63,19 @@ GEM
     rake (10.4.2)
     rdoc (3.12.2)
       json (~> 1.4)
+    rspec (3.2.0)
+      rspec-core (~> 3.2.0)
+      rspec-expectations (~> 3.2.0)
+      rspec-mocks (~> 3.2.0)
+    rspec-core (3.2.2)
+      rspec-support (~> 3.2.0)
+    rspec-expectations (3.2.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.2.0)
+    rspec-mocks (3.2.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.2.0)
+    rspec-support (3.2.2)
     shoulda (3.5.0)
       shoulda-context (~> 1.0, >= 1.0.1)
       shoulda-matchers (>= 1.4.1, < 3.0)
@@ -81,10 +95,11 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  activerecord
-  activesupport
+  activerecord (>= 3.0)
+  activesupport (>= 3.0)
   bundler (~> 1.0)
   jeweler (~> 2.0)
   rdoc (~> 3.12)
+  rspec
   shoulda (~> 3.5)
   simplecov (~> 0.9)

data/VERSION

@@ -1 +1 @@
-0.0.2
+0.0.3

data/bank-validator.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: bank-validator 0.0.2 ruby lib
+# stub: bank-validator 0.0.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "bank-validator"
-  s.version = "0.0.2"
+  s.version = "0.0.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
@@ -28,7 +28,7 @@ Gem::Specification.new do |s|
     "VERSION",
     "bank-validator.gemspec",
     "lib/active_model.rb",
-    "lib/active_model/validations/iban_validator.rb",
+    "lib/active_model/iban_validator.rb",
     "lib/bank-validator.rb",
     "test/helper.rb",
     "test/test_bank-validator.rb"
@@ -42,16 +42,18 @@ Gem::Specification.new do |s|
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<activesupport>, [">= 0"])
-      s.add_runtime_dependency(%q<activerecord>, [">= 0"])
+      s.add_runtime_dependency(%q<activesupport>, [">= 3.0"])
+      s.add_runtime_dependency(%q<activerecord>, [">= 3.0"])
+      s.add_development_dependency(%q<rspec>, [">= 0"])
       s.add_development_dependency(%q<shoulda>, ["~> 3.5"])
       s.add_development_dependency(%q<rdoc>, ["~> 3.12"])
       s.add_development_dependency(%q<bundler>, ["~> 1.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 2.0"])
       s.add_development_dependency(%q<simplecov>, ["~> 0.9"])
     else
-      s.add_dependency(%q<activesupport>, [">= 0"])
-      s.add_dependency(%q<activerecord>, [">= 0"])
+      s.add_dependency(%q<activesupport>, [">= 3.0"])
+      s.add_dependency(%q<activerecord>, [">= 3.0"])
+      s.add_dependency(%q<rspec>, [">= 0"])
       s.add_dependency(%q<shoulda>, ["~> 3.5"])
       s.add_dependency(%q<rdoc>, ["~> 3.12"])
       s.add_dependency(%q<bundler>, ["~> 1.0"])
@@ -59,8 +61,9 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<simplecov>, ["~> 0.9"])
     end
   else
-    s.add_dependency(%q<activesupport>, [">= 0"])
-    s.add_dependency(%q<activerecord>, [">= 0"])
+    s.add_dependency(%q<activesupport>, [">= 3.0"])
+    s.add_dependency(%q<activerecord>, [">= 3.0"])
+    s.add_dependency(%q<rspec>, [">= 0"])
     s.add_dependency(%q<shoulda>, ["~> 3.5"])
     s.add_dependency(%q<rdoc>, ["~> 3.12"])
     s.add_dependency(%q<bundler>, ["~> 1.0"])

data/lib/active_model.rb

@@ -1,5 +1,5 @@
-require_relative './active_model/validations/iban_validator'
+require_relative './active_model/iban_validator'
 
 module ActiveModel
-  autoload :IbanValidator, './active_model/validations/iban_validator'
+  autoload :IbanValidator, './active_model/iban_validator'
 end

data/lib/active_model/iban_validator.rb

@@ -0,0 +1,30 @@
+require 'active_model'
+
+class IbanValidator < ActiveModel::EachValidator
+
+  def validate_each(record, attribute, value)
+    record_error(record, attribute, value) unless value =~ regexp && valid_iban?(value)
+  end
+  
+  private
+  
+  def record_error(record, attribute, value)
+    record.errors.add(attribute, :invalid_iban)#, options.merge!(value: value))
+  end
+  
+  def regexp
+    /[A-Z]{2}[a-zA-Z0-9]{14,}/
+  end
+
+  def valid_iban?(iban)
+    # Move first four characters to end of string
+    first_four_chars = iban.slice!(0..3)
+    iban += first_four_chars
+
+    # Substitute all letters with integers
+    iban.split(//).each { |char| iban.gsub!(char, (char.downcase.ord - 87).to_s) if (char =~ /[a-zA-Z]/).present? }
+
+    # Check if division by 97 yields a remainder of 1, in which case it could be a valid IBAN
+    (iban.to_i % 97) == 1
+  end
+end

data/test/helper.rb

@@ -1,3 +1,4 @@
+require 'active_model'
 require 'simplecov'
 
 module SimpleCov::Configuration
@@ -8,7 +9,7 @@ end
 
 SimpleCov.configure do
   clean_filters
-  load_adapter 'test_frameworks'
+  load_profile 'test_frameworks'
 end
 
 ENV["COVERAGE"] && SimpleCov.start do
@@ -23,12 +24,16 @@ rescue Bundler::BundlerError => e
   $stderr.puts "Run `bundle install` to install missing gems"
   exit e.status_code
 end
-require 'test/unit'
+
+require 'minitest/autorun'
 require 'shoulda'
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 require 'bank-validator'
 
-class Test::Unit::TestCase
+class MiniTest::Test
+  include ActiveModel
 end
+
+MiniTest.autorun

data/test/test_bank-validator.rb

@@ -1,7 +1,51 @@
+require 'active_model'
 require 'helper'
 
-class TestBankValidator < Test::Unit::TestCase
-  should "probably rename this file and start testing for real" do
-    flunk "hey buddy, you should probably rename this file and start testing for real"
+class TestBankValidator < MiniTest::Test
+
+  class TestUser
+    include ActiveModel::Validations
+    validates :iban, iban: true
+
+    attr_accessor :iban
+
+    def initialize(attributes = {})
+      @iban = attributes[:iban]
+    end
+
+    def save
+      return false unless valid?
+    end
+
+    def self.create(attributes = {})
+      new(attributes).save
+    end
+  end
+
+  should "not save if the iban is too short" do
+    assert_equal TestUser.create(iban: "GB82WEST"), false
+  end
+
+  should "save if the iban is at least 16 characters" do
+    assert_equal TestUser.create(iban: "GB82WEST12345698765432"), nilk
+  end
+
+  should "returns false if the iban does not leave a remainder of 1 when divided by 97" do
+    assert_equal TestUser.create(iban: "GB82WEST123456987654Df"), false
+  end
+
+  should "returns true if the iban returns a remainder of 1 when divided by 97" do
+    assert_equal TestUser.create(iban: "GB82WEST12345698765432"), nil
+  end
+
+  should "work for different IBAN formats" do
+    #Belgium
+    assert_equal TestUser.create(iban: "BE62510007547061"), nil
+
+    #Bulgaria
+    assert_equal TestUser.create(iban: "BG80BNBG96611020345678"), nil
+
+    #Germany
+    assert_equal TestUser.create(iban: "DE89370400440532013000"), nil
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bank-validator
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Adam Bahlke
@@ -16,23 +16,37 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :runtime
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -125,7 +139,7 @@ files:
 - VERSION
 - bank-validator.gemspec
 - lib/active_model.rb
-- lib/active_model/validations/iban_validator.rb
+- lib/active_model/iban_validator.rb
 - lib/bank-validator.rb
 - test/helper.rb
 - test/test_bank-validator.rb

data/lib/active_model/validations/iban_validator.rb

@@ -1,34 +0,0 @@
-require 'active_model'
-module ActiveModel
-  module Validations
-    class IbanValidator < EachValidator
-
-      def validate_each(record, attribute, value)
-        record_error(record, attribute, value) unless value =~ regexp && valid_iban?(value)
-      end
-      
-      private
-      
-      def record_error(record, attribute, value)
-        record.errors.add(attribute, :invalid_iban, options.merge!(value: value))
-      end
-      
-      def regexp
-        /[A-Z]{2}[a-zA-Z0-9]{14,}/
-      end
-  
-      def valid_iban?(iban)
-        # Move first four characters to end of string
-        first_four_chars = iban.slice!(0..3)
-        iban += first_four_chars
-
-        # Substitute all letters with integers
-        iban.split(//).each { |char| iban.gsub!(char, char.downcase.ord - 87) if (char =~ /[a-zA-Z]/).present? }
-
-        # Check if division by 97 yields a remainder of 1, in which case it could be a valid IBAN
-        (iban.to_i % 97) == 1
-      end
-  
-    end
-  end
-end