bambora-client 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f9a1ebaa8ff8caf77c90408b8ed6b4688cd78b0f28210bc1aece1d6209a41dad
-  data.tar.gz: f47ca550819ee31a4fd516d72a7a16fe2c9c5732b830edee73fa83b4672f1630
+  metadata.gz: 395e9139c238631535595895b2f59ace8bbdb7ec65c853b44aa4eca6f85466bc
+  data.tar.gz: 6ccfb72d9d62005daf0327540d97bd86293494b86fb9f6ba5420738efd149d55
 SHA512:
-  metadata.gz: '08f5735b9efde79f4ccd9c28a5c63cde0aa0b3637c3d1a4944b9e64651a6e8a76cfa26c8a018cc57ba26f2028f8bc5235b8bfc3d4f82930591b6d07ee00c9fc6'
-  data.tar.gz: 8009add71906682226f07a64e639d18810bf08ea4adf7bc95ddc01116a5dd01b3a37bded5962c88c8839c59e719b80fbcf80bec947d9d26847b79dfac0dc047a
+  metadata.gz: d07e4984c23a99253a872596138de6a654d671995fedcf041a1eafeddbd68631f027395a04c084ad5ff82805216467a4b8ff7ee3401f501b2c2902f004406732
+  data.tar.gz: 1b8d8fea61f5f2e12cd2b667492c787dcdf30e3d62157ffb823cdbf836fd2ea273c30f4f6427da3ce57b7c1a84b68e317bc6fa91779292bd2012b630f21c0835

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.1.3 (2020-04-30)
+
+- Ensure Batch Report returns empty array `:record` in response at the very least
+
 ## 0.1.2 (2020-04-14)
 
 - Fix nil record with Bank Batch Report returns

data/lib/bambora/bank/batch_report_resource.rb

@@ -53,17 +53,24 @@ module Bambora
       #
       #  @params profile_data [Hash] with values as noted in the example.
       def show(report_data)
-        add_messages_to_response(
-          client.post(path: sub_path, body: batch_report_body(report_data)),
-        )
+        response = client.post(path: sub_path, body: batch_report_body(report_data))
+
+        response = ensure_record_key_exists(response)
+        response = add_messages_to_response(response)
+
+        response
       end
 
       private
 
-      def add_messages_to_response(response)
-        # bambora can return null or empty record results, don't decorate with messages
-        return response if response.dig(:response, :record).nil?
+      def ensure_record_key_exists(response)
+        # bambora can return null or empty record results, fill it in for consistency
+        response.dig(:response)[:record] = [] if response.dig(:response, :record).nil?
 
+        response
+      end
+
+      def add_messages_to_response(response)
         response.dig(:response, :record).map! do |record|
           record.merge!(messages: record[:messageId].split(',').map { |id| MESSAGES[id] })
         end

data/lib/bambora/client/version.rb

@@ -2,6 +2,6 @@
 
 module Bambora
   class Client
-    VERSION = '0.1.2'
+    VERSION = '0.1.3'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bambora-client
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Cassidy K
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-14 00:00:00.000000000 Z
+date: 2020-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: excon