bamboo-client 0.0.8 → 0.0.9

data/features/rest.feature

@@ -16,14 +16,13 @@ Feature: Bamboo REST client
     Then I should get a list of projects
     And all projects should have a key
 
-  Scenario: Fetch all builds
-    When I fetch all builds
-    Then I should get a list of builds
-    And all builds should have a state
+  Scenario: Fetch all results
+    When I fetch all results
+    Then I should get a list of results
+    And all results should have a state
   
   Scenario: Authenticated API
     When I log in
     Then I should get a session ID
-    When I fetch all the plans
-    Then I should get a list of plans
-    And all plans should have a key
+    When I fetch all results
+    Then all results should have a state

data/features/step_definitions/rest_steps.rb

@@ -24,12 +24,17 @@ Then /^all projects should have a key$/ do
   @projects.each { |e| e.key.should be_kind_of(String) }
 end
 
-When /^I fetch all builds$/ do
-  @builds = client.builds
+When /^I fetch all results$/ do
+  @results = client.results
 end
 
-Then /^all builds should have a state$/ do
-  @builds.each { |b| [:successful, :failed].should include(b.state) }
+Then /^I should get a list of results$/ do
+  @results.should_not be_empty
+  @results.each { |result| result.should be_kind_of(Bamboo::Client::Rest::Result) }
+end
+
+Then /^all results should have a state$/ do
+  @results.each { |r| [:successful, :failed].should include(r.state) }
 end
 
 When /^I log in$/ do
@@ -38,4 +43,4 @@ end
 
 Then /^I should get a session ID$/ do
   client.cookies.has_key? :JSESSIONID
-end
+end

data/lib/bamboo-client/http/xml.rb

@@ -41,7 +41,15 @@ module Bamboo
         end # Doc
 
         def post(path, data = {})
-          Doc.from RestClient.post(uri_for(path), data)
+          resp = RestClient.post(uri_for(path), data) do |response, request, result, &block|
+            if [301, 302, 307].include? response.code
+              response.follow_redirection(request, result, &block)
+            else
+              response.return!(request, result, &block)
+            end
+          end
+
+          Doc.from resp
         end
 
       end # Xml

data/lib/bamboo-client/rest.rb

@@ -37,8 +37,8 @@ module Bamboo
         get("project/").auto_expand Project, @http
       end
 
-      def builds
-        get("build/").auto_expand Build, @http
+      def results
+        get("result/").auto_expand Result, @http
       end
 
       private
@@ -97,7 +97,7 @@ module Bamboo
         end
       end # Project
 
-      class Build
+      class Result
         def initialize(data, http)
           @data = data
           @http = http
@@ -145,7 +145,7 @@ module Bamboo
         def fetch_details(expand)
           @http.get(uri, :expand => expand)
         end
-      end # Build
+      end # Result
 
       class Change
         def initialize(data, http)

data/lib/bamboo-client/version.rb

@@ -1,5 +1,5 @@
 module Bamboo
   module Client
-    VERSION = "0.0.8"
+    VERSION = "0.0.9"
   end
 end

data/spec/bamboo-client/rest_spec.rb

@@ -39,13 +39,13 @@ module Bamboo
         client.projects.should == %w[foo bar]
       end
 
-      it "should be able to fetch builds" do
-        document.should_receive(:auto_expand).with(Rest::Build, http).and_return %w[foo bar]
+      it "should be able to fetch results" do
+        document.should_receive(:auto_expand).with(Rest::Result, http).and_return %w[foo bar]
 
-        http.should_receive(:get).with("/rest/api/latest/build/", nil, nil).
+        http.should_receive(:get).with("/rest/api/latest/result/", nil, nil).
                                   and_return(document)
 
-        client.builds.should == %w[foo bar]
+        client.results.should == %w[foo bar]
       end
 
       describe Rest::Plan do
@@ -95,38 +95,38 @@ module Bamboo
         end
       end
 
-      describe Rest::Build do
-        let(:data) { json_fixture("build") }
-        let(:build) { Rest::Build.new data, http }
+      describe Rest::Result do
+        let(:data) { json_fixture("result") }
+        let(:result) { Rest::Result.new data, http }
 
         it "has a key" do
-          build.key.should == "IAD-DEFAULT-5388"
+          result.key.should == "IAD-DEFAULT-5388"
         end
 
         it "has a state" do
-          build.state.should == :successful
+          result.state.should == :successful
         end
 
         it "has an id" do
-          build.id.should == 8487295
+          result.id.should == 8487295
         end
 
         it "has a number" do
-          build.number.should == 5388
+          result.number.should == 5388
         end
 
         it "has a life cycle state" do
-          build.life_cycle_state.should == :finished
+          result.life_cycle_state.should == :finished
         end
 
         it "has a URL" do
-          build.url.should == "http://localhost:8085/rest/api/latest/result/IAD-DEFAULT-5388"
+          result.url.should == "http://localhost:8085/rest/api/latest/result/IAD-DEFAULT-5388"
         end
 
         it "has a list of changes" do
           # TODO: arg expectation
-          http.should_receive(:get).and_return Http::Json::Doc.new(json_fixture("build_with_changes"))
-          build.changes.first.should be_kind_of(Rest::Change)
+          http.should_receive(:get).and_return Http::Json::Doc.new(json_fixture("result_with_changes"))
+          result.changes.first.should be_kind_of(Rest::Change)
         end
       end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: bamboo-client
 version: !ruby/object:Gem::Version 
-  hash: 15
+  hash: 13
   prerelease: 
   segments: 
   - 0
   - 0
-  - 8
-  version: 0.0.8
+  - 9
+  version: 0.0.9
 platform: ruby
 authors: 
 - Jari Bakken
@@ -144,7 +144,6 @@ files:
 - features/rest.feature
 - features/step_definitions/remote_steps.rb
 - features/step_definitions/rest_steps.rb
-- features/step_definitions/rest_steps.rb~
 - features/support/env.rb
 - lib/bamboo-client.rb
 - lib/bamboo-client/abstract.rb
@@ -160,13 +159,13 @@ files:
 - spec/bamboo-client/http/xml_spec.rb
 - spec/bamboo-client/remote_spec.rb
 - spec/bamboo-client/rest_spec.rb
-- spec/fixtures/build.json
 - spec/fixtures/build.xml
 - spec/fixtures/build_result.xml
-- spec/fixtures/build_with_changes.json
 - spec/fixtures/change.json
 - spec/fixtures/plan.json
 - spec/fixtures/project.json
+- spec/fixtures/result.json
+- spec/fixtures/result_with_changes.json
 - spec/spec_helper.rb
 homepage: ""
 licenses: []
@@ -206,19 +205,18 @@ test_files:
 - features/rest.feature
 - features/step_definitions/remote_steps.rb
 - features/step_definitions/rest_steps.rb
-- features/step_definitions/rest_steps.rb~
 - features/support/env.rb
 - spec/bamboo-client/client_spec.rb
 - spec/bamboo-client/http/json_spec.rb
 - spec/bamboo-client/http/xml_spec.rb
 - spec/bamboo-client/remote_spec.rb
 - spec/bamboo-client/rest_spec.rb
-- spec/fixtures/build.json
 - spec/fixtures/build.xml
 - spec/fixtures/build_result.xml
-- spec/fixtures/build_with_changes.json
 - spec/fixtures/change.json
 - spec/fixtures/plan.json
 - spec/fixtures/project.json
+- spec/fixtures/result.json
+- spec/fixtures/result_with_changes.json
 - spec/spec_helper.rb
 has_rdoc: 

data/features/step_definitions/rest_steps.rb~

@@ -1,38 +0,0 @@
-When /^I fetch all the plans$/ do
-  @plans = client.plans
-end
-
-Then /^I should get a list of plans$/ do
-  @plans.should_not be_empty
-  @plans.each { |plan| plan.should be_kind_of(Bamboo::Client::Rest::Plan) }
-end
-
-When /^I fetch all projects$/ do
-  @projects = client.projects
-end
-
-Then /^I should get a list of projects$/ do
-  @projects.should_not be_empty
-  @projects.each { |pro| pro.should be_kind_of(Bamboo::Client::Rest::Project) }
-end
-
-Then /^all plans should have a key$/ do
-  @plans.each { |e| e.key.should be_kind_of(String) }
-end
-
-Then /^all projects should have a key$/ do
-  @projects.each { |e| e.key.should be_kind_of(String) }
-end
-
-When /^I fetch all builds$/ do
-  @builds = client.builds
-end
-
-Then /^all builds should have a state$/ do
-  @builds.each { |b| [:successful, :failed].should include(b.state) }
-end
-
-When /^I login to in with my credentials, (.*) and (.*)$/ do |username, password|
-  client.login(username, password)
-  client.cookies != nil
-end