balanced 0.3.3 → 0.3.4

data/.travis.yml

@@ -1,3 +1,6 @@
 language: ruby
+bundler_args: --without development
+script: "bundle exec rake spec"
 rvm:
+  - 1.9.2
   - 1.9.3

data/Gemfile

@@ -1,7 +1,19 @@
-source 'https://rubygems.org'
-
+source :rubygems
 
 # Specify your gem's dependencies in balanced.gemspec
-gemspec
 
-gem 'rspec'
+gem "faraday"
+gem "faraday_middleware"
+
+group :development do
+  gem "yard"
+  gem "ruby-debug19"
+  gem "guard", '~> 1.1.1'
+  gem "guard-rspec", '~> 1.0.0'
+end
+
+group :test do
+  gem "rspec", '~> 2.10'
+  gem "rake", '~> 0.9.2'
+  gem "vcr", '~> 2.2.0'
+end

data/Rakefile

@@ -3,8 +3,10 @@ require "rake"
 require "rspec/core/rake_task"
 require "bundler/gem_tasks"
 
-RSpec::Core::RakeTask.new
+desc "Run spec suite"
+RSpec::Core::RakeTask.new(:spec) { |t| }
 
+desc "Default the task to run the spec"
 task :default => [:spec]
 
 

data/balanced.gemspec

@@ -1,9 +1,11 @@
+#!/usr/bin/env gem build
 # -*- encoding: utf-8 -*-
+require "base64"
 require File.expand_path('../lib/balanced/version', __FILE__)
 
 Gem::Specification.new do |gem|
   gem.authors       = ["Mahmoud Abdelkader"]
-  gem.email         = %w(mahmoud@poundpay.com)
+  gem.email         = ["bWFobW91ZEBwb3VuZHBheS5jb20="].map { |i| Base64.decode64(i) }
   gem.description   = %q{Balanced is the payments platform for marketplaces.
     Integrate a payments experience just like Amazon for your marketplace.
     Forget about dealing with banking systems, compliance, fraud, and security.
@@ -14,17 +16,10 @@ Gem::Specification.new do |gem|
   gem.add_dependency("faraday", '~> 0.8')
   gem.add_dependency("faraday_middleware", '~> 0.8.7')
 
-  gem.add_development_dependency("rspec", '~> 2.10')
-  gem.add_development_dependency("vcr", '~> 2.2.0')
-  gem.add_development_dependency("guard", '~> 1.1.1')
-  gem.add_development_dependency("guard-rspec", '~> 1.0.0')
-  gem.add_development_dependency("yard")
-  gem.add_development_dependency("ruby-debug19")
-
   gem.files         = `git ls-files`.split($\)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = "balanced"
   gem.require_paths = %w(lib)
   gem.version       = Balanced::VERSION
-end
+end

data/examples/examples.rb

@@ -116,5 +116,3 @@ bank_account['is_valid'] = false
 bank_account.save
 
 raise "This card is INCORRECTLY VALID" if bank_account.is_valid
-
-puts "and there you have it :)"

data/lib/balanced/client.rb

@@ -1,7 +1,9 @@
-require 'logger'
+require "logger"
 require "uri"
 require "faraday"
 require "faraday_middleware"
+require "balanced_exception_middleware"
+
 
 module Balanced
   class Client
@@ -27,12 +29,16 @@ module Balanced
       logger = Logger.new(STDOUT)
       logger.level = Logger.const_get(DEFAULTS[:logging_level].to_s)
 
+      Faraday.register_middleware :response,
+          :handle_balanced_errors => lambda {Faraday::Response::RaiseBalancedError}
+
       @conn = Faraday.new url do |cxn|
         cxn.request  :json
 
         cxn.response :logger, logger
+        cxn.response :handle_balanced_errors
         cxn.response :json
-        cxn.response :raise_error  # raise exceptions on 40x, 50x responses
+        # cxn.response :raise_error  # raise exceptions on 40x, 50x responses
         cxn.adapter  Faraday.default_adapter
       end
       conn.path_prefix = '/'

data/lib/balanced/error.rb

@@ -0,0 +1,85 @@
+module Balanced
+
+  # Custom error class for rescuing from all Balanced errors
+  class Error < StandardError
+    attr_reader :response
+
+    def initialize(response)
+      @response = response
+      super error_message
+    end
+
+    def body
+      Utils.hash_with_indifferent_read_access response[:body]
+    end
+
+    def error_message
+      set_attrs
+      extra = body[:additional] ? " -- #{body[:additional]}" : ""
+      "#{self.class.name}(#{response[:status]})::#{body[:status]}:: "\
+      "#{response[:method].to_s.upcase} #{response[:url].to_s}: "\
+      "#{body[:category_code]}: #{body[:description]} #{extra}"
+    end
+
+    private
+    def set_attrs
+      body.keys.each do |name|
+        self.class.instance_eval {
+          define_method(name) { body[name] }                       # Get.
+          define_method("#{name}?") { !!body[name].nil? }          # Present.
+        }
+      end
+    end
+  end
+
+  class MoreInformationRequired < Error
+    def redirect_uri
+      response.headers['Location']
+    end
+
+    def error_message
+      set_attrs
+      "#{self.class.name} :: #{response[:method].to_s.upcase} #{response[:url].to_s}: "\
+      "#{response[:status]}: \n#{body[:friendly_html]}"
+    end
+  end
+
+  # Raised when Balanced returns a 400 HTTP status code
+  class BadRequest < Error; end
+
+  # Raised when Balanced returns a 401 HTTP status code
+  class Unauthorized < Error; end
+
+  # Raised when Balanced returns a 402 HTTP status code
+  class PaymentRequired < Error; end
+
+  # Raised when Balanced returns a 403 HTTP status code
+  class Forbidden < Error; end
+
+  # Raised when Balanced returns a 404 HTTP status code
+  class NotFound < Error; end
+
+  # Raised when Balanced returns a 405 HTTP status code
+  class MethodNotAllowed < Error; end
+
+  # Raised when Balanced returns a 409 HTTP status code
+  class Conflict < Error; end
+
+  # Raised when Balanced returns a 410 HTTP status code
+  class Gone < Error; end
+
+  # Raised when Balanced returns a 500 HTTP status code
+  class InternalServerError < Error; end
+
+  # Raised when Balanced returns a 501 HTTP status code
+  class NotImplemented < Error; end
+
+  # Raised when Balanced returns a 502 HTTP status code
+  class BadGateway < Error; end
+
+  # Raised when Balanced returns a 503 HTTP status code
+  class ServiceUnavailable < Error; end
+
+  # Raised when Balanced returns a 504 HTTP status code
+  class GatewayTimeout < Error; end
+end

data/lib/balanced/resources/account.rb

@@ -7,18 +7,6 @@ module Balanced
   class Account
     include Balanced::Resource
 
-    class MoreInformationRequiredError < StandardError
-      attr_reader :response
-
-      def initialize(response)
-        @response = response
-      end
-
-      def redirect_uri
-        response.headers['Location']
-      end
-    end
-
     def initialize attributes = {}
       Balanced::Utils.stringify_keys! attributes
       unless attributes.has_key? 'uri'
@@ -27,6 +15,17 @@ module Balanced
       super attributes
     end
 
+    # Attempts to find an existing buyer account by email
+    #
+    # @param [String] email An email of a buyer account
+    # @return [Account] if buyer is found
+    # @return [nil] if buyer is not found
+    def self.find_by_email email
+      response = Balanced.get Balanced::Marketplace.my_marketplace.accounts_uri, {email_address: email}
+      record = response.body["items"].first
+      construct_from_response(record) unless record.nil?
+    end
+
     def save
       the_response = super
       if response.status == 300

data/lib/balanced/response/balanced_exception_middleware.rb

@@ -0,0 +1,33 @@
+require 'faraday'
+require 'balanced/error'
+
+# @api private
+module Faraday
+
+  class Response::RaiseBalancedError < Response::Middleware
+
+    HTTP_STATUS_CODES = {
+        300 => Balanced::MoreInformationRequired,
+        400 => Balanced::BadRequest,
+        401 => Balanced::Unauthorized,
+        402 => Balanced::PaymentRequired,
+        403 => Balanced::Forbidden,
+        404 => Balanced::NotFound,
+        405 => Balanced::MethodNotAllowed,
+        409 => Balanced::Conflict,
+        410 => Balanced::Gone,
+        500 => Balanced::InternalServerError,
+        501 => Balanced::NotImplemented,
+        502 => Balanced::BadGateway,
+        503 => Balanced::ServiceUnavailable,
+        504 => Balanced::GatewayTimeout,
+    }
+    def on_complete(response)
+      status_code = response[:status].to_i
+      error_class = HTTP_STATUS_CODES[status_code]
+      raise error_class.new(response) if error_class
+    end
+
+  end
+
+end

data/lib/balanced/utils.rb

@@ -31,8 +31,15 @@ module Balanced
     end
 
     def hash_with_indifferent_read_access base = {}
-      indifferent = Hash.new { |hash, key| hash[key.to_s] if key.is_a? Symbol }
-      base.each_pair { |key, value| indifferent[key.to_s] = value }
+      indifferent = Hash.new do |hash, key|
+        hash[key.to_s] if key.is_a? Symbol
+      end
+      base.each_pair do |key, value|
+        if value.is_a? Hash
+          value = hash_with_indifferent_read_access value
+        end
+        indifferent[key.to_s] = value
+      end
       indifferent
     end
 

data/lib/balanced/version.rb

@@ -1,3 +1,3 @@
 module Balanced
-  VERSION = '0.3.3'
+  VERSION = '0.3.4'
 end

data/lib/balanced.rb

@@ -1,10 +1,12 @@
 $:.unshift File.join(File.dirname(__FILE__), "balanced", "resources")
+$:.unshift File.join(File.dirname(__FILE__), "balanced", "response")
 
 require 'uri'
 require 'balanced/version' unless defined? Balanced::VERSION
 require 'balanced/client'
 require 'balanced/utils'
 require 'balanced/resources'
+require 'balanced/error'
 
 module Balanced
 

data/spec/balanced/resources/account_spec.rb

@@ -419,4 +419,36 @@ describe Balanced::Account do
 
     end
   end
+
+  describe ".find_by_email" do
+    use_vcr_cassette
+    before do
+      api_key = Balanced::ApiKey.new.save
+      Balanced.configure api_key.secret
+      @marketplace = Balanced::Marketplace.new.save
+      card = Balanced::Card.new(
+        :card_number => "5105105105105100",
+        :expiration_month => "12",
+        :expiration_year => "2015",
+      ).save
+      buyer = Balanced::Marketplace.my_marketplace.create_buyer(
+        "john.doe@example.com",
+        card.uri
+      )
+    end
+
+    context "email address is in system" do
+      use_vcr_cassette
+      it "should return account object" do
+        Balanced::Account.find_by_email("john.doe@example.com").should be_instance_of Balanced::Account
+      end
+    end
+
+    context "email address does not exist" do
+      use_vcr_cassette
+      it "should return nil" do
+        Balanced::Account.find_by_email("foo@bar.com").should be_nil
+      end
+    end
+  end
 end

data/spec/balanced/response/balanced_exception_middleware_spec.rb

@@ -0,0 +1,47 @@
+require "spec_helper"
+require "faraday"
+
+describe Faraday::Response::RaiseBalancedError, :type => :response do
+  context "when used" do
+    let(:raise_server_error) { described_class.new }
+  end
+
+  context "integration test" do
+
+    before(:each) do
+      Faraday.register_middleware :response,
+          :handle_balanced_errors => lambda { described_class }
+      VCR.turn_off!
+    end
+
+    after(:each)  do
+      VCR.turn_on!
+    end
+
+    let(:stubs) { Faraday::Adapter::Test::Stubs.new }
+    let(:connection) do
+      Faraday::Connection.new do |builder|
+        builder.response :handle_balanced_errors
+        builder.response :json
+        builder.adapter :test, stubs
+      end
+    end
+
+    it "should raise exceptions on bad request errors" do
+      stubs.get("/error") {
+        [400, {}, JSON.dump({
+            :status =>"Bad Request",
+            :status_code =>400,
+            :description => "Missing expected field expiration_year Your request "\
+                            "id is OHM62bf258abfea11e1aaba026ba7e5e72e.",
+            :request_id => "OHM62bf258abfea11e1aaba026ba7e5e72e"
+        })]
+      }
+
+      lambda {
+        connection.get('/error')
+      }.should raise_error(Balanced::BadRequest)
+    end
+
+  end
+end

data/spec/spec_helper.rb

@@ -1,9 +1,15 @@
 require 'rubygems'
 require 'bundler/setup'
-require 'ruby-debug'
 require 'balanced'
 require 'vcr'
 
+begin
+  require 'ruby-debug'
+rescue LoadError
+# ignored
+end
+
+
 VCR.configure do |c|
   c.cassette_library_dir = 'spec/cassettes'
   c.hook_into :faraday

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: balanced
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-21 00:00:00.000000000 Z
+date: 2012-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -43,102 +43,6 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 0.8.7
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.10'
-- !ruby/object:Gem::Dependency
-  name: vcr
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 2.2.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 2.2.0
-- !ruby/object:Gem::Dependency
-  name: guard
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.1.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.1.1
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.0.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.0.0
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: ruby-debug19
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 description: ! "Balanced is the payments platform for marketplaces.\n    Integrate
   a payments experience just like Amazon for your marketplace.\n    Forget about dealing
   with banking systems, compliance, fraud, and security.\n    "
@@ -172,6 +76,7 @@ files:
 - examples/examples.rb
 - lib/balanced.rb
 - lib/balanced/client.rb
+- lib/balanced/error.rb
 - lib/balanced/resources.rb
 - lib/balanced/resources/account.rb
 - lib/balanced/resources/api_key.rb
@@ -185,12 +90,14 @@ files:
 - lib/balanced/resources/refund.rb
 - lib/balanced/resources/resource.rb
 - lib/balanced/resources/transaction.rb
+- lib/balanced/response/balanced_exception_middleware.rb
 - lib/balanced/utils.rb
 - lib/balanced/version.rb
 - spec/balanced/resources/account_spec.rb
 - spec/balanced/resources/api_key_spec.rb
 - spec/balanced/resources/hold_spec.rb
 - spec/balanced/resources/marketplace_spec.rb
+- spec/balanced/response/balanced_exception_middleware_spec.rb
 - spec/balanced_spec.rb
 - spec/client_spec.rb
 - spec/spec_helper.rb
@@ -225,7 +132,9 @@ test_files:
 - spec/balanced/resources/api_key_spec.rb
 - spec/balanced/resources/hold_spec.rb
 - spec/balanced/resources/marketplace_spec.rb
+- spec/balanced/response/balanced_exception_middleware_spec.rb
 - spec/balanced_spec.rb
 - spec/client_spec.rb
 - spec/spec_helper.rb
 - spec/utils_spec.rb
+has_rdoc: