bai2 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 975f734808bc96fce7ca38c08e1ba90e8839b8c6
-  data.tar.gz: 99d17eec7002b0b0c6ca70b9a3228f2500efadc5
+  metadata.gz: b2c135a421db2cecf82dd36a921239da5893f64f
+  data.tar.gz: 13b70262c5e59a5c0568fa4ddabddb3deb7176f1
 SHA512:
-  metadata.gz: bdd5385fe33114722442f33838c2bab6406cfc41ab7a1e3125bd09bf1d269e351e57008090da8ccb34b6ae11edefd4ec222cf9ae7fad32edcd3fb86a9b18bb6e
-  data.tar.gz: eb2228fdfaaba4856d141508995809e7ecc0235de2b6437206faa774c9382c469486ae9a001be4a2398746882a697b59936fd01aad5cf1713382159c6eed3ed7
+  metadata.gz: b23d85fe51f1ec6b4e75a9c9735c796dc2ba5249baba21d2b35663d0ccf0e747f57079df2d0b79965c6788d87fc24789c86e3683c0b78d078d1522082a872161
+  data.tar.gz: 045ebbb486134bde017a2d3de65a3a5ff21bcd92f217645e62171c35f0f36ba3b3e6a1930aa81db736b37b7dc183c812e70c0e8b34b62fddf3f23b63dce30eeb

data/.circleci/config.yml

@@ -0,0 +1,37 @@
+version: 2
+jobs:
+  build:
+    parallelism: 1
+    resource_class: small
+    working_directory: "~/bai2"
+    docker:
+    - image: 207583270433.dkr.ecr.us-west-1.amazonaws.com/universe/ruby_24:0.15
+    steps:
+      - checkout
+      - run:
+          name: build gem
+          command: |
+            gem build bai2.gemspec
+      - run:
+          name: push gem
+          command: |
+            if [[ -n "${GEMFURY_USERNAME}" && -n "${GEMFURY_PASSWORD}" ]]; then
+              echo -e "machine api.fury.io\n  login ${GEMFURY_USERNAME}\n  password ${GEMFURY_PASSWORD}" >> ~/.netrc
+              chmod 600 ~/.netrc
+              version=$(parse-gemspec-cli bai2.gemspec | jq -r ".version")
+              grep -q "${version}" <(fury versions bai2) || EXIT_CODE=$? && true
+              if [[ $EXIT_CODE == 1 ]]; then
+                fury push bai2-${version}.gem
+              else
+                echo "bai2 version ${version} has previously been released to gemfury, increment the version for a new release"
+              fi
+            fi
+workflows:
+  version: 2
+  build-and-push:
+    jobs:
+    - build:
+        context: org-global
+        filters:
+          branches:
+            only: master

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 Changelog
 
+## 2.0.1
+- Add `continuations_slash_delimit_end_of_line_only` to options. This option allows parsing continuation records that begin with a slash character (`/`).
+
 ## 2.0.0
 - Add parameters for whether or not we use account summaries for account control checksum. We now include it by default. To disable it `account_control_ignores_summary_amounts` should passed into `options` This is the only breaking change.
 - Allow for optional "as of" times on the Group header.

data/README.md

@@ -86,6 +86,9 @@ account control values.
 * `options[:num_account_summary_continuation_records]` (Integer, Default: 0)
 The number of continuation records the account summary.
 
+* `options[:continuations_slash_delimit_end_of_line_only]` (Boolean, Default: False)
+This allows continuation records to begin with `88,\` and still have the text including the slash to be processed.
+
 
 ##### Usage:
 

data/bai2.gemspec

@@ -1,11 +1,10 @@
 # coding: utf-8
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'bai2/version'
 
 Gem::Specification.new do |spec|
   spec.name          = 'bai2'
-  spec.version       = Bai2::VERSION
+  spec.version       = '2.0.1'
   spec.authors       = ['Kenneth Ballenegger']
   spec.email         = ['kenneth@ballenegger.com']
   spec.summary       = %q{Parse BAI2 files.}

data/lib/bai2.rb

@@ -1,4 +1,3 @@
-require 'bai2/version'
 require 'bai2/record'
 require 'bai2/parser'
 require 'bai2/integrity'
@@ -13,7 +12,8 @@ module Bai2
 
     DEFAULT_OPTIONS = {
       account_control_ignores_summary_amounts: false,
-      num_account_summary_continuation_records: 0
+      num_account_summary_continuation_records: 0,
+      continuations_slash_delimit_end_of_line_only: false,
     }.freeze
 
     # Parse a file on disk:
@@ -33,7 +33,7 @@ module Bai2
       @raw = raw
       @groups = []
       @options = DEFAULT_OPTIONS.merge(options)
-      parse(raw)
+      parse(raw, options)
     end
 
     # This is the raw data. Probably not super important.
@@ -62,9 +62,9 @@ module Bai2
     # This delegates most of the work to Bai2::Parser to build the ParseNode
     # tree.
     #
-    def parse(data)
+    def parse(data, options)
 
-      root = Parser.parse(data)
+      root = Parser.parse(data, options)
 
       # parse the file node; will descend tree and parse children
       parse_file_node(root)

data/lib/bai2/parser.rb

@@ -26,10 +26,10 @@ module Bai2
       # 1. Build a tree
       # 2. Parse the tree
       #
-      def parse(data)
+      def parse(data, options)
 
         # split records, handle stupid DOS-format files, instantiate records
-        records = data.split("\n").map(&:strip).map {|l| Record.new(l) }
+        records = data.split("\n").map(&:strip).map {|l| Record.new(l, options: options) }
 
         # merge continuations
         records = merge_continuations(records)

data/lib/bai2/record.rb

@@ -112,11 +112,18 @@ module Bai2
     }
 
 
-    def initialize(line, physical_record_count = 1)
+    def initialize(line, physical_record_count = 1, options: {})
       @code = RECORD_CODES[line[0..1]]
       @physical_record_count = physical_record_count
       # clean / delimiter
-      @raw = line.sub(/,\/.+$/, '').sub(/\/$/, '')
+      @raw = if options[:continuations_slash_delimit_end_of_line_only]
+              # Continuation records for transaction details extend the text fields
+              # and they may begin with 88,/ but should include the rest of the line.
+              # A proper fix would involve each continuation record knowing what field it was extending.
+              line.sub(/\/$/, '')
+             else
+              line.sub(/,\/.+$/, '').sub(/\/$/, '')
+             end
     end
 
     attr_reader :code, :raw, :physical_record_count

data/test/data/eod_with_slash_in_text.bai2

@@ -0,0 +1,18 @@
+01,121140399,3333333333,100831,1720,000001,80,1,2/
+02,3333333333,121140399,1,100831,,USD,4/
+03,3333333333,USD,,,,/
+16,195,8325982,,,,FED NO: 20100831L1B77D1CDSDSDJSIO15608310954FT01
+88,SENDER BNK:=ETRADE BANK
+88,SENDER ID:=056073573
+88,ORG:=OPTIONS LINK WIRE CLEARING
+88,ORG ADDRESS:=2/AV MAIN 2/AVENUE DE ANGELLIST 3/MX
+88,/MEXICO ;
+88,BNF ID:=3300333333
+88,BNF NAME:=YOUR NAME HERE INC
+88,BNF ADDRESS:=185 B ST SAN FRAN, CA 94011
+88,REC FI:=SIL VLY BK SCLA
+88,REC ID:=121140399
+88,OBI:=INVOICE 123456
+49,8325982,14/
+98,8325982,1,16/
+99,8325982,1,18/

data/test/tests/bai2.rb

@@ -11,8 +11,10 @@ class Bai2Test < Minitest::Test
 
     @eod = Bai2::BaiFile.parse(File.expand_path('../../data/eod.bai2', __FILE__))
     @eod_no_as_of_time = Bai2::BaiFile.parse(File.expand_path('../../data/eod_without_as_of_time.bai2', __FILE__))
+    @eod_with_slash_in_continuation = Bai2::BaiFile.parse(File.expand_path('../../data/eod_with_slash_in_text.bai2', __FILE__),
+                                                          continuations_slash_delimit_end_of_line_only: true)
 
-    @all_files = [@daily, @daily_with_summary, @eod, @eod_no_as_of_time]
+    @all_files = [@daily, @daily_with_summary, @eod, @eod_no_as_of_time, @eod_with_slash_in_continuation]
   end
 
   def test_parsing
@@ -73,5 +75,4 @@ class Bai2Test < Minitest::Test
       Bai2::BaiFile.parse(File.expand_path('../../data/invalid_checksum_eod.bai2', __FILE__))
     end
   end
-
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bai2
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Kenneth Ballenegger
@@ -73,6 +73,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".gitignore"
 - CHANGELOG.md
 - Gemfile
@@ -86,11 +87,11 @@ files:
 - lib/bai2/parser.rb
 - lib/bai2/record.rb
 - lib/bai2/type-code-data.rb
-- lib/bai2/version.rb
 - test/autorun.rb
 - test/data/daily.bai2
 - test/data/daily_with_summary.bai2
 - test/data/eod.bai2
+- test/data/eod_with_slash_in_text.bai2
 - test/data/eod_without_as_of_time.bai2
 - test/data/invalid_checksum_eod.bai2
 - test/tests/bai2.rb
@@ -124,6 +125,7 @@ test_files:
 - test/data/daily.bai2
 - test/data/daily_with_summary.bai2
 - test/data/eod.bai2
+- test/data/eod_with_slash_in_text.bai2
 - test/data/eod_without_as_of_time.bai2
 - test/data/invalid_checksum_eod.bai2
 - test/tests/bai2.rb

data/lib/bai2/version.rb

@@ -1,3 +0,0 @@
-module Bai2
-  VERSION = '2.0.0'
-end