bagger 0.1.0 → 0.1.1

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## v 0.1.1
+
+* Do not version cache manifest (http://diveintohtml5.org/offline.html)
+
 ## v 0.1.0
 
 * Combine javascript and stylesheets into several packages

data/lib/bagger/packager.rb

@@ -20,6 +20,10 @@ module Bagger
       @manifest = {}
     end
 
+    def add_to_manifest(key, path)
+      @manifest[key] = File.expand_path(@path_prefix + "/" + path)
+    end
+
     def to_manifest(path, keep_original = true)
       content = File.open(File.join(@target_dir, path)) { |f| f.read }
       extension = File.extname(path)
@@ -32,9 +36,8 @@ module Bagger
       File.open(new_file_path, 'w') { |f| f.write content }
       FileUtils.rm(File.join(@target_dir, path)) unless keep_original
       manifest_key_path = File.expand_path("/#{dirname}/#{basename}#{extension}")
-      effective_path = File.expand_path(@path_prefix + "/" + File.join(dirname, new_file_name))
-      @manifest[manifest_key_path] = effective_path
-    end
+      add_to_manifest(manifest_key_path, File.join(dirname, new_file_name))
+   end
 
     def stylesheets
       @stylesheets ||= calculate_stylesheets
@@ -49,7 +52,7 @@ module Bagger
       version_files
       combine_css
       combine_js
-      generate_and_version_cache_manifest
+      generate_cache_manifest
       write_manifest
     end
 
@@ -127,7 +130,11 @@ module Bagger
       File.open(File.join(@target_dir, javascript_path), 'w'){|f| f.write compressed}
     end
 
-    def generate_and_version_cache_manifest
+    # IMPORTANT:html 5 cache manifest should not be cached
+    # because that would treat it as a new manifest with
+    # new resources discarding the ones already downloaded
+    # http://diveintohtml5.org/offline.html
+    def generate_cache_manifest
       path = File.join(@target_dir, @cache_manifest_path)
       FileUtils.mkdir_p(File.dirname(path))
       File.open(path, 'w') do |f|
@@ -139,7 +146,7 @@ module Bagger
         f.puts 'NETWORK:'
         f.puts '*'
       end
-      to_manifest(@cache_manifest_path)
+      add_to_manifest(File.join("/", @cache_manifest_path), @cache_manifest_path)
     end
 
     protected

data/lib/bagger/version.rb

@@ -1,3 +1,3 @@
 module Bagger
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/test/bagger_test.rb

@@ -90,13 +90,13 @@ class BaggerTest < Test::Unit::TestCase
 
     should 'add the cache manifest to the manifest' do
       Bagger.bagit!(default_options)
-      assert_match /\/cache\..*\.manifest/, manifest['/cache.manifest']
+      assert_equal "/cache.manifest", manifest['/cache.manifest']
     end
 
-    should 'create a versioned cache manifest' do
+    should 'not version the cache manifest (http://diveintohtml5.org/offline.html)' do
       Bagger.bagit!(default_options)
-      expected_path = File.join(@target_dir, manifest['/cache.manifest'])
-      assert File.exists?(expected_path), 'versioned cache manifest not found'
+      expected_path = File.join(@target_dir, 'cache.manifest')
+      assert File.exists?(expected_path), 'unversionened cache manifest not found'
     end
 
     should 'allow to specify the path' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bagger
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-08-12 00:00:00.000000000 Z
+date: 2011-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
-  requirement: &70153224223720 !ruby/object:Gem::Requirement
+  requirement: &70212879727180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70153224223720
+  version_requirements: *70212879727180
 - !ruby/object:Gem::Dependency
   name: addressable
-  requirement: &70153224223120 !ruby/object:Gem::Requirement
+  requirement: &70212879721620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70153224223120
+  version_requirements: *70212879721620
 - !ruby/object:Gem::Dependency
   name: uglifier
-  requirement: &70153224222560 !ruby/object:Gem::Requirement
+  requirement: &70212879718780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70153224222560
+  version_requirements: *70212879718780
 - !ruby/object:Gem::Dependency
   name: rainpress
-  requirement: &70153224221960 !ruby/object:Gem::Requirement
+  requirement: &70212879718260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70153224221960
+  version_requirements: *70212879718260
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70153224221440 !ruby/object:Gem::Requirement
+  requirement: &70212879717020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70153224221440
+  version_requirements: *70212879717020
 - !ruby/object:Gem::Dependency
   name: shoulda-context
-  requirement: &70153224220920 !ruby/object:Gem::Requirement
+  requirement: &70212879716160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70153224220920
+  version_requirements: *70212879716160
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &70153224220300 !ruby/object:Gem::Requirement
+  requirement: &70212879715420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,7 +87,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70153224220300
+  version_requirements: *70212879715420
 description: ! 'A framework agnostic packaging solution for your assets: version files,
   combine them, minify them and create a manifest'
 email: