badgeville_berlin 1.0.1 → 1.0.2

data/README_ADVANCED.md

@@ -106,7 +106,10 @@ This is an open source Ruby wrapper for interacting with the [Badgeville RESTful
 
 ```
 
-### 8. Delete a reward definition.
+### 8. Delete a reward definition. 
+<ul>
+  <li>A reward definition can only be deleted if associated earned rewards have been deleted.</li>
+</ul>
 ```ruby
         BadgevilleBerlin::RewardDefinition.delete(new_reward_def.id)
 ```

data/badgeville.gemspec

@@ -31,6 +31,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency "autotest-growl"
   s.add_development_dependency "logger", ">=1.2.8"
 
-  s.add_runtime_dependency "activeresource", '>= 3.1.3'
+  s.add_runtime_dependency "activeresource", "~> 3.1"
   # s.add_runtime_dependency "rest-client"
 end

data/lib/badgeville_berlin/activity_definition.rb

@@ -1,5 +1,6 @@
 # Subclasses BaseResource to represent a remote resource model class.
 module BadgevilleBerlin
   class ActivityDefinition < BadgevilleBerlin::BaseResource
+    COMPLEX_ATTRIBUTES = :selector, :adjustment
   end
 end

data/lib/badgeville_berlin/base_resource.rb

@@ -4,6 +4,8 @@ module BadgevilleBerlin
   # Subclasses ActiveResource::Base as BaseResource
   class BaseResource < ActiveResource::Base
 
+    COMPLEX_ATTRIBUTES = []
+
     def initialize(attributes = {}, persisted = false)
       #we return a nested JSON response with player rewards keyed off of mongo id's
       #on groups endpoint which causes activeresource to break when looking up a
@@ -36,7 +38,7 @@ module BadgevilleBerlin
                   end
                 end
               when Hash
-                if [:selector, :adjustment].include?(key)
+                if self.class::COMPLEX_ATTRIBUTES.include?(key)
                   #if the key is selector or adjustment, as on the ActivityDefinition object, we don't want to create a nested resource
                   value
                 else

data/lib/badgeville_berlin/player.rb

@@ -1,5 +1,6 @@
 # Subclasses BaseResource to represent a remote resource model class.
 module BadgevilleBerlin
   class Player < BadgevilleBerlin::BaseResource
+    COMPLEX_ATTRIBUTES = [:custom]
   end
 end

data/lib/badgeville_berlin/version.rb

@@ -1,3 +1,3 @@
 module BadgevilleBerlin
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/spec/unit/base_resource_spec.rb

@@ -36,7 +36,6 @@ module BadgevilleBerlin
   #  context "BaseResource passes correct arguments to send method" do
   #    it "should call sanitize request and update record." do
   #      @mock_activity_definition.bucket_drain_rate = 180
-  #      debugger
   #      @path = ENDPOINTKEY + "/activity_definitions/" + @mock_activity_definition._id + ".json"
   #      FakeWeb.allow_net_connect = false
   #

data/spec/use_case/readme_use_case_spec.rb

@@ -13,8 +13,9 @@ module BadgevilleBerlin
       FakeWeb.allow_net_connect = true
 
       # Configure the gem with the host site and the API Key
-      my_api_key = "<myapikey>"
-      my_hostname = "<http://myhostname.com>"
+
+      my_hostname = '<http://myhostname.com>'
+      my_api_key = '<my_api_key>'
 
       Config.conf(:host_name => my_hostname, :api_key => my_api_key)
 
@@ -265,8 +266,17 @@ module BadgevilleBerlin
 
     # DELETE RewardDefinition
     it "should have deleted a reward definition", :affects_bv_server => true do
-      RewardDefinition.delete(@new_reward_defn.id)
-      lambda { RewardDefinition.find(@new_reward_defn.id) }.should raise_error(ActiveResource::ResourceNotFound)
+      # Not in the README:
+      @new_reward_defn2 = RewardDefinition.new(
+        :site_id          => @new_site.id,
+        :name             => 'Blog Rockstar',
+        :reward_template  => '{"message":"Congrats, you are a Blog Rockstar!"}',
+        :components       => '[{"comparator":{"$gte":1},"where":{"verb":"blog","player_id":"%player_id"},"command":"count"}]',
+        :active           => true )
+      @new_reward_defn2.save
+
+      RewardDefinition.delete(@new_reward_defn2.id)
+      lambda { RewardDefinition.find(@new_reward_defn2.id) }.should raise_error(ActiveResource::ResourceNotFound)
     end
 
     # DELETE ActivityDefinition

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: badgeville_berlin
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-30 00:00:00.000000000 Z
+date: 2013-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-debug19
@@ -163,17 +163,17 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 3.1.3
+        version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 3.1.3
+        version: '3.1'
 description: This is an open source Ruby wrapper for interacting with the Badgeville
   RESTful Berlin API.
 email: