backlog 0.12.4 → 0.13.0

data/History.txt

@@ -1,3 +1,22 @@
+== 0.13.0 2007-11-12
+
+=== Features
+
+* Removed "Track done" attribute from backlog, since it is determined by setting a work account.
+* Speed up of work related tasks
+
+=== Fixes
+
+* Changed to allow not setting a work account for a backlog.
+* Fixed faulty javascript to select active task.
+* Fixed redirect to create a new sprint when moving a task to next sprint for the first time.
+* Added setting of executable flag for init.d startup script.
+
+=== Known bugs
+
+* Ordering in the Show Backlog view is messed up.
+* Finishing or reopening tasks makes remaining tasks show wrong priority number.
+
 == 0.12.4 2007-11-11
 
 === Fixes

data/app/controllers/application.rb

@@ -189,8 +189,6 @@ class ApplicationController < ActionController::Base
     def setup_remove
       @last_active = @task.higher_item.nil? && @task.lower_item.nil? 
       @last_active_in_backlog = @last_active || ((@task.higher_item.nil? || @task.higher_item.backlog != @task.backlog) && (@task.lower_item.nil? || @task.lower_item.backlog != @task.backlog))
-      finished_count = Task.count(:conditions => ['period_id = ? AND finished_at IS NOT NULL', @task.period_id])
-      @first_finished = finished_count == 0
     end
         
   end

data/app/controllers/tasks_controller.rb

@@ -213,7 +213,7 @@ class TasksController < ApplicationController
       params[:period_id] = next_period && next_period.id
       move_to_period
     else
-      redirect_to :action => :edit, :id => @task
+      rjs_redirect_to :action => :edit, :id => @task
     end
   end
   

data/app/controllers/works_controller.rb

@@ -3,7 +3,7 @@ class WorksController < ApplicationController
   in_place_edit_for :work, :invoice
   in_place_edit_for :work, :started_at_time
   in_place_edit_for :work, :completed_at_time
-  skip_before_filter :populate_layout, :only => [ :auto_complete_for_work_description, :daily_work_sheet, :set_work_hours, :timeliste, :weekly_work_sheet, :weekly_work_sheet2 ]
+  skip_before_filter :populate_layout, :except => [:create, :destroy, :edit, :index, :list, :new, :show, :update]
   auto_complete_for :work, :description
   
   def index

data/app/helpers/tasks_helper.rb

@@ -45,7 +45,8 @@ module TasksHelper
   end
   
   def add_finished_task(page)
-    unless @first_finished
+    finished_count = Task.count(:conditions => ['period_id = ? AND finished_at IS NOT NULL', @task.period_id])
+    unless finished_count == 1
       page.select('#completed_tasks tr').first.remove
     end
     
@@ -56,7 +57,9 @@ module TasksHelper
   end
   
   def update_burn_down_chart(page)
-    page['burn_down_chart'].src = url_for(:controller => 'periods', :action => :burn_down_chart_thumbnail, :id => @task.period.id, :rnd => rand)
+    if @task.period
+      page['burn_down_chart'].src = url_for(:controller => 'periods', :action => :burn_down_chart_thumbnail, :id => @task.period.id, :rnd => rand)
+    end
   end
   
   def record(page, script)

data/app/models/backlog.rb

@@ -3,7 +3,6 @@ class Backlog < ActiveRecord::Base
   validates_length_of :name, :allow_nil => false, :maximum => 64
   validates_uniqueness_of :name
   validates_inclusion_of :track_todo, :in => [true, false], :allow_nil => true, :message => ActiveRecord::Errors.default_error_messages[:blank]
-  validates_inclusion_of :track_done, :in => [true, false], :allow_nil => true, :message => ActiveRecord::Errors.default_error_messages[:blank]
   validates_inclusion_of :enable_subtasks, :in => [true, false], :allow_nil => false, :message => ActiveRecord::Errors.default_error_messages[:blank]
   validates_inclusion_of :enable_customer, :in => [true, false], :allow_nil => true, :message => ActiveRecord::Errors.default_error_messages[:blank]
   validates_inclusion_of :enable_users, :in => [true, false], :allow_nil => true, :message => ActiveRecord::Errors.default_error_messages[:blank]
@@ -51,6 +50,10 @@ class Backlog < ActiveRecord::Base
     work_account && work_account.invoice_code && work_account.invoice_code.length > 0
   end
   
+  def track_done?
+    not work_account.nil?
+  end
+  
   def track_times?
     work_account && work_account.track_times?
   end

data/app/models/period.rb

@@ -148,7 +148,7 @@ class Period < ActiveRecord::Base
   end
   
   def track_work?
-    not backlogs.find {|backlog| backlog.track_done?}.nil?
+    not backlogs.find {|backlog| backlog.work_account}.nil?
   end
   
   def track_times?

data/app/models/task.rb

@@ -127,7 +127,7 @@ class Task < ActiveRecord::Base
   end
   
   def reopen
-    if period.passed?
+    if period && period.passed?
       flash[:notice] = "You cannot reopen a task in a period that is passed."
     else
       open
@@ -244,7 +244,7 @@ class Task < ActiveRecord::Base
   end
   
   def track_done?
-    root_task.backlog.track_done
+    not root_task.backlog.work_account.nil?
   end
   
   def track_times?

data/app/views/backlogs/_form.rhtml

@@ -9,12 +9,6 @@
 <label for="backlog_track_todo"><%=l :track_todo%></label>
 </p>
 
-<!-- TODO (uwe): Edit this on WorkAccount -->
-<p>
-<%= check_box 'backlog', 'track_done'  %>
-<label for="backlog_track_done"><%=l :track_done%></label>
-</p>
-
 <p>
 <%= check_box 'backlog', 'enable_subtasks'  %>
 <label for="backlog_enable_subtasks"><%=l :enable_subtasks%></label>
@@ -32,7 +26,7 @@
 
 <p>
 <label for="backlog_work_account"><%=l :work_account%></label><br/>
-<%=select 'backlog', 'work_account_id', @work_accounts.map {|wa| [wa.name, wa.id]}.sort %>
+<%=select 'backlog', 'work_account_id', [['', '']] + @work_accounts.map {|wa| [wa.name, wa.id]}.sort %>
 <% if @backlog.work_account %>
   <%=image_detour_to('work_account.png', "#{l(:work_account)} #{@backlog.work_account.name}", {:controller => 'work_accounts', :action => :edit, :id => @backlog.work_account}, {:class => 'image-submit', :style => 'vertical-align: bottom'}) %>
 <% end %>

data/app/views/backlogs/_tasks.rhtml

@@ -4,6 +4,7 @@
         <h4><%=l :tasks%></h4>
     </div>
         
+<div id="active_tasks"<%=' style="display: none;"' unless @tasks and not @tasks.empty?%>>
     <table>
       <%= render :partial => '/tasks/backlog_header', :locals => {:backlog => @backlog, :track_times => tasks.find {|t|t.period && t.period.active?}} %>
       <% i = 0 %>
@@ -17,6 +18,10 @@
         <%= render :partial => '/tasks/task/', :locals => {:task => @task, :i => i += 1, :active => true, :highlight_task => false, :update => :maincontent, :hidden => false} %>
       <% end %>
     </table>
+</div>
+
+<p id="no_tasks_message"<%=' style="display: none;"' if @tasks and not @tasks.empty?%>><%=l :no_pending_tasks_in_backlog%></p>
+
     <%=back_or_link_to(l(:back)) %>
   </div>
 

data/app/views/periods/_show_active.rhtml

@@ -55,8 +55,8 @@ function handleEvent(field, event, id) {
 
 
 <script type="text/JavaScript">
-<% if @selected_task %>
-document.getElementById('<%=@selected_task.id%>_description').focus();
-//document.getElementById('<%=@selected_task.id%>_description').select();
+<% if @selected_task && @selected_task.active?%>
+document.getElementById('task_<%=@selected_task.id%>_description').focus();
+//document.getElementById('task_<%=@selected_task.id%>_description').select();
 <% end %>
 </script>

data/app/views/tasks/_completed.rhtml

@@ -1,8 +1,8 @@
 <% current_period = nil %>
 
 <table id="completed_tasks" class="input">
-<% for task in @completed_tasks %>
-  <% if task.period != current_period %>
+<% @completed_tasks.each_with_index do |task, i| %>
+  <% if i == 0 || task.period != current_period %>
       <%= render :partial => '/tasks/period_header', :locals => {:period => task.period} unless @completed_tasks.map(&:period).uniq.size == 1 %>
       <%= render :partial => '/tasks/fields_header', :locals => {:backlog => task.backlog, :active => false, :track_times => false} %>
       <% current_period = task.period %>

data/bin/backlog

@@ -73,7 +73,8 @@ when 'setup_unix'
   if File.directory? '/etc/init.d'
     startup_app = "/etc/init.d/#{APPLICATION}"
     File.delete startup_app if File.exists? startup_app
-    `cp #{INSTALL_DIR}/bin/backlog_init.d #{startup_app}` unless File.exists? startup_app
+    `cp -p #{INSTALL_DIR}/bin/backlog_init.d #{startup_app}` unless File.exists? startup_app
+    `chmod a+x #{startup_app}` if File.exists? startup_app
   end
   FileUtils.cp "#{INSTALL_DIR}/etc/#{APPLICATION}.conf", config_file unless File.exists? config_file
   `su - -c "chkconfig --add #{APPLICATION}"`

data/db/migrate/022_remove_track_done_flag.rb

@@ -0,0 +1,9 @@
+class RemoveTrackDoneFlag < ActiveRecord::Migration
+  def self.up
+    remove_column :backlogs, :track_done
+  end
+
+  def self.down
+    add_column :backlogs, :track_done, :boolean
+  end
+end

data/db/schema.rb

@@ -2,12 +2,11 @@
 # migrations feature of ActiveRecord to incrementally modify your database, and
 # then regenerate this schema definition.
 
-ActiveRecord::Schema.define(:version => 21) do
+ActiveRecord::Schema.define(:version => 22) do
 
   create_table "backlogs", :force => true do |t|
     t.column "name",            :string,  :limit => 64,                    :null => false
     t.column "track_todo",      :boolean
-    t.column "track_done",      :boolean
     t.column "enable_subtasks", :boolean,               :default => false, :null => false
     t.column "enable_customer", :boolean
     t.column "enable_users",    :boolean

data/lang/en.yaml

@@ -61,6 +61,7 @@ new_task: Add new task
 new_work: Add new work record
 next: Next
 no_pending_tasks: There are no pending tasks in this sprint.
+no_pending_tasks_in_backlog: There are no pending tasks in this backlog.
 notes: Notes
 password: Password
 period: Sprint

data/lang/no.yaml

@@ -61,6 +61,7 @@ new_task: Legg til ny oppgave
 new_work: Registrer arbeid
 next: Neste
 no_pending_tasks: Det er ingen ventende oppgaver i denne perioden.
+no_pending_tasks_in_backlog: Det er ingen ventende oppgaver i denne oppgavelisten.
 notes: Notater
 password: Passord
 period: Periode

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.4
 specification_version: 1
 name: backlog
 version: !ruby/object:Gem::Version 
-  version: 0.12.4
-date: 2007-11-11 00:00:00 +01:00
+  version: 0.13.0
+date: 2007-11-14 00:00:00 +01:00
 summary: Application to aid collecting, processing, organizing, reviewing and doing tasks.
 require_paths: 
 - lib
@@ -142,6 +142,7 @@ files:
 - db/migrate/021_create_work_accounts.rb
 - db/migrate/016_add_invoicable_flag.rb
 - db/migrate/018_create_groups.rb
+- db/migrate/022_remove_track_done_flag.rb
 - db/migrate/005_add_field_work_started_at.rb
 - db/migrate/006_works_data_fix.rb
 - db/test.db