backlog 0.12.2 → 0.12.3

data/History.txt

@@ -1,3 +1,18 @@
+== 0.12.3 2007-11-10
+
+=== Fixes
+
+* Fix bug in update of burn down chart when updating start time for task in progress.
+* Fixed wrong update of page after update in "list started" view.
+* Fixed bug when finishing a task by entering 0 estimation point.
+* Speed up of finish and abort tasks.
+* Fixed bad layout in Safari.
+* Now set focus on user name field in login dialog on Safari.
+
+=== Known bugs
+
+* Finishing or reopening tasks makes remaining tasks show wrong priority number.
+
 == 0.12.2 2007-11-08
 
 ===Features

data/app/controllers/estimates_controller.rb

@@ -24,7 +24,7 @@ class EstimatesController < ApplicationController
     # Only necessary since we have an unecessary complex update of estimates
     @task.reload
     if @task.finished?
-      render :template => '/tasks/finish_ajax', :layout => false
+      render :template => '/tasks/finish', :layout => false
     end
   end
   

data/app/controllers/tasks_controller.rb

@@ -1,5 +1,5 @@
 class TasksController < ApplicationController
-  skip_before_filter :populate_layout, :only => [:create, :update, :destroy, :set_task_description, :move_to, :move_to_next_period, :move_to_period, :reopen, :start_work]
+  skip_before_filter :populate_layout, :only => [:create, :update, :destroy, :set_task_description, :move_to, :move_to_next_period, :move_to_period, :reopen, :start_work, :finish, :abort]
   
   verify :method => :post, :except => [ :new, :show, :edit, :list_started, :move_to_next_period],
   :redirect_to => { :controller => 'backlogs' }

data/app/helpers/tasks_helper.rb

@@ -56,7 +56,7 @@ module TasksHelper
   end
   
   def update_burn_down_chart(page)
-    page['burn_down_chart'].src = url_for(:controller => 'periods', :action => :burn_down_chart_thumbnail, :id => @task.period_id, :rnd => rand)
+    page['burn_down_chart'].src = url_for(:controller => 'periods', :action => :burn_down_chart_thumbnail, :id => @task.period.id, :rnd => rand)
   end
   
   def record(page, script)

data/app/views/estimates/create_ajax.rjs

@@ -7,5 +7,5 @@ if @success
     page.insert_html :bottom, :completed_tasks, :partial => '/tasks/task'
     page.visual_effect :appear, "task_#{@task.id}"
   end
-  page['burn_down_chart'].src = url_for(:controller => 'periods', :action => :burn_down_chart_thumbnail, :id => @task.period_id, :rnd => rand)
+  update_burn_down_chart(page)
 end

data/app/views/tasks/_task.rhtml

@@ -28,7 +28,7 @@
           <%=submit_tag('checkmark', :value => l(:save), :style => 'display: none')%>
           <% if @task.work_started? -%>
             <%=f.text_field 'started_at_time', :id => "work_#{@task.started_work.id}_started_at_time", :tabindex => i+1, :value => @task.started_work.started_at.strftime('%H:%M'),
-                :class => :task_time, :maxlength => 5, :onkeypress => "handleEvent(this, event, #{@task.id})" %>
+                :class => :task_time, :maxlength => 5 %>
           <% elsif @task.track_times? && @task.period && @task.period.active? %>
             <%=image_link_to_remote 'hammer.png', l(:start_work), {:controller => 'tasks', :action => :start_work, :id => @task.id}, nil, true %>
           <% end -%>
@@ -50,7 +50,7 @@
           <%= submit_tag('checkmark', :value => l(:save), :style => 'display: none')%>
           <% unless @task.track_times? || @task.work_started? || @task.finished_at -%>
             <%=text_field 'work', 'hours', :tabindex => i+1, :id => "#{@task.id}_done", 
-                :class => :task_hours, :maxlength => 4, :onkeypress => "handleEvent(this, event, #{@task.id})",
+                :class => :task_hours, :maxlength => 4,
                 :ondblclick => "form.elements[1].style.display = 'inline';this.style.display = 'none'" -%>
           <% end -%>
           <%=t @task.total_done if @task.total_done != 0%>
@@ -63,18 +63,18 @@
         <% remote_form_for(:estimate, :url => {:controller => 'estimates', :action => :create_ajax, :id => @task}) do |f| -%>
           <% if @task.track_todo? -%>
             <% if @task.period.nil? || @task.period.active_or_future? -%>
-              <%=f.text_field :todo, :tabindex => i+2, :id => "#{@task.id}_todo", :value => @task.todo, :class => :task_hours, :maxlength => 4, :onkeypress => "handleEvent(this, event, #{@task.id})" %>
+              <%=f.text_field :todo, :tabindex => i+2, :id => "#{@task.id}_todo", :value => @task.todo, :class => :task_hours, :maxlength => 4 %>
             <% else -%>
               <%=@task.todo %>
             <% end -%>
           <% end -%>
           <% if (not @task.track_times?) && !@task.work_started? && (@task.period.nil? || @task.period.active?) %>
-            <%= image_link_to_remote('checkmark.png', l(:complete), {:controller => 'tasks', :action => :finish, :id => @task}, nil, true)%>
+            <%=image_link_to_remote('checkmark.png', l(:complete), {:controller => 'tasks', :action => :finish, :id => @task}, nil, true)%>
           <% end -%>
         <% end -%>
       <% end -%>
     </td>
-    <td align="right" nowrap="true" width="1">
+    <td align="right" nowrap="true" width="54">
       <% form_tag({:controller => 'tasks', :action => 'update', :id => @task}) do %>
         <% if @task.active? %>
           <% if @task.loggable? %>

data/app/views/tasks/list_started.rhtml

@@ -50,7 +50,7 @@ function handleEvent(field, event, id) {
       <%= render :partial => '/tasks/fields_header', :locals => {:backlog => task.root_task.backlog, :active => true, :track_times => @tasks.find {|t|t.period && t.period.active?}} %>
       <% current_period = task.period %>
 	<% end %>
-  <%=render :partial => 'task', :locals => { :task => task, :i => i, :active => true, :highlight_task => (task == @selected_task), :update => :spotlight } %>
+  <%=render :partial => 'task', :locals => { :task => task, :i => i, :active => true, :highlight_task => (task == @selected_task), :update => :spotlight, :hidden => false } %>
   <% i += 1 %>
 <% end %>
 
@@ -64,7 +64,7 @@ function handleEvent(field, event, id) {
 document.getElementById('<%=@selected_task.id%>_description').focus();
 document.getElementById('<%=@selected_task.id%>_description').select();
 <% else %>
-document.links['new_task'].focus();
+//document.links['new_task'].focus();
 <% end %>
 </script>
 </div>

data/app/views/user/login.rhtml

@@ -2,30 +2,32 @@
 
 <div title="<%= title_helper %>" class="form">
   <div class="form-padding">
-    <%= start_form_tag_helper  %>
+    <% form_for :user do |f| %>
       <table>
         <tr class="two_columns">
           <td class="prompt"><label>Login:</label></td>
-          <td class="value"><%= text_field 'user', 'login', :size => 30 %></td>
+          <td class="value"><%=f.text_field :login, :size => 30 %></td>
         </tr>
         <tr class="two_columns">
           <td class="prompt"><label>Password:</label></td>
-          <td class="value"><%= password_field 'user', 'password', :size => 30 %></td>
+          <td class="value"><%=f.password_field :password, :size => 30 %></td>
         </tr>
         <tr class="two_columns">
           <td class="prompt"><label>Remember me:</label></td>
-          <td class="value"><%= check_box 'user', 'autologin', :checked => !cookies['autologin'] %></td>
+          <td class="value"><%=f.check_box :autologin, :checked => !cookies['autologin'] %></td>
         </tr>
       </table>
 
       <div class="button-bar">
-        <%= submit_tag l(:log_in) %>
-        <%= link_to 'Register for an account', :action => 'signup' %> |
-        <%= link_to 'Forgot my password', :action => 'forgot_password' %>      </div>
-    </form>
+        <%=submit_tag l(:log_in) %>
+        <%=link_to 'Register for an account', :action => 'signup' %> |
+        <%=link_to 'Forgot my password', :action => 'forgot_password' %>
+	  </div>
+    <% end %>
   </div>
 </div>
 
-<script type="text/JavaScript">
-document.getElementById('user_login').select();
-</script>
+<%=update_page_tag do |page|
+  page['user_login'].focus
+  page['user_login'].select
+end %>

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.4
 specification_version: 1
 name: backlog
 version: !ruby/object:Gem::Version 
-  version: 0.12.2
-date: 2007-11-09 00:00:00 +01:00
+  version: 0.12.3
+date: 2007-11-10 00:00:00 +01:00
 summary: Application to aid collecting, processing, organizing, reviewing and doing tasks.
 require_paths: 
 - lib