backlog-api-client 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb36a99c98687e332dc99c78cf21d35fbb8160d5
-  data.tar.gz: ba889529d74d33d33b362d4056971d60e720ff5c
+  metadata.gz: 200c8783133ef6deaf7610f8b51270d9adfccb2b
+  data.tar.gz: 65c204678b0602af546fa1ad21b3c38c4399b9d6
 SHA512:
-  metadata.gz: 50e0775472d005c3b528b730fd8cf51e03265d904702504988a2dea3eb90f86d76051ef205bf8132ae0a3f9bbb4909f877f091973c6732af730a78cebb692d7c
-  data.tar.gz: 1cb3bb5dc36c464c2d42e2e390840406b82a91c3c9d21ec01889321eb8d6065fa60a9ba22fd0f2ea8d3b8e56898fe3820a52510d315a4041277a67f09fa04542
+  metadata.gz: 883643aba5618bac1c48d1fbaef6b9014461612712ddbc84e24d7a38191b2c57a4c93771059a763e46807c249625f123ece192bb5695e419903e126ddb2f1c84
+  data.tar.gz: d33257bd858149ae5ad3364a74c0cdc485ae2cf4ad94b67ac94ac26f6df72a69d2307c8ce0e1436fbf0ad29e06d5e376a50a1a3f811b145554576b35803aeee9

data/README.md

@@ -77,13 +77,14 @@ cli.issues.update('TST-3', {
 - Update Issue(/api/v2/issues/:issueIdOrKey)
 - Delete Issue(/api/v2/issues/:issueIdOrKey)
 
-### How to use not support API
-You can use not support API by using BacklogApiClient::Client has methods.
+### How to use unsupported API
+You can use unsupported API by using BacklogApiClient::Client has methods.
 
 - \#get
 - \#post
 - \#patch
 - \#put
+- \#delete
 - \#file_upload
 
 But I would be glad if you send Pull Request without to use these methods.
@@ -110,8 +111,3 @@ cli.post('/api/v2/wikis', {
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create a new Pull Request
-
-
-## Release
-- 0.0.1
-    - first release

data/lib/backlog-api-client/client.rb

@@ -7,7 +7,8 @@ module BacklogApiClient
     def initialize(space_name, api_key)
       @space_name = space_name
       @api_key = { apiKey: api_key }
-      @http_cli = Faraday.new(url: "https://#{space_name}#{API_PATH}")
+      backlog_url = (space_name =~ %r{^https?://.*} ? space_name : "https://#{space_name}")
+      @http_cli = Faraday.new(url: "#{backlog_url}#{API_PATH}")
     end
 
     def get(resource_path, params = {})
@@ -15,27 +16,27 @@ module BacklogApiClient
       @http_cli.get "#{resource_path}#{to_request_params(params)}"
     end
 
-    def post(resource_path, request_body = {})
+    def post(resource_path, request = {})
       @http_cli.post do |req|
         req.url "#{resource_path}#{to_request_params(@api_key)}"
-        req.headers['Content-Type'] = 'application/json'
-        req.body = request_body.to_json
+        req.headers['Content-Type'] = 'application/x-www-form-urlencoded'
+        req.body = build_request_body(request)
       end
     end
 
-    def patch(resource_path, request_body = {})
+    def patch(resource_path, request = {})
       @http_cli.patch do |req|
         req.url "#{resource_path}#{to_request_params(@api_key)}"
-        req.headers['Content-Type'] = 'application/json'
-        req.body = request_body.to_json
+        req.headers['Content-Type'] = 'application/x-www-form-urlencoded'
+        req.body = build_request_body(request)
       end
     end
 
-    def put(resource_path, request_body = {})
+    def put(resource_path, request = {})
       @http_cli.put do |req|
         req.url "#{resource_path}#{to_request_params(@api_key)}"
-        req.headers['Content-Type'] = 'application/json'
-        req.body = request_body.to_json
+        req.headers['Content-Type'] = 'application/x-www-form-urlencoded'
+        req.body = build_request_body(request)
       end
     end
 
@@ -63,6 +64,13 @@ module BacklogApiClient
 
     private
 
+    def build_request_body(request_hash)
+      request_hash.each_with_object('') do |(k, v), body|
+        body << '&' unless body.empty?
+        body << "#{k}=#{v}"
+      end
+    end
+
     def to_request_params(hash)
       hash.each_with_object('') do |(k, v), request_params|
         request_params << (request_params.empty? ? '?' : '&')

data/lib/backlog-api-client/version.rb

@@ -1,3 +1,3 @@
 module BacklogApiClient
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

data/spec/backlog-api-client/client_spec.rb

@@ -2,31 +2,79 @@ require 'spec_helper'
 
 describe BacklogApiClient::Client do
   let(:http_cli) { double('http_cli') }
-  let(:space_name) { 'test_space_name' }
   let(:api_key) { 'test_api_key' }
-  before { expect(Faraday).to receive(:new).with(url: "https://#{space_name}/api/v2").and_return(http_cli) }
-
-  describe '#get' do
-    let(:params) { { params: 'test-param' } }
-    let(:resource_path) { 'test/resource' }
-    before { expect(http_cli).to receive(:get).with("#{resource_path}?#{q(params)}&apiKey=#{api_key}").and_return('ok') }
-    subject { described_class.new(space_name, api_key).get(resource_path, params) }
-    it { should eq 'ok' }
-  end
 
-  describe '#post' do
-    # ToDo: write test
-  end
+  context 'normal cases' do
+
+    let(:space_name) { 'test_space_name' }
+    before { expect(Faraday).to receive(:new).with(url: "https://#{space_name}/api/v2").and_return(http_cli) }
+
+    describe '#get' do
+      let(:params) { { params: 'test-param' } }
+      let(:resource_path) { 'test/resource' }
+      before { expect(http_cli).to receive(:get).with("#{resource_path}?#{q(params)}&apiKey=#{api_key}").and_return('ok') }
+      subject { described_class.new(space_name, api_key).get(resource_path, params) }
+      it { should eq 'ok' }
+    end
 
-  describe '#patch' do
-    # ToDo: write test
+    describe '#post' do
+      let(:params) { { param1: 'test-param1', param2: 'test-param2' } }
+      let(:resource_path) { 'test/resource' }
+      before do
+        request_header = { 'Content-Type' => '' }
+        request = double('request', url: 'test-url', headers: request_header)
+        expect(request).to receive(:body=).with('param1=test-param1&param2=test-param2')
+        expect(http_cli).to receive(:post).and_yield(request).and_return('ok')
+      end
+      subject { described_class.new(space_name, api_key).post(resource_path, params) }
+      it { should eq 'ok' }
+    end
+
+    describe '#patch' do
+      let(:params) { { param1: 'test-param1', param2: 'test-param2' } }
+      let(:resource_path) { 'test/resource' }
+      before do
+        request_header = { 'Content-Type' => '' }
+        request = double('request', url: 'test-url', headers: request_header)
+        expect(request).to receive(:body=).with('param1=test-param1&param2=test-param2')
+        expect(http_cli).to receive(:patch).and_yield(request).and_return('ok')
+      end
+      subject { described_class.new(space_name, api_key).patch(resource_path, params) }
+      it { should eq 'ok' }
+    end
+
+    describe '#put' do
+      let(:params) { { param1: 'test-param1', param2: 'test-param2' } }
+      let(:resource_path) { 'test/resource' }
+      before do
+        request_header = { 'Content-Type' => '' }
+        request = double('request', url: 'test-url', headers: request_header)
+        expect(request).to receive(:body=).with('param1=test-param1&param2=test-param2')
+        expect(http_cli).to receive(:put).and_yield(request).and_return('ok')
+      end
+      subject { described_class.new(space_name, api_key).put(resource_path, params) }
+      it { should eq 'ok' }
+    end
+
+    describe '#delete' do
+      let(:resource_path) { 'test/resource' }
+      before { expect(http_cli).to receive(:delete).with("#{resource_path}?apiKey=#{api_key}").and_return('ok') }
+      subject { described_class.new(space_name, api_key).delete(resource_path) }
+      it { should eq 'ok' }
+    end
   end
 
-  describe '#delete' do
-    let(:resource_path) { 'test/resource' }
-    before { expect(http_cli).to receive(:delete).with("#{resource_path}?apiKey=#{api_key}").and_return('ok') }
-    subject { described_class.new(space_name, api_key).delete(resource_path) }
-    it { should eq 'ok' }
+  context 'http request' do
+    let(:space_name) { 'http://test_space_name' }
+    before { expect(Faraday).to receive(:new).with(url: "#{space_name}/api/v2").and_return(http_cli) }
+
+    describe '#get' do
+      let(:params) { { params: 'test-param' } }
+      let(:resource_path) { 'test/resource' }
+      before { expect(http_cli).to receive(:get).with("#{resource_path}?#{q(params)}&apiKey=#{api_key}").and_return('ok') }
+      subject { described_class.new(space_name, api_key).get(resource_path, params) }
+      it { should eq 'ok' }
+    end
   end
 
   def q(hash)

data/wercker.yml

@@ -7,7 +7,7 @@ build:
     steps:
         # Uncomment this to force RVM to use a specific Ruby version
         - rvm-use:
-              version: 2.1.2
+              version: 2.1.5
 
         - script:
             name: bundle

metadata

@@ -1,83 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: backlog-api-client
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - joe-re
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-16 00:00:00.000000000 Z
+date: 2014-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: This is a simple and easy-to-use Backlog Restful Api client.
@@ -87,7 +87,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
+- .gitignore
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -117,17 +117,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: ''