backfiller 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e03f52ddf2d8dbe1a7aada95079d1bbbeb6588e0a361122062a6c7e1c871d01d
-  data.tar.gz: d6b0f6b92fe6da8ac84338ff76435f16a6eea506ce42e762a594f2e81af05542
+  metadata.gz: d546e155a0790fdb0190454b6f59ccfa7847000ea93e64c785b7af932446c2aa
+  data.tar.gz: f8fb83e301f507909783ac29eb405c80d7497c318915a6af2c3df803f2a85ce2
 SHA512:
-  metadata.gz: d2d62553aa42545079e829e93c58d01171047b6874112e123fe2f4bc0bb0bf5117c5334bd5b527600d216bc3997ed137b8f5ffded9327e068fde057f006b909c
-  data.tar.gz: ab0c2aa054baabd9afd9b94bdd5cf9b3313420ef41971c374b3c4571cacf551ebef04e7dc0488f389a6f179a766fea7cb15bf4133a1b58d274b79331127353df
+  metadata.gz: 6741e63a19b01bbc57829817f558838ccbe31adc18ec53fcad2115b23cba122a396e4981d0b773ad46a3af3d531771efd29fbca5d20a700a9a849a31a196b2d4
+  data.tar.gz: 0bf707056834e42d4e94fcf50477d121eb4e2fb8b4b31a98e13eb5be926a7cb32d1260726fd10f14d43ed0c3631bafc5788257cc835dab551cba57d084250fc8

data/Changelog.md

@@ -0,0 +1,5 @@
+# Changelog
+
+## 0.1.1
+
+* Support Rails 6.0.0

data/README.md

@@ -7,11 +7,11 @@ This gem maybe handly for `no-downtime` deployment especially when you need to f
 
 ## Typical no-downtime and non-locking cycle
 
-* add migaration that adds new column (null: true)
+* add migration that adds new column (null: true)
 * deploy and run migration task
 * deploy code that starts filling new column in corresponding flows
 * add backfill task
-* deploy and run backflill task
+* deploy and run backfill task
 * [optional] add migration that invokes backfill task asn so keep all environments consistent (except production environment because we already backfilled data)
 * add migration that disallow null values (null: false)
 * deploy code that starts using new column
@@ -49,7 +49,7 @@ Or install it yourself as:
 
 ## Usage
 
-Assume we we want to backfill `profiles.name` column from `users.first_name`, `users.last_name` columns.
+Assume we want to backfill `profiles.name` column from `users.first_name`, `users.last_name` columns.
 
 Create backfill task into `db/backfill/profile_name.rb` and defined required methods:
 
@@ -148,6 +148,7 @@ class Backfill::ProfileName
           #{connection.quote(row['profile_name'])},
         )
       SQL
+    end
     connection.execute 'COMMIT'
   end
 

data/backfiller.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "backfiller"
-  spec.version       = "0.1.0"
+  spec.version       = "0.1.1"
   spec.authors       = ["Andriy Yanko"]
   spec.email         = ["andriy.yanko@railsware.com"]
 

data/lib/backfiller/configuration.rb

@@ -9,8 +9,6 @@ module Backfiller
 
     attr_accessor :task_namespace
 
-    attr_accessor :connection_pool
-
     attr_accessor :batch_size
 
     attr_accessor :logger

data/lib/backfiller/railtie.rb

@@ -13,8 +13,6 @@ module Backfiller
 
         config.batch_size = 1_000
 
-        config.connection_pool = defined?(ApplicationRecord) ? ApplicationRecord.connection_pool : ActiveRecord::Base.connection_pool
-
         config.logger = defined?(ApplicationRecord) ? ApplicationRecord.logger : ActiveRecord::Base.logger
       end
     end

data/lib/backfiller/runner.rb

@@ -9,7 +9,7 @@ module Backfiller
 
     def initialize(task_name)
       @task = build_task(task_name)
-      @connection_pool = @task.respond_to?(:connection_pool) ? @task.connection_pool : Backfiller.connection_pool
+      @connection_pool = @task.respond_to?(:connection_pool) ? @task.connection_pool : default_connection_pool
       @batch_size = @task.respond_to?(:batch_size) ? @task.batch_size : Backfiller.batch_size
       @process_method = @task.respond_to?(:process_row) ? @task.method(:process_row) : self.method(:process_row)
     end
@@ -36,6 +36,10 @@ module Backfiller
 
     ###########################################################################
 
+    def default_connection_pool
+      defined?(ApplicationRecord) ? ApplicationRecord.connection_pool : ActiveRecord::Base.connection_pool
+    end
+
     def acquire_connection
       connection_pool.checkout
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: backfiller
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Andriy Yanko
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-06-03 00:00:00.000000000 Z
+date: 2019-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -75,6 +75,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- Changelog.md
 - Gemfile
 - README.md
 - Rakefile