backbone-support 0.3.0 → 0.3.1

data/CHANGELOG

@@ -1,3 +1,9 @@
+0.3.1 (March 05, 2013)
+
+Views fire 'leave' event when calling leave()
+renderChildInto works with elements not yet rendered
+Refactoring
+
 0.3.0
 
 CompositeView provides this.bindTo(source, event, callback) to provide easy

data/lib/assets/javascripts/backbone-support.js

@@ -1,2 +1,3 @@
 //= require backbone-support/support
+//= require backbone-support/observer
 //= require_tree ./backbone-support

data/lib/assets/javascripts/backbone-support/composite_view.js

@@ -1,11 +1,11 @@
 Support.CompositeView = function(options) {
   this.children = _([]);
-  this.bindings = _([]);
   Backbone.View.apply(this, [options]);
 };
 
-_.extend(Support.CompositeView.prototype, Backbone.View.prototype, {
+_.extend(Support.CompositeView.prototype, Backbone.View.prototype, Support.Observer.prototype, {
   leave: function() {
+    this.trigger('leave');
     this.unbind();
     this.unbindFromAll();
     this.remove();
@@ -13,18 +13,6 @@ _.extend(Support.CompositeView.prototype, Backbone.View.prototype, {
     this._removeFromParent();
   },
 
-  bindTo: function(source, event, callback) {
-    source.bind(event, callback, this);
-    this.bindings.push({ source: source, event: event, callback: callback });
-  },
-
-  unbindFromAll: function() {
-    this.bindings.each(function(binding) {
-      binding.source.unbind(binding.event, binding.callback);
-    });
-    this.bindings = _([]);
-  },
-
   renderChild: function(view) {
     view.render();
     this.children.push(view);
@@ -33,7 +21,7 @@ _.extend(Support.CompositeView.prototype, Backbone.View.prototype, {
   
   renderChildInto: function(view, container) {
     this.renderChild(view);
-    $(container).empty().append(view.el);
+    this.$(container).empty().append(view.el);
   },
 
   appendChild: function(view) {
@@ -43,7 +31,7 @@ _.extend(Support.CompositeView.prototype, Backbone.View.prototype, {
   
   appendChildTo: function (view, container) {
     this.renderChild(view);
-    $(container).append(view.el);
+    this.$(container).append(view.el);
   },
   
   prependChild: function(view) {

data/lib/assets/javascripts/backbone-support/observer.js

@@ -0,0 +1,16 @@
+Support.Observer = function() {};
+
+_.extend(Support.Observer.prototype, {
+  bindTo: function(source, event, callback) {
+    source.bind(event, callback, this);
+    this.bindings = this.bindings || [];
+    this.bindings.push({ source: source, event: event, callback: callback });
+  },
+
+  unbindFromAll: function() {
+    _.each(this.bindings, function(binding) {
+      binding.source.unbind(binding.event, binding.callback);
+    });
+    this.bindings = []
+  }
+});

data/lib/backbone-support/version.rb

@@ -1,3 +1,3 @@
 module BackboneSupport
-  VERSION = '0.3.0'.freeze
+  VERSION = '0.3.1'.freeze
 end

data/spec/javascripts/composite_view_spec.js

@@ -42,12 +42,22 @@ describe("Support.CompositeView", function() {
   describe("#renderChildInto", function() {
     it("renders child into the given element and replaces content there", function() {
       $("#test1").text("Replace this!");
+      $("#test").append($("#test1"));
 
       var view = new blankView({el: "#test"});
       view.renderChildInto(new orangeView(), "#test1");
 
-      expect($("#test").text()).toEqual("");
       expect($("#test1").text()).toEqual("Orange!");
+
+      $("#test1").remove();
+      expect($("#test").text()).toEqual("");
+    });
+
+    it("renders child into a sub-element of the view, even if it is not yet added to the document", function() {
+      var view = new blankView({el: $('<div><div class="inside"></div></div>')});
+      view.renderChildInto(new orangeView(), ".inside");
+
+     expect($(view.el).find('.inside').text()).toEqual("Orange!"); 
     });
   });
 
@@ -64,12 +74,22 @@ describe("Support.CompositeView", function() {
   describe("#appendChildTo", function() {
     it("appends child into the given element", function() {
       $("#test1").text("Append to this!");
-  
+      $("#test").append($("#test1"));
+
       var view = new blankView({el: "#test"});
       view.appendChildTo(new orangeView(), "#test1");
-  
-      expect($("#test").text()).toEqual("");
+
       expect($("#test1").text()).toEqual("Append to this!Orange!");
+      
+      $("#test1").remove();
+      expect($("#test").text()).toEqual("");
+    });
+
+    it("appends child into a sub-element even if it is not added to the document", function() {
+      var view = new blankView({el: $('<div><div class="inside">Append to this!</div></div>')});
+      view.appendChildTo(new orangeView(), ".inside");
+
+      expect($(view.el).find('.inside').text()).toEqual("Append to this!Orange!"); 
     });
   });
   
@@ -184,5 +204,61 @@ describe("Support.CompositeView", function() {
 
       expect(eventListener.called).toBeFalsy();
     });
+
+    it("fires leave event", function() {
+      var eventListener = sinon.spy();
+      var view = new (Support.CompositeView.extend({
+        initialize: function(options) {
+          this.bindTo(this, 'leave', eventListener);
+        }
+      }))({model: {}});
+
+      view.leave();
+
+      expect(eventListener.called).toBeTruthy();
+    });
   });
+
+  describe("#bindTo", function() {
+    var view = new orangeView();
+    var callback = sinon.spy();
+    var source = new Backbone.Model({
+        title: 'Model or Collection'
+    });
+
+    it("calls the unbindFromAll method when leaving the view", function() {
+      view.bindTo(source, 'foobar', callback);
+      expect(view.bindings.length).toEqual(1);
+    });
+  });
+
+  describe("#unbindFromAll", function() {
+    var view = new orangeView();
+    var spy = sinon.spy(view, 'unbindFromAll');
+    var callback = sinon.spy();
+    var source = new Backbone.Model({
+        title: 'Model or Collection'
+    });
+
+    runs(function() {
+      view.render();
+      view.bindTo(source, 'foo', callback);
+      expect(view.bindings.length).toEqual(1);
+    });
+
+    Helpers.sleep();
+
+    runs(function() {
+      view.leave();
+    });
+
+    Helpers.sleep();
+
+    it("calls the unbindFromAll method when leaving the view", function() {
+      runs(function() {
+        expect(spy.called).toBeTruthy();
+      });
+    });
+  });
+
 });

data/spec/javascripts/observer_spec.js

@@ -0,0 +1,99 @@
+describe('Support.Observer', function() {
+
+  var normalView = Support.CompositeView.extend({
+    render: function() {
+      var text = this.make("span", {}, "Normal!");
+      $(this.el).append(text);
+    },
+    leave: function() {
+      this.unbindFromAll();
+    }
+  });
+
+  beforeEach(function() {
+    Helpers.setup();
+    Helpers.append("test1");
+    Helpers.append("test2");
+  });
+
+  afterEach(function() {
+    Helpers.teardown();
+  });
+
+  describe("#bindTo", function() {
+    var view, spy, source, callback;
+    beforeEach(function() { Helpers.setup();
+      view = new normalView();
+      spy = sinon.spy(view, "bindTo");
+      callback = sinon.spy();
+
+      source = new Backbone.Model({
+        title: 'Model or Collection'
+      });
+    });
+
+    afterEach(function() {
+      view, spy, source, callback = null;
+    });
+
+    it("should add the event to the bindings for the view", function() {
+      view.bindTo(source, 'foobar', callback);
+      expect(view.bindings.length).toEqual(1);
+    });
+
+    it("binds the event to the source object", function() {
+      var mock = sinon.mock(source).expects('bind').once();
+
+      view.bindTo(source, 'change:title', callback);
+
+      mock.verify();
+    });
+  });
+
+  describe("#unbindFromAll", function() {
+    var view, spy, mock;
+    beforeEach(function() {
+      view = new normalView();
+      spy = sinon.spy(view, 'unbindFromAll');
+      callback = sinon.spy();
+      source = new Backbone.Model({
+        title: 'Model or Collection'
+      });
+      unbindSpy = sinon.spy(source, 'unbind');
+
+      runs(function() {
+        view.render();
+        view.bindTo(source, 'foo', callback);
+        view.bindTo(source, 'bar', callback);
+        expect(view.bindings.length).toEqual(2);
+      });
+
+      Helpers.sleep();
+
+      runs(function() {
+        view.leave();
+      });
+
+      Helpers.sleep();
+    });
+
+    it("calls the unbindFromAll method when leaving the view", function() {
+      runs(function() {
+        expect(spy.called).toBeTruthy();
+      });
+    });
+
+    it("calls unbind on the source object", function() {
+      runs(function() {
+        expect(unbindSpy.calledTwice).toBeTruthy();
+      });
+    });
+
+    it("removes all the views bindings attached with bindTo", function() {
+      runs(function() {
+        expect(view.bindings.length).toEqual(0);
+      });
+    });
+  });
+
+});

data/spec/javascripts/support/jasmine.yml

@@ -16,6 +16,7 @@ src_files:
     - vendor/backbone.js
     - lib/assets/javascripts/backbone-support.js
     - lib/assets/javascripts/backbone-support/support.js
+    - lib/assets/javascripts/backbone-support/observer.js
     - lib/**/*.js
 
 # spec_files

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: backbone-support
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-28 00:00:00.000000000 Z
+date: 2013-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jasmine
@@ -47,6 +47,7 @@ files:
 - backbone-support.gemspec
 - lib/assets/javascripts/backbone-support.js
 - lib/assets/javascripts/backbone-support/composite_view.js
+- lib/assets/javascripts/backbone-support/observer.js
 - lib/assets/javascripts/backbone-support/support.js
 - lib/assets/javascripts/backbone-support/swapping_router.js
 - lib/backbone-support.rb
@@ -55,6 +56,7 @@ files:
 - spec/javascripts/composite_view_spec.js
 - spec/javascripts/helpers/helpers.js
 - spec/javascripts/helpers/sinon-1.1.1.js
+- spec/javascripts/observer_spec.js
 - spec/javascripts/support/jasmine.yml
 - spec/javascripts/support/jasmine_config.rb
 - spec/javascripts/support/jasmine_runner.rb
@@ -82,7 +84,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: SwappingController and CompositeView for Backbone.js
@@ -90,6 +92,7 @@ test_files:
 - spec/javascripts/composite_view_spec.js
 - spec/javascripts/helpers/helpers.js
 - spec/javascripts/helpers/sinon-1.1.1.js
+- spec/javascripts/observer_spec.js
 - spec/javascripts/support/jasmine.yml
 - spec/javascripts/support/jasmine_config.rb
 - spec/javascripts/support/jasmine_runner.rb