babysitter 0.0.6 → 0.0.8

data/lib/babysitter/configuration.rb

@@ -14,10 +14,6 @@ module Babysitter
     end
 
     def enable_simple_notification_service(opts = {})
-      [:access_key_id, :secret_access_key, :topic_arn].each do |key|
-        raise ArgumentError, "#{key} is required" unless opts.has_key?(key)
-      end
-
       @exception_notifiers << ExceptionNotifiers::SimpleNotificationService.new(opts)
     end
 

data/lib/babysitter/exception_notifiers/simple_notification_service.rb

@@ -3,16 +3,22 @@ require 'aws-sdk'
 module Babysitter
   module ExceptionNotifiers
     class SimpleNotificationService
-      def initialize(opts)
-        access_key = opts.delete :access_key_id
-        secret_access_key = opts.delete :secret_access_key
-        @sns = AWS::SNS.new(access_key_id: access_key, secret_access_key: secret_access_key)
-        @topic = @sns.topics[opts.delete(:topic_arn)]
+      def initialize(opts = {})
+        topic_arn = opts.delete(:topic_arn)
+        raise ArgumentError, "topic_arn is required." if topic_arn.nil?
+
+        @sns = AWS::SNS.new(opts)
+        @topic = @sns.topics[topic_arn]
         validate_topic
       end
 
       def notify(subject, msg)
-        @topic.publish(msg, subject: subject)
+        sanitised_subject = if subject.size > 100
+                              subject[0..96] + "..."
+                            else
+                              subject
+                            end
+        @topic.publish(msg, subject: sanitised_subject)
       end
 
       private

data/lib/babysitter/version.rb

@@ -1,3 +1,3 @@
 module Babysitter
-  VERSION = "0.0.6"
+  VERSION = "0.0.8"
 end

data/spec/lib/babysitter/configuration_spec.rb

@@ -20,8 +20,7 @@ module Babysitter
     describe 'enabling Amazon simple notification service integration' do
       let (:sns_exception_notifier) { double }
       let (:valid_params) { { 
-        access_key_id: "an-access-key",
-        secret_access_key: "a-secret-address-key",
+        arbritary_key: "some-value",
         topic_arn: "my-topic-arn" 
       } }
 
@@ -29,21 +28,6 @@ module Babysitter
         Babysitter::ExceptionNotifiers::SimpleNotificationService.stub(:new).and_return(sns_exception_notifier)
       end
 
-      it 'requires an access key id' do
-        valid_params.delete :access_key_id
-        -> { subject.enable_simple_notification_service(valid_params) }.should raise_error(ArgumentError, /access_key_id/)
-      end
-
-      it 'requires a secret address key' do
-        valid_params.delete :secret_access_key
-        -> { subject.enable_simple_notification_service(valid_params) }.should raise_error(ArgumentError, /secret_access_key/)
-      end
-
-      it 'requires a topic arn' do
-        valid_params.delete :topic_arn
-        -> { subject.enable_simple_notification_service(valid_params) }.should raise_error(ArgumentError, /topic_arn/)
-      end
-
       it 'adds an exception notifier' do
         subject.enable_simple_notification_service(valid_params)
 

data/spec/lib/babysitter/exception_notifiers/simple_notification_service_spec.rb

@@ -15,6 +15,10 @@ module Babysitter
         AWS::SNS.stub(:new).and_return(sns)
       end
 
+      it 'requires a topic_arn' do
+        -> { SimpleNotificationService.new() }.should raise_error(ArgumentError, /topic_arn/)
+      end
+
       it 'uses the options passed to configure the credentials for sns' do
         AWS::SNS.should_receive(:new).with(valid_opts.reject { |key| key == :topic_arn } )
         subject
@@ -40,6 +44,15 @@ module Babysitter
 
           subject.notify(notification_subject, message)
         end
+
+        it "shortens the subject to 100 characters if necessary" do
+          shortened_subject = 97.times.map { "x" }.join + "..."
+          original_subject = 101.times.map { "x" }.join
+
+          topic.should_receive(:publish).with(message, hash_including(subject: shortened_subject))
+
+          subject.notify(original_subject, message)
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: babysitter
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.8
   prerelease: 
 platform: ruby
 authors:
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-29 00:00:00.000000000 Z
+date: 2013-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fozzie