babysitter 0.0.9 → 0.0.10

data/lib/babysitter/exception_notifiers/simple_notification_service.rb

@@ -19,13 +19,11 @@ module Babysitter
       private
 
       def sanitise_subject(subject)
-        if subject.size > 100
-          subject[0..96] + "..."
-        elsif subject.empty?
-          "(no subject)"
-        else
-          subject
-        end
+        sanitised = /\s*([^\x00-\x1F]*)/.match(subject)[1]
+
+        return "(no subject)" if sanitised.empty?
+        return sanitised[0..96] + "..." if sanitised.size > 100
+        sanitised
       end
 
       def validate_topic

data/lib/babysitter/version.rb

@@ -1,3 +1,3 @@
 module Babysitter
-  VERSION = "0.0.9"
+  VERSION = "0.0.10"
 end

data/spec/lib/babysitter/exception_notifiers/simple_notification_service_spec.rb

@@ -54,6 +54,25 @@ module Babysitter
           subject.notify(original_subject, message)
         end
 
+        it "strips control characters" do
+          expected_subject = "this is the subject"
+          original_subject = "#{expected_subject}"
+          32.times.each { |code| original_subject << code.chr }
+
+          topic.should_receive(:publish).with(message, hash_including(subject: expected_subject))
+
+          subject.notify(original_subject, message)
+        end
+
+        it "strips leading whitespace" do
+          expected_subject = "this is the subject"
+          original_subject = "  #{expected_subject}"
+
+          topic.should_receive(:publish).with(message, hash_including(subject: expected_subject))
+
+          subject.notify(original_subject, message)
+        end
+
         it "handles empty subject" do
           topic.should_receive(:publish).with(message, hash_including(subject: "(no subject)"))
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: babysitter
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
   prerelease: 
 platform: ruby
 authors:
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-05 00:00:00.000000000 Z
+date: 2013-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fozzie