babelyoda 2.1.20 → 2.2.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: a0347f2782ffb4abd2e513b84f86015ed1d0a4ff
+  data.tar.gz: 4393ec8e01b4b536f34dbf90ab0195550c1259d3
+SHA512:
+  metadata.gz: 7f9e9a76f375f4419b78b7fe46b833e6a86145db2f5f965e2d62a91bf3c873ab86e754b3e57c669bcb546259762f0f1401c7c0b497b3701e39e90e942411a0c8
+  data.tar.gz: 79671401dbaa7345b650501ced99e265f5572c1feeeefe5d6336e35f07cf7d8041d1ea81b5f8f83984863c0f8c85620b67073120f5fa312142c21117eaa89122

data/CHANGELOG

@@ -3,3 +3,4 @@ v1.4.0. Better command line options handling + Bugfixes.
 v1.5.0. Fixed a major bug in localization of XIB files.
 v2.0.0. Full re-write. Yay!
 v2.1.14. Fix merging of pluralized keys: translated values are now preserved correctly.
+v2.2.0. Add a task checking for long translations.

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2010-2012 Andrey Subbotin
+Copyright (c) 2010-2016 Andrey Subbotin
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -20,7 +20,8 @@ The following people contributed patches, made suggestions or made otherwise hel
 
 * [Ivan Moskalev](https://github.com/ivanmoskalev)
 * [Alexander Denisov](https://github.com/StoneSpb)
+* [Mikhail Chupin](https://github.com/ilmarion)
 
 ## Copyright
 
-Copyright (c) 2010-2014 Andrey Subbotin. See LICENSE for details.
+Copyright (c) 2010-2016 Andrey Subbotin. See LICENSE for details.

data/babelyoda.gemspec

@@ -5,7 +5,7 @@ require "babelyoda/version"
 Gem::Specification.new do |s|
   s.name        = "babelyoda"
   s.version     = Babelyoda::VERSION
-  s.authors     = ["Andrey Subbotin", "Ivan Moskalev", "Alexander Denisov"]
+  s.authors     = ["Andrey Subbotin", "Ivan Moskalev", "Alexander Denisov", "Mikhail Chupin"]
   s.email       = ["andrey@subbotin.me"]
   s.homepage    = "http://github.com/eploko/babelyoda"
   s.summary     = "Xcode project localization made easy"

data/lib/babelyoda.rb

@@ -8,6 +8,8 @@ require_relative 'babelyoda/git'
 require_relative 'babelyoda/ibtool'
 require_relative 'babelyoda/keyset'
 require_relative 'babelyoda/localization_key'
+require_relative 'babelyoda/length_checker'
+require_relative 'babelyoda/length_checker_params'
 require_relative 'babelyoda/localization_value'
 require_relative 'babelyoda/logger'
 require_relative 'babelyoda/rake'
@@ -247,17 +249,7 @@ namespace :babelyoda do
     
     desc "Verifies all local translations are present"
     task :verify do
-      combined_keyset = Babelyoda::Keyset.new('babelyoda.verify')
-      spec.strings_files.each do |filename|
-        dev_lang_strings = Babelyoda::Strings.new(filename, spec.development_language).read
-        combined_keyset.merge!(dev_lang_strings)
-        spec.localization_languages.each do |language|
-          lang_strings = Babelyoda::Strings.new(File.localized(filename, language), language).read
-          combined_keyset.merge!(lang_strings)
-        end
-      end
-      combined_keyset.drop_empty!
-      
+      combined_keyset = combined_keyset(spec, 'babelyoda.verify')
       count = {}
       spec.all_languages.each { |lang| count[lang.to_sym] = 0}
       
@@ -281,6 +273,23 @@ namespace :babelyoda do
       end
       exit 1 unless all_found
     end
+    
+    desc "Checks localizations length"
+    task :check_localizations_length do
+      combined_keyset = combined_keyset(spec, 'babelyoda.check_length')
+      dev_lang = spec.development_language.to_sym
+      params = spec.length_checker_params
+      checker = Babelyoda::LengthChecker.new(dev_lang, params)
+      checker.long_translations(combined_keyset).each_pair do |lang, translations|
+        $logger.warn lang.to_s
+        translations.each do |t|
+          $logger.warn "/* #{t.context} */"
+          $logger.warn "'#{t.text}' >>> '#{t.dev_text}'"
+          $logger.warn ""
+        end
+        $logger.warn ""
+      end
+    end
         
     namespace :remote do
       
@@ -321,3 +330,17 @@ def strings_filename(keyset_name, lang)
     File.join("#{lang}.lproj", "#{keyset_name}.strings")
   end
 end
+
+def combined_keyset(spec, keyset_name)
+  keyset = Babelyoda::Keyset.new(keyset_name)
+  spec.strings_files.each do |filename|
+    dev_lang_strings = Babelyoda::Strings.new(filename, spec.development_language).read
+    keyset.merge!(dev_lang_strings)
+    spec.localization_languages.each do |language|
+      lang_strings = Babelyoda::Strings.new(File.localized(filename, language), language).read
+      keyset.merge!(lang_strings)
+    end
+  end
+  keyset.drop_empty!
+  keyset
+end

data/lib/babelyoda/length_checker.rb

@@ -0,0 +1,67 @@
+module Babelyoda
+  class LengthChecker
+    def initialize(dev_language, params)
+      @dev_language = dev_language
+      @params = params
+    end
+
+    def long_translations(keyset)
+      long_translations = {}
+
+      keyset.keys.each_value do |key|
+        dev_value = key.values[@dev_language]
+        dev_text = longest_translation(dev_value)
+        dev_len = dev_text.length.to_f
+
+        key.values.each_value do |value|
+          text = longest_translation(value)
+          len = text.nil? ? 0 : text.length
+          ratio = len/dev_len
+          big_ratio = ratio >= @params.ratio
+          big_delta = (len - dev_len) >= @params.delta
+
+          if big_ratio && big_delta
+            lang = value.language.to_sym
+            translation = Babelyoda::LongTranslation.new(dev_text, text, key.context)
+            if long_translations.has_key?(lang)
+              long_translations[lang].push(translation)
+            else
+              long_translations[lang] = [translation]
+            end
+          end
+        end
+      end
+      long_translations
+    end
+
+  private
+
+    def longest_translation(localizaition_value)
+      if localizaition_value.plural?
+        translation = localizaition_value.text.values.max_by {|str| str.nil? ? 0 : str.length}
+      else
+        translation = localizaition_value.text
+      end
+      translation
+    end
+  end
+
+  class LongTranslation
+    attr_accessor :dev_text
+    attr_accessor :text
+    attr_accessor :context
+    
+    def initialize(dev_text, text, context)
+      @dev_text = dev_text
+      @text = text
+      @context = context
+    end
+    
+    def ==(other_obj)
+      dev_texts_equal = @dev_text == other_obj.dev_text
+      texts_equal = @text == other_obj.text
+      contexts_equal = @context == other_obj.context
+      dev_texts_equal && texts_equal && contexts_equal
+   end
+  end
+end

data/lib/babelyoda/length_checker_params.rb

@@ -0,0 +1,10 @@
+require_relative 'specification_loader'
+
+module Babelyoda
+  class LengthCheckerParams
+    include Babelyoda::SpecificationLoader
+
+    attr_accessor :ratio
+    attr_accessor :delta
+  end
+end

data/lib/babelyoda/specification.rb

@@ -16,6 +16,7 @@ module Babelyoda
     attr_accessor :xib_files
     attr_accessor :strings_files
     attr_accessor :scm
+    attr_accessor :length_checker_params
 
     FILENAME = 'Babelfile'
 

data/lib/babelyoda/version.rb

@@ -1,3 +1,3 @@
 module Babelyoda
-  VERSION = "2.1.20"
+  VERSION = "2.2.0"
 end

data/spec/lib/babelyoda/length_checker_spec.rb

@@ -0,0 +1,106 @@
+require 'babelyoda/keyset'
+require 'babelyoda/length_checker'
+require 'babelyoda/length_checker_params'
+require 'babelyoda/strings_lexer'
+require 'babelyoda/strings_parser'
+
+describe "length checker" do
+  before(:example) do
+    @ratio = 2
+    @delta = 3
+    @params = Babelyoda::LengthCheckerParams.new()
+    @params.ratio = @ratio
+    @params.delta = @delta
+    @dev_lang = :dev_lang
+    @lang1 = :lang1
+    @lang2 = :lang2
+    @checker = Babelyoda::LengthChecker.new(@dev_lang, @params)
+  end
+  
+  describe "finding long translations in keyset" do
+    def add_lang_strings_to_keyset(lang, strings, keyset)
+      lexer = Babelyoda::StringsLexer.new    
+      parser = Babelyoda::StringsParser.new(lexer, lang)
+      parser.parse(strings) do |record|
+        keyset.merge_key!(record)
+      end
+    end
+    
+    def generate_keyset(dev_str, lang1_str, lang2_str)
+      keyset = Babelyoda::Keyset.new("test_keyset")
+      add_lang_strings_to_keyset(@dev_lang, dev_str, keyset)
+      add_lang_strings_to_keyset(@lang1, lang1_str, keyset)
+      add_lang_strings_to_keyset(@lang2, lang2_str, keyset)
+      keyset
+    end
+    
+    it "doesn't find anything in empty keyset" do
+      empty_keyset = Babelyoda::Keyset.new("empty_keyset")
+      
+      expect(@checker.long_translations(empty_keyset)).to be_empty
+    end
+    
+    context "when has only non-plural keys" do 
+      it "finds long translations" do
+        dev_str = <<-EOF 
+        /* comment hi */
+        "Hi" = "Hi";
+        /* comment hello */
+        "Hello" = "Hello";
+        EOF
+        
+        lang1_str = <<-EOF 
+        /* comment hi */
+        "Hi" = "HiHi";
+        /* comment hello */
+        "Hello" = "HelloHello";
+        EOF
+        
+        lang2_str = <<-EOF 
+        /* comment hi */
+        "Hi" = "HiHiHiHi";
+        /* comment hello */
+        "Hello" = "HelloHelloHello";
+        EOF
+        
+        keyset = generate_keyset(dev_str, lang1_str, lang2_str)
+        lang1_hello_problem = Babelyoda::LongTranslation.new("Hello", "HelloHello", "comment hello")
+        lang2_hi_problem = Babelyoda::LongTranslation.new("Hi", "HiHiHiHi", "comment hi")
+        lang2_hello_problem = Babelyoda::LongTranslation.new("Hello", "HelloHelloHello", "comment hello")
+        expected = {}
+        expected[@lang1] = [lang1_hello_problem]
+        expected[@lang2] = [lang2_hi_problem, lang2_hello_problem]
+      
+        expect(@checker.long_translations(keyset)).to eq(expected) 
+      end
+    end
+    
+    context "when has plural keys" do
+      it "compares longest plural variants" do
+        dev_str = <<-EOF
+        /* comment min */
+        "%[one]u min" = "min";
+        "%[many]u min" = "minutes";
+        EOF
+        
+        lang1_str = <<-EOF
+        /* comment min */
+        "%[one]u min" = "minminmin";
+        "%[many]u min" = "minutes";
+        EOF
+        
+        lang2_str = <<-EOF
+        /* comment min */
+        "%[one]u min" = "minminmin";
+        "%[many]u min" = "minutesminutes";
+        EOF
+        
+        keyset = generate_keyset(dev_str, lang1_str, lang2_str)
+        lang2_problem = Babelyoda::LongTranslation.new("minutes", "minutesminutes", "comment min")
+        expected = {@lang2 => [lang2_problem]}
+        
+        expect(@checker.long_translations(keyset)).to eq(expected)  
+      end
+    end
+  end
+end

data/templates/Babelfile.erb

@@ -24,4 +24,9 @@ Babelyoda::Specification.new do |s|
 	s.resources_folder = 'Resources'
 	s.xib_files = FileList['{Classes,Resources}/**/en.lproj/*.{xib}']
 	s.strings_files = FileList['{Classes,Resources}/**/en.lproj/*.{strings}']
+	
+	s.length_checker_params = Babelyoda::LengthCheckerParams.new do |p|
+		p.ratio = 1.5
+		p.delta = 10
+	end
 end

metadata

@@ -1,212 +1,192 @@
 --- !ruby/object:Gem::Specification
 name: babelyoda
 version: !ruby/object:Gem::Version
-  version: 2.1.20
-  prerelease: 
+  version: 2.2.0
 platform: ruby
 authors:
 - Andrey Subbotin
 - Ivan Moskalev
 - Alexander Denisov
+- Mikhail Chupin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-26 00:00:00.000000000 Z
+date: 2016-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: ruby_gntp
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: awesome_print
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.9.2.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.9.2.2
 - !ruby/object:Gem::Dependency
   name: rchardet19
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.3.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.3.5
 - !ruby/object:Gem::Dependency
   name: builder
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '3.0'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '3.0'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.5'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.5.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.5'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.5.5
 - !ruby/object:Gem::Dependency
   name: log4r
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.1.10
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.1.10
 description: A simple utility to push/pull l10n resources of an Xcode project to/from
@@ -234,6 +214,8 @@ files:
 - lib/babelyoda/git_versions.rb
 - lib/babelyoda/ibtool.rb
 - lib/babelyoda/keyset.rb
+- lib/babelyoda/length_checker.rb
+- lib/babelyoda/length_checker_params.rb
 - lib/babelyoda/localization_key.rb
 - lib/babelyoda/localization_value.rb
 - lib/babelyoda/logger.rb
@@ -249,6 +231,7 @@ files:
 - lib/babelyoda/version.rb
 - lib/babelyoda/xib.rb
 - spec/lib/babelyoda/keyset_spec.rb
+- spec/lib/babelyoda/length_checker_spec.rb
 - spec/lib/babelyoda/localization_key_spec.rb
 - spec/lib/babelyoda/localization_value_spec.rb
 - spec/lib/babelyoda/specification_spec.rb
@@ -260,26 +243,25 @@ files:
 - templates/Babelfile.erb
 homepage: http://github.com/eploko/babelyoda
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: babelyoda
-rubygems_version: 1.8.23.2
+rubygems_version: 2.0.14.1
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Xcode project localization made easy
 test_files: []