azeroth 0.6.4 → 0.6.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac2c03e9a7b51ed50db9ecab43a4f7257d98839126f79a45cc6b3563efd7b296
-  data.tar.gz: 95d18220fae24c2f049cf186fe25a0d5cdc94bada48ccd9ce02b867c5334f3ce
+  metadata.gz: 8e28a5c409533eebedc8579f02941b55a956b8296459243b8cf5572857f64d1c
+  data.tar.gz: ba50b329165868a7b2a65b4762a20c91898c45593bedc528e440d6d51b9fae01
 SHA512:
-  metadata.gz: 8dd092347ebebde2ccdaad5b2c165a8a595a2f8f2a6fc463303566f1b3812d84b22a0295f75ce9dbf696c752ad045691953696166705e0294f94ae3450b0f3e7
-  data.tar.gz: 4a406a9e2d4609034cab48bd8aff6ead1c644f3535d3cacd6e18523881572dde035afccbc4279ee96f9a110a0b078897641ebcfc5008a93cf47b7b4ce89bd746
+  metadata.gz: 38ca1d96bf67471f7eb0bdd1c626832e534c9418646d09d2381659096c1739a8d06b592a8c4063e1068f4e2fa8502bc9fcc25f2a9e6c998c659459eea837325c
+  data.tar.gz: 9cb5e259c5f9961d60d6ae8c50563ada7d45ab2a850f2cf79dfd8977d5b30b53ea9e029617466d19a237c2256db3c6491fe9a674cb463ad074e76b78693852ee

data/README.md

@@ -11,7 +11,7 @@ Azeroth
 
 Yard Documentation
 -------------------
-[https://www.rubydoc.info/gems/azeroth/0.6.4](https://www.rubydoc.info/gems/azeroth/0.6.4)
+[https://www.rubydoc.info/gems/azeroth/0.6.5](https://www.rubydoc.info/gems/azeroth/0.6.5)
 
 Azeroth has been designed making the coding of controllers easier
 as routes in controllers are usually copy, paste and replace of same
@@ -36,9 +36,9 @@ which adds a resource and action methods for `create`, `show`, `index`,
 `update`, `delete`, `edit`
 
 It accepts options
--only List of actions to be built
--except List of actions to not to be built
--decorator Decorator class or flag allowing/disallowing decorators
+- only List of actions to be built
+- except List of actions to not to be built
+- decorator Decorator class or flag allowing/disallowing decorators
 
 ```ruby
   # publishers_controller.rb
@@ -121,6 +121,6 @@ Exposing is done through the class method
 [expose](https://www.rubydoc.info/gems/azeroth/Azeroth/Decorator#expose-class_method)
 which accepts several options:
 
--as: custom key to expose
--if: method/block to be called checking if an attribute should or should not be exposed
--decorator: flag to use or not a decorator or decorator class to be used
+- as: custom key to expose
+- if: method/block to be called checking if an attribute should or should not be exposed
+- decorator: flag to use or not a decorator or decorator class to be used

data/lib/azeroth/decorator.rb

@@ -257,6 +257,8 @@ module Azeroth
     #
     # @return [Hash]
     def as_json(*args)
+      return nil if object.nil?
+
       return array_as_json(*args) if enum?
 
       HashBuilder.new(self).as_json

data/lib/azeroth/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Azeroth
-  VERSION = '0.6.4'
+  VERSION = '0.6.5'
 end

data/spec/lib/azeroth/decorator/key_value_extractor_spec.rb

@@ -227,5 +227,37 @@ describe Azeroth::Decorator::KeyValueExtractor do
         end
       end
     end
+
+    context 'when value is nil' do
+      context 'without decorator options' do
+        let(:object) { build(:document, name: nil) }
+
+        it 'returns nil for value' do
+          expect(extractor.as_json)
+            .to eq({ 'name' => nil })
+        end
+      end
+
+      context 'with decorator false' do
+        let(:object)       { build(:document, name: nil) }
+        let(:options_hash) { { decorator: false } }
+
+        it 'returns nil for value' do
+          expect(extractor.as_json)
+            .to eq({ 'name' => nil })
+        end
+      end
+
+      context 'with decorator option' do
+        let(:object)       { create(:pokemon_master) }
+        let(:options_hash) { { decorator: Pokemon::Decorator } }
+        let(:attribute)    { :favorite_pokemon }
+
+        it 'returns nil for value' do
+          expect(extractor.as_json)
+            .to eq({ 'favorite_pokemon' => nil })
+        end
+      end
+    end
   end
 end

data/spec/lib/azeroth/decorator_spec.rb

@@ -62,6 +62,12 @@ describe Azeroth::Decorator do
   end
 
   describe '#as_json' do
+    context 'when object is nil' do
+      let(:object) { nil }
+
+      it { expect(decorator.as_json).to be_nil }
+    end
+
     context 'when object is just a model' do
       let(:expected_json) do
         {
@@ -166,7 +172,7 @@ describe Azeroth::Decorator do
       end
     end
 
-    context 'with decotator for model with validation' do
+    context 'with decorator for model with validation' do
       subject(:decorator) do
         Document::DecoratorWithError.new(object)
       end
@@ -255,6 +261,26 @@ describe Azeroth::Decorator do
           expect(decorator.as_json).to eq(expected_json)
         end
       end
+
+      context 'with nil value and defined decorator' do
+        subject(:decorator) do
+          Factory::DecoratorWithProduct.new(factory)
+        end
+
+        let(:factory) { create(:factory) }
+
+        let(:expected_json) do
+          {
+            name: factory.name,
+            main_product: nil,
+            products: []
+          }.deep_stringify_keys
+        end
+
+        it 'exposes relation' do
+          expect(decorator.as_json).to eq(expected_json)
+        end
+      end
     end
   end
 
@@ -262,7 +288,7 @@ describe Azeroth::Decorator do
     subject(:decorator) { decorator_class.new(object) }
 
     let(:decorator_class) { Class.new(described_class) }
-    let(:model) { build(:dummy_model) }
+    let(:model)           { build(:dummy_model) }
 
     it 'delegates methods to object' do
       expect(decorator.first_name).not_to be_nil

data/spec/support/factories/pokemon_master.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :pokemon_master, class: '::PokemonMaster' do
+    sequence(:first_name) { |n| "Ash-#{n}" }
+    sequence(:last_name)  { |n| "Ketchum-#{n}" }
+    age                   { 10 }
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: azeroth
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.6.5
 platform: ruby
 authors:
 - Darthjee
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-06 00:00:00.000000000 Z
+date: 2020-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -560,6 +560,7 @@ files:
 - spec/support/factories/dummy_model.rb
 - spec/support/factories/factory.rb
 - spec/support/factories/game.rb
+- spec/support/factories/pokemon_master.rb
 - spec/support/factories/product.rb
 - spec/support/factories/publisher.rb
 - spec/support/factories/user.rb
@@ -715,6 +716,7 @@ test_files:
 - spec/support/factories/dummy_model.rb
 - spec/support/factories/factory.rb
 - spec/support/factories/game.rb
+- spec/support/factories/pokemon_master.rb
 - spec/support/factories/product.rb
 - spec/support/factories/publisher.rb
 - spec/support/factories/user.rb