axiom-sql-generator 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d25343b68c5a6f3bdd4ed65617eb70603a9cccb
-  data.tar.gz: f9811c6a02fa2d5164bcae6834fd0efcdc1765f4
+  metadata.gz: 1f5e40b841ac0de3395606dc63f690b93dbe801b
+  data.tar.gz: 0101aab61557b95116cdc6a97ee1ce17f52aeb46
 SHA512:
-  metadata.gz: e653e67c840caddfad52723fd1cd9b292f5b938e58c2b4d0134ed62031d4255e4ea23706ee8b502b4af97615524bac89c4b1476ad4637a77f24d5734b9ee1742
-  data.tar.gz: b74b606e245597593ae5967b83511d0d84077029ab70e4fb688f0f0db6435841c17c0c551ae09ebf07aa82ed6450def109e7e949b7e7a25a02ae920f2f43960c
+  metadata.gz: 15ea52586ef4a567cd64dcdb0b27746189201d058d47e9b7d4fd784ac0ee96e239afdbd5c1e9851217b5826dd00cc93bc70639e43e8ce06eb180faf448a5f28e
+  data.tar.gz: e5ee3c0437f8793002ea99aef0c6a1133830ac534e0dd263614922d56fa9e6def8f35b1107908da74e6e2473617ed7ce50d43851acbd1491ae54846df0557229

data/.rubocop.yml

@@ -0,0 +1,6 @@
+AllCops:
+  Includes:
+    - 'Gemfile'
+  Excludes:
+    - 'Gemfile.devtools'
+    - 'vendor/**'

data/.ruby-gemset

@@ -0,0 +1 @@
+axiom-sql-generator

data/.travis.yml

@@ -1,35 +1,29 @@
 language: ruby
 before_install: gem install bundler
 bundler_args: --without yard guard benchmarks
-script: "bundle exec rake ci"
+script: "bundle exec rake ci:metrics"
 rvm:
-  - ree
-  - 1.8.7
-  - 1.9.2
   - 1.9.3
   - 2.0.0
+  - 2.1.0
   - ruby-head
-  - rbx-18mode
-  - rbx-19mode
-  - jruby-18mode
-notifications:
-  irc:
-    channels:
-      - irc.freenode.org#datamapper
-    on_success: never
-    on_failure: change
-  email:
-    recipients:
-      - dan.kubb@gmail.com
-    on_success: never
-    on_failure: change
+  - rbx
 matrix:
   include:
     - rvm: jruby-19mode
-      env: JRUBY_OPTS="$JRUBY_OPTS --debug"
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug"  # for simplecov
+    - rvm: jruby-20mode
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug"  # for simplecov
+    - rvm: jruby-21mode
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug"  # for simplecov
     - rvm: jruby-head
-      env: JRUBY_OPTS="$JRUBY_OPTS --debug"
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug"  # for simplecov
   allow_failures:
-    # mutant fails
-    - rvm: 1.9.3
-    - rvm: rbx-19mode
+    - rvm: 2.1.0  # buggy runtime
+  fast_finish: true
+notifications:
+  irc:
+    channels:
+      - irc.freenode.org#rom-rb
+    on_success: never
+    on_failure: change

data/CONTRIBUTING.md

@@ -1,5 +1,4 @@
-Contributing
-------------
+# Contributing
 
 * If you want your code merged into the mainline, please discuss the proposed changes with me before doing any work on it. This library is still in early development, and the direction it is going may not always be clear. Some features may not be appropriate yet, may need to be deferred until later when the foundation for them is laid, or may be more applicable in a plugin.
 * Fork the project.

data/Gemfile

@@ -2,7 +2,14 @@
 
 source 'https://rubygems.org'
 
-gem 'axiom', '~> 0.0.8', :git => 'https://github.com/dkubb/axiom.git'
+gemspec
 
-gem 'devtools', :git => 'https://github.com/datamapper/devtools.git'
-eval File.read('Gemfile.devtools')
+platform :rbx do
+  gem 'rubysl-bigdecimal', '~> 2.0.2'
+end
+
+group :development, :test do
+  gem 'devtools', git: 'https://github.com/rom-rb/devtools.git'
+end
+
+eval_gemfile 'Gemfile.devtools'

data/Gemfile.devtools

@@ -1,48 +1,60 @@
 # encoding: utf-8
 
 group :development do
-  gem 'rake',  '~> 10.0.4'
-  gem 'rspec', '~> 2.13.0'
-  gem 'yard',  '~> 0.8.5.2'
+  gem 'rake',  '~> 10.1.0'
+  gem 'rspec', '~> 2.14.1'
+  gem 'yard',  '~> 0.8.7'
+
+  platform :rbx do
+    gem 'rubysl-singleton', '~> 2.0.0'
+  end
 end
 
 group :yard do
-  gem 'kramdown', '~> 1.0.1'
+  gem 'kramdown', '~> 1.3.0'
 end
 
 group :guard do
-  gem 'guard',         '~> 1.7.0'
-  gem 'guard-bundler', '~> 1.0.0'
-  gem 'guard-rspec',   '~> 2.5.2'
+  gem 'guard',         '~> 2.3.0'
+  gem 'guard-bundler', '~> 2.0.0'
+  gem 'guard-rspec',   '~> 4.2.0'
+  gem 'guard-rubocop', '~> 1.0.0'
 
   # file system change event handling
-  gem 'listen',     '~> 0.7.3'
-  gem 'rb-fchange', '~> 0.0.6', :require => false
-  gem 'rb-fsevent', '~> 0.9.3', :require => false
-  gem 'rb-inotify', '~> 0.9.0', :require => false
+  gem 'listen',     '~> 2.4.0'
+  gem 'rb-fchange', '~> 0.0.6', require: false
+  gem 'rb-fsevent', '~> 0.9.3', require: false
+  gem 'rb-inotify', '~> 0.9.0', require: false
 
   # notification handling
-  gem 'libnotify',               '~> 0.8.0', :require => false
-  gem 'rb-notifu',               '~> 0.0.4', :require => false
-  gem 'terminal-notifier-guard', '~> 1.5.3', :require => false
+  gem 'libnotify',               '~> 0.8.0', require: false
+  gem 'rb-notifu',               '~> 0.0.4', require: false
+  gem 'terminal-notifier-guard', '~> 1.5.3', require: false
 end
 
 group :metrics do
-  gem 'backports',       '~> 3.3', '>= 3.3.0'
-  gem 'coveralls',       '~> 0.6.4'
-  gem 'flay',            '~> 2.1.0'
-  gem 'flog',            '~> 3.2.3'
-  gem 'reek',            '~> 1.3.1', :git => 'https://github.com/troessner/reek.git'
-  gem 'simplecov',       '~> 0.7.1'
-  gem 'yardstick',       '~> 0.9.5'
-  gem 'yard-spellcheck', '~> 0.1.5'
-
-  platforms :mri_19, :rbx do
-    gem 'mutant', '~> 0.2.20'
+  gem 'coveralls', '~> 0.7.0'
+  gem 'flay',      '~> 2.4.0'
+  gem 'flog',      '~> 4.2.0'
+  gem 'reek',      '~> 1.3.2'
+  gem 'rubocop',   '~> 0.16.0'
+  gem 'simplecov', '~> 0.8.2'
+  gem 'yardstick', '~> 0.9.9'
+
+  platforms :mri do
+    gem 'mutant', '~> 0.3.4'
+  end
+
+  platforms :ruby_19, :ruby_20 do
+    gem 'yard-spellcheck', '~> 0.1.5'
   end
 
-  platforms :rbx do
-    gem 'pelusa', '~> 0.2.2'
+  platform :rbx do
+    gem 'json',               '~> 1.8.1'
+    gem 'racc',               '~> 1.4'
+    gem 'rubysl-logger',      '~> 2.0.0'
+    gem 'rubysl-open-uri',    '~> 2.0.0'
+    gem 'rubysl-prettyprint', '~> 2.0.2'
   end
 end
 

data/README.md

@@ -1,5 +1,4 @@
-axiom-sql-generator
-===================
+# axiom-sql-generator
 
 Relational algebra SQL generator
 
@@ -15,31 +14,7 @@ Relational algebra SQL generator
 [codeclimate]: https://codeclimate.com/github/dkubb/axiom-sql-generator
 [coveralls]: https://coveralls.io/r/dkubb/axiom-sql-generator
 
-Installation
-------------
-
-With Rubygems:
-
-```bash
-$ gem install axiom-sql-generator
-$ irb -rubygems
->> require 'axiom-sql-generator'
-=> true
-```
-
-With git and local working copy:
-
-```bash
-$ git clone git://github.com/dkubb/axiom-sql-generator.git
-$ cd axiom-sql-generator
-$ rake install
-$ irb -rubygems
->> require 'axiom-sql-generator'
-=> true
-```
-
-Usage
------
+## Usage
 
 ```ruby
 # visit every node in the relation AST
@@ -52,19 +27,16 @@ sql = generator.to_sql
 subquery_sql = generator.to_subquery
 ```
 
-Description
------------
+## Description
 
 The purpose of this gem is to produce valid SQL from a [axiom](https://github.com/dkubb/axiom) relation. A relation is a representation of a query constructed using relational algebra organized into an AST. Each node in the AST corresponds to an operation defined in the algebra.
 
 The SQL produced has been verified and tested against [PostgreSQL](http://www.postgresql.org/) 9.0.4. Dialects for [MySQL](http://www.mysql.com/), [SQLite](http://www.sqlite.org/), [Oracle](http://www.oracle.com/) and [SQL Server](http://www.microsoft.com/sqlserver/) are planned.
 
-Contributing
-------------
+## Contributing
 
 See [CONTRIBUTING.md](CONTRIBUTING.md) for details.
 
-Copyright
----------
+## Copyright
 
 Copyright © 2010-2013 Dan Kubb. See LICENSE for details.

data/axiom-sql-generator.gemspec

@@ -10,16 +10,14 @@ Gem::Specification.new do |gem|
   gem.description = 'Generate SQL from a axiom relation'
   gem.summary     = 'Relational algebra SQL generator'
   gem.homepage    = 'https://github.com/dkubb/axiom-sql-generator'
-  gem.licenses    = %w[MIT]
+  gem.license     = 'MIT'
 
   gem.require_paths    = %w[lib]
   gem.files            = `git ls-files`.split($/)
   gem.test_files       = `git ls-files -- spec/unit`.split($/)
   gem.extra_rdoc_files = %w[LICENSE README.md CONTRIBUTING.md TODO]
 
-  gem.add_runtime_dependency('axiom', '~> 0.1.0')
+  gem.add_runtime_dependency('axiom', '~> 0.2.0')
 
-  gem.add_development_dependency('rake',  '~> 10.0.4')
-  gem.add_development_dependency('rspec', '~> 2.13.0')
-  gem.add_development_dependency('yard',  '~> 0.8.5.2')
+  gem.add_development_dependency('bundler', '~> 1.5', '>= 1.5.2')
 end

data/config/devtools.yml

@@ -0,0 +1,2 @@
+---
+unit_test_timeout: 1.0

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 63
-total_score: 396
+total_score: 399

data/config/reek.yml

@@ -114,7 +114,7 @@ TooManyStatements:
   - Axiom::SQL::Generator::Relation::Unary#visit_axiom_relation_operation_binary
   - Axiom::SQL::Generator::Relation::Unary#visit_axiom_relation_operation_limit
   - Axiom::SQL::Generator::Relation::Unary#visit_axiom_relation_operation_offset
-  - Axiom::SQL::Generator::Relation::Unary#visit_axiom_relation_operation_order
+  - Axiom::SQL::Generator::Relation::Unary#visit_axiom_relation_operation_sorted
   - Axiom::SQL::Generator::Visitor#self.method_for
   - each
   max_statements: 2

data/config/rubocop.yml

@@ -0,0 +1,59 @@
+inherit_from: ../.rubocop.yml
+
+# Avoid parameter lists longer than five parameters.
+ParameterLists:
+  Max: 3
+  CountKeywordArgs: true
+
+# Avoid more than `Max` levels of nesting.
+BlockNesting:
+  Max: 3
+
+# Align with the style guide.
+CollectionMethods:
+  PreferredMethods:
+    collect:  'map'
+    inject:   'reduce'
+    find:     'detect'
+    find_all: 'select'
+
+# Do not force public/protected/private keyword to be indented at the same
+# level as the def keyword. My personal preference is to outdent these keywords
+# because I think when scanning code it makes it easier to identify the
+# sections of code and visually separate them. When the keyword is at the same
+# level I think it sort of blends in with the def keywords and makes it harder
+# to scan the code and see where the sections are.
+AccessModifierIndentation:
+  Enabled: false
+
+# Limit line length
+LineLength:
+  Max: 392  # TODO: lower to 79
+
+# Disable documentation checking until a class needs to be documented once
+Documentation:
+  Enabled: false
+
+# Do not always use &&/|| instead of and/or.
+AndOr:
+  Enabled: false
+
+# Do not favor modifier if/unless usage when you have a single-line body
+IfUnlessModifier:
+  Enabled: false
+
+# Allow case equality operator (in limited use within the specs)
+CaseEquality:
+  Enabled: false
+
+# Constants do not always have to use SCREAMING_SNAKE_CASE
+ConstantName:
+  Enabled: false
+
+# Not all trivial readers/writers can be defined with attr_* methods
+TrivialAccessors:
+  Enabled: false
+
+# Allow empty lines around body
+EmptyLinesAroundBody:
+  Enabled: false

data/lib/axiom/sql/generator/core_ext/date_time.rb

@@ -33,12 +33,11 @@ private
   def iso8601_timediv(time_scale)
     date_time = frozen? ? dup : self
 
-    fractional_seconds = unless time_scale.zero?
-      '.%0*d' % [
-        time_scale,
-        date_time.sec_fraction * SEC_FRACTION_MULTIPLIER * 10**time_scale
-      ]
-    end
+    fractional_seconds = sprintf(
+      '.%0*d',
+      time_scale,
+      date_time.sec_fraction * SEC_FRACTION_MULTIPLIER * 10**time_scale
+    ) unless time_scale.zero?
 
     date_time.strftime("T%T#{fractional_seconds}%Z")
   end

data/lib/axiom/sql/generator/direction.rb

@@ -12,23 +12,23 @@ module Axiom
 
         # Visit an Ascending Direction
         #
-        # @param [Relation::Operation::Order::Ascending] direction
+        # @param [Relation::Operation::Sorted::Ascending] direction
         #
         # @return [#to_s]
         #
         # @api private
-        def visit_axiom_relation_operation_order_ascending(direction)
+        def visit_axiom_relation_operation_sorted_ascending(direction)
           dispatch direction.attribute
         end
 
         # Visit an Descending Direction
         #
-        # @param [Relation::Operation::Order::Descending] direction
+        # @param [Relation::Operation::Sorted::Descending] direction
         #
         # @return [#to_s]
         #
         # @api private
-        def visit_axiom_relation_operation_order_descending(direction)
+        def visit_axiom_relation_operation_sorted_descending(direction)
           dispatch(direction.attribute) << DESC
         end
 

data/lib/axiom/sql/generator/function/predicate.rb

@@ -256,7 +256,7 @@ module Axiom
           #
           # @api private
           def optional?(operand)
-            operand.respond_to?(:required?) && ! operand.required?
+            operand.respond_to?(:required?) && !operand.required?
           end
 
         end # module Predicate

data/lib/axiom/sql/generator/relation.rb

@@ -29,16 +29,17 @@ module Axiom
         #
         # @api private
         def self.visit(relation)
-          klass = case relation
-          when Axiom::Relation::Operation::Insertion then self::Insertion
-          when Axiom::Relation::Operation::Set       then self::Set
-          when Axiom::Relation::Operation::Binary    then self::Binary
-          when Axiom::Relation::Operation::Unary     then self::Unary
-          when Axiom::Relation::Base                 then self::Base
-          when Axiom::Relation::Materialized         then self::Materialized
-          else
-            raise InvalidRelationError, "#{relation.class} is not a visitable relation"
-          end
+          klass =
+            case relation
+            when Axiom::Relation::Operation::Insertion then self::Insertion
+            when Axiom::Relation::Operation::Set       then self::Set
+            when Axiom::Relation::Operation::Binary    then self::Binary
+            when Axiom::Relation::Operation::Unary     then self::Unary
+            when Axiom::Relation::Base                 then self::Base
+            when Axiom::Relation::Materialized         then self::Materialized
+            else
+              fail InvalidRelationError, "#{relation.class} is not a visitable relation"
+            end
           klass.new.visit(relation)
         end
 
@@ -144,7 +145,7 @@ module Axiom
         #
         # @api private
         def implicit_columns
-          sql = [ STAR, column_list_for(@extensions) ]
+          sql = [STAR, column_list_for(@extensions)]
           sql.reject! { |fragment| fragment.empty? }
           sql.join(SEPARATOR)
         end