awskeyring 1.5.0 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e56bbd10b469c722c15eaca7729bf39eac3aa3bde760c6faa44fd891200c7e2d
-  data.tar.gz: f1381f0d3e9c9f69c5404cae3a12499d94bfc003999fc96f3eabc2fe98218852
+  metadata.gz: c8bf8ca4f1b8acb13b25ac0c3a362afcf390e5e8e8d5f1e42b1c4c68748f0149
+  data.tar.gz: 3693e3e8d7a9fa30ab1430cea360cd32c85c98a22a9ae68a725f236c335afe2b
 SHA512:
-  metadata.gz: b1fcf72a9fded0b2464f5f12bdcba598928400bb9b7c25bc586deb28f244d8044514433e596d758e1a54121c24c56972e2e137cc6803cca545dfb0486bc45a3e
-  data.tar.gz: 46a6c39a038ca5258a84cda96f12a3e8c6b7cea655f918476aef5b0ecc70c032cf02162eefc47ed4ed498e5234a4eb2637ec958309d8b23461b3306013a8a6b0
+  metadata.gz: 7c786f1bf73ccbe18f3c259824dfbc60bcbcf70e611916b70b8349fd9a40350f045b7e5b8e676e71bbf7bb0feadba76f54da28816cf18c32dd7a2d7acdc1d3e0
+  data.tar.gz: 5a03251d5b09208802a0790b2d52dcfa3a581394e3cd041e79cf69fa39fbd298ec8e76ae47b237342f360402d85ea5b6512f7eea89163157dcff5fd7bbd946a5

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## [v1.6.0](https://github.com/servian/awskeyring/tree/v1.6.0) (2020-08-11)
+
+[Full Changelog](https://github.com/servian/awskeyring/compare/v1.5.0...v1.6.0)
+
+**Implemented enhancements:**
+
+- Warn about missing accounts/roles [\#69](https://github.com/servian/awskeyring/pull/69) ([tristanmorgan](https://github.com/tristanmorgan))
+- RuboCop and Spec update [\#68](https://github.com/servian/awskeyring/pull/68) ([tristanmorgan](https://github.com/tristanmorgan))
+- Add SimpleCov reports. [\#67](https://github.com/servian/awskeyring/pull/67) ([tristanmorgan](https://github.com/tristanmorgan))
+
 ## [v1.5.0](https://github.com/servian/awskeyring/tree/v1.5.0) (2020-07-08)
 
 [Full Changelog](https://github.com/servian/awskeyring/compare/v1.4.0...v1.5.0)

data/Gemfile

@@ -15,5 +15,6 @@ group :development do
   gem 'rubocop-rake'
   gem 'rubocop-rspec'
   gem 'rubocop-rubycw'
+  gem 'simplecov'
   gem 'yard'
 end

data/SECURITY.md

@@ -0,0 +1,4 @@
+# Security Policy
+
+If you believe you have found a security issue in Awskeyring, please responsibly disclose by contacting me at
+[tristan.morgan@servian.com](mailto:tristan.morgan@servian.com).

data/awskeyring.gemspec

@@ -20,6 +20,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
+  spec.required_ruby_version = '>= 2.6.0'
+
   spec.metadata = {
     'bug_tracker_uri' => "#{Awskeyring::HOMEPAGE}/issues",
     'changelog_uri' => "#{Awskeyring::HOMEPAGE}/blob/master/CHANGELOG.md",

data/i18n/en.yml

@@ -75,6 +75,8 @@ en:
     delexpired: '# Removing expired session credentials'
     exec: '# COMMAND not provided'
     missing: '# Config missing, run `%{bin} initialise` to recreate.'
+    missing_account: '# No accounts added, run `%{bin} add` to add.'
+    missing_role: '# No roles added, run `%{bin} add-role` to add.'
     rotate: '# You have two access keys for account %{account}'
     temporary: '# Using temporary session credentials.'
     timeout: '# It is STRONGLY recommended to set your keychain to lock in 5 minutes or less.'

data/lib/awskeyring.rb

@@ -174,26 +174,26 @@ module Awskeyring # rubocop:disable Metrics/ModuleLength
 
   # Return a list account item names
   def self.list_account_names
-    items = list_items.map { |elem| elem.attributes[:label][(ACCOUNT_PREFIX.length)..-1] }
+    items = list_items.map { |elem| elem.attributes[:label][(ACCOUNT_PREFIX.length)..] }
 
-    tokens = list_tokens.map { |elem| elem.attributes[:label][(SESSION_KEY_PREFIX.length)..-1] }
+    tokens = list_tokens.map { |elem| elem.attributes[:label][(SESSION_KEY_PREFIX.length)..] }
 
     (items + tokens).uniq.sort
   end
 
   # Return a list role item names
   def self.list_role_names
-    list_roles.map { |elem| elem.attributes[:label][(ROLE_PREFIX.length)..-1] }.sort
+    list_roles.map { |elem| elem.attributes[:label][(ROLE_PREFIX.length)..] }.sort
   end
 
   # Return a list token item names
   def self.list_token_names
-    list_tokens.map { |elem| elem.attributes[:label][(SESSION_KEY_PREFIX.length)..-1] }.sort
+    list_tokens.map { |elem| elem.attributes[:label][(SESSION_KEY_PREFIX.length)..] }.sort
   end
 
   # Return a list role item names and arns
   def self.list_role_names_plus
-    list_roles.map { |elem| "#{elem.attributes[:label][(ROLE_PREFIX.length)..-1]}\t#{elem.attributes[:account]}" }
+    list_roles.map { |elem| "#{elem.attributes[:label][(ROLE_PREFIX.length)..]}\t#{elem.attributes[:account]}" }
   end
 
   # Return a list of console paths

data/lib/awskeyring/awsapi.rb

@@ -198,9 +198,9 @@ module Awskeyring
         sessionToken: token
       }.to_json
 
-      destination_param = '&Destination=' + CGI.escape(console_url)
+      destination_param = "&Destination=#{CGI.escape(console_url)}"
 
-      AWS_SIGNIN_URL + '?Action=login' + token_param(session_json: session_json) + destination_param
+      "#{AWS_SIGNIN_URL}?Action=login#{token_param(session_json: session_json)}#{destination_param}"
     end
 
     # Get the signin token param
@@ -214,7 +214,7 @@ module Awskeyring
       returned_content = request.get(uri).body
 
       signin_token = JSON.parse(returned_content)['SigninToken']
-      '&SigninToken=' + CGI.escape(signin_token)
+      "&SigninToken=#{CGI.escape(signin_token)}"
     end
 
     # Get the current region

data/lib/awskeyring/version.rb

@@ -6,7 +6,7 @@ require 'json'
 # Version const and query of latest.
 module Awskeyring
   # The Gem's version number
-  VERSION = '1.5.0'
+  VERSION = '1.6.0'
   # The Gem's homepage
   HOMEPAGE = 'https://github.com/servian/awskeyring'
 

data/lib/awskeyring_command.rb

@@ -72,6 +72,10 @@ class AwskeyringCommand < Thor # rubocop:disable Metrics/ClassLength
   desc 'list', I18n.t('list.desc')
   # list the accounts
   def list
+    if Awskeyring.list_account_names.empty?
+      warn I18n.t('message.missing_account', bin: File.basename($PROGRAM_NAME))
+      exit 1
+    end
     puts Awskeyring.list_account_names.join("\n")
   end
 
@@ -80,6 +84,10 @@ class AwskeyringCommand < Thor # rubocop:disable Metrics/ClassLength
   method_option 'detail', type: :boolean, aliases: '-d', desc: I18n.t('method_option.detail'), default: false
   # List roles
   def list_role
+    if Awskeyring.list_role_names.empty?
+      warn I18n.t('message.missing_role', bin: File.basename($PROGRAM_NAME))
+      exit 1
+    end
     if options['detail']
       puts Awskeyring.list_role_names_plus.join("\n")
     else
@@ -539,23 +547,23 @@ class AwskeyringCommand < Thor # rubocop:disable Metrics/ClassLength
 
   def ask(message:, secure: false, optional: false, limited_to: nil)
     if secure
-      Awskeyring::Input.read_secret(message.rjust(20) + ': ')
+      Awskeyring::Input.read_secret("#{message.rjust(20)}: ")
     elsif optional
-      Thor::LineEditor.readline((message + ' (optional)').rjust(20) + ': ')
+      Thor::LineEditor.readline("#{"#{message} (optional)".rjust(20)}: ")
     elsif limited_to
-      Thor::LineEditor.readline(message.rjust(20) + ': ', limited_to: limited_to)
+      Thor::LineEditor.readline("#{message.rjust(20)}: ", limited_to: limited_to)
     else
-      Thor::LineEditor.readline(message.rjust(20) + ': ')
+      Thor::LineEditor.readline("#{message.rjust(20)}: ")
     end
   end
 
   def unbundle
     to_delete = ENV.keys.select { |elem| elem.start_with?('BUNDLER_ORIG_') }
-    bundled_env = to_delete.map { |elem| elem[('BUNDLER_ORIG_'.length)..-1] }
+    bundled_env = to_delete.map { |elem| elem[('BUNDLER_ORIG_'.length)..] }
     to_delete << 'BUNDLE_GEMFILE'
     bundled_env.each do |env_name|
-      ENV[env_name] = ENV['BUNDLER_ORIG_' + env_name]
-      to_delete << env_name if ENV['BUNDLER_ORIG_' + env_name].start_with? 'BUNDLER_'
+      ENV[env_name] = ENV["BUNDLER_ORIG_#{env_name}"]
+      to_delete << env_name if ENV["BUNDLER_ORIG_#{env_name}"].start_with? 'BUNDLER_'
     end
     to_delete.each do |env_name|
       ENV.delete(env_name)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: awskeyring
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.0
 platform: ruby
 authors:
 - Tristan Morgan
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-07-08 00:00:00.000000000 Z
+date: 2020-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-iam
@@ -80,6 +80,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- SECURITY.md
 - awskeyring.gemspec
 - exe/awskeyring
 - i18n/en.yml
@@ -97,8 +98,8 @@ licenses:
 metadata:
   bug_tracker_uri: https://github.com/servian/awskeyring/issues
   changelog_uri: https://github.com/servian/awskeyring/blob/master/CHANGELOG.md
-  documentation_uri: https://rubydoc.info/gems/awskeyring/1.5.0
-  source_code_uri: https://github.com/servian/awskeyring/tree/v1.5.0
+  documentation_uri: https://rubydoc.info/gems/awskeyring/1.6.0
+  source_code_uri: https://github.com/servian/awskeyring/tree/v1.6.0
   wiki_uri: https://github.com/servian/awskeyring/wiki
 post_install_message: 
 rdoc_options: []
@@ -108,7 +109,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="