aws_sns_subscription 1.0.0 → 1.0.1

data/lib/aws_sns_subscription/confirmer.rb

@@ -1,10 +1,13 @@
 module AWSSNSSubscription
   module Confirmer
     extend ActiveSupport::Concern
+    class MessageWasNotAuthentic < StandardError; end
 
     def respond_to_aws_sns_subscription_confirmations
       if request.headers["x-amz-sns-message-type"] == "SubscriptionConfirmation"
-        HTTParty.get JSON.parse(request.raw_post)["SubscribeURL"]
+        sns = SNS.new(request.raw_post)
+        raise MessageWasNotAuthentic unless sns.authentic?
+        HTTParty.get sns.subscribe_url
         head :ok and return
       end
     end

data/lib/aws_sns_subscription/sns.rb

@@ -0,0 +1,19 @@
+module AWSSNSSubscription
+  class SNS
+
+    attr_reader :raw
+
+    def initialize(json)
+      @raw = json
+    end
+
+    def subscribe_url
+      JSON.parse(raw)["SubscribeURL"]
+    end
+
+    def authentic?
+      subscribe_url =~ /^https.*amazonaws\.com\//
+    end
+
+  end
+end

data/lib/aws_sns_subscription/version.rb

@@ -1,3 +1,3 @@
 module AWSSNSSubscription
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/lib/aws_sns_subscription.rb

@@ -1,5 +1,6 @@
 require 'httparty'
 require 'active_support/all'
+require 'aws-sdk'
 require 'require_all'
 require_rel 'aws_sns_subscription'
 

data/spec/confirmer_spec.rb

@@ -2,6 +2,7 @@ require 'spec_helper'
 require 'active_support/all'
 require 'httparty'
 require  File.expand_path('../../lib/aws_sns_subscription/confirmer.rb', __FILE__)
+require  File.expand_path('../../lib/aws_sns_subscription/sns.rb', __FILE__)
 
 module AWSSNSSubscription
   class Controller
@@ -15,6 +16,9 @@ module AWSSNSSubscription
       let(:raw_post) do
         File.read(File.expand_path("../fixtures/raw_post.txt", __FILE__))
       end
+      let(:raw_bologna_post) do
+        File.read(File.expand_path("../fixtures/raw_bologna_post.txt", __FILE__))
+      end
       before(:each) do
         subject.stub(:request).and_return(mock("request", headers: { "x-amz-sns-message-type" => "SubscriptionConfirmation" }, raw_post: raw_post))
       end
@@ -22,6 +26,14 @@ module AWSSNSSubscription
         HTTParty.should_receive(:get).with("https://sns.us-east-1.amazonaws.com/?Action=ConfirmSubscription&TopicArn=arn:aws:sns:us-east-1:123456789012:MyTopic&Token=2336412f37fb687f5d51e6e241d09c805a5a57b30d712f794cc5f6a988666d92768dd60a747ba6f3beb71854e285d6ad02428b09ceece29417f1f02d609c582afbacc99c583a916b9981dd2728f4ae6fdb82efd087cc3b7849e05798d2d2785c03b0879594eeac82c01f235d0e717736")
         subject.respond_to_aws_sns_subscription_confirmations
       end
+      describe "with a bologna endpoint" do
+        before(:each) do
+          subject.stub(:request).and_return(mock("request", headers: { "x-amz-sns-message-type" => "SubscriptionConfirmation" }, raw_post: raw_bologna_post))
+        end
+        it "should raise the right exception" do
+          expect { subject.respond_to_aws_sns_subscription_confirmations }.to raise_error AWSSNSSubscription::Confirmer::MessageWasNotAuthentic
+        end
+      end
     end
     describe "not receiving a subscription confirmation request" do
       before(:each) do

data/spec/fixtures/raw_bologna_post.txt

@@ -0,0 +1,12 @@
+{
+  "Type" : "SubscriptionConfirmation",
+  "MessageId" : "165545c9-2a5c-472c-8df2-7ff2be2b3b1b",
+  "Token" : "2336412f37fb687f5d51e6e241d09c805a5a57b30d712f794cc5f6a988666d92768dd60a747ba6f3beb71854e285d6ad02428b09ceece29417f1f02d609c582afbacc99c583a916b9981dd2728f4ae6fdb82efd087cc3b7849e05798d2d2785c03b0879594eeac82c01f235d0e717736",
+  "TopicArn" : "arn:aws:sns:us-east-1:123456789012:MyTopic",
+  "Message" : "You have chosen to subscribe to the topic arn:aws:sns:us-east-1:123456789012:MyTopic.\nTo confirm the subscription, visit the SubscribeURL included in this message.",
+  "SubscribeURL" : "http://bologna.com",
+  "Timestamp" : "2012-04-26T20:45:04.751Z",
+  "SignatureVersion" : "1",
+  "Signature" : "EXAMPLEpH+DcEwjAPg8O9mY8dReBSwksfg2S7WKQcikcNKWLQjwu6A4VbeS0QHVCkhRS7fUQvi2egU3N858fiTDN6bkkOxYDVrY0Ad8L10Hs3zH81mtnPk5uvvolIC1CXGu43obcgFxeL3khZl8IKvO61GWB6jI9b5+gLPoBc1Q=",
+  "SigningCertURL" : "https://sns.us-east-1.amazonaws.com/SimpleNotificationService-f3ecfb7224c7233fe7bb5f59f96de52f.pem"
+  }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aws_sns_subscription
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -92,8 +92,10 @@ files:
 - lib/aws_sns_subscription.rb
 - lib/aws_sns_subscription/confirmer.rb
 - lib/aws_sns_subscription/railtie.rb
+- lib/aws_sns_subscription/sns.rb
 - lib/aws_sns_subscription/version.rb
 - spec/confirmer_spec.rb
+- spec/fixtures/raw_bologna_post.txt
 - spec/fixtures/raw_post.txt
 - spec/spec_helper.rb
 homepage: ''
@@ -122,5 +124,6 @@ specification_version: 3
 summary: Auto responds to AWS SNS subscription confirmations
 test_files:
 - spec/confirmer_spec.rb
+- spec/fixtures/raw_bologna_post.txt
 - spec/fixtures/raw_post.txt
 - spec/spec_helper.rb