aws_runas 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 166b3e595ae6aa7dd121a945715a9eff29aae90c
-  data.tar.gz: 76ce3d0b5522a93ce950bf849cfebc0227b068c0
+  metadata.gz: b42c61f6910d824c789cda5dfd180ee21526a4eb
+  data.tar.gz: 633b4c171c180074c8236fadbb0b1fd228d28286
 SHA512:
-  metadata.gz: 3cf889367e458ed4ba71c87e2e263acfb56a1399a4bdb0bde55cc26fab7f237a67e0af8f3a5026972bf869f37e87c9dfef753cfbd9bffa6872f3e6e074c8c630
-  data.tar.gz: c3e14f375de48a3260680376c23c1622c75bfa0e4ac78639a398a53b727d4a2d5a45d1fdeb3252700c184b3cbbe6e8c92298e5a125646543e27430aad3a32c68
+  metadata.gz: 89c0b88c7dc6ac5700b96934db1741c5a6847bb879d05675d6ab7d520d56a1e7ab4e169d216d77912c083062b59043f5596de9f4a51a7c872043f46b07f977e2
+  data.tar.gz: 950a1ab391f0508b074a824937ded7948b99137022b0d3b8fa69dc93ef5b43f00965e4f7cd1a0406b6937e17c2cb183378ab14ad7b2a24f75f98d4cdbb388881

data/CHANGELOG.md

@@ -1,6 +1,12 @@
 aws_runas CHANGELOG
 ====================
 
+0.1.3 (Fri 27 Nov 2015 08:05:45 PST)
+-------------------------------------
+
+ * Fixed #3 (better handling of invalid profile name).
+ * Added guard for invalid file as well.
+
 0.1.2 (Wed 25 Nov 2015 09:09:09 PST)
 -------------------------------------
 

data/lib/aws_runas/config.rb

@@ -29,6 +29,7 @@ module AwsRunAs
     def initialize(path:, profile:)
       @path = path
       @path = self.class.find_config_file unless @path
+      fail(Errno::ENOENT, "#{@path}") unless File.exist?(@path.to_s)
       @profile = profile
     end
 
@@ -36,8 +37,10 @@ module AwsRunAs
     def load_config_value(key:)
       section = @profile
       section = "profile #{@profile}" unless @profile == 'default'
-      aws_config = IniFile.load(@path) if File.exist?(@path)
-      nil unless aws_config
+      aws_config = IniFile.load(@path)
+      unless aws_config.has_section?(section)
+        fail(NameError, "Profile #{@profile} not found in #{@path}")
+      end
       aws_config[section][key]
     end
 

data/lib/aws_runas/version.rb

@@ -13,5 +13,5 @@
 # limitations under the License.
 
 module AwsRunAs
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/spec/aws_runas/config_spec.rb

@@ -81,4 +81,28 @@ describe AwsRunAs::Config do
       end
     end
   end
+
+  context 'with profile set to an invalid profile' do
+    before(:context) do
+      @cfg = AwsRunAs::Config.new(path: MOCK_AWS_CONFIGPATH, profile: 'bad-profile')
+    end
+
+    describe '#load_config_value' do
+      it 'raises a NameError when a value load is attempted' do
+        expect { @cfg.load_config_value(key: 'region') }.to raise_error(NameError)
+      end
+    end
+  end
+
+  context 'with an invalid config file supplied' do
+    describe '#load_config_value' do
+      it 'raises a Errno::ENOENT error' do
+        expect do
+          AwsRunAs::Config.new(
+            path: '/bad/path/here', profile: 'default'
+          )
+        end.to raise_error(Errno::ENOENT)
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aws_runas
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Chris Marchesi
@@ -31,7 +31,7 @@ cert_chain:
   reriQxVYXGlD8ZDuaKlDyVqUbF026ZHIlHKIgg90O037qFPxCBACTtxtYTP2hwug
   Yis=
   -----END CERTIFICATE-----
-date: 2015-11-25 00:00:00.000000000 Z
+date: 2015-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk