awesome_bot 1.13.3 → 1.13.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 66cab9489f67486d0e789ee5610f7e0eb46033f3
-  data.tar.gz: bcac80b32a5e966ed9b6b38f2073adc9babe2342
+  metadata.gz: 06365d94443a05ed03f115ef3d0b490cb512016e
+  data.tar.gz: e14ba8d9a8a55496d62c763ac18a32bfc1978ffd
 SHA512:
-  metadata.gz: a6857196eeb0c7265fdd3574f90c51f676279905e45f6800ba55572f545230cd51aff59d2fd883fa53224bf932fccf71778fb0fd6e62ac84202d4a1325b96e74
-  data.tar.gz: 201fe4ded0451bb6621b05b7c5dd98c41d86698331ebfd53adbc434f5c3c654696b4b404a04f95282ea2863d06f41ee11fb535a8878b3ad2b2372678619e01c7
+  metadata.gz: 8a0705f7b850a4a0e1e6c90308b6e67b30d8b212ab2bb02c5c2aa530b7dd5b9719728e9e92c94bba2ec4f33815b26b9e53e6af689ecd272c8398edb3510cd0e1
+  data.tar.gz: 3a86393003437ac2d4e7c59b3fa3047b7714ca18876d74a4ea8ed43e2c8e4283ec30311eea995af656bba92df127c2a5b3bb03a4aeb16b55e1477fa2b28d1682

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 Changes by [Daniel Khamsing][] unless otherwise noted.
 
+# 1.13.4
+
+- cleanup `-1` error in markdown table
+- isolate `write`
+
 # 1.13.3
 
 - add markdown results table artifacts to use with [`danger`](https://github.com/danger/danger)

data/README.md

@@ -132,7 +132,10 @@ Does your GitHub README contain a lot of links? `awesome_bot` can help you valid
 
 and [more](status/status.md).
 
-Tip: Use the keyword `[ci skip]` in your commit title/message to skip verification.
+Tips
+
+- Use the keyword `[ci skip]` in your commit title/message to skip verification.
+- Use [Danger](#danger).
 
 ### Travis CI
 
@@ -214,12 +217,10 @@ You can also add a badge for other CI tools, check out [shields.io](http://shiel
 
 ### Danger
 
-You can integrate `awesome_bot` with [`danger`](https://github.com/danger/danger)
+Integrate `awesome_bot` with [Danger](https://github.com/danger/danger) and have results reported back to the [pull request](https://github.com/vsouza/awesome-ios/pull/1001)).
 
 ![danger](https://cloud.githubusercontent.com/assets/4723115/17375716/0cdd37cc-5967-11e6-8ae3-829060a786dc.png)
 
-The above is from an actual [pull request](https://github.com/vsouza/awesome-ios/pull/1001).
-
 Here's the step in your **Dangerfile**:
 
 ```ruby

data/bin/assets/test-dupe

@@ -1,5 +1,5 @@
-https://twitter.com
-https://twitter.com
+http://www.nytimes.com/
+http://www.nytimes.com/
 https://github.com/dkhamsing
 https://github.com
 https://github.com

data/lib/awesome_bot/cli.rb

@@ -2,11 +2,10 @@ require 'awesome_bot/check'
 require 'awesome_bot/output'
 require 'awesome_bot/result'
 require 'awesome_bot/version'
+require 'awesome_bot/write'
 
 # Command line interface
 module AwesomeBot
-  RESULTS_PREFIX = 'ab-results'
-
   class << self
     def cli()
       require 'optparse'
@@ -132,8 +131,8 @@ module AwesomeBot
 
       if r.success(options) == true
         puts 'No issues :-)'
-        cli_write_results(filename, r)
-        cli_write_markdown_results(filename, nil)
+        write_results(filename, r)
+        write_markdown_results(filename, nil)
         return STATUS_OK
       else
         filtered_issues = []
@@ -174,7 +173,7 @@ module AwesomeBot
                 'link'=> url,
                 'error'=> error
               }
-              filtered_issues.push hash              
+              filtered_issues.push hash
 
               print "  #{pad_text index + 1, pad_list(r.dupes.uniq)}. "
               print loc_formatted loc, largest
@@ -183,71 +182,11 @@ module AwesomeBot
           end
         end
 
-        cli_write_results(filename, r)
-        filtered = cli_write_results_filtered(filename, filtered_issues)
-        cli_write_markdown_results(filename, filtered)
+        write_results(filename, r)
+        filtered = write_results_filtered(filename, filtered_issues)
+        write_markdown_results(filename, filtered)
         return 'Issues'
       end
     end
-
-    def cli_write_results(f, r)
-      results_file_filter = f.gsub('/','-')
-      results_file = "#{RESULTS_PREFIX}-#{results_file_filter}.json"
-      r.write results_file
-      puts "\nWrote results to #{results_file}"
-    end
-
-    def cli_write_results_filtered(file, filtered)
-        require 'json'
-        results_file_filter = file.gsub('/','-')
-        results_file = "#{RESULTS_PREFIX}-#{results_file_filter}-filtered.json"
-        File.open(results_file, 'w') { |f| f.write JSON.pretty_generate(filtered) }
-        puts "Wrote filtered results to #{results_file}"
-
-        return results_file
-    end
-
-    def cli_write_markdown_results(filename, filtered)
-      payload =
-      if filtered.nil?
-        {'error'=>false}
-      else
-        title = 'Found links issues'
-        message = "#### Link issues by [`awesome_bot`](https://github.com/dkhamsing/awesome_bot)\n\n"
-        message << "  Line | Status | Link\n"
-        message << "| ---: | :----: | --- |\n"
-
-        results = File.read filtered
-        require 'json'
-        j = JSON.parse results
-        j.sort_by { |h| h['loc'] }.each do |i|
-          error = i['error']
-          loc   = i['loc']
-          link  = i['link']
-          s     = i['status']
-          r     = i['redirect']
-
-          if error=='Dupe'
-            message << "#{loc} | Dupe | #{link} "
-          else
-            message << "#{loc} | [#{s}](https://httpstatuses.com/#{s}) | #{link} "
-            message << "<br> #{error}" unless error ==''
-            message << "redirects to<br>#{r}" unless r==''
-          end
-          message << "\n"
-        end
-
-        {
-          'error'  => true,
-          'title'  => title,
-          'message'=> message
-        }
-      end
-
-      results_file_filter = filename.gsub('/','-')
-      results_file = "#{RESULTS_PREFIX}-#{results_file_filter}-markdown-table.json"
-      File.open(results_file, 'w') { |f| f.write JSON.pretty_generate(payload) }
-      puts "Wrote markdown table results to #{results_file}"
-    end
   end # class
 end

data/lib/awesome_bot/version.rb

@@ -5,5 +5,5 @@ module AwesomeBot
                         'Great for "awesome" projects.'
   PROJECT_URL = 'https://github.com/dkhamsing/awesome_bot'
 
-  VERSION = '1.13.3'
+  VERSION = '1.13.4'
 end

data/lib/awesome_bot/write.rb

@@ -0,0 +1,74 @@
+require 'json'
+
+# Command line interface
+module AwesomeBot
+  RESULTS_PREFIX = 'ab-results'
+
+  class << self
+    def filter_filename(f)
+      f.gsub('/','-')
+    end
+
+    def write_markdown_results(filename, filtered)
+      payload =
+      if filtered.nil?
+        {'error'=>false}
+      else
+        results = File.read filtered
+        j = JSON.parse results
+
+        num = j.count
+        plural = num==1?'':'s'
+        title = "Found #{num} link issue#{plural}"
+        message = "#### Link issue#{plural} by [`awesome_bot`](https://github.com/dkhamsing/awesome_bot)\n\n"
+        message << "  Line | Status | Link\n"
+        message << "| ---: | :----: | --- |\n"
+
+        j.sort_by { |h| h['loc'] }.each do |i|
+          error = i['error']
+          loc   = i['loc']
+          link  = i['link']
+          s     = i['status']
+          r     = i['redirect']
+
+          if error=='Dupe'
+            message << "#{loc} | Dupe | #{link} "
+          else
+            status = s==-1? 'Error' : "[#{s}](https://httpstatuses.com/#{s})"
+            message << "#{loc} | #{status} | #{link} "
+            message << "<br> #{error}" unless error ==''
+            message << "redirects to<br>#{r}" unless r==''
+          end
+          message << "\n"
+        end
+
+        {
+          'error'  => true,
+          'title'  => title,
+          'message'=> message
+        }
+      end
+
+      results_file_filter = filter_filename filename
+      results_file = "#{RESULTS_PREFIX}-#{results_file_filter}-markdown-table.json"
+      File.open(results_file, 'w') { |f| f.write JSON.pretty_generate(payload) }
+      puts "Wrote markdown table results to #{results_file}"
+    end
+
+    def write_results(f, r)
+      results_file_filter = filter_filename f
+      results_file = "#{RESULTS_PREFIX}-#{results_file_filter}.json"
+      r.write results_file
+      puts "\nWrote results to #{results_file}"
+    end
+
+    def write_results_filtered(file, filtered)
+      results_file_filter = filter_filename file
+      results_file = "#{RESULTS_PREFIX}-#{results_file_filter}-filtered.json"
+      File.open(results_file, 'w') { |f| f.write JSON.pretty_generate(filtered) }
+      puts "Wrote filtered results to #{results_file}"
+
+      return results_file
+    end
+  end # class
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: awesome_bot
 version: !ruby/object:Gem::Version
-  version: 1.13.3
+  version: 1.13.4
 platform: ruby
 authors:
 - Daniel Khamsing
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-03 00:00:00.000000000 Z
+date: 2016-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parallel
@@ -67,6 +67,7 @@ files:
 - lib/awesome_bot/result.rb
 - lib/awesome_bot/version.rb
 - lib/awesome_bot/white_list.rb
+- lib/awesome_bot/write.rb
 - status/README.md
 - status/list-circle-ci
 - status/list-travis-ci