avromatic 0.9.0.rc4 → 0.9.0.rc6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1d65e7071a11c5a0b6ffa58c3d495b8b8a551461
-  data.tar.gz: fe9c6e799c8bc16e05520b6de4d3960030e6ae8b
+  metadata.gz: ba5443f9bd3883ce2b78d8a27782069b8b6f9387
+  data.tar.gz: 010950770be1bea00cc8aa4143e8124667d00379
 SHA512:
-  metadata.gz: 8277129ab8bdc6f7265f798654d04029b1ca58065b33581d786c1d00ec007ca89d5b9dd1329c70d509800ebbeb558f0d2d2b35e9e0e7220ac21cdf6c28763579
-  data.tar.gz: 70a0355e84f6d7ddffb2a12b5085f1b3ef3d5b9e840bcbf82c855de1dc01b10c169c7fc5434165a459a6e6f76e738f6131915a40c547f7bb93ec61a2f7207d40
+  metadata.gz: 353f84a00f41772c41d4b9889f3610750b66364151d051ab315429f3f5b77a353376f70cd2101c896e043b486a4df22f20e7467158ef29eb5c47d72d9109444b
+  data.tar.gz: f86f38a32fad99f98f8c697119cc0b4c4b2a8f4e76264b6e8755d8a148b2ee3a3076d19b51c16ca5fefaeb07ff450c3e1b1376dbd3836719648bd353699689dd

data/CHANGELOG.md

@@ -5,6 +5,10 @@
 - Allow nested models to be referenced and reused.
 - Fix the serialization of nested complex types.
 - Add support for recursive models.
+- Allow required array and map fields to be empty. Only nil values for required
+  array and map fields are now considered invalid.
+- Validate nested models. This does not apply to nested models embedded
+  within other complex types (array, map, and union).
 
 ## v0.8.0
 - Add support for logical types. Currently this requires using the

data/avromatic.gemspec

@@ -34,6 +34,6 @@ Gem::Specification.new do |spec|
   # For FakeSchemaRegistryServer
   spec.add_development_dependency 'sinatra'
   spec.add_development_dependency 'salsify_rubocop', '~> 0.42.0'
-  spec.add_development_dependency 'overcommit'
+  spec.add_development_dependency 'overcommit', '0.35.0'
   spec.add_development_dependency 'appraisal'
 end

data/lib/avromatic/model/attributes.rb

@@ -77,14 +77,32 @@ module Avromatic
                       inclusion: { in: Set.new(field.type.symbols.map(&:freeze)).freeze })
           when :fixed
             validates(field.name, length: { is: field.type.size })
+          when :record
+            validate_record(field.name)
           end
 
           add_required_validation(field)
         end
 
+        def validate_record(field_name)
+          validate do |instance|
+            record = instance.send(field_name)
+            if record && record.invalid?
+              record.errors.each do |key, message|
+                errors.add(field_name.to_sym, "invalid: #{key} #{message}")
+              end
+            end
+          end
+        end
+
         def add_required_validation(field)
           if required?(field) && field.default == :no_default
-            validates(field.name, presence: true)
+            case field.type.type_sym
+            when :array, :map, :boolean
+              validates(field.name, exclusion: { in: [nil], message: "can't be nil" })
+            else
+              validates(field.name, presence: true)
+            end
           end
         end
 

data/lib/avromatic/model_registry.rb

@@ -19,6 +19,7 @@ module Avromatic
       raise 'models with a key schema are not supported' if model.key_avro_schema
       name = model.avro_schema.fullname
       name = remove_prefix(name)
+      raise "'#{name}' has already been registered" if registered?(name)
       @hash[name] = model
     end
 

data/lib/avromatic/version.rb

@@ -1,3 +1,3 @@
 module Avromatic
-  VERSION = '0.9.0.rc4'.freeze
+  VERSION = '0.9.0.rc6'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: avromatic
 version: !ruby/object:Gem::Version
-  version: 0.9.0.rc4
+  version: 0.9.0.rc6
 platform: ruby
 authors:
 - Salsify Engineering
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-09-21 00:00:00.000000000 Z
+date: 2016-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: avro
@@ -196,16 +196,16 @@ dependencies:
   name: overcommit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.35.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.35.0
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement