avromatic 0.15.0 → 0.15.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a6f0ed00b507561bee5c905af3ad8d32e752cbaf
-  data.tar.gz: 6aad47be2668c65a14f23b66da204c88a720b9e9
+  metadata.gz: 46512fd49a1b53c39202a90d03214b23303a7775
+  data.tar.gz: e63c9f9f1dd812b6627f3e06c93283d3ce095ad4
 SHA512:
-  metadata.gz: e7f64c1ed68803b496ff6b923b6dda7ce9f89306f8a590ec1dbe7676e344e2fc7353d6a98c627c4929ce38d19e6f73900033273951a19dc24611d38026ef3df3
-  data.tar.gz: c6dd1ae8d6dde959cc6da12f280453126917a4f43120f6d7f812f0dde845ab516a0f26253acd5b483d0cba4c48575a3ff0a3e3e44fd1c65fc083dacb208bd2fc
+  metadata.gz: 6619307c3c04ad60f7072f1ab019ee20ae718464cfac13f74be82d3556bfe51a9ef6c4fa9ca9eb566535e7c24d74577e4e67a50deab2505e362285e9d3e1e713
+  data.tar.gz: ef6be3d67985f24e3b1f7ff3836a28945e769f4b8878ba9973ba0a9ecf4919c1f4788f7f1587af8847d31ea7a1f3a0e1166bac4d1e361e823fd274104ed11921

data/.travis.yml

@@ -1,7 +1,11 @@
 language: ruby
 rvm:
-  - 2.2.4
-  - 2.3.1
+  - 2.4.0
+  - 2.3.3
+  - 2.2.6
+before_install:
+  # Workaround for https://github.com/sickill/rainbow/issues/48
+  - gem update --system
 before_script:
   - bundle exec appraisal install --jobs=3
 script:

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # avromatic changelog
 
+## v0.15.1
+- Add `Avromatic.use_cacheable_schema_registration` option to control the lookup
+  of existing schema ids by fingerprint.
+
 ## v0.15.0
 - Add patch to `AvroTurf::SchemaRegistry` to lookup existing schema ids using
   `GET /subjects/:subject/fingerprints/:fingerprint` from `#register`.

data/README.md

@@ -58,6 +58,13 @@ and the [Messaging API](#messaging-api).
   `registry_url` must be configured.
 * **registry_url**: URL for the schema registry. Either `schema_registry` or 
   `registry_url` must be configured.
+* **use_cacheable_schema_registration**: Avromatic supports a Schema Registry
+  [extension](https://github.com/salsify/avro-schema-registry#extensions) that
+  provides an endpoint to lookup existing schema ids by fingerprint.
+  A successful response from this GET request can be cached indefinitely.
+  The use of this additional endpoint can be disabled by setting this option to
+  `false` and this is recommended if using a Schema Registry that does not support
+  the endpoint.
 * **messaging**: An `AvroTurf::Messaging` object to be shared by all generated models.
   The `build_messaging!` method may be used to create a `Avromatic::Messaging`
   instance based on the other configuration values.

data/lib/avromatic/schema_registry_patch.rb

@@ -1,27 +1,33 @@
 require 'avro_turf'
 require 'avro_turf/schema_registry'
 
-AvroTurf::SchemaRegistry.class_eval do
-  # Override register to first check if a schema is registered by fingerprint
-  def register(subject, schema)
-    schema_object = if schema.is_a?(String)
-                      Avro::Schema.parse(schema)
-                    else
-                      schema
-                    end
+module Avromatic
+  module CacheableSchemaRegistration
+    # Override register to first check if a schema is registered by fingerprint
+    def register(subject, schema)
+      return super unless Avromatic.use_cacheable_schema_registration
 
-    registered = false
-    data = begin
-             get("/subjects/#{subject}/fingerprints/#{schema_object.sha256_fingerprint.to_s(16)}")
-           rescue
-             registered = true
-             post("/subjects/#{subject}/versions", body: { schema: schema.to_s }.to_json)
-           end
+      schema_object = if schema.is_a?(String)
+                        Avro::Schema.parse(schema)
+                      else
+                        schema
+                      end
 
-    id = data.fetch('id')
+      registered = false
+      data = begin
+        get("/subjects/#{subject}/fingerprints/#{schema_object.sha256_fingerprint.to_s(16)}")
+      rescue
+        registered = true
+        post("/subjects/#{subject}/versions", body: { schema: schema.to_s }.to_json)
+      end
 
-    @logger.info("#{registered ? 'Registered' : 'Found'} schema for subject `#{subject}`; id = #{id}")
+      id = data.fetch('id')
 
-    id
+      @logger.info("#{registered ? 'Registered' : 'Found'} schema for subject `#{subject}`; id = #{id}")
+
+      id
+    end
   end
 end
+
+AvroTurf::SchemaRegistry.prepend(Avromatic::CacheableSchemaRegistration)

data/lib/avromatic/version.rb

@@ -1,3 +1,3 @@
 module Avromatic
-  VERSION = '0.15.0'.freeze
+  VERSION = '0.15.1'.freeze
 end

data/lib/avromatic.rb

@@ -9,7 +9,7 @@ module Avromatic
   class << self
     attr_accessor :schema_registry, :registry_url, :schema_store, :logger,
                   :messaging, :type_registry, :nested_models,
-                  :use_custom_datum_reader
+                  :use_custom_datum_reader, :use_cacheable_schema_registration
 
     delegate :register_type, to: :type_registry
   end
@@ -18,6 +18,7 @@ module Avromatic
   self.logger = Logger.new($stdout)
   self.type_registry = Avromatic::Model::TypeRegistry.new
   self.use_custom_datum_reader = true
+  self.use_cacheable_schema_registration = true
 
   def self.configure
     yield self

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: avromatic
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.15.1
 platform: ruby
 authors:
 - Salsify Engineering
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-01-20 00:00:00.000000000 Z
+date: 2017-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: avro
@@ -296,7 +296,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Generate Ruby models from Avro schemas