avro_turf 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4973e043a05b5317719217586f8cee3b9f913d1a
-  data.tar.gz: fb36f804b15c0bed61161d7b73242b7cb0a4cd83
+  metadata.gz: 0df3c290be95bcafd27a4473ba75df36a5275a6b
+  data.tar.gz: 17e1a0283f0479c60a691d3c52e33fb8eaf3f30c
 SHA512:
-  metadata.gz: 234fa5e60fa5d41ead791b6f48c0db08b2ae02a53848b0fbd31dcf13ee07610800c8407a760e86b9329da3f0b0a2d96ea6c44768f7db9438e18aebe72a3f7ab6
-  data.tar.gz: deaa4c2afa94cabe4d50070d17c3cd455623461d1fb91397e2ed0a2ff473df9892e409836efe7e4bc13d55658de6b340955c1342a8251bee1a52aef2b8d875cb
+  metadata.gz: 7df0d445557d08c28a9a6e0357dea7b76159846ab3f3e456b1200e4a28c84bb1853727d4259bcf94432567f8031cfb34e80b30963b5fb1e1f43fff5ce0a52e1e
+  data.tar.gz: 144873d0859cb6c937898b94ca3649dca34284b9fa16ebaa122244faef4c20d838c871ab51ecf91c9c69d803d84fd55215867544ac57d5283a86b18fbc8ffc9f

data/README.md

@@ -99,7 +99,7 @@ By default, AvroTurf will encode data in the Avro data file format. This means t
 
 The Messaging API will automatically register schemas used for encoding data, and will fetch the corresponding schema when decoding. Instead of including the full schema in the output, only a schema id generated by the registry is included. Registering the same schema twice is idempotent, so no coordination is needed.
 
-**NOTE:** The Messaging format is _not_ compatible with the Avro data file API.
+**NOTE:** [The Messaging format](https://github.com/confluentinc/schema-registry/blob/master/docs/serializer-formatter.rst#wire-format) is _not_ compatible with the Avro data file API.
 
 The Messaging API is not included by default, so you must require 'avro_turf/messaging' explicitly if you want to use it.
 

data/lib/avro_turf/messaging.rb

@@ -43,12 +43,12 @@ class AvroTurf
     # namespace   - The namespace of the schema (optional).
     #
     # Returns the encoded data as a String.
-    def encode(message, schema_name: nil, namespace: @namespace)
+    def encode(message, schema_name: nil, namespace: @namespace, subject: nil)
       schema = @schema_store.find(schema_name, namespace)
 
       # Schemas are registered under the full name of the top level Avro record
-      # type.
-      schema_id = @registry.register(schema.fullname, schema)
+      # type, or `subject` if it's provided.
+      schema_id = @registry.register(subject || schema.fullname, schema)
 
       stream = StringIO.new
       writer = Avro::IO::DatumWriter.new(schema)

data/lib/avro_turf/schema_to_avro_patch.rb

@@ -34,8 +34,19 @@ class AvroTurf
         end
       end
     end
+
+    module DatumReader
+      def read_default_value(field_schema, default_value)
+        if default_value == :no_default
+          raise Avro::AvroError, "Missing data for #{field_schema} with no default"
+        end
+
+        super
+      end
+    end
   end
 end
 
 Avro::Schema::RecordSchema.send(:prepend, AvroTurf::AvroGemPatch::RecordSchema)
 Avro::Schema::Field.send(:prepend, AvroTurf::AvroGemPatch::Field)
+Avro::IO::DatumReader.send(:prepend, AvroTurf::AvroGemPatch::DatumReader)

data/lib/avro_turf/version.rb

@@ -1,3 +1,3 @@
 class AvroTurf
-  VERSION = "0.7.1"
+  VERSION = "0.7.2"
 end

data/spec/messaging_spec.rb

@@ -79,7 +79,14 @@ describe AvroTurf::Messaging do
       allow(registry).to receive(:register).and_call_original
       message = { "full_name" => "John Doe" }
       avro.encode(message, schema_name: "person")
-      expect(registry).to have_received(:register)
+      expect(registry).to have_received(:register).with("person", anything)
+    end
+
+    it "allows specifying a schema registry subject" do
+      allow(registry).to receive(:register).and_call_original
+      message = { "full_name" => "John Doe" }
+      avro.encode(message, schema_name: "person", subject: "people")
+      expect(registry).to have_received(:register).with("people", anything)
     end
   end
 

data/spec/schema_to_avro_patch_spec.rb

@@ -22,3 +22,45 @@ describe Avro::Schema do
     })
   end
 end
+
+
+describe Avro::IO::DatumReader do
+  let(:writer_schema) do
+    Avro::Schema.parse <<-AVSC
+      {
+        "name": "no_default",
+        "type": "record",
+        "fields": [
+          { "type": "string", "name": "one" }
+        ]
+      }
+    AVSC
+  end
+  let(:reader_schema) do
+    Avro::Schema.parse <<-AVSC
+      {
+        "name": "no_default",
+        "type": "record",
+        "fields": [
+          { "type": "string", "name": "one" },
+          { "type": "string", "name": "two" }
+        ]
+      }
+    AVSC
+  end
+
+  it "raises an error for missing fields without a default" do
+    stream = StringIO.new
+    writer = Avro::IO::DatumWriter.new(writer_schema)
+    encoder = Avro::IO::BinaryEncoder.new(stream)
+    writer.write({ 'one' => 'first' }, encoder)
+    encoded = stream.string
+
+    stream = StringIO.new(encoded)
+    decoder = Avro::IO::BinaryDecoder.new(stream)
+    reader = Avro::IO::DatumReader.new(writer_schema, reader_schema)
+    expect do
+      reader.read(decoder)
+    end.to raise_error(Avro::AvroError, 'Missing data for "string" with no default')
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: avro_turf
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - Daniel Schierbeck
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-15 00:00:00.000000000 Z
+date: 2016-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: avro