avo-icons 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ade5d8a320ddc48f948c992dddfb970d97a96073cab7e6cc57ca5a83488b38f7
-  data.tar.gz: 946092a71177db88065762d270510253fc024da224fb5447284fa94fe8256f7d
+  metadata.gz: d7e1ba1003c871809b4a0e3d1ed7ba933698ab3b4e3195ab465410ed914d11be
+  data.tar.gz: 2be3955291f9dacbdbe213a4d1fdbd67d391c8bf07f791caca8780ea4e7e8c38
 SHA512:
-  metadata.gz: 921503ad245c16ce813823ad1cc461926b1a70f1cf05f59912373d4c8b5c32b5286597115ab378430893259847c08cdee5726eddb906b2fbaa7b5d0710522682
-  data.tar.gz: 4ac6b8449a17da2e984dd9b3db134d0ba1af810401d9031555c9adb6bf022369a0afccecbb351fa1c1fe4b642c07e6e77164f13b70db232ed10f6fe7e91bf391
+  metadata.gz: 3ce50600d3946cfa30f8971a16bf825cc2f3294ef06af591353d66712c689b41eb703c95ec17a325c4559b3e6145d8239f0f0871d2f3d5376be5c6dd9a4a95b7
+  data.tar.gz: b13e91c5981c074de4a251ecd4837ea6608acbc48cc05581aa77aff0c2b7a9c68947c88171cb680cb258fad961a6b20e820ef70d338cb8511ea7174fd596fc99

data/lib/avo/icons/helpers.rb

@@ -20,23 +20,41 @@ module Avo
 
       private
 
-      # Override inline_svg's placeholder to use our own css class.
+      # Override inline_svg's placeholder, but only for lookups made through
+      # our #svg helper (detected via the asset finder thread-local). Host app
+      # calls to inline_svg/inline_svg_tag keep inline_svg's own behavior.
       # https://github.com/jamesmartin/inline_svg/blob/main/lib/inline_svg/action_view/helpers.rb#L61
       def placeholder(filename)
+        return avo_missing_svg_placeholder(filename) if Thread.current[:inline_svg_asset_finder] == Avo::Icons::SvgFinder
+        return super if defined?(super)
+
+        # Minimal silent placeholder for direct calls outside a full ActionView
+        # helper chain. Mirrors inline_svg's default shape only — it does not
+        # consult svg_not_found_css_class or add the extension hint.
+        escaped_filename = ERB::Util.html_escape_once(filename.to_s)
+        "<svg><!-- SVG file not found: '#{escaped_filename}' --></svg>".html_safe
+      end
+
+      # The loud debug glyph rendered when an Avo icon lookup misses.
+      def avo_missing_svg_placeholder(filename)
         css_class = "avo-missing-svg"
         escaped_filename = ERB::Util.html_escape_once(filename.to_s)
         missing_icon = '<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="icon icon-tabler icons-tabler-outline icon-tabler-ice-cream-off"><path stroke="none" d="M0 0h24v24H0z" fill="none" /><path d="M12 21.5v-4.5" /><path d="M8 8v9h8v-1m0 -4v-5a4 4 0 0 0 -7.277 -2.294" /><path d="M8 10.5l1.74 -.76m2.79 -1.222l3.47 -1.518" /><path d="M8 14.5l4.488 -1.964" /><path d="M3 3l18 18" /></svg>'
         "<div data-tippy='tooltip' class='#{css_class}' style='width: 2rem; height: 2rem; color: #ef4444;' title='SVG file not found: #{escaped_filename}'><!-- SVG file not found: '#{escaped_filename}' -->#{missing_icon}</div>".html_safe
       end
 
-      # Taken from the original library
+      # Adapted from the original library, with an ensure so the Avo finder
+      # marker (which #placeholder keys off) cannot outlive the call — even
+      # when the block raises — and any pre-existing finder is restored
+      # instead of clobbered.
       # https://github.com/jamesmartin/inline_svg/blob/main/lib/inline_svg/action_view/helpers.rb#L76
       def with_asset_finder(asset_finder)
+        previous_asset_finder = Thread.current[:inline_svg_asset_finder]
         Thread.current[:inline_svg_asset_finder] = asset_finder
-        output = yield
-        Thread.current[:inline_svg_asset_finder] = nil
 
-        output
+        yield
+      ensure
+        Thread.current[:inline_svg_asset_finder] = previous_asset_finder
       end
     end
   end

data/lib/avo/icons/version.rb

@@ -1,5 +1,5 @@
 module Avo
   module Icons
-    VERSION = "0.2.0"
+    VERSION = "0.2.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: avo-icons
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Paul Bob