avatax 18.4.0 → 18.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: add871ab3afdc0119f99b02c044b02bd8225ecf932a5b6d03a05dca34b634c42
-  data.tar.gz: 81010bad716cfc21394149b55922060a35a17d1246e330c489a66bac65678c96
+  metadata.gz: 5c682c2d510ba0f739f3528ea2e37581b8c00e0150ca278f8fac37b612e88bc0
+  data.tar.gz: 45b64370a02b2f67278a300f057730b674e372da22ffbd2cf9605a13eb68f70e
 SHA512:
-  metadata.gz: 5d017ab32652887888d279f02ff25b4dff502c0c37d5d94baf43c9cd48d0a8b9473a6e094e44d418bed5202bb348cc7a214c7d39724576bee5d8849b1f7e83ee
-  data.tar.gz: 5c56513540926d23b348b4f3c3e7a861c0f23a3403f21523ff5e76d1f93bebd5f1f92d197d60801a9db1549783540ca246ab6089553bd034a0150282f798aab6
+  metadata.gz: bcf764f94c7845a671f54e271098edac1630ddd1f1defcb3f6ef4e86fbdb5b305216cdadbaa107fa754d1b9bb5d450ad5893dfd8a1885393786c1bf45d3e562b
+  data.tar.gz: 33088610c8a59d0b8b77ead54972f4073c1f29724cb523ae17c2e557c5f8458c64185711113cbcad86bc3a6ba58f7aae6e44d433c4d458050e157cfa577e364b

data/example/avatax.rb

@@ -18,11 +18,11 @@ end
 
 @client = AvaTax::Client.new(:logger => true)
 
-#puts @client.query_companies
+# puts @client.query_companies
 
 createTransactionModel = {
   type: 'SalesInvoice',
-  companyCode: 'DEFAULT',
+  companyCode: '12670',
   date: '2017-06-05',
   customerCode: 'ABC',
   "addresses": {
@@ -44,4 +44,4 @@ createTransactionModel = {
   lines: [{amount: 100}]
 }
 transaction = @client.create_transaction(createTransactionModel)
-puts transaction
+puts JSON.pretty_generate(transaction)

data/lib/avatax/configuration.rb

@@ -15,7 +15,11 @@ module AvaTax
       :password,
       :connection_options,
       :logger,
+      :custom_logger,
+      :custom_logger_options,
       :proxy,
+      :faraday_response,
+      :response_big_decimal_conversion
     ].freeze
 
     DEFAULT_APP_NAME = nil
@@ -27,7 +31,11 @@ module AvaTax
     DEFAULT_PASSWORD = nil
     DEFAULT_CONNECTION_OPTIONS = {}
     DEFAULT_LOGGER = false
+    DEFAULT_CUSTOM_LOGGER = nil
+    DEFAULT_CUSTOM_LOGGER_OPTIONS = {}
     DEFAULT_PROXY = nil
+    DEFAULT_FARADAY_RESPONSE = false
+    DEFAULT_RESPONSE_BIG_DECIMAL_CONVERSION = false
 
     attr_accessor *VALID_OPTIONS_KEYS
 
@@ -57,7 +65,11 @@ module AvaTax
       self.password = DEFAULT_PASSWORD
       self.connection_options = DEFAULT_CONNECTION_OPTIONS
       self.logger = DEFAULT_LOGGER
+      self.custom_logger = DEFAULT_CUSTOM_LOGGER
+      self.custom_logger_options = DEFAULT_CUSTOM_LOGGER_OPTIONS
       self.proxy = DEFAULT_PROXY
+      self.faraday_response = DEFAULT_FARADAY_RESPONSE
+      self.response_big_decimal_conversion = DEFAULT_RESPONSE_BIG_DECIMAL_CONVERSION
     end
 
   end

data/lib/avatax/connection.rb

@@ -4,6 +4,8 @@ module AvaTax
 
   module Connection
     private
+    AUTHORIZATION_FILTER_REGEX = /(Authorization\:\ \"Basic\ )(\w+)\=/
+    REMOVED_LABEL = '\1[REMOVED]'
 
     def connection
       client_id = "#{app_name};#{app_version};RubySdk;#{AvaTax::VERSION.dup};#{machine_name}"
@@ -19,7 +21,7 @@ module AvaTax
       }.merge(connection_options)
 
       Faraday.new(options) do |faraday|
-        if Gem::Version.new(RUBY_VERSION) > Gem::Version.new('2.2.2')
+        if Gem::Version.new(RUBY_VERSION) > Gem::Version.new('2.2.2') and response_big_decimal_conversion
           Oj.default_options = {
             bigdecimal_load: :bigdecimal
           }
@@ -30,7 +32,13 @@ module AvaTax
 
         if logger
           faraday.response :logger do |logger|
-            logger.filter(/(Authorization\:\ \"Basic\ )(\w+)\=/, '\1[REMOVED]')
+            logger.filter(AUTHORIZATION_FILTER_REGEX, REMOVED_LABEL)
+          end
+        end
+
+        if custom_logger
+          faraday.response :logger, custom_logger, custom_logger_options do |logger|
+            logger.filter(AUTHORIZATION_FILTER_REGEX, REMOVED_LABEL)
           end
         end
 

data/lib/avatax/request.rb

@@ -1,4 +1,5 @@
 require 'hashie'
+require 'faraday'
 require 'json'
 
 module AvaTax
@@ -32,9 +33,11 @@ module AvaTax
         end
       end
 
-      #::Hashie::Mash.new response.body
-      response.body
+      if faraday_response
+        response
+      else
+        response.body
+      end
     end
-
   end
 end

data/lib/avatax/version.rb

@@ -1,3 +1,3 @@
 module AvaTax
-  VERSION = '18.4.0'.freeze unless defined?(::AvaTax::VERSION)
+  VERSION = '18.4.1'.freeze unless defined?(::AvaTax::VERSION)
 end

data/spec/avatax/client/transactions_spec.rb

@@ -37,4 +37,44 @@ describe AvaTax::Client do
     end
 
   end
+
+
+  # Test the option of faraday_response, the returned response should be a type of Faraday response rather than Hashie
+  describe ".transaction_with_faraday_response" do
+    before do
+      @client.faraday_response = true
+      @base_transaction = {
+        type: 'SalesInvoice',
+        companyCode: @company_code,
+        date: '2017-06-05',
+        customerCode: 'ABC',
+        addresses: {
+          ShipFrom: {
+            line1: "123 Main Street",
+            city: "Irvine",
+            region: "CA",
+            country: "US",
+            postalCode: "92615"
+          },
+          ShipTo: {
+            line1: "100 Market Street",
+            city: "San Francisco",
+            region: "CA",
+            country: "US",
+            postalCode: "94105"
+          }
+        },
+        lines: [{amount: 100}]
+      }
+    end
+
+    it "should create a transaction and return the faraday response" do
+      faraday_trans = @client.create_transaction(@base_transaction)
+      expect(faraday_trans).to be_a Object
+      expect(faraday_trans["status"]) == 201
+      expect(faraday_trans["reason_phrase"]) == "Created"
+      expect(faraday_trans["request_headers"]).to be_a Object
+      expect(faraday_trans["body"]).to be_a Object
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: avatax
 version: !ruby/object:Gem::Version
-  version: 18.4.0
+  version: 18.4.1
 platform: ruby
 authors:
 - Marcus Vorwaller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-23 00:00:00.000000000 Z
+date: 2018-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake