automatic_record 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 40acbf709da113d0bf43a47c07d6bec14844f870
-  data.tar.gz: 978030fe910a4f7423496fe0d9a0d012a572e5b2
+  metadata.gz: 12dcf108b424c2704cf0e8850ecfa6da84076f0c
+  data.tar.gz: 72c1f43594b34489fdc22500f4969c8f66c27cde
 SHA512:
-  metadata.gz: 984c40283762c8dc41218d30cd9d1f78dff321fa7f09fc3ad9341af505240f3f0e63a3441eb5eef93a5c4882038e829d66a0a023a584c5df22eebb532d01419b
-  data.tar.gz: 0e666081ee81d57227bf47469efb50f5c0b0df5bc228fb33d9da7334313fc8b05cdc2065d1fc35ed9b7df479f9e6d790b01a62b6a59bdb3484f9864164b16be7
+  metadata.gz: ba76de7cc5a42b4d1a77cc7009970b77797fab29db4773d3f160f3ee3fc725491feea382f055a5b5b048e0be985d678fe0b89a75cefe902a2b4c3cb591aee20f
+  data.tar.gz: c0bfa1287c95b0de9223c8a4ea01b36c84d39dcf55d3840c94854b208a6e3ed7efd556d2f3573ae608909e2b6a0809d3a53c78492c9497652cbaf1690be09191

data/Rakefile

@@ -14,7 +14,7 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__)
+APP_RAKEFILE = File.expand_path('../spec/dummy/Rakefile', __FILE__)
 load 'rails/tasks/engine.rake'
 
 Bundler::GemHelper.install_tasks

data/lib/automatic_record/auto_create.rb

@@ -27,30 +27,30 @@ module AutomaticRecord
       # Pass a block to be used for object creation:
       #  auto_create :preference, ->(user){ user.create_preference(:language => 'en', :notifications => true) }
       #
-      def auto_create(assoc, default_attrs_or_block={})        
+      def auto_create(assoc, default_attrs_or_block = {})
         reflection = reflect_on_association(assoc)
         if reflection.nil?
-          raise AutomaticRecord::Error::MissingAssociation.new(assoc)
+          raise AutomaticRecord::Error::MissingAssociation, assoc
         elsif !(reflection.has_one? || reflection.belongs_to?)
-          raise AutomaticRecord::Error::InvalidAssociation.new(assoc)
+          raise AutomaticRecord::Error::InvalidAssociation, assoc
         else
-          define_method(assoc) do |force_reload=false|
-            return get_or_auto_create_assoc(assoc, force_reload, default_attrs_or_block)
+          define_method(assoc) do |_force_reload = nil| # force_reload is deprecated by rails
+            return get_or_auto_create_assoc(assoc, default_attrs_or_block)
           end
         end
       end
     end
 
-private
+    private
 
-    def get_or_auto_create_assoc(assoc, force_reload=false, default_attrs_or_block={}) # :nodoc:
-      result = method(assoc).super_method.call(force_reload)
+    def get_or_auto_create_assoc(assoc, default_attrs_or_block = {}) # :nodoc:
+      result = method(assoc).super_method.call
       if result.blank?
-        if default_attrs_or_block.is_a?(Proc)
-          result = default_attrs_or_block.call(self)
-        else
-          result = send("create_#{assoc}", default_attrs_or_block)
-        end
+        result = if default_attrs_or_block.is_a?(Proc)
+                   default_attrs_or_block.call(self)
+                 else
+                   send("create_#{assoc}", default_attrs_or_block)
+                 end
       end
       return result
     end

data/lib/automatic_record/engine.rb

@@ -5,7 +5,7 @@ module AutomaticRecord
 
     config.generators do |g|
       g.test_framework :rspec
-      g.fixture_replacement :factory_girl, :dir => 'spec/factories'
+      g.fixture_replacement :factory_girl, dir: 'spec/factories'
     end
 
     initializer 'automatic_record' do

data/lib/automatic_record/version.rb

@@ -1,3 +1,3 @@
 module AutomaticRecord
-  VERSION = "0.0.2"
+  VERSION = '0.0.3'.freeze
 end

data/spec/dummy/app/models/preference.rb

@@ -1,13 +1,13 @@
 class Preference < ActiveRecord::Base
 
   belongs_to :user
-  belongs_to :user_with_default_attrs, :class_name => 'User', :foreign_key => 'user_id'
-  belongs_to :user_with_block, :class_name => 'User', :foreign_key => 'user_id'
+  belongs_to :user_with_default_attrs, class_name: 'User', foreign_key: 'user_id'
+  belongs_to :user_with_block, class_name: 'User', foreign_key: 'user_id'
 
   auto_create :user
-  auto_create :user_with_default_attrs, {:username => 'defaulted'}
-  auto_create :user_with_block, ->(instance){
-    instance.create_user(:username => 'blocked')
+  auto_create :user_with_default_attrs, username: 'defaulted'
+  auto_create :user_with_block, ->(instance) {
+    instance.create_user(username: 'blocked')
   }
 
 end

data/spec/dummy/app/models/user.rb

@@ -1,13 +1,13 @@
 class User < ActiveRecord::Base
 
   has_one :preference
-  has_one :preference_with_default_attrs, :class_name => 'Preference'
-  has_one :preference_with_block, :class_name => 'Preference'
+  has_one :preference_with_default_attrs, class_name: 'Preference'
+  has_one :preference_with_block, class_name: 'Preference'
 
   auto_create :preference
-  auto_create :preference_with_default_attrs, {:language => 'en', :notifications => true}
-  auto_create :preference_with_block, ->(instance){
-    instance.create_preference(:language => 'fr', :notifications => true)
+  auto_create :preference_with_default_attrs, language: 'en', notifications: true
+  auto_create :preference_with_block, ->(instance) {
+    instance.create_preference(language: 'fr', notifications: true)
   }
 
 end

data/spec/dummy/bin/setup

@@ -2,15 +2,15 @@
 require 'pathname'
 
 # path to your application root.
-APP_ROOT = Pathname.new File.expand_path('../../',  __FILE__)
+APP_ROOT = Pathname.new File.expand_path('../../', __FILE__)
 
 Dir.chdir APP_ROOT do
   # This script is a starting point to setup your application.
   # Add necessary setup steps to this file:
 
-  puts "== Installing dependencies =="
-  system "gem install bundler --conservative"
-  system "bundle check || bundle install"
+  puts '== Installing dependencies =='
+  system 'gem install bundler --conservative'
+  system 'bundle check || bundle install'
 
   # puts "\n== Copying sample files =="
   # unless File.exist?("config/database.yml")
@@ -18,12 +18,12 @@ Dir.chdir APP_ROOT do
   # end
 
   puts "\n== Preparing database =="
-  system "bin/rake db:setup"
+  system 'bin/rake db:setup'
 
   puts "\n== Removing old logs and tempfiles =="
-  system "rm -f log/*"
-  system "rm -rf tmp/cache"
+  system 'rm -f log/*'
+  system 'rm -rf tmp/cache'
 
   puts "\n== Restarting application server =="
-  system "touch tmp/restart.txt"
+  system 'touch tmp/restart.txt'
 end

data/spec/dummy/config/application.rb

@@ -3,7 +3,7 @@ require File.expand_path('../boot', __FILE__)
 require 'rails/all'
 
 Bundler.require(*Rails.groups)
-require "automatic_record"
+require 'automatic_record'
 
 module Dummy
   class Application < Rails::Application
@@ -18,9 +18,5 @@ module Dummy
     # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
     # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
     # config.i18n.default_locale = :de
-
-    # Do not swallow errors in after_commit/after_rollback callbacks.
-    config.active_record.raise_in_transactional_callbacks = true
   end
 end
-

data/spec/dummy/config/environments/test.rb

@@ -13,8 +13,8 @@ Rails.application.configure do
   config.eager_load = false
 
   # Configure static file server for tests with Cache-Control for performance.
-  config.serve_static_files   = true
-  config.static_cache_control = 'public, max-age=3600'
+  config.public_file_server.enabled = true
+  config.public_file_server.headers = { 'Cache-Control' => 'public, max-age=3600' }
 
   # Show full error reports and disable caching.
   config.consider_all_requests_local       = true

data/spec/dummy/db/schema.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 # This file is auto-generated from the current state of the database. Instead
 # of editing this file, please use the migrations feature of Active Record to
 # incrementally modify your database, and then regenerate this schema definition.
@@ -13,18 +12,18 @@
 
 ActiveRecord::Schema.define(version: 20150416151003) do
 
-  create_table "preferences", force: :cascade do |t|
-    t.integer  "user_id",       limit: 4
-    t.string   "language",      limit: 255
-    t.boolean  "notifications", limit: 1
-    t.datetime "created_at",                null: false
-    t.datetime "updated_at",                null: false
+  create_table "preferences", force: :cascade, options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" do |t|
+    t.integer  "user_id"
+    t.string   "language"
+    t.boolean  "notifications"
+    t.datetime "created_at",    null: false
+    t.datetime "updated_at",    null: false
   end
 
-  create_table "users", force: :cascade do |t|
-    t.string   "username",   limit: 255
-    t.datetime "created_at",             null: false
-    t.datetime "updated_at",             null: false
+  create_table "users", force: :cascade, options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" do |t|
+    t.string   "username"
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
   end
 
 end

data/spec/models/preference_spec.rb

@@ -5,14 +5,14 @@ RSpec.describe Preference, type: :model do
   describe '#belongs_to' do
     it 'should create the user record' do
       preference = FactoryGirl.create(:preference)
-      expect{
+      expect do
         preference.user
-      }.to change(User, :count).by(1)
+      end.to change(User, :count).by(1)
     end
 
     it 'should get the pre-existing record' do
       user = FactoryGirl.create(:user)
-      preference = FactoryGirl.create(:preference, :user_id => user.id)
+      preference = FactoryGirl.create(:preference, user_id: user.id)
       expect(preference.user).to eq(user)
     end
 
@@ -27,17 +27,6 @@ RSpec.describe Preference, type: :model do
       user = preference.user_with_block
       expect(user.username).to eq('blocked')
     end
-
-    it 'should reload the record from the database' do
-      preference = FactoryGirl.create(:preference)
-      user = preference.user
-
-      user_alt = User.find_by(:id => user.id)
-      user_alt.update_attribute(:username, 'reloaded')
-
-      expect(preference.user.username).to_not eq('reloaded')
-      expect(preference.user(true).username).to eq('reloaded')
-    end
   end
 
 end

data/spec/models/user_spec.rb

@@ -5,15 +5,15 @@ RSpec.describe User, type: :model do
   describe '#has_one' do
     it 'should create the preference record' do
       user = FactoryGirl.create(:user)
-      expect(Preference.find_by(:user_id => user.id)).to eq(nil)
-      expect{
+      expect(Preference.find_by(user_id: user.id)).to eq(nil)
+      expect do
         user.preference
-      }.to change(Preference, :count).by(1)
+      end.to change(Preference, :count).by(1)
     end
 
     it 'should get the pre-existing record' do
       user = FactoryGirl.create(:user)
-      preference = FactoryGirl.create(:preference, :user_id => user.id)
+      preference = FactoryGirl.create(:preference, user_id: user.id)
       expect(user.preference).to eq(preference)
     end
 
@@ -30,33 +30,22 @@ RSpec.describe User, type: :model do
       expect(preference.language).to eq('fr')
       expect(preference.notifications).to eq(true)
     end
-
-    it 'should reload the record from the database' do
-      user = FactoryGirl.create(:user)
-      preference = user.preference
-
-      preference_alt = Preference.find_by(:id => preference.id)
-      preference_alt.update_attribute(:language, 'ca')
-
-      expect(user.preference.language).to_not eq('ca')
-      expect(user.preference(true).language).to eq('ca')
-    end
   end
 
   describe 'errors' do
     it 'should raise an error if the association does not exist' do
-      expect{
+      expect do
         User.class_eval('auto_create :does_not_exist')
-      }.to raise_error(AutomaticRecord::Error::MissingAssociation)
+      end.to raise_error(AutomaticRecord::Error::MissingAssociation)
     end
 
     it 'should raise an error if the association is not :belongs_to or :has_one' do
-      expect{
+      expect do
         User.class_eval do
           has_many :widgets
           auto_create :widgets
         end
-      }.to raise_error(AutomaticRecord::Error::InvalidAssociation)
+      end.to raise_error(AutomaticRecord::Error::InvalidAssociation)
     end
   end
 

data/spec/rails_helper.rb

@@ -1,12 +1,12 @@
 # This file is copied to spec/ when you run 'rails generate rspec:install'
-ENV["RAILS_ENV"] ||= 'test'
+ENV['RAILS_ENV'] ||= 'test'
 require 'spec_helper'
-require File.expand_path("../dummy/config/environment.rb",  __FILE__)
+require File.expand_path('../dummy/config/environment.rb', __FILE__)
 require 'rspec/rails'
 
 # Add additional requires below this line. Rails is not loaded until this point!
 require 'database_cleaner'
-require "factory_girl_rails"
+require 'factory_girl_rails'
 require 'simplecov'
 
 SimpleCov.start 'rails'

data/spec/spec_helper.rb

@@ -38,48 +38,46 @@ RSpec.configure do |config|
     mocks.verify_partial_doubles = true
   end
 
-# The settings below are suggested to provide a good initial experience
-# with RSpec, but feel free to customize to your heart's content.
-=begin
-  # These two settings work together to allow you to limit a spec run
-  # to individual examples or groups you care about by tagging them with
-  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-  # get run.
-  config.filter_run :focus
-  config.run_all_when_everything_filtered = true
-
-  # Limits the available syntax to the non-monkey patched syntax that is recommended.
-  # For more details, see:
-  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
-  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
-  config.disable_monkey_patching!
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-=end
+  # The settings below are suggested to provide a good initial experience
+  # with RSpec, but feel free to customize to your heart's content.
+  #   # These two settings work together to allow you to limit a spec run
+  #   # to individual examples or groups you care about by tagging them with
+  #   # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  #   # get run.
+  #   config.filter_run :focus
+  #   config.run_all_when_everything_filtered = true
+  #
+  #   # Limits the available syntax to the non-monkey patched syntax that is recommended.
+  #   # For more details, see:
+  #   #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+  #   #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
+  #   config.disable_monkey_patching!
+  #
+  #   # Many RSpec users commonly either run the entire suite or an individual
+  #   # file, and it's useful to allow more verbose output when running an
+  #   # individual spec file.
+  #   if config.files_to_run.one?
+  #     # Use the documentation formatter for detailed output,
+  #     # unless a formatter has already been configured
+  #     # (e.g. via a command-line flag).
+  #     config.default_formatter = 'doc'
+  #   end
+  #
+  #   # Print the 10 slowest examples and example groups at the
+  #   # end of the spec run, to help surface which specs are running
+  #   # particularly slow.
+  #   config.profile_examples = 10
+  #
+  #   # Run specs in random order to surface order dependencies. If you find an
+  #   # order dependency and want to debug it, you can fix the order by providing
+  #   # the seed, which is printed after each run.
+  #   #     --seed 1234
+  #   config.order = :random
+  #
+  #   # Seed global randomization in this process using the `--seed` CLI option.
+  #   # Setting this allows you to use `--seed` to deterministically reproduce
+  #   # test failures related to randomization by passing the same `--seed` value
+  #   # as the one that triggered the failure.
+  #   Kernel.srand config.seed
 end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: automatic_record
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Greg Woods
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-16 00:00:00.000000000 Z
+date: 2017-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.1
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mysql2
   requirement: !ruby/object:Gem::Requirement
@@ -42,58 +42,72 @@ dependencies:
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: factory_girl_rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.4.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.4.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: '0'
 description: Automatically create a has_one or belongs_to association the first time
   it is accessed. Also supports optional default attributes or block usage to customize
   the record creation.
@@ -178,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Automatically create has_one and belongs_to associations the first time they