autocomplete-off 0.0.1 → 0.1.0

data/Gemfile

@@ -1,11 +1,11 @@
 source "http://rubygems.org"
-# Add dependencies required to use your gem here.
-# Example:
-#   gem "activesupport", ">= 2.3.5"
+gem "actionpack", ">= 3.0.0"
+gem "activesupport", ">= 3.0.0"
 
-# Add dependencies to develop your gem here.
-# Include everything needed to run rake, tests, features, etc.
 group :development do
   gem "bundler", "~> 1.0.0"
   gem "jeweler", "~> 1.6.2"
+  gem 'simplecov', '>= 0.3.8', :require => false
+  gem "rspec", "~> 2.6.0"
+  gem "yard", "~> 0.6.0"
 end

data/Gemfile.lock

@@ -1,16 +1,60 @@
 GEM
   remote: http://rubygems.org/
   specs:
+    abstract (1.0.0)
+    actionpack (3.0.8)
+      activemodel (= 3.0.8)
+      activesupport (= 3.0.8)
+      builder (~> 2.1.2)
+      erubis (~> 2.6.6)
+      i18n (~> 0.5.0)
+      rack (~> 1.2.1)
+      rack-mount (~> 0.6.14)
+      rack-test (~> 0.5.7)
+      tzinfo (~> 0.3.23)
+    activemodel (3.0.8)
+      activesupport (= 3.0.8)
+      builder (~> 2.1.2)
+      i18n (~> 0.5.0)
+    activesupport (3.0.8)
+    builder (2.1.2)
+    diff-lcs (1.1.2)
+    erubis (2.6.6)
+      abstract (>= 1.0.0)
     git (1.2.5)
+    i18n (0.5.0)
     jeweler (1.6.2)
       bundler (~> 1.0)
       git (>= 1.2.5)
       rake
-    rake (0.9.1)
+    rack (1.2.3)
+    rack-mount (0.6.14)
+      rack (>= 1.0.0)
+    rack-test (0.5.7)
+      rack (>= 1.0)
+    rake (0.9.2)
+    rspec (2.6.0)
+      rspec-core (~> 2.6.0)
+      rspec-expectations (~> 2.6.0)
+      rspec-mocks (~> 2.6.0)
+    rspec-core (2.6.4)
+    rspec-expectations (2.6.0)
+      diff-lcs (~> 1.1.2)
+    rspec-mocks (2.6.0)
+    simplecov (0.4.2)
+      simplecov-html (~> 0.4.4)
+    simplecov-html (0.4.5)
+    tzinfo (0.3.27)
+    yard (0.6.8)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  actionpack (>= 3.0.0)
+  activesupport (>= 3.0.0)
   bundler (~> 1.0.0)
   jeweler (~> 1.6.2)
+  rspec (~> 2.6.0)
+  simplecov (>= 0.3.8)
+  yard (~> 0.6.0)

data/README.rdoc

@@ -21,7 +21,8 @@ Or if you want to use it as plugin
 It works right out of the box. Just install, restart your server and see it working.
 
 == Features
-TODO
+
+* Handle input tag with type text or password or email and add default autocomplete=off for default
 
 == Maintainers
 

data/Rakefile

@@ -25,21 +25,13 @@ Jeweler::Tasks.new do |gem|
 end
 Jeweler::RubygemsDotOrgTasks.new
 
-require 'rake/testtask'
-Rake::TestTask.new(:test) do |test|
-  test.libs << 'lib' << 'test'
-  test.pattern = 'test/**/test_*.rb'
-  test.verbose = true
+require 'rspec/core'
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec) do |spec|
+  spec.pattern = FileList['spec/**/*_spec.rb']
 end
 
-task :default => :test
+task :default => :spec
 
-require 'rake/rdoctask'
-Rake::RDocTask.new do |rdoc|
-  version = File.exist?('VERSION') ? File.read('VERSION') : ""
-
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title = "autocomplete-off #{version}"
-  rdoc.rdoc_files.include('README*')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
+require 'yard'
+YARD::Rake::YardocTask.new

data/VERSION

@@ -1 +1 @@
-0.0.1
+0.1.0

data/autocomplete-off.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{autocomplete-off}
-  s.version = "0.0.1"
+  s.version = "0.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Alexander Dreher"]
-  s.date = %q{2011-06-07}
+  s.date = %q{2011-06-08}
   s.description = %q{Adds `autocomplete="off"` html attribute to FormHelper generated input tags by default.}
   s.email = %q{alexdreher@lxmedia.net}
   s.extra_rdoc_files = [
@@ -27,8 +27,8 @@ Gem::Specification.new do |s|
     "autocomplete-off.gemspec",
     "init.rb",
     "lib/autocomplete-off.rb",
-    "test/helper.rb",
-    "test/test_autocomplete-off.rb"
+    "spec/autocomplete-off_spec.rb",
+    "spec/spec_helper.rb"
   ]
   s.homepage = %q{http://github.com/phatworx/autocomplete-off}
   s.licenses = ["MIT"]
@@ -40,15 +40,30 @@ Gem::Specification.new do |s|
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
+      s.add_runtime_dependency(%q<actionpack>, [">= 3.0.0"])
+      s.add_runtime_dependency(%q<activesupport>, [">= 3.0.0"])
       s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.6.2"])
+      s.add_development_dependency(%q<simplecov>, [">= 0.3.8"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.6.0"])
+      s.add_development_dependency(%q<yard>, ["~> 0.6.0"])
     else
+      s.add_dependency(%q<actionpack>, [">= 3.0.0"])
+      s.add_dependency(%q<activesupport>, [">= 3.0.0"])
       s.add_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_dependency(%q<jeweler>, ["~> 1.6.2"])
+      s.add_dependency(%q<simplecov>, [">= 0.3.8"])
+      s.add_dependency(%q<rspec>, ["~> 2.6.0"])
+      s.add_dependency(%q<yard>, ["~> 0.6.0"])
     end
   else
+    s.add_dependency(%q<actionpack>, [">= 3.0.0"])
+    s.add_dependency(%q<activesupport>, [">= 3.0.0"])
     s.add_dependency(%q<bundler>, ["~> 1.0.0"])
     s.add_dependency(%q<jeweler>, ["~> 1.6.2"])
+    s.add_dependency(%q<simplecov>, [">= 0.3.8"])
+    s.add_dependency(%q<rspec>, ["~> 2.6.0"])
+    s.add_dependency(%q<yard>, ["~> 0.6.0"])
   end
 end
 

data/lib/autocomplete-off.rb

@@ -1,13 +1,22 @@
+require 'erb'
+require 'active_support/concern'
+require 'action_view/helpers/capture_helper'
+require 'action_view/helpers/tag_helper'
+
 module ActionView
   module Helpers
     module TagHelper
+
+      # rename original method for extending     
+      alias_method :tag_without_autocomplete_off, :tag
+      
       # This re-opens the tag method which is used by every form builder helper
       # to disable browsers autocomplete by default.
       #
       # Fields can use the browsers autocomplete by explicitly setting ":autocomplete => 'on'"
       def tag(name, options = nil, open = false, escape = true)
-        options['autocomplete'] ||= 'off' if name == 'input'
-        "<#{name}#{tag_options(options, escape) if options}#{open ? ">" : " />"}".html_safe
+        options['autocomplete'] ||= 'off' if options.is_a?(Hash) and name.to_s == 'input' and ['password', 'text', 'email'].include?(options['type'].to_s)
+        tag_without_autocomplete_off(name, options, open, escape)
       end
     end
   end

data/spec/autocomplete-off_spec.rb

@@ -0,0 +1,50 @@
+# encoding: utf-8
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+
+describe ActionView::Helpers::TagHelper do
+  describe "#tag" do
+    include ActionView::Helpers::TagHelper
+
+    it "should have autocomplete off on input type text" do
+      tag('input', { 'type' => 'text' }).should include('autocomplete="off"')
+    end
+    
+    it "should have autocomplete off on input type password" do
+      tag('input', { 'type' => 'password' }).should include('autocomplete="off"')
+    end
+    
+    it "should have autocomplete off on input type email" do
+      tag('input', { 'type' => 'email' }).should include('autocomplete="off"')
+    end
+    
+    it "should not have autocomplete off on a" do
+      tag('a').should_not include('autocomplete="off"')
+    end
+
+    it "should not have autocomplete off on a with href attribute" do
+      tag('a', { 'href' => 'about:blank' }).should_not include('autocomplete="off"')
+    end
+    
+    it "should not have autocomplete off on input type radio" do
+      tag('input', { 'type' => 'radio' }).should_not include('autocomplete="off"')
+    end
+
+    it "should not have autocomplete off on input type text if manual disabled" do
+      tag('input', { 'type' => 'text', 'autocomplete' => 'on' }).should_not include('autocomplete="off"')
+      tag('input', { 'type' => 'text', 'autocomplete' => 'on' }).should include('autocomplete="on"')
+    end
+
+    it "should not have autocomplete off on input type password if manual disabled" do
+      tag('input', { 'type' => 'password', 'autocomplete' => 'on' }).should_not include('autocomplete="off"')
+      tag('input', { 'type' => 'password', 'autocomplete' => 'on' }).should include('autocomplete="on"')
+    end
+
+    it "should not have autocomplete off on input type email if manual disabled" do
+      tag('input', { 'type' => 'email', 'autocomplete' => 'on' }).should_not include('autocomplete="off"')
+      tag('input', { 'type' => 'email', 'autocomplete' => 'on' }).should include('autocomplete="on"')
+    end
+    
+  end
+
+end
+

data/spec/spec_helper.rb

@@ -0,0 +1,19 @@
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+
+require 'erb'
+require 'active_support/concern'
+require 'action_view/helpers/capture_helper'
+require 'action_view/helpers/tag_helper'
+require 'rspec'
+require 'simplecov'
+SimpleCov.start
+require 'autocomplete-off'
+
+# Requires supporting files with custom matchers and macros, etc,
+# in ./support/ and its subdirectories.
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+
+RSpec.configure do |config|
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: autocomplete-off
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,12 +9,34 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-06-07 00:00:00.000000000 +02:00
+date: 2011-06-08 00:00:00.000000000 +02:00
 default_executable: 
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: actionpack
+  requirement: &24047340 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: *24047340
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: &24046640 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: *24046640
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &20122960 !ruby/object:Gem::Requirement
+  requirement: &24045780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -22,10 +44,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *20122960
+  version_requirements: *24045780
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &20122480 !ruby/object:Gem::Requirement
+  requirement: &24044860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -33,7 +55,40 @@ dependencies:
         version: 1.6.2
   type: :development
   prerelease: false
-  version_requirements: *20122480
+  version_requirements: *24044860
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: &24006420 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.3.8
+  type: :development
+  prerelease: false
+  version_requirements: *24006420
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: &24004420 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.6.0
+  type: :development
+  prerelease: false
+  version_requirements: *24004420
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: &24003620 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.6.0
+  type: :development
+  prerelease: false
+  version_requirements: *24003620
 description: Adds `autocomplete="off"` html attribute to FormHelper generated input
   tags by default.
 email: alexdreher@lxmedia.net
@@ -53,8 +108,8 @@ files:
 - autocomplete-off.gemspec
 - init.rb
 - lib/autocomplete-off.rb
-- test/helper.rb
-- test/test_autocomplete-off.rb
+- spec/autocomplete-off_spec.rb
+- spec/spec_helper.rb
 has_rdoc: true
 homepage: http://github.com/phatworx/autocomplete-off
 licenses:
@@ -71,7 +126,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3088871125341252101
+      hash: 4285089215067781878
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:

data/test/helper.rb

@@ -1,17 +0,0 @@
-require 'rubygems'
-require 'bundler'
-begin
-  Bundler.setup(:default, :development)
-rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts "Run `bundle install` to install missing gems"
-  exit e.status_code
-end
-require 'test/unit'
-
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-require 'autocomplete-off'
-
-class Test::Unit::TestCase
-end

data/test/test_autocomplete-off.rb

@@ -1,5 +0,0 @@
-require 'helper'
-
-class TestAutocompleteOff < Test::Unit::TestCase
-  
-end