auto_strip_attributes 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4bd8eadb5f2deb62f0fb5b0b0fbe62296865465c
-  data.tar.gz: 72fd859cbcc3cb6fae5d5b8fd2c58e1bb91d98fc
+  metadata.gz: 624c9f6db12d0350cb1a4185eafa37c992b310f1
+  data.tar.gz: b6ef7f53808cd252c8bdea23f83935fff4533751
 SHA512:
-  metadata.gz: 5cb7ed37fa4a3f86e20c47b00c7dad36999a994850bc58d73c627c789520486a2cbf10f24607c580053ae05032959bf1e4f556f672d33937820bdf1f28aa6e79
-  data.tar.gz: b1ebe7f5bd4f4265573b549e180ed91064c86c294e4a73ef6a7b44ef8b0cc50c0c636173a19fa96466d4f277ba24842460e50c5d44050e2741e8f575139beda0
+  metadata.gz: 6cc0bf5cdced2dba776f05e6ca9290e19f3a3e8df4822595c5163e62fa6f8840231907125b7d3f00d4e5be51e0835d2aa1baa63bb9db29964e27e8df83a7c70b
+  data.tar.gz: 8ad8b23e63c8451fd6c14a95f44ec26273c7a73f52984a2e1f3ef6d3d42568e94aa3ddf50bb7b872f011576b6745ac664ff6a947dd3d26f54ed4d097a4bad9a1

data/.travis.yml

@@ -2,15 +2,11 @@ language: ruby
 sudo: false
 cache: bundler
 rvm:
-  - 2.1.9
   - 2.2.5
   - 2.3.1
+  - 2.4.0
 env:
-  - "RAILS_VERSION=4.0"
-  - "RAILS_VERSION=4.1"
   - "RAILS_VERSION=4.2"
   - "RAILS_VERSION=5.0"
-matrix:
-  exclude:
-    - rvm: 2.1.9
-      env: "RAILS_VERSION=5.0"
+  - "RAILS_VERSION=5.1"
+

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Master]
 
+## [2.2] - 2016-07-28
+
+  - Added 'virtual'-option (thnks to [@nasa42](https://github.com/holli/auto_strip_attributes/pull/23))
+
 ## [2.1] - 2016-07-28
 
   - Drop support for ruby 1.9.3

data/README.md

@@ -8,13 +8,15 @@ It works by adding a before_validation hook to the record. No other methods are
 Gem has option to set empty strings to nil or to remove extra spaces inside the string.
 
 [<img src="https://secure.travis-ci.org/holli/auto_strip_attributes.png" />](http://travis-ci.org/holli/auto_strip_attributes)
+[![Gem](https://img.shields.io/gem/dt/auto_strip_attributes.svg?maxAge=2592000)](https://rubygems.org/gems/auto_strip_attributes/)
+[![Gem](https://img.shields.io/gem/v/auto_strip_attributes.svg?maxAge=2592000)](https://rubygems.org/gems/auto_strip_attributes/)
 
 ## Howto / examples
 
 Include gem in your Gemfile:
 
 ```ruby
-gem "auto_strip_attributes", "~> 2.0"
+gem "auto_strip_attributes", "~> 2.2"
 ```
 
 ```ruby
@@ -28,19 +30,23 @@ class User < ActiveRecord::Base
 
   # Won't set to null even if string is blank. "   " => ""
   auto_strip_attributes :email, :nullify => false
+
+  # Use with attributes that are not mapped to a column
+  auto_strip_attributes :password, virtual: true
 end
 ```
 
-# Filters
-### Default filters
+# Options
+### Default options
 
-By default the following filters are defined (listed in the order of processing):
+By default the following options are defined (listed in the order of processing):
 
-- :convert_non_breaking_spaces (disabled by default) - converts non-breaking spaces to normal spaces (Unicode U+00A0)
 - :strip (enabled by default) - removes whitespaces from the beginning and the end of string
 - :nullify (enabled by default) - replaces empty strings with nil
 - :squish (disabled by default) - replaces extra whitespaces (including tabs) with one space
 - :delete_whitespaces (disabled by default) - delete all whitespaces (including tabs)
+- :convert_non_breaking_spaces (disabled by default) - converts non-breaking spaces to normal spaces (Unicode U+00A0)
+- :virtual (disabled by default) - By default `auto_strip_attributes` doesn't work with non-persistent attributes (e.g., attributes that are created with `attr_accessor`). This is to avoid calling their custom getter/setter methods. Use this option with non-persistent attributes.
 
 ### Custom Filters
 
@@ -96,7 +102,7 @@ AutoStripAttributes::Config.setup accepts following options
 
 # Requirements
 
-Gem has been tested with newest Ruby & Rails combination and it probably works also with older versions. See test matrix at https://github.com/holli/auto_strip_attributes/blob/master/.travis.yml 
+Gem has been tested with newest Ruby & Rails combination and it probably works also with older versions. See test matrix at https://github.com/holli/auto_strip_attributes/blob/master/.travis.yml
 
 [<img src="https://secure.travis-ci.org/holli/auto_strip_attributes.png" />](http://travis-ci.org/holli/auto_strip_attributes)
 
@@ -128,4 +134,3 @@ different approaches. See discussion in previous chapter.
 # Licence
 
 Released under the MIT license (http://www.opensource.org/licenses/mit-license.php)
-

data/auto_strip_attributes.gemspec

@@ -26,5 +26,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency "minitest", ">= 2.8.1"
   s.add_development_dependency "mocha", "~> 0.14"
   s.add_development_dependency 'rake'
+  # s.add_development_dependency 'pry'
 
 end

data/lib/auto_strip_attributes.rb

@@ -7,14 +7,26 @@ module AutoStripAttributes
       options = options.merge(attributes.pop)
     end
 
+    # option `:virtual` is needed because we want to guarantee that
+    # getter/setter methods for an attribute will _not_ be invoked by default
+    virtual = options.delete(:virtual)
+
     attributes.each do |attribute|
       before_validation do |record|
         #debugger
-        value = record[attribute]
+        if virtual
+          value = record.public_send(attribute)
+        else
+          value = record[attribute]
+        end
         AutoStripAttributes::Config.filters_order.each do |filter_name|
           next unless options[filter_name]
           value = AutoStripAttributes::Config.filters[filter_name].call value
-          record[attribute] = value
+          if virtual
+            record.public_send("#{attribute}=", value)
+          else
+            record[attribute] = value
+          end
         end
       end
     end

data/lib/auto_strip_attributes/version.rb

@@ -1,3 +1,3 @@
 module AutoStripAttributes
-  VERSION = "2.1.0"
+  VERSION = "2.2.0"
 end

data/test/auto_strip_attributes_test.rb

@@ -9,10 +9,9 @@ require "auto_strip_attributes"
 require 'mocha/setup'
 
 # if you need debug, add relevant line to auto_strip_attributes.gemspec
-# s.add_development_dependency 'ruby-debug'
-# s.add_development_dependency 'ruby-debug19'
-# and uncomment following line
-# require 'ruby-debug'
+# s.add_development_dependency 'pry'
+# and uncomment following line, and then write binding.pry somewhere
+# require 'pry'
 
 
 class MockRecordParent
@@ -27,7 +26,8 @@ class MockRecordParent
   end
 
   def [](key)
-    instance_variable_get(:"@#{key}")
+    k = :"@#{key}"
+    instance_variable_defined?(k) ? instance_variable_get(k) : nil
   end
 
 end
@@ -230,6 +230,31 @@ describe AutoStripAttributes do
     end
   end
 
+  describe "Virtual attributes" do
+    class MockVirtualAttribute < MockRecordParent
+      undef :[]=
+      undef :[]
+
+      auto_strip_attributes :foo, virtual: true
+
+      def foo
+        @bar
+      end
+
+      def foo=(val)
+        @bar = val
+      end
+    end
+
+    it "should handle everything ok" do
+      @record = MockVirtualAttribute.new
+      @record.foo = "  foo  "
+      @record.foo.must_equal "  foo  "
+      @record.valid?
+      @record.foo.must_equal "foo"
+    end
+  end
+
   describe "Configuration tests" do
     it "should have defined AutoStripAttributes::Config" do
       assert AutoStripAttributes.const_defined?(:Config)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: auto_strip_attributes
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Olli Huotari
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-28 00:00:00.000000000 Z
+date: 2017-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -108,7 +108,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: auto_strip_attributes
-rubygems_version: 2.5.1
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: Removes unnecessary whitespaces in attributes. Extension to ActiveRecord