authy 2.7.1 → 2.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bb9d7de576c3afc925818fc8b89d5e67aac65fa9
-  data.tar.gz: 6a5313143bd01165c1b7ab33553b77a7ade3867b
+  metadata.gz: 8113421bc21b13bc9ad8d67d40f0396448d3950f
+  data.tar.gz: e6d280e4e5e44a8a507531961d07c5e47199a122
 SHA512:
-  metadata.gz: 7a16398319ebcc4c88f2c1622a7d12c45b0528ccc1bbfe8570894dcc34340e77288d74cb94631d1293a9920dee3b2980015503364b4359b341f8db086739e707
-  data.tar.gz: aadec96c432b3454d8a325c5476f3c87d8799611fa9416e84306a7cf634bda789e44c4590b1e023fdecece709c4ca70db81c740e9d379e7829341d9025b889bc
+  metadata.gz: 94643682f6f44bbbaab85beb4efc63b0a2c49c383571fc904b078d1e46f5c3e6e1cc96278366089a1a9bc3c7d049da1b81800f299ac6dd4f8b21e93cc3d53026
+  data.tar.gz: 4cd4391e4747294e2d66ea6aa93e55c27f2102f13d0ebbdef4c6240ecd4e20d922ec2bd7b139ce32eb8a99ff8864bfdde89fd98350aeeb4a8de7fb482c6ee3ef

data/.travis.yml

@@ -1,4 +1,4 @@
 language: ruby
 rvm:
-  - 2.3.0
-  - 2.2.3
+  - 2.3.1
+  - 2.2.4

data/Gemfile

@@ -5,7 +5,7 @@ gem 'httpclient', ">= 2.5.3.3"
 group :development do
   gem "rspec"
   gem 'pry'
-  gem "yard"
+  gem "yard", "~> 0.9.11"
   gem "rdoc"
   gem "jeweler"
   gem "simplecov", ">= 0"

data/Gemfile.lock

@@ -2,101 +2,104 @@ GEM
   remote: https://rubygems.org/
   specs:
     addressable (2.4.0)
-    ast (2.2.0)
+    ast (2.3.0)
     axiom-types (0.1.1)
       descendants_tracker (~> 0.0.4)
       ice_nine (~> 0.11.0)
       thread_safe (~> 0.3, >= 0.3.1)
-    builder (3.2.2)
-    codeclimate-engine-rb (0.3.1)
+    builder (3.2.3)
+    codeclimate-engine-rb (0.4.1)
       virtus (~> 1.0)
-    coderay (1.1.1)
+    coderay (1.1.2)
     coercible (1.0.0)
       descendants_tracker (~> 0.0.1)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
-    diff-lcs (1.2.5)
+    diff-lcs (1.3)
     docile (1.1.5)
     equalizer (0.0.11)
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)
     git (1.3.0)
-    github_api (0.13.1)
+    github_api (0.16.0)
       addressable (~> 2.4.0)
       descendants_tracker (~> 0.0.4)
       faraday (~> 0.8, < 0.10)
       hashie (>= 3.4)
-      multi_json (>= 1.7.5, < 2.0)
-      oauth2
-    hashie (3.4.3)
-    highline (1.7.8)
-    httpclient (2.7.1)
+      mime-types (>= 1.16, < 3.0)
+      oauth2 (~> 1.0)
+    hashie (3.5.7)
+    highline (1.7.10)
+    httpclient (2.8.3)
     ice_nine (0.11.2)
-    jeweler (2.0.1)
+    jeweler (2.3.7)
       builder
-      bundler (>= 1.0)
+      bundler (>= 1)
       git (>= 1.2.5)
-      github_api
+      github_api (~> 0.16.0)
       highline (>= 1.6.15)
       nokogiri (>= 1.5.10)
+      psych (~> 2.2)
       rake
       rdoc
-    json (1.8.3)
-    jwt (1.5.1)
-    method_source (0.8.2)
-    mini_portile2 (2.0.0)
-    multi_json (1.11.2)
-    multi_xml (0.5.5)
+      semver2
+    json (2.1.0)
+    jwt (1.5.6)
+    method_source (0.9.0)
+    mime-types (2.99.3)
+    mini_portile2 (2.3.0)
+    multi_json (1.12.2)
+    multi_xml (0.6.0)
     multipart-post (2.0.0)
-    nokogiri (1.6.7.2)
-      mini_portile2 (~> 2.0.0.rc2)
-    oauth2 (1.1.0)
-      faraday (>= 0.8, < 0.10)
-      jwt (~> 1.0, < 1.5.2)
+    nokogiri (1.8.1)
+      mini_portile2 (~> 2.3.0)
+    oauth2 (1.4.0)
+      faraday (>= 0.8, < 0.13)
+      jwt (~> 1.0)
       multi_json (~> 1.3)
       multi_xml (~> 0.5)
       rack (>= 1.2, < 3)
-    parser (2.3.0.6)
-      ast (~> 2.2)
-    pry (0.10.3)
+    parser (2.4.0.2)
+      ast (~> 2.3)
+    pry (0.11.3)
       coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    rack (1.6.4)
-    rainbow (2.1.0)
-    rake (11.1.1)
-    rdoc (4.2.2)
-      json (~> 1.4)
-    reek (4.0.0)
-      codeclimate-engine-rb (~> 0.3.1)
-      parser (~> 2.3, >= 2.3.0.6)
+      method_source (~> 0.9.0)
+    psych (2.2.4)
+    rack (2.0.3)
+    rainbow (2.2.2)
+      rake
+    rake (12.3.0)
+    rdoc (6.0.0)
+    reek (4.7.3)
+      codeclimate-engine-rb (~> 0.4.0)
+      parser (>= 2.4.0.0, < 2.5)
       rainbow (~> 2.0)
-    rspec (3.4.0)
-      rspec-core (~> 3.4.0)
-      rspec-expectations (~> 3.4.0)
-      rspec-mocks (~> 3.4.0)
-    rspec-core (3.4.4)
-      rspec-support (~> 3.4.0)
-    rspec-expectations (3.4.0)
+    rspec (3.7.0)
+      rspec-core (~> 3.7.0)
+      rspec-expectations (~> 3.7.0)
+      rspec-mocks (~> 3.7.0)
+    rspec-core (3.7.0)
+      rspec-support (~> 3.7.0)
+    rspec-expectations (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-mocks (3.4.1)
+      rspec-support (~> 3.7.0)
+    rspec-mocks (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-support (3.4.1)
-    simplecov (0.11.2)
+      rspec-support (~> 3.7.0)
+    rspec-support (3.7.0)
+    semver2 (3.4.2)
+    simplecov (0.15.1)
       docile (~> 1.1.0)
-      json (~> 1.8)
+      json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
-    slop (3.6.0)
-    thread_safe (0.3.5)
+    simplecov-html (0.10.2)
+    thread_safe (0.3.6)
     virtus (1.0.5)
       axiom-types (~> 0.1)
       coercible (~> 1.0)
       descendants_tracker (~> 0.0, >= 0.0.3)
       equalizer (~> 0.0, >= 0.0.9)
-    yard (0.8.7.6)
+    yard (0.9.12)
 
 PLATFORMS
   ruby
@@ -109,7 +112,7 @@ DEPENDENCIES
   reek
   rspec
   simplecov
-  yard
+  yard (~> 0.9.11)
 
 BUNDLED WITH
-   1.11.2
+   1.16.0

data/lib/authy/response.rb

@@ -39,6 +39,7 @@ module Authy
     end
 
     protected
+
     def method_missing(name, *args, &block)
       if self.include?(name.to_s)
         self[name.to_s]
@@ -48,10 +49,12 @@ module Authy
     end
 
     def parse_body
-      body = JSON.parse(@raw_response.body) rescue {}
+      body = JSON.parse(@raw_response.body)
       body.each do |k,v|
         self[k] = v
       end
+    rescue
+      self['message'] = 'invalid json'
     end
   end
 end

data/lib/authy/version.rb

@@ -1,3 +1,3 @@
 module Authy
-  VERSION = "2.7.1"
+  VERSION = "2.7.2"
 end

data/spec/authy/api_spec.rb

@@ -1,71 +1,67 @@
 require 'spec_helper'
 
 describe "Authy::API" do
-
   describe "request headers" do
-
     it "contains api key in header" do
-      url = "protected/json/foo/2"
+      expect_any_instance_of(HTTPClient).to receive(:request).twice.with( any_args, hash_including(header: { "X-Authy-API-Key" => Authy.api_key }) ) { double(ok?: true, body: "", status: 200) }
 
-      HTTPClient.any_instance.should_receive(:request).twice.with( any_args, hash_including(:header=> { "X-Authy-API-Key" => Authy.api_key }) ) { double(:ok? => true, :body => "", :status => 200) }
-      response = Authy::API.get_request(url, {})
-      response = Authy::API.post_request(url, {})
+      url = "protected/json/foo/2"
+      Authy::API.get_request(url, {})
+      Authy::API.post_request(url, {})
     end
   end
 
   describe "Registering users" do
-
     it "should find or create a user" do
       user = Authy::API.register_user(
-        :email => generate_email,
-        :cellphone => generate_cellphone,
-        :country_code => 1
+        email: generate_email,
+        cellphone: generate_cellphone,
+        country_code: 1
       )
-      user.should be_kind_of(Authy::Response)
 
-      user.should be_kind_of(Authy::User)
-      user.should_not be_nil
-      user.id.should_not be_nil
-      user.id.should be_kind_of(Integer)
+      expect(user).to be_kind_of(Authy::Response)
+      expect(user).to be_kind_of(Authy::User)
+      expect(user).to_not be_nil
+      expect(user.id).to_not be_nil
+      expect(user.id).to be_kind_of(Integer)
     end
 
     it "should return the error messages as a hash" do
       user = Authy::API.register_user(
-        :email => generate_email,
-        :cellphone => "abc-1234",
-        :country_code => 1
+        email: generate_email,
+        cellphone: "abc-1234",
+        country_code: 1
       )
 
-      user.errors.should be_kind_of(Hash)
-      user.errors['cellphone'].should == 'is invalid'
+      expect(user.errors).to be_kind_of(Hash)
+      expect(user.errors['cellphone']).to include 'is invalid'
     end
 
     it "should allow to override the API key" do
       user = Authy::API.register_user(
-        :email => generate_email,
-        :cellphone => generate_cellphone,
-        :country_code => 1,
-        :api_key => "invalid_api_key"
+        email: generate_email,
+        cellphone: generate_cellphone,
+        country_code: 1,
+        api_key: "invalid_api_key"
       )
 
-      user.should_not be_ok
-      user.errors['message'].should =~ /invalid api key/i
+      expect(user).to_not be_ok
+      expect(user.errors['message']).to match(/invalid api key/i)
     end
 
     it "should allow overriding send_install_link_via_sms default" do
       user = Authy::API.register_user(
-        :email => generate_email,
-        :cellphone => generate_cellphone,
-        :country_code => 1,
-        :send_install_link_via_sms => false #default is true. See http://docs.authy.com/totp.html#totp-api
+        email: generate_email,
+        cellphone: generate_cellphone,
+        country_code: 1,
+        send_install_link_via_sms: false # Default is true. See http://docs.authy.com/totp.html#totp-api
       )
 
-      user.should be_kind_of(Authy::Response)
-
-      user.should be_kind_of(Authy::User)
-      user.should_not be_nil
-      user.id.should_not be_nil
-      user.id.should be_kind_of(Integer)
+      expect(user).to be_kind_of(Authy::Response)
+      expect(user).to be_kind_of(Authy::User)
+      expect(user).to_not be_nil
+      expect(user.id).to_not be_nil
+      expect(user.id).to be_kind_of(Integer)
     end
 
   end
@@ -74,51 +70,53 @@ describe "Authy::API" do
     before do
       @email = generate_email
       @cellphone = generate_cellphone
-      @user = Authy::API.register_user(:email => @email,
-                                       :cellphone => @cellphone,
-                                       :country_code => 1)
-      @user.should be_ok
+      @user = Authy::API.register_user(
+        email: @email,
+        cellphone: @cellphone,
+        country_code: 1
+      )
+      expect(@user).to be_ok
     end
 
     it "should fail to validate a given token if the user is not registered" do
-      response = Authy::API.verify(:token => 'invalid_token', :id => @user.id)
+      response = Authy::API.verify(token: 'invalid_token', id: @user.id)
 
-      response.should be_kind_of(Authy::Response)
-      response.ok?.should be_falsey
-      response.errors['message'].should == 'Token format is invalid'
+      expect(response).to be_kind_of(Authy::Response)
+      expect(response.ok?).to be_falsey
+      expect(response.errors['message']).to include 'Token format is invalid'
     end
 
     it "should allow to override the API key" do
-      response = Authy::API.verify(:token => '123456', :id => @user['id'], :api_key => "invalid_api_key")
+      response = Authy::API.verify(token: '123456', id: @user['id'], api_key: "invalid_api_key")
 
-      response.should_not be_ok
-      response.errors['message'].should =~ /invalid api key/i
+      expect(response).to_not be_ok
+      expect(response.errors['message']).to match(/invalid api key/i)
     end
 
     it "should escape the params" do
-      expect {
-        Authy::API.verify(:token => '[=#%@$&#(!@);.,', :id => @user['id'])
-      }.to_not raise_error
+      expect do
+        Authy::API.verify(token: '[=#%@$&#(!@);.,', id: @user['id'])
+      end.to_not raise_error
     end
 
     it "should escape the params if have white spaces" do
-      expect {
-        Authy::API.verify(:token => "token with space", :id => @user['id'])
-      }.to_not raise_error
+      expect do
+        Authy::API.verify(token: "token with space", id: @user['id'])
+      end.to_not raise_error
     end
 
     it "should fail if a param is missing" do
-      response = Authy::API.verify(:id => @user['id'])
-      response.should be_kind_of(Authy::Response)
-      response.should_not be_ok
-      response["message"] =~ /Token format is invalid/
+      response = Authy::API.verify(id: @user['id'])
+      expect(response).to be_kind_of(Authy::Response)
+      expect(response).to_not be_ok
+      expect(response["message"]).to include('Token format is invalid')
     end
 
     it 'fails when token format is invalid' do
-      response = Authy::API.verify(:token => '0000', :id => @user.id)
+      response = Authy::API.verify(token: '0000', id: @user.id)
 
       expect(response.ok?).to be_falsey
-      response.should be_kind_of(Authy::Response)
+      expect(response).to be_kind_of(Authy::Response)
       expect(response.errors['message']).to eq 'Token format is invalid'
     end
   end
@@ -127,34 +125,34 @@ describe "Authy::API" do
     title = kind.upcase
     describe "Requesting #{title}" do
       before do
-        @user = Authy::API.register_user(:email => generate_email, :cellphone => generate_cellphone, :country_code => 1)
-        @user.should be_ok
+        @user = Authy::API.register_user(email: generate_email, cellphone: generate_cellphone, country_code: 1)
+        expect(@user).to be_ok
       end
 
       it "should request a #{title} token" do
         uri_param = kind == "phone_call" ? "call" : kind
         url = "#{Authy.api_uri}/protected/json/#{uri_param}/#{Authy::API.escape_for_url(@user.id)}"
-        HTTPClient.any_instance.should_receive(:request).with(:get, url, {:query=>{}, :header=>{ "X-Authy-API-Key" => Authy.api_key }, :follow_redirect=>nil}) { double(:ok? => true, :body => "", :status => 200) }
-        response = Authy::API.send("request_#{kind}", :id => @user.id)
-        response.should be_ok
+        expect_any_instance_of(HTTPClient).to receive(:request).with(:get, url, {query:{}, header:{ "X-Authy-API-Key" => Authy.api_key }, follow_redirect:nil}) { double(ok?: true, body: "", status: 200) }
+        response = Authy::API.send("request_#{kind}", id: @user.id)
+        expect(response).to be_ok
       end
 
       it "should allow to override the API key" do
-        response = Authy::API.send("request_#{kind}", :id => @user.id, :api_key => "invalid_api_key")
-        response.should_not be_ok
-        response.errors['message'].should =~ /invalid api key/i
+        response = Authy::API.send("request_#{kind}", id: @user.id, api_key: "invalid_api_key")
+        expect(response).to_not be_ok
+        expect(response.errors['message']).to match(/invalid api key/i)
       end
 
       it "should request a #{title} token using custom actions" do
         response = Authy::API.send("request_#{kind}", id: @user.id, action: "custom action?", action_message: "Action message $%^?@#")
-        response.should be_ok
+        expect(response).to be_ok
       end
 
       context "user doesn't exist" do
         it "should not be ok" do
-          response = Authy::API.send("request_#{kind}", :id => "tony")
-          response.errors['message'].should == "User not found."
-          response.should_not be_ok
+          response = Authy::API.send("request_#{kind}", id: "tony")
+          expect(response.errors['message']).to eq "User not found."
+          expect(response).to_not be_ok
         end
       end
     end
@@ -163,22 +161,22 @@ describe "Authy::API" do
   describe "delete users" do
     context "user doesn't exist" do
       it "should not be ok" do
-        response = Authy::API.delete_user(:id => "tony")
-        response.errors['message'].should == "User not found."
-        response.should_not be_ok
+        response = Authy::API.delete_user(id: "tony")
+        expect(response.errors['message']).to eq "User not found."
+        expect(response).to_not be_ok
       end
     end
 
     context "user exists" do
       before do
-        @user = Authy::API.register_user(:email => generate_email, :cellphone => generate_cellphone, :country_code => 1)
-        @user.should be_ok
+        @user = Authy::API.register_user(email: generate_email, cellphone: generate_cellphone, country_code: 1)
+        expect(@user).to be_ok
       end
 
       it "should be ok" do
-        response = Authy::API.delete_user(:id => @user.id)
-        response.message.should == "User was added to remove."
-        response.should be_ok
+        response = Authy::API.delete_user(id: @user.id)
+        expect(response.message).to eq "User was added to remove."
+        expect(response).to be_ok
       end
     end
   end
@@ -186,37 +184,37 @@ describe "Authy::API" do
   describe "user status" do
     context "user doesn't exist" do
       it "should not be ok" do
-        response = Authy::API.user_status(:id => "tony")
-        response.errors["message"].should == "User not found."
-        response.should_not be_ok
+        response = Authy::API.user_status(id: "tony")
+        expect(response.errors["message"]).to eq "User not found."
+        expect(response).to_not be_ok
       end
     end
 
     context "user exists" do
       before do
-        @user = Authy::API.register_user(:email => generate_email, :cellphone => generate_cellphone, :country_code => 1)
-        @user.should be_ok
+        @user = Authy::API.register_user(email: generate_email, cellphone: generate_cellphone, country_code: 1)
+        expect(@user).to be_ok
       end
 
       it "should be ok" do
-        response = Authy::API.user_status(:id => @user.id)
-        response.status.should be_kind_of(Hash)
-        response.should be_ok
+        response = Authy::API.user_status(id: @user.id)
+        expect(response.status).to be_kind_of(Hash)
+        expect(response).to be_ok
       end
     end
   end
 
   describe "blank params" do
     before do
-      @user = Authy::API.register_user(:email => generate_email, :cellphone => generate_cellphone, :country_code => 1)
-      @user.should be_ok
+      @user = Authy::API.register_user(email: generate_email, cellphone: generate_cellphone, country_code: 1)
+      expect(@user).to be_ok
     end
 
     [:request_sms, :request_phone_call, :delete_user].each do |method|
       it "should return a proper response with the errors for #{method}" do
-        response = Authy::API.send(method, :id => nil)
-        response.should_not be_ok
-        response.message.should == "user_id is blank."
+        response = Authy::API.send(method, id: nil)
+        expect(response).to_not be_ok
+        expect(response.message).to eq "user_id is blank."
       end
     end
 

data/spec/authy/config_spec.rb

@@ -1,47 +1,47 @@
 require 'spec_helper'
 
-describe "Authy" do
-  describe "api_key" do
-    before(:each) do
+describe 'Authy' do
+  describe 'api_key' do
+    before do
       @default_api_key = Authy.api_key
       Authy.api_key = nil
-      ENV["AUTHY_API_KEY"] = nil
+      ENV['AUTHY_API_KEY'] = nil
     end
 
-    after(:each) do
+    after do
       Authy.api_key = @default_api_key
     end
 
 
     it "should set and read instance variable" do
-      Authy.api_key = "foo"
-      Authy.api_key.should == "foo"
+      Authy.api_key = 'foo'
+      expect(Authy.api_key).to eq 'foo'
     end
 
     it "should fallback to ENV variable" do
-      ENV["AUTHY_API_KEY"] = "bar"
-      Authy.api_key.should == "bar"
+      ENV['AUTHY_API_KEY'] = 'bar'
+      expect(Authy.api_key).to eq 'bar'
     end
   end
 
   describe "api_url" do
-    before(:each) do
+    before do
       @default_api_url = Authy.api_url
       Authy.api_url = nil
     end
 
-    after(:each) do
+    after do
       Authy.api_url = @default_api_url
     end
 
     it "should set and read instance variable" do
-      Authy.api_url = "https://example.com/"
-      Authy.api_url.should == "https://example.com/"
+      Authy.api_url = 'https://example.com/'
+      expect(Authy.api_url).to eq 'https://example.com/'
     end
 
     it "should fallback to default value" do
       Authy.api_url = nil
-      Authy.api_url.should == "https://api.authy.com"
+      expect(Authy.api_url).to eq 'https://api.authy.com'
     end
   end
 end

data/spec/authy/onetouch_spec.rb

@@ -9,10 +9,11 @@ describe Authy::OneTouch do
       @user = Authy::API.register_user(:email => @email,
                                        :cellphone => @cellphone,
                                        :country_code => 1)
-      @user.should be_ok
+      expect(@user).to be_ok
     end
 
     it 'creates a new approval_request for user' do
+      pending('The Authy account this test uses needs to have OneTouch enabled. Another option is to mock the API')
       response = Authy::OneTouch.send_approval_request(
         id: @user.id,
         message: 'You are moving 10 BTC from your account',
@@ -48,6 +49,7 @@ describe Authy::OneTouch do
     end
 
     it 'does not require other fields as mandatory' do
+      pending('The Authy account this test uses needs to have OneTouch enabled. Another option is to mock the API')
       response = Authy::OneTouch.send_approval_request(
         id: @user.id,
         message: 'Test message'
@@ -58,6 +60,7 @@ describe Authy::OneTouch do
     end
 
     it 'checks logos format' do
+      pending('The Authy account this test uses needs to have OneTouch enabled. Another option is to mock the API')
       response = Authy::OneTouch.send_approval_request(
         id: @user.id,
         message: 'You are moving 10 BTC from your account',
@@ -79,6 +82,7 @@ describe Authy::OneTouch do
 
   describe '.approval_request_status' do
     it 'returns approval request status' do
+      pending('The Authy account this test uses needs to have OneTouch enabled. Another option is to mock the API')
       response = Authy::OneTouch.approval_request_status(
         uuid: '550e8400-e29b-41d4-a716-446655440000'
       )

data/spec/authy/phone_intelligence_spec.rb

@@ -4,22 +4,23 @@ describe "Authy::PhoneIntelligence" do
   describe "Sending the verification code" do
 
     it "should send the code via SMS" do
+      pending("API is not returning expected response in this case. The test phone number is invalid.")
       response = Authy::PhoneIntelligence.verification_start(
-        :via => "sms",
-        :country_code => "1",
-        :phone_number => "111-111-1111"
+        via: "sms",
+        country_code: "1",
+        phone_number: "111-111-1111"
       )
 
-      response.should be_kind_of(Authy::Response)
-      response.should be_ok
-      response.message.should == "Text message sent to +1 111-111-1111."
+      expect(response).to be_kind_of(Authy::Response)
+      expect(response).to be_ok
+      expect(response.message).to eq "Text message sent to +1 111-111-1111."
     end
 
     # it "should send the code via CALL" do
     #   response = Authy::PhoneIntelligence.verification_start(
-    #     :via => "call",
-    #     :country_code => "1",
-    #     :phone_number => "111-111-1111"
+    #     via: "call",
+    #     country_code: "1",
+    #     phone_number: "111-111-1111"
     #   )
 
     # response.should be_kind_of(Authy::Response)
@@ -31,63 +32,63 @@ describe "Authy::PhoneIntelligence" do
   describe "validate the fields required" do
     it "should return an error. Country code is required" do
       response = Authy::PhoneIntelligence.verification_start(
-        :via => "sms",
-        :phone_number => "111-111-1111"
+        via: "sms",
+        phone_number: "111-111-1111"
       )
 
-      response.should_not be_ok
-      response.errors['message'] =~ /Country code is mandatory/
+      expect(response).to_not be_ok
+      expect(response.errors['message']).to match(/country_code - Parameter is required/)
     end
 
     it "should return an error. Cellphone is invalid" do
       response = Authy::PhoneIntelligence.verification_start(
-        :via => "sms",
-        :country_code => "1",
-        :phone_number => "123"
+        via: "sms",
+        country_code: "1",
+        phone_number: "123"
       )
 
-      response.should_not be_ok
-      response.errors['message'] =~ /Phone number is invalid/
+      expect(response).to_not be_ok
+      expect(response.errors['message']).to match(/Phone number is invalid/)
     end
   end
 
   describe "Check the verification code" do
     it "should return success true if code is correct" do
-      pending("API is not returning expected response in this case.")
+      pending("API is not returning expected response in this case. The test phone number is invalid.")
 
       response = Authy::PhoneIntelligence.verification_check(
-        :country_code => "1",
-        :phone_number => "111-111-1111",
-        :verification_code => "0000"
+        country_code: "1",
+        phone_number: "111-111-1111",
+        verification_code: "0000"
       )
 
-      response.should be_ok
-      response.message.should == "Verification code is correct."
+      expect(response).to be_ok
+      expect(response.message).to eq "Verification code is correct."
     end
 
     it "should return an error if code is incorrect" do
-      pending("API is not returning expected response in this case.")
+      pending("API is not returning expected response in this case. The test phone number is invalid.")
 
       response = Authy::PhoneIntelligence.verification_check(
-        :country_code => "1",
-        :phone_number => "111-111-1111",
-        :verification_code => "1234"
+        country_code: "1",
+        phone_number: "111-111-1111",
+        verification_code: "1234"
       )
 
-      response.should_not be_ok
-      response.message.should == "Verification code is incorrect."
+      expect(response).to_not be_ok
+      expect(response.message).to eq 'Verification code is incorrect.'
     end
   end
 
   describe "Requesting phone number information" do
     it "should return the phone information" do
       response = Authy::PhoneIntelligence.info(
-        :country_code => "1",
-        :phone_number => "7754615609"
+        country_code: '1',
+        phone_number: '7754615609'
       )
 
-      response.should be_ok
-      response.message.should =~ /Phone number information as of/
+      expect(response).to be_ok
+      expect(response.message).to match(/Phone number information as of/)
     end
   end
 end

data/spec/authy/phone_verification_spec.rb

@@ -4,22 +4,23 @@ describe "Authy::PhoneVerification" do
   describe "Sending the verification code" do
 
     it "should send the code via SMS" do
+      pending("API is not returning expected response in this case. The test phone number is invalid.")
       response = Authy::PhoneVerification.start(
-        :via => "sms",
-        :country_code => "1",
-        :phone_number => "111-111-1111"
+        via: "sms",
+        country_code: "1",
+        phone_number: "111-111-1111"
       )
 
-      response.should be_kind_of(Authy::Response)
-      response.should be_ok
-      response.message.should == "Text message sent to +1 111-111-1111."
+      expect(response).to be_kind_of(Authy::Response)
+      expect(response).to be_ok
+      expect(response.message).to eq "Text message sent to +1 111-111-1111."
     end
 
     # it "should send the code via CALL" do
     #   response = Authy::PhoneVerification.start(
-    #     :via => "call",
-    #     :country_code => "1",
-    #     :phone_number => "111-111-1111"
+    #     via: "call",
+    #     country_code: "1",
+    #     phone_number: "111-111-1111"
     #   )
 
     # response.should be_kind_of(Authy::Response)
@@ -31,34 +32,35 @@ describe "Authy::PhoneVerification" do
   describe "validate the fields required" do
     it "should return an error. Country code is required" do
       response = Authy::PhoneVerification.start(
-        :via => "sms",
-        :phone_number => "111-111-1111"
+        via: "sms",
+        phone_number: "111-111-1111"
       )
 
-      response.should_not be_ok
-      response.errors['message'] =~ /Country code is mandatory/
+
+      expect(response).to_not be_ok
+      expect(response.errors['message']).to match(/country_code - Parameter is required/)
     end
 
     it "should return an error. Cellphone is invalid" do
       response = Authy::PhoneVerification.start(
-        :via => "sms",
-        :country_code => "1",
-        :phone_number => "123"
+        via: "sms",
+        country_code: "1",
+        phone_number: "123"
       )
 
-      response.should_not be_ok
-      response.errors['message'] =~ /Phone number is invalid/
+      expect(response).to_not be_ok
+      expect(response.errors['message']).to eq('Phone number is invalid')
     end
   end
 
   describe "Check the verification code" do
     it "should return success true if code is correct" do
-      pending("API is not returning expected response in this case.")
+      pending("API is not returning expected response in this case. The test phone number is invalid.")
 
       response = Authy::PhoneVerification.check(
-        :country_code => "1",
-        :phone_number => "111-111-1111",
-        :verification_code => "0000"
+        country_code: "1",
+        phone_number: "111-111-1111",
+        verification_code: "0000"
       )
 
       expect(response).to be_ok
@@ -66,16 +68,29 @@ describe "Authy::PhoneVerification" do
     end
 
     it "should return an error if code is incorrect" do
-      pending("API is not returning expected response in this case.")
+      pending("API is not returning expected response in this case. The test phone number is invalid")
 
       response = Authy::PhoneVerification.check(
-        :country_code => "1",
-        :phone_number => "111-111-1111",
-        :verification_code => "1234"
+        country_code: "1",
+        phone_number: "111-111-1111",
+        verification_code: "1234"
       )
 
       expect(response).not_to be_ok
       expect(response.message).to eq('Verification code is incorrect.')
     end
   end
+
+  describe 'Check the phone number' do
+    it "should return an error if phone number is invalid" do
+      response = Authy::PhoneVerification.check(
+        country_code: "1",
+        phone_number: "111-111-1111",
+        verification_code: "1234"
+      )
+
+      expect(response).not_to be_ok
+      expect(response.message).to eq('Phone number is invalid')
+    end
+  end
 end

data/spec/authy/response_spec.rb

@@ -1,33 +1,46 @@
 require 'spec_helper'
 
 describe "Authy::Response" do
-  before :each do
-    @fake_response = OpenStruct.new
-    @fake_response.body = {'v1' => 'r1','v2' => 42}.to_json
-    @fake_response.status = 200
-
-    @response = Authy::Response.new(@fake_response)
-  end
-
-  it "should parse to json the body" do
-    @response['v2'].should == 42
+  let(:response) { Authy::Response.new(fake_response) }
+
+  context 'response is valid' do
+    let(:fake_response) do
+      OpenStruct.new.tap do |struct|
+        struct.body = { 'v1' => 'r1','v2' => 42 }.to_json
+        struct.status = 200
+      end
+    end
+
+    it "should parse to json the body" do
+      expect(response['v2']).to eq 42
+      expect(response.error_msg).to eq "No error"
+      expect(response.ok?).to be_truthy
+    end
   end
 
-  it "should be ok if the return code is 200" do
-    @response.ok?.should be_truthy
+  context 'response returns a 401 status code' do
+    let(:fake_response) do
+      OpenStruct.new.tap do |struct|
+        struct.status = 401
+      end
+    end
 
-    @fake_response.status = 401
-    @response = Authy::Response.new(@fake_response)
-    @response.ok?.should be_falsey
+    it 'response is not ok' do
+      expect(response.ok?).to be_falsey
+    end
   end
 
-  it "should return the error message" do
-    @response.error_msg.should == "No error"
-
-    @fake_response.body = 'invalid json'
-    @fake_response.status = 401
-    @response = Authy::Response.new(@fake_response)
-
-    @response.error_msg.should == "invalid json"
+  context 'response returns invalid json' do
+    let(:fake_response) do
+      OpenStruct.new.tap do |struct|
+        struct.body = 'invalid json'
+        struct.status = 401
+      end
+    end
+
+    it "should return the error message" do
+      expect(response.error_msg).to eq "invalid json"
+      expect(response.message).to eq "invalid json"
+    end
   end
 end

data/spec/authy/url_helpers_spec.rb

@@ -7,30 +7,30 @@ describe "Authy::URL" do
 
   describe "escape_for_url" do
     it "should user URI escape" do
-      URI.should_receive :escape
+      expect(URI).to receive :escape
       Dummy.escape_for_url("that")
     end
 
     it "should use Regexp" do
-      Regexp.should_receive(:new).with("[^#{URI::PATTERN::UNRESERVED}]").and_return(/a/)
+      expect(Regexp).to receive(:new).with("[^#{URI::PATTERN::UNRESERVED}]").and_return(/a/)
       Dummy.escape_for_url("that")
     end
   end
 
   describe "to_param" do
     it "should user HTTP::Message.escape" do
-      HTTP::Message.should_receive(:escape).exactly(2).times.and_return "basic string"
+      expect(HTTP::Message).to receive(:escape).exactly(2).times.and_return "basic string"
       Dummy.to_param('key', 'value')
     end
 
     it "should paramify the left to right" do
-      Dummy.to_param('key', 'value').should == 'key=value'
+      expect(Dummy.to_param('key', 'value')).to eq 'key=value'
     end
   end
 
   describe "params_from_array" do
     it "should return an array of params" do
-      Dummy.params_from_array("da key", ["one", "two"]).should == [HTTP::Message.escape("da key[]") + "=one", HTTP::Message.escape("da key[]") + "=two"]
+      expect(Dummy.params_from_array("da key", ["one", "two"])).to eq([HTTP::Message.escape("da key[]") + "=one", HTTP::Message.escape("da key[]") + "=two"])
     end
   end
 end

data/spec/spec_helper.rb

@@ -15,12 +15,6 @@ RSpec.configure do |config|
     Authy.api_key = 'bf12974d70818a08199d17d5e2bae630'
   end
 
-  config.before(:each) do
-  end
-
-  config.after(:each) do
-  end
-
   def generate_email
     domain = "@authy.com"
     user = (0...8).map{97.+(rand(25)).chr}.join

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: authy
 version: !ruby/object:Gem::Version
-  version: 2.7.1
+  version: 2.7.2
 platform: ruby
 authors:
 - Authy Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-22 00:00:00.000000000 Z
+date: 2017-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient
@@ -181,7 +181,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: authy
-rubygems_version: 2.6.0
+rubygems_version: 2.5.2.1
 signing_key: 
 specification_version: 4
 summary: Ruby library to access Authy services
@@ -194,4 +194,3 @@ test_files:
 - spec/authy/response_spec.rb
 - spec/authy/url_helpers_spec.rb
 - spec/spec_helper.rb
-has_rdoc: