authpwn_rails 0.15.2 → 0.15.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2fbda7d8809e12cfb311d5538e09f4e82ada94ee
-  data.tar.gz: b901e46b029479f4d20c5426b378d4ccf5867c3f
+  metadata.gz: c6719080b86f274594a57d3736066da719c014a2
+  data.tar.gz: a29c73989fafec440e2a5f0ff7136fffa0c61ddd
 SHA512:
-  metadata.gz: 6853c521836ea31383f6a326ed6ab938d76bbc2cc4d98152e0901c303627961115edee8a85cee1da05d0bf618451e5f11e9de86301fca6127208278de1c7bcb4
-  data.tar.gz: 3b3b0d57b2ff140f9b194a2f21635e60e05154d85e66fe48b0a2225002637cd342d3b2234f6e13662186380ae8b2d3e6f48fc17c2f2feb175013a00ccad7b1fb
+  metadata.gz: f39686f3fe9d96375aacf85f10192d0e0bb3a76bad5059a820229c40dc76f3d9cd34e61a8cbac4689f3808423e0266906ca5884e1363eedc82ac69ce0f80e561
+  data.tar.gz: f781ce4ed9fc990e028818c140efc71fd5ae1f7ee7655e4819c55803793e63a06e68bac7dd66ebf67a2a9cd014a535f7a095b963ce6e911585e085214ec7466e

data/VERSION

@@ -1 +1 @@
-0.15.2
+0.15.3

data/authpwn_rails.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = "authpwn_rails"
-  s.version = "0.15.2"
+  s.version = "0.15.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Victor Costan"]

data/lib/authpwn_rails/session_controller.rb

@@ -195,15 +195,13 @@ module SessionController
     if @credential
       # An old password is set, must verify it.
       if @credential.check_password params[:old_password]
-        success = @credential.update_attributes(
-            change_password_params[:credential])
+        success = @credential.update_attributes change_password_params
       else
         success = false
         flash[:alert] = 'Incorrect old password. Please try again.'
       end
     else
-      @credential = Credentials::Password.new(
-          change_password_params[:credential])
+      @credential = Credentials::Password.new change_password_params
       @credential.user = current_user
       success = @credential.save
     end
@@ -225,13 +223,12 @@ module SessionController
 
     # Parameters used to change the user's password.
     def change_password_params
-      params.permit :format, :old_password,
-          credential: [ :password, :password_confirmation ]
+      params.require(:credential).permit :password, :password_confirmation
     end
   else
     # Rails 3.
     def change_password_params
-      params
+      params[:credential]
     end
   end
 

data/test/session_controller_api_test.rb

@@ -381,6 +381,17 @@ class SessionControllerApiTest < ActionController::TestCase
         'hacks'), 'password not changed'
   end
 
+  test "change_password works with correct input and extra form input" do
+    set_session_current_user @user
+    post :change_password, old_password: 'password',
+         credential: { password: 'hacks', password_confirmation: 'hacks'},
+         utf8: "\u2713", commit: 'Change password'
+    assert_redirected_to session_url
+    assert_equal @password_credential, assigns(:credential)
+    assert_equal @user, User.authenticate_signin(@email_credential.email,
+        'hacks'), 'password not changed'
+  end
+
   test "change_password rejects bad old password" do
     set_session_current_user @user
     post :change_password, old_password: '_password',

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: authpwn_rails
 version: !ruby/object:Gem::Version
-  version: 0.15.2
+  version: 0.15.3
 platform: ruby
 authors:
 - Victor Costan