authorized_persona 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3072dc5f8b435349401f93116e4b0b7e3b7186f575edc9b8445d8cb57b0dff5a
-  data.tar.gz: b667896c39b2f9707949556f27bbaf38da5c98c59e0bdd2ef7fe201eb078f6b4
+  metadata.gz: 83c7b75e101248119260f84dc0cfabd9dc6db7a079cacf89de689d7863e12028
+  data.tar.gz: 9d1e4c231c66e743650ae5566192a5a5aa640974d616c3f508b0f08a981ed592
 SHA512:
-  metadata.gz: 359023dc6e9a4a3404fba063afc428cab6054910c7f495acbd3e8eaac045d1a3e8145f57b9b2e3355b7518110b57dcf6977338d75981ef6e93e5d267a01ba9e7
-  data.tar.gz: 6109174ab892f4585d4a6cec4300d29184d55db985b100aae70a299b0a1f5f555bf50b97f20065b34e282cec13a633047989e759d2141cbca578b571e7ac84da
+  metadata.gz: db6b39f1ca8cadb3e9180e17bf36eb33467c5d929144444ac9d17d2e949d13697c36a21241f4e168367c0013569699299e6322b2e85d1548ef2360c9377ff890
+  data.tar.gz: 6300f79ee516294b170acd149d555b80c23033a29513d667511ef447e8025abccff942faf9ab55823dedc3d871daa17326c691ef4ef969d544c2958451bd5794

data/.github/workflows/ci.yml

@@ -0,0 +1,27 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ['2.7', '3.0']
+        gemfile:
+          - gemfiles/rails_6_0.gemfile
+          - gemfiles/rails_6_1.gemfile
+          - gemfiles/rails_7_0.gemfile
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      env:
+        BUNDLE_GEMFILE: ${{ matrix.gemfile }}
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run tests and linter
+      env:
+        BUNDLE_GEMFILE: ${{ matrix.gemfile }}
+      run: bundle exec rake

data/.gitignore

@@ -11,3 +11,4 @@
 .rspec_status
 
 /Gemfile.lock
+*.gemfile.lock

data/.rubocop.yml

@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
 inherit_gem:
-  rubocop-betterment:
+  betterlint:
     - config/default.yml

data/.rubocop_todo.yml

@@ -0,0 +1,100 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 99999`
+# on 2023-05-09 13:01:46 UTC using RuboCop version 1.50.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 4
+# Configuration parameters: EnforcedStyle, AllowedGems, Include.
+# SupportedStyles: Gemfile, gems.rb, gemspec
+# Include: **/*.gemspec, **/Gemfile, **/gems.rb
+Gemspec/DevelopmentDependencies:
+  Exclude:
+    - 'authorized_persona.gemspec'
+
+# Offense count: 1
+# Configuration parameters: Severity, Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'authorized_persona.gemspec'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Exclude:
+    - 'lib/authorized_persona/authorization.rb'
+
+# Offense count: 2
+Lint/MissingSuper:
+  Exclude:
+    - 'spec/authorized_persona/authorization_spec.rb'
+    - 'spec/authorized_persona/persona_spec.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'lib/authorized_persona/authorization.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowedMethods, AllowedPatterns, Max.
+Metrics/PerceivedComplexity:
+  Exclude:
+    - 'lib/authorized_persona/persona.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/BeEq:
+  Exclude:
+    - 'spec/authorized_persona/authorization_spec.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/ActiveSupportOnLoad:
+  Exclude:
+    - 'lib/authorized_persona/railtie.rb'
+
+# Offense count: 1
+Rails/I18nLocaleTexts:
+  Exclude:
+    - 'lib/authorized_persona/authorization.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Include.
+# Include: **/Rakefile, **/*.rake
+Rails/RakeEnvironment:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Rake/Desc:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedReceivers.
+# AllowedReceivers: Thread.current
+Style/HashEachMethods:
+  Exclude:
+    - 'lib/authorized_persona/persona.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/MapToHash:
+  Exclude:
+    - 'lib/authorized_persona/authorization.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Mode.
+Style/StringConcatenation:
+  Exclude:
+    - 'lib/authorized_persona/view_helpers.rb'

data/.ruby-version

@@ -0,0 +1 @@
+3.0.6

data/Appraisals

@@ -0,0 +1,14 @@
+appraise 'rails-6-0' do
+  gem 'railties', '~> 6.0.0'
+  gem 'activemodel', '~>6.0.0'
+end
+
+appraise 'rails-6-1' do
+  gem 'railties', '~> 6.1.0'
+  gem 'activemodel', '~>6.1.0'
+end
+
+appraise 'rails-7-0' do
+  gem 'railties', '~> 7.0.0'
+  gem 'activemodel', '~>7.0.0'
+end

data/README.md

@@ -107,23 +107,24 @@ end
 class ApplicationController < ActionController::Base
   include AuthorizedPersona::Authorization
 
-  # Any needed hooks your authentication library needs to ensure
+  # Any hooks your authentication library needs to ensure
   # `current_user` is set before # authorization, e.g.:
   #
-  # before_filter :authenticate_user!
+  # before_action :authenticate_user!
 
   authorize_persona class_name: "User"
 
   # or optionally override the method name we use to fetch current_[class_name] e.g.:
   #
-  # authorize_persona class_name: "User", current_user_method_name: :current_fancy_user
+  # authorize_persona class_name: "User", current_user_method: :current_fancy_user
 
   # Your code here...
 end
 ```
 
 At this point, no user is authorized to make a request to any descendent
-of `ApplicationController`.
+of `ApplicationController`. Note that any unauthenticated controllers (e.g. authentication
+controllers) will need to have authorization disabled via `skip_before_action :authorize!`.
 
 3. Grant privileges in your base controller or any subclass:
 

data/authorized_persona.gemspec

@@ -22,13 +22,15 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  rails_version_range = [">= 5.1.6.2", "< 7"]
+  rails_version_range = [">= 5.1.6.2", "< 7.1"]
 
   spec.add_dependency "railties", *rails_version_range
 
   spec.add_development_dependency "activemodel", *rails_version_range
-  spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "appraisal"
+  spec.add_development_dependency "betterlint"
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "rubocop-betterment"
+  spec.metadata['rubygems_mfa_required'] = 'true'
 end

data/gemfiles/rails_6_0.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activemodel", "~>6.0.0"
+gem "railties", "~> 6.0.0"
+
+gemspec path: "../"

data/gemfiles/rails_6_1.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activemodel", "~>6.1.0"
+gem "railties", "~> 6.1.0"
+
+gemspec path: "../"

data/gemfiles/rails_7_0.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activemodel", "~>7.0.0"
+gem "railties", "~> 7.0.0"
+
+gemspec path: "../"

data/lib/authorized_persona/authorization.rb

@@ -13,7 +13,7 @@ module AuthorizedPersona
 
     class_methods do
       # Configure authorization for an authorized persona class
-      def authorize_persona(class_name:, current_user_method: nil) # rubocop:disable Metrics/AbcSize, Metrics/PerceivedComplexity, Metrics/MethodLength, Metrics/LineLength
+      def authorize_persona(class_name:, current_user_method: nil) # rubocop:disable Metrics/AbcSize, Metrics/PerceivedComplexity, Metrics/
         raise AuthorizedPersona::Error, "you can only configure authorization once" if authorization_persona_class_name.present?
         raise AuthorizedPersona::Error, "class_name must be a string" unless class_name.is_a?(String)
         raise AuthorizedPersona::Error, "current_user_method must be a symbol" if current_user_method && !current_user_method.is_a?(Symbol)
@@ -36,13 +36,13 @@ module AuthorizedPersona
 
       # Grants replace all previous grants to avoid privilege leakage
       def grant(privileges) # rubocop:disable Metrics/AbcSize
-        self.authorized_actions = Hash[privileges.map { |auth_tier, actions| [auth_tier.to_s, [actions].flatten.map(&:to_sym)] }]
+        self.authorized_actions = privileges.map { |auth_tier, actions| [auth_tier.to_s, [actions].flatten.map(&:to_sym)] }.to_h
 
         tier_names = authorization_persona.authorization_tier_names
         extra_keys = authorized_actions.keys - authorization_persona.authorization_tier_names
         if extra_keys.present?
           raise AuthorizedPersona::Error, "invalid grant: #{authorization_persona_class_name} " \
-            "has authorization tiers #{tier_names.join(', ')} but received extra keys: #{extra_keys.join(', ')}"
+                                          "has authorization tiers #{tier_names.join(', ')} but received extra keys: #{extra_keys.join(', ')}"
         end
       end
 
@@ -79,7 +79,7 @@ module AuthorizedPersona
     def authorization_current_user
       unless authorization_current_user_method.is_a?(Symbol)
         raise AuthorizedPersona::Error, "you must configure authorization with a valid current_user method name, " \
-          "e.g. `authorize_persona class_name: 'User', current_user_method: :my_custom_current_user`"
+                                        "e.g. `authorize_persona class_name: 'User', current_user_method: :my_custom_current_user`"
       end
 
       send(self.class.authorization_current_user_method)
@@ -89,7 +89,7 @@ module AuthorizedPersona
       self.class.authorized_tier(action: params[:action])
     end
 
-    def authorize! # rubocop:disable Metrics/MethodLength
+    def authorize!
       return if authorized?
 
       respond_to do |format|

data/lib/authorized_persona/persona.rb

@@ -34,7 +34,7 @@ module AuthorizedPersona
       end
 
       # Configure the authorization tiers in my_tier_slug: "My Tier Title And Description" form from lowest to highest privilege.
-      def authorization_tiers(tiers) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      def authorization_tiers(tiers) # rubocop:disable Metrics/AbcSize
         raise AuthorizedPersona::Error, "you can only define authorization tiers once" if instance_variable_defined?(:@authorization_tiers)
 
         if !tiers.is_a?(Hash) || !tiers.all? { |k, v| k.is_a?(Symbol) && v.is_a?(String) }

data/lib/authorized_persona/railtie.rb

@@ -1,7 +1,7 @@
 module AuthorizedPersona
   class Railtie < Rails::Railtie
     initializer "authorized_persona.view_helpers" do
-      ActionView::Base.send :include, AuthorizedPersona::ViewHelpers
+      ActionView::Base.include AuthorizedPersona::ViewHelpers
     end
   end
 end

data/lib/authorized_persona/version.rb

@@ -1,3 +1,3 @@
 module AuthorizedPersona
-  VERSION = "0.9.0".freeze
+  VERSION = "0.9.1".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: authorized_persona
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - John Mileham
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2019-06-08 00:00:00.000000000 Z
+date: 2023-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -19,7 +19,7 @@ dependencies:
         version: 5.1.6.2
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: 5.1.6.2
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
@@ -39,7 +39,7 @@ dependencies:
         version: 5.1.6.2
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '7.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -49,51 +49,51 @@ dependencies:
         version: 5.1.6.2
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: betterlint
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-betterment
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -106,6 +106,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 description: AuthorizedPersona is a rails implementation of Betterment's Persona Centric
   Authorization pattern
 email:
@@ -114,10 +128,13 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
+- ".rubocop_todo.yml"
+- ".ruby-version"
+- Appraisals
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -126,6 +143,9 @@ files:
 - authorized_persona.gemspec
 - bin/console
 - bin/setup
+- gemfiles/rails_6_0.gemfile
+- gemfiles/rails_6_1.gemfile
+- gemfiles/rails_7_0.gemfile
 - lib/authorized_persona.rb
 - lib/authorized_persona/authorization.rb
 - lib/authorized_persona/persona.rb
@@ -135,8 +155,9 @@ files:
 homepage: https://github.com/Betterment/authorized_persona
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -151,8 +172,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.4.12
+signing_key:
 specification_version: 4
 summary: the simplest authorization library you will ever love
 test_files: []

data/.travis.yml

@@ -1,7 +0,0 @@
----
-sudo: false
-language: ruby
-cache: bundler
-rvm:
-  - 2.6.1
-before_install: gem install bundler -v 2.0.1