authorized_persona 0.1.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4c94ee11ec5cc61e600479f513dbd1977768ff146b61ec18ae34f34aeaa2e223
-  data.tar.gz: 687dde9d36b005ab6a8b8d08e6b40ea7349819d765fb93c1cd4c06fb568dfc5d
+  metadata.gz: 3072dc5f8b435349401f93116e4b0b7e3b7186f575edc9b8445d8cb57b0dff5a
+  data.tar.gz: b667896c39b2f9707949556f27bbaf38da5c98c59e0bdd2ef7fe201eb078f6b4
 SHA512:
-  metadata.gz: 7d146c61b9932e9eea82aea03ac7f48798ce42c47bf3eb8eb9cffc403631db58e56559a1098c7b9a640e4598858552a37ca75e6749c564882f248188c8bcd00c
-  data.tar.gz: e371dc3c7752412945d46cb76716d8973ad6d1cdc3149d49bf31dde852b5b12c37e10b3d05490f0b4711694bdb0d1108ea683e28bef6d6ecd9dd322919095db6
+  metadata.gz: 359023dc6e9a4a3404fba063afc428cab6054910c7f495acbd3e8eaac045d1a3e8145f57b9b2e3355b7518110b57dcf6977338d75981ef6e93e5d267a01ba9e7
+  data.tar.gz: 6109174ab892f4585d4a6cec4300d29184d55db985b100aae70a299b0a1f5f555bf50b97f20065b34e282cec13a633047989e759d2141cbca578b571e7ac84da

data/.gitignore

@@ -9,3 +9,5 @@
 
 # rspec failure tracking
 .rspec_status
+
+/Gemfile.lock

data/README.md

@@ -34,7 +34,7 @@ your data model and trust root chaining. But even when more access
 control logic is required, you will develop simpler, better-fit
 solutions within your application.
 
-Which lead us to the following conclusions:
+Which led us to the following conclusions:
 
 * Applications should be built for a single persona each.
 * In Rails applications, authorization should be granted and enforced
@@ -73,7 +73,7 @@ We'll assume you're using an authentication library like `devise` or
 
 1.  Integrate AuthorizedPersona into your user model.
 
-The example uses ActiveRecord, but any ActiveModel-based ORM will do.
+The example uses ActiveRecord, but any ActiveModel-like ORM will do.
 Your model only needs to have a string attribute named
 `authorization_tier`.
 
@@ -107,6 +107,11 @@ end
 class ApplicationController < ActionController::Base
   include AuthorizedPersona::Authorization
 
+  # Any needed hooks your authentication library needs to ensure
+  # `current_user` is set before # authorization, e.g.:
+  #
+  # before_filter :authenticate_user!
+
   authorize_persona class_name: "User"
 
   # or optionally override the method name we use to fetch current_[class_name] e.g.:
@@ -187,6 +192,24 @@ class BillSearch
 end
 ```
 
+6. (Advanced) If you need to determine which users are at or above an
+   authorization tier, e.g. for fanning out notifications:
+
+```ruby
+# app/jobs/sensitive_bill_notification_job.rb
+class SensitiveBillNotificationJob < ApplicationJob
+
+  def perform(bill_id)
+    bill = Bill.find(bill_id)
+    # AuthorizedPersona::Persona provides a `.[tier]_or_above` scope if
+    # your ORM supports a `.where` method
+    User.admin_or_above.find_each do |admin|
+      AdminMailer.with(user: admin, bill: bill).sensitive_bill_notification.deliver_later
+    end
+  end
+end
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/authorized_persona.gemspec

@@ -24,9 +24,9 @@ Gem::Specification.new do |spec|
 
   rails_version_range = [">= 5.1.6.2", "< 7"]
 
-  spec.add_dependency "activemodel", *rails_version_range
-  spec.add_dependency "railties",    *rails_version_range
+  spec.add_dependency "railties", *rails_version_range
 
+  spec.add_development_dependency "activemodel", *rails_version_range
   spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"

data/lib/authorized_persona.rb

@@ -1,7 +1,6 @@
 require "authorized_persona/version"
 
 require "rails"
-require "active_model"
 
 require "authorized_persona/persona"
 require "authorized_persona/authorization"

data/lib/authorized_persona/authorization.rb

@@ -9,13 +9,11 @@ module AuthorizedPersona
       self.authorized_actions = {}
 
       helper_method :authorization_current_user
-
-      before_action :authorize!
     end
 
     class_methods do
       # Configure authorization for an authorized persona class
-      def authorize_persona(class_name:, current_user_method: nil) # rubocop:disable Metrics/AbcSize
+      def authorize_persona(class_name:, current_user_method: nil) # rubocop:disable Metrics/AbcSize, Metrics/PerceivedComplexity, Metrics/MethodLength, Metrics/LineLength
         raise AuthorizedPersona::Error, "you can only configure authorization once" if authorization_persona_class_name.present?
         raise AuthorizedPersona::Error, "class_name must be a string" unless class_name.is_a?(String)
         raise AuthorizedPersona::Error, "current_user_method must be a symbol" if current_user_method && !current_user_method.is_a?(Symbol)
@@ -26,7 +24,14 @@ module AuthorizedPersona
           raise AuthorizedPersona::Error, "#{class_name} must be an AuthorizedPersona::Persona"
         end
 
-        self.authorization_current_user_method = current_user_method || :"current_#{authorization_persona.model_name.singular_route_key}"
+        model_name = if authorization_persona.respond_to?(:model_name)
+                       authorization_persona.model_name.singular_route_key
+                     else
+                       authorization_persona.name.underscore
+                     end
+        self.authorization_current_user_method = current_user_method || :"current_#{model_name}"
+
+        before_action :authorize!
       end
 
       # Grants replace all previous grants to avoid privilege leakage

data/lib/authorized_persona/persona.rb

@@ -2,6 +2,14 @@ module AuthorizedPersona
   module Persona
     extend ActiveSupport::Concern
 
+    included do
+      if respond_to?(:where)
+        def self.with_authorization_tier_at_or_above(tier)
+          where(authorization_tier_attribute_name => authorization_tier_names.drop(authorization_tier_level(tier)))
+        end
+      end
+    end
+
     class_methods do
       # Get the attribute name for authorization_tier
       def authorization_tier_attribute_name
@@ -45,6 +53,19 @@ module AuthorizedPersona
           end
         end
 
+        if respond_to?(:with_authorization_tier_at_or_above)
+          class_methods = Module.new
+          extend class_methods
+
+          class_methods.module_eval do
+            tiers.keys.each do |tier|
+              define_method "#{tier}_or_above" do
+                with_authorization_tier_at_or_above(tier)
+              end
+            end
+          end
+        end
+
         @authorization_tiers = tiers.freeze
       end
 

data/lib/authorized_persona/version.rb

@@ -1,3 +1,3 @@
 module AuthorizedPersona
-  VERSION = "0.1.0".freeze
+  VERSION = "0.9.0".freeze
 end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: authorized_persona
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.9.0
 platform: ruby
 authors:
 - John Mileham
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-06-07 00:00:00.000000000 Z
+date: 2019-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activemodel
+  name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -31,7 +31,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '7'
 - !ruby/object:Gem::Dependency
-  name: railties
+  name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -40,7 +40,7 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '7'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -120,7 +120,6 @@ files:
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile

data/Gemfile.lock

@@ -1,112 +0,0 @@
-PATH
-  remote: .
-  specs:
-    authorized_persona (0.1.0)
-      activemodel (>= 5.1.6.2, < 7)
-      railties (>= 5.1.6.2, < 7)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    actionpack (5.2.3)
-      actionview (= 5.2.3)
-      activesupport (= 5.2.3)
-      rack (~> 2.0)
-      rack-test (>= 0.6.3)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.2.3)
-      activesupport (= 5.2.3)
-      builder (~> 3.1)
-      erubi (~> 1.4)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activemodel (5.2.3)
-      activesupport (= 5.2.3)
-    activesupport (5.2.3)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    ast (2.4.0)
-    builder (3.2.3)
-    concurrent-ruby (1.1.5)
-    crass (1.0.4)
-    diff-lcs (1.3)
-    erubi (1.8.0)
-    i18n (1.6.0)
-      concurrent-ruby (~> 1.0)
-    jaro_winkler (1.5.2)
-    loofah (2.2.3)
-      crass (~> 1.0.2)
-      nokogiri (>= 1.5.9)
-    method_source (0.9.2)
-    mini_portile2 (2.4.0)
-    minitest (5.11.3)
-    nokogiri (1.10.3)
-      mini_portile2 (~> 2.4.0)
-    parallel (1.17.0)
-    parser (2.6.3.0)
-      ast (~> 2.4.0)
-    powerpack (0.1.2)
-    rack (2.0.7)
-    rack-test (1.1.0)
-      rack (>= 1.0, < 3)
-    rails-dom-testing (2.0.3)
-      activesupport (>= 4.2.0)
-      nokogiri (>= 1.6)
-    rails-html-sanitizer (1.0.4)
-      loofah (~> 2.2, >= 2.2.2)
-    railties (5.2.3)
-      actionpack (= 5.2.3)
-      activesupport (= 5.2.3)
-      method_source
-      rake (>= 0.8.7)
-      thor (>= 0.19.0, < 2.0)
-    rainbow (3.0.0)
-    rake (10.5.0)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.0)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.3)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.0)
-    rubocop (0.61.1)
-      jaro_winkler (~> 1.5.1)
-      parallel (~> 1.10)
-      parser (>= 2.5, != 2.5.1.1)
-      powerpack (~> 0.1)
-      rainbow (>= 2.2.2, < 4.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.4.0)
-    rubocop-betterment (1.8.0)
-      rubocop (~> 0.61.1)
-      rubocop-rspec (= 1.28.0)
-    rubocop-rspec (1.28.0)
-      rubocop (>= 0.58.0)
-    ruby-progressbar (1.10.1)
-    thor (0.20.3)
-    thread_safe (0.3.6)
-    tzinfo (1.2.5)
-      thread_safe (~> 0.1)
-    unicode-display_width (1.4.1)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  authorized_persona!
-  bundler (~> 2.0)
-  rake (~> 10.0)
-  rspec (~> 3.0)
-  rubocop-betterment
-
-BUNDLED WITH
-   2.0.1