authlogic 4.3.0 → 4.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4338f1d172e52ed21fd06d6dee7959a1b9697185
-  data.tar.gz: 8b30bfa5118abf8e8381ee6f95fa646326bc02aa
+  metadata.gz: aff376d83dfc9c82fc0da8cf663c0da3a57d3773
+  data.tar.gz: c010cbc52a5c7311e82a24f5c8200be9e13ddc7e
 SHA512:
-  metadata.gz: 303dc0ff5dd80290c8696362bc152fc853f0f48f24d773e3d8627cbb3f95b325f105345044ac7cc5981482ebdafe2093d2100fd0f4df9bf2b48e940c66823d37
-  data.tar.gz: '0336508798d6b17a5f1cc457ddf3beeda15c62ba23f51964476352a48f26851061ddd30f1aa94f2e522c3d9c0664bf2f9fb395151fbeeb4aa402741c6735d0d3'
+  metadata.gz: e4c98cc836da6a832ae6511026123eb5d6704176da7eaecaa8edb5dd04665c45ac2e671bbda68c7be7978f1dada2b97a95c74ffd7a1759bbe234a69533c210d8
+  data.tar.gz: efd33a8b26b53d23f9709e5b00d89faec6d7003b5cd65a21162622282b98b2c8cfd632e5ab4172a11e1bebcd3643f5d1ad3584bf3fb9c112c6023784d327d01c

data/CHANGELOG.md

@@ -16,6 +16,21 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 * Fixed
   * None
 
+## 4.4.0 (2018-09-21)
+
+* Breaking Changes
+  * None
+* Added
+  * None
+* Fixed
+  * None
+* Deprecation
+  * [#627](https://github.com/binarylogic/authlogic/pull/627) -
+    Deprecate `authenticates_many` without replacement
+  * [#623](https://github.com/binarylogic/authlogic/pull/623) -
+    Deprecate unnecessary validation features, use normal rails validation
+    instead
+
 ## 4.3.0 (2018-08-12)
 
 * Breaking Changes

data/README.md

@@ -15,7 +15,7 @@ A clean, simple, and unobtrusive ruby authentication solution.
 | Version     | Documentation |
 | ----------- | ------------- |
 | Unreleased  | https://github.com/binarylogic/authlogic/blob/master/README.md |
-| 4.3.0       | https://github.com/binarylogic/authlogic/blob/v4.3.0/README.md |
+| 4.4.0       | https://github.com/binarylogic/authlogic/blob/v4.4.0/README.md |
 | 3.7.0       | https://github.com/binarylogic/authlogic/blob/v3.7.0/README.md |
 | 2.1.11      | https://github.com/binarylogic/authlogic/blob/v2.1.11/README.rdoc |
 | 1.4.3       | https://github.com/binarylogic/authlogic/blob/v1.4.3/README.rdoc |
@@ -42,6 +42,7 @@ A clean, simple, and unobtrusive ruby authentication solution.
 
 | Version | branch       | ruby     | activerecord  |
 | ------- | ------------ | -------- | ------------- |
+| 4.4     | 4-4-stable   | >= 2.3.0 | >= 4.2, < 5.3 |
 | 4.3     | 4-3-stable   | >= 2.3.0 | >= 4.2, < 5.3 |
 | 4.2     | 4-2-stable   | >= 2.2.0 | >= 4.2, < 5.3 |
 | 3       | 3-stable     | >= 1.9.3 | >= 3.2, < 5.2 |

data/lib/authlogic/acts_as_authentic/email.rb

@@ -29,6 +29,7 @@ module Authlogic
         # * <tt>Default:</tt> true
         # * <tt>Accepts:</tt> Boolean
         def validate_email_field(value = nil)
+          deprecate_authlogic_config("validate_email_field")
           rw_config(:validate_email_field, value, true)
         end
         alias_method :validate_email_field=, :validate_email_field
@@ -44,6 +45,7 @@ module Authlogic
         # * <tt>Default:</tt> {:maximum => 100}
         # * <tt>Accepts:</tt> Hash of options accepted by validates_length_of
         def validates_length_of_email_field_options(value = nil)
+          deprecate_authlogic_config("validates_length_of_email_field_options")
           rw_config(:validates_length_of_email_field_options, value, maximum: 100)
         end
         alias_method(
@@ -61,6 +63,7 @@ module Authlogic
         #
         #   merge_validates_length_of_email_field_options :my_option => my_value
         def merge_validates_length_of_email_field_options(options = {})
+          deprecate_authlogic_config("merge_validates_length_of_email_field_options")
           self.validates_length_of_email_field_options =
             validates_length_of_email_field_options.merge(options)
         end
@@ -96,6 +99,7 @@ module Authlogic
         #
         # * <tt>Accepts:</tt> Hash of options accepted by validates_format_of
         def validates_format_of_email_field_options(value = nil)
+          deprecate_authlogic_config("validates_format_of_email_field_options")
           rw_config(
             :validates_format_of_email_field_options,
             value,
@@ -116,6 +120,7 @@ module Authlogic
         # See merge_validates_length_of_email_field_options. The same thing
         # except for validates_format_of_email_field_options.
         def merge_validates_format_of_email_field_options(options = {})
+          deprecate_authlogic_config("merge_validates_format_of_email_field_options")
           self.validates_format_of_email_field_options =
             validates_format_of_email_field_options.merge(options)
         end
@@ -139,6 +144,7 @@ module Authlogic
         #
         # * <tt>Accepts:</tt> Hash of options accepted by validates_uniqueness_of
         def validates_uniqueness_of_email_field_options(value = nil)
+          deprecate_authlogic_config("validates_uniqueness_of_email_field_options")
           rw_config(
             :validates_uniqueness_of_email_field_options,
             value,
@@ -155,6 +161,7 @@ module Authlogic
         # See merge_validates_length_of_email_field_options. The same thing
         # except for validates_uniqueness_of_email_field_options.
         def merge_validates_uniqueness_of_email_field_options(options = {})
+          deprecate_authlogic_config("merge_validates_uniqueness_of_email_field_options")
           self.validates_uniqueness_of_email_field_options =
             validates_uniqueness_of_email_field_options.merge(options)
         end

data/lib/authlogic/acts_as_authentic/login.rb

@@ -27,6 +27,7 @@ module Authlogic
         # * <tt>Default:</tt> true
         # * <tt>Accepts:</tt> Boolean
         def validate_login_field(value = nil)
+          deprecate_authlogic_config("validate_login_field")
           rw_config(:validate_login_field, value, true)
         end
         alias_method :validate_login_field=, :validate_login_field
@@ -42,6 +43,7 @@ module Authlogic
         # * <tt>Default:</tt> {:within => 3..100}
         # * <tt>Accepts:</tt> Hash of options accepted by validates_length_of
         def validates_length_of_login_field_options(value = nil)
+          deprecate_authlogic_config("validates_length_of_login_field_options")
           rw_config(:validates_length_of_login_field_options, value, within: 3..100)
         end
         alias_method(
@@ -59,6 +61,7 @@ module Authlogic
         #
         #   merge_validates_length_of_login_field_options :my_option => my_value
         def merge_validates_length_of_login_field_options(options = {})
+          deprecate_authlogic_config("merge_validates_length_of_login_field_options")
           self.validates_length_of_login_field_options =
             validates_length_of_login_field_options.merge(options)
         end
@@ -85,6 +88,7 @@ module Authlogic
         #
         # * <tt>Accepts:</tt> Hash of options accepted by validates_format_of
         def validates_format_of_login_field_options(value = nil)
+          deprecate_authlogic_config("validates_format_of_login_field_options")
           rw_config(
             :validates_format_of_login_field_options,
             value,
@@ -105,6 +109,7 @@ module Authlogic
         # See merge_validates_length_of_login_field_options. The same thing,
         # except for validates_format_of_login_field_options
         def merge_validates_format_of_login_field_options(options = {})
+          deprecate_authlogic_config("merge_validates_format_of_login_field_options")
           self.validates_format_of_login_field_options =
             validates_format_of_login_field_options.merge(options)
         end
@@ -127,6 +132,7 @@ module Authlogic
         #
         # * <tt>Accepts:</tt> Hash of options accepted by validates_uniqueness_of
         def validates_uniqueness_of_login_field_options(value = nil)
+          deprecate_authlogic_config("validates_uniqueness_of_login_field_options")
           rw_config(
             :validates_uniqueness_of_login_field_options,
             value,
@@ -143,6 +149,7 @@ module Authlogic
         # See merge_validates_length_of_login_field_options. The same thing,
         # except for validates_uniqueness_of_login_field_options
         def merge_validates_uniqueness_of_login_field_options(options = {})
+          deprecate_authlogic_config("merge_validates_uniqueness_of_login_field_options")
           self.validates_uniqueness_of_login_field_options =
             validates_uniqueness_of_login_field_options.merge(options)
         end

data/lib/authlogic/acts_as_authentic/password.rb

@@ -98,6 +98,7 @@ module Authlogic
         # * <tt>Default:</tt> true
         # * <tt>Accepts:</tt> Boolean
         def validate_password_field(value = nil)
+          deprecate_authlogic_config("validate_password_field")
           rw_config(:validate_password_field, value, true)
         end
         alias_method :validate_password_field=, :validate_password_field
@@ -113,6 +114,7 @@ module Authlogic
         # * <tt>Default:</tt> {:minimum => 8, :if => :require_password?}
         # * <tt>Accepts:</tt> Hash of options accepted by validates_length_of
         def validates_length_of_password_field_options(value = nil)
+          deprecate_authlogic_config("validates_length_of_password_field_options")
           rw_config(
             :validates_length_of_password_field_options,
             value,
@@ -135,6 +137,9 @@ module Authlogic
         #
         #   merge_validates_length_of_password_field_options :my_option => my_value
         def merge_validates_length_of_password_field_options(options = {})
+          deprecate_authlogic_config(
+            "merge_validates_length_of_password_field_options"
+          )
           self.validates_length_of_password_field_options =
             validates_length_of_password_field_options.merge(options)
         end
@@ -150,6 +155,9 @@ module Authlogic
         # * <tt>Default:</tt> {:if => :require_password?}
         # * <tt>Accepts:</tt> Hash of options accepted by validates_confirmation_of
         def validates_confirmation_of_password_field_options(value = nil)
+          deprecate_authlogic_config(
+            "validates_confirmation_of_password_field_options"
+          )
           rw_config(
             :validates_confirmation_of_password_field_options,
             value,
@@ -162,6 +170,9 @@ module Authlogic
         # See merge_validates_length_of_password_field_options. The same thing, except for
         # validates_confirmation_of_password_field_options
         def merge_validates_confirmation_of_password_field_options(options = {})
+          deprecate_authlogic_config(
+            "merge_validates_confirmation_of_password_field_options"
+          )
           self.validates_confirmation_of_password_field_options =
             validates_confirmation_of_password_field_options.merge(options)
         end
@@ -177,6 +188,9 @@ module Authlogic
         # * <tt>Default:</tt> validates_length_of_password_field_options
         # * <tt>Accepts:</tt> Hash of options accepted by validates_length_of
         def validates_length_of_password_confirmation_field_options(value = nil)
+          deprecate_authlogic_config(
+            "validates_length_of_password_confirmation_field_options"
+          )
           rw_config(
             :validates_length_of_password_confirmation_field_options,
             value,
@@ -191,6 +205,9 @@ module Authlogic
         # See merge_validates_length_of_password_field_options. The same thing, except for
         # validates_length_of_password_confirmation_field_options
         def merge_validates_length_of_password_confirmation_field_options(options = {})
+          deprecate_authlogic_config(
+            "merge_validates_length_of_password_confirmation_field_options"
+          )
           self.validates_length_of_password_confirmation_field_options =
             validates_length_of_password_confirmation_field_options.merge(options)
         end

data/lib/authlogic/acts_as_authentic/validations_scope.rb

@@ -23,6 +23,7 @@ module Authlogic
         # * <tt>Default:</tt> nil
         # * <tt>Accepts:</tt> Symbol or Array of symbols
         def validations_scope(value = nil)
+          deprecate_authlogic_config("validations_scope")
           rw_config(:validations_scope, value)
         end
         alias_method :validations_scope=, :validations_scope

data/lib/authlogic/authenticates_many/base.rb

@@ -19,6 +19,13 @@ module Authlogic
   module AuthenticatesMany
     # These methods become class methods of ::ActiveRecord::Base.
     module Base
+      DPR_AUTH_MANY = <<~EOS.freeze
+        authenticates_many is deprecated without replacement. Let us know
+        if you would like to take over maintenance of this feature as a separate
+        gem. If no one volunteers to extract and maintain a new gem, then this
+        feature will simply be deleted.
+      EOS
+
       # Allows you to set up a relationship with your sessions. See module
       # definition above for more details.
       #
@@ -53,6 +60,7 @@ module Authlogic
       #   `scope_cookies` is misleading. Perhaps simply `scope` or `scoped`
       #   would have been better.
       def authenticates_many(name, options = {})
+        ::ActiveSupport::Deprecation.warn(DPR_AUTH_MANY)
         options[:session_class] ||= name.to_s.classify.constantize
         options[:relationship_name] ||= options[:session_class].klass_name.underscore.pluralize
         class_eval <<-EOS, __FILE__, __LINE__ + 1

data/lib/authlogic/config.rb

@@ -1,5 +1,15 @@
 module Authlogic
   module Config
+    E_USE_NORMAL_RAILS_VALIDATION = <<~EOS.freeze
+      This Authlogic configuration option (%s) is deprecated. Use normal
+      ActiveRecord validations instead. For example, instead of the Authlogic
+      method validates_length_of_email_field_options, you can use
+
+          validates :email, length: { ... }
+
+      These deprecated Authlogic methods will be removed in the next major version.
+    EOS
+
     def self.extended(klass)
       klass.class_eval do
         class_attribute :acts_as_authentic_config
@@ -9,6 +19,12 @@ module Authlogic
 
     private
 
+    def deprecate_authlogic_config(method_name)
+      ::ActiveSupport::Deprecation.warn(
+        format(E_USE_NORMAL_RAILS_VALIDATION, method_name)
+      )
+    end
+
     # This is a one-liner method to write a config setting, read the config
     # setting, and also set a default value for the setting.
     def rw_config(key, value, default_value = nil)

data/lib/authlogic/version.rb

@@ -16,6 +16,6 @@ module Authlogic
   #
   # @api public
   def self.gem_version
-    ::Gem::Version.new("4.3.0")
+    ::Gem::Version.new("4.4.0")
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: authlogic
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 4.4.0
 platform: ruby
 authors:
 - Ben Johnson
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-13 00:00:00.000000000 Z
+date: 2018-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord