authlogic 3.8.0 → 4.0.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: 01513a841f9c0e5be7c9c2f641d0beaa30aef05b76ba736938343901bad249da
+  data.tar.gz: f4e55611a93e2f3d3957bfaf200602217949d857f01a99d05443d94ba1bf6d40
+SHA512:
+  metadata.gz: 84ab5533d3b8e87cffc450b5de009b16537bb52119fd3049df865a39c4fb0e06c82ed0d7678f956569d51f3181fd5d9a7fbd3190dacfa66c2d010e1b2cdcdf19
+  data.tar.gz: a11379da2cf5d69792a7cacc8fe8efdb75e8e42fca2c690941bd9e8410f8fcb1cae9ff2c99affc721151aaa01e5a02802594d487e323063f54de45f80e593933

data/.github/triage.md

@@ -0,0 +1,87 @@
+# Triage
+
+Common responses to issues.
+
+## Usage question we were able to answer
+
+```
+If that doesn't answer your question, please ask a new question 
+on [stackoverflow][1]. Unfortunatley, we just don't have enough volunteers to 
+handle usage questions on github.
+
+Also, please check the [reference documentation][2]. You might find something
+there that's not in the readme.
+
+Thanks!
+
+[1]: http://stackoverflow.com/questions/tagged/authlogic
+[2]: https://github.com/binarylogic/authlogic#1c-reference-documentation
+```
+
+## Old issue, generic
+
+```
+Hello, I'm going through old authlogic issues and seeing what to do with them.
+Skimming through this, it's unclear if it's a usage question, a feature request,
+or a bug report.
+
+If this is a bug report, and you can still reproduce this issue with a clean
+install of the latest version of authlogic and rails (currently 3.6.0 and 5.1.4
+respectively), please create a git repo with a sample app that reproduces the
+problem, and open a new issue.
+
+If this is a feature request, it's still relevant, and you are committed to 
+implementing it, please open a new issue and we can discuss your implementation 
+plan.
+
+If this is a usage question, please ask it on [stackoverflow][1]. Unfortunatley,
+we just don't have enough volunteers to handle usage questions on github. Also,
+please check the [reference documentation][2]. You might find something there
+that's not in the readme.
+
+Thanks!
+
+[1]: http://stackoverflow.com/questions/tagged/authlogic
+[2]: https://github.com/binarylogic/authlogic#1c-reference-documentation
+```
+
+## Old issue, usage question / feature request
+
+```
+Hello, I'm going through old authlogic issues and seeing what to do with them.
+This one looks a bit like a usage question and a bit like a feature request.
+
+If this is a feature request, it's still relevant, and you are committed to 
+implementing it, please open a new issue and we can discuss your implementation 
+plan.
+
+If this is a usage question, please ask it on [stackoverflow][1]. Unfortunatley,
+we just don't have enough volunteers to handle usage questions on github. Also,
+please check the [reference documentation][2]. You might find something there
+that's not in the readme.
+
+Thanks!
+
+[1]: http://stackoverflow.com/questions/tagged/authlogic
+[2]: https://github.com/binarylogic/authlogic#1c-reference-documentation
+```
+
+## Old issue, bug report
+
+```
+Hello, I'm going through old authlogic issues and seeing what to do with them.
+This one looks like a bug report.
+
+If you can still reproduce this issue with a clean install of the latest 
+version of authlogic and rails (currently 3.6.0 and 5.1.4 respectively), please 
+create a git repo with a sample app that reproduces the problem, and open a new 
+issue.
+
+If this was more of a usage question than a bug report, please ask your question 
+on [stackoverflow][1]. Unfortunatley, we just don't have enough volunteers to 
+handle usage questions on github.
+
+Thanks!
+
+[1]: http://stackoverflow.com/questions/tagged/authlogic 
+```

data/.gitignore

@@ -11,4 +11,5 @@ test/gemfiles/Gemfile*.lock
 .bundle
 Gemfile.lock
 .ruby-gemset
-.ruby-version
+.ruby-version
+.byebug_history

data/.rubocop.yml

@@ -4,11 +4,7 @@ AllCops:
   # You can run the authlogic test suite with any supported version of MRI, but the
   # linter will only care about this `TargetRubyVersion`. This should be set to the
   # lowest version of MRI that authlogic supports.
-  TargetRubyVersion: 1.9
-
-# Compared to metrics like AbcSize, MethodLength has questionable value.
-Metrics/MethodLength:
-  Enabled: false
+  TargetRubyVersion: 2.1
 
 # Please use normal indentation when aligning parameters.
 #
@@ -29,5 +25,65 @@ Metrics/MethodLength:
 #                 b)
 #
 # The latter is harder to maintain and uses too much horizontal space.
-Style/AlignParameters:
+Layout/AlignParameters:
   EnforcedStyle: with_fixed_indentation
+
+# This project uses rails-style method indentation, ie. indent after `private`.
+Layout/IndentationConsistency:
+  EnforcedStyle: rails
+
+Layout/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+# Questionable value compared to metrics like AbcSize or CyclomaticComplexity.
+Metrics/BlockLength:
+  Enabled: false
+
+# Questionable value compared to metrics like AbcSize or CyclomaticComplexity.
+Metrics/ClassLength:
+  Enabled: false
+
+# Questionable value compared to metrics like AbcSize or CyclomaticComplexity.
+Metrics/MethodLength:
+  Enabled: false
+
+# Questionable value compared to metrics like AbcSize or CyclomaticComplexity.
+Metrics/ModuleLength:
+  Enabled: false
+
+# Sometimes prefixing a method name with get_ or set_ is a reasonable choice.
+Naming/AccessorMethodName:
+  Enabled: false
+
+# Having a consistent delimiter, like EOS, improves reading speed. The delimiter
+# is syntactic noise, just like a quotation mark, and inconsistent naming would
+# hurt reading speed, just as inconsistent quoting would.
+Naming/HeredocDelimiterNaming:
+  Enabled: false
+
+# Avoid single-line method definitions.
+Style/EmptyMethod:
+  EnforcedStyle: expanded
+
+# Too subtle to lint. Guard clauses are great, use them if they help.
+Style/GuardClause:
+  Enabled: false
+
+# Too subtle to lint. A multi-line conditional may improve readability, even if
+# a postfix conditional would satisfy `Metrics/LineLength`.
+Style/IfUnlessModifier:
+  Enabled: false
+
+# Too subtle to lint. Use semantic style, but prefer `}.x` over `end.x`.
+Style/BlockDelimiters:
+  Enabled: false
+
+# Use the nested style because it is safer. It is easier to make mistakes with
+# the compact style.
+Style/ClassAndModuleChildren:
+  EnforcedStyle: nested
+
+# Both `module_function` and `extend_self` are legitimate. Most importantly,
+# they are different (http://bit.ly/2hSQAGm)
+Style/ModuleFunction:
+  Enabled: false

data/.rubocop_todo.yml

@@ -1,323 +1,90 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-07-18 00:47:31 -0400 using RuboCop version 0.41.2.
+# on 2017-11-08 17:51:32 -0500 using RuboCop version 0.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-Lint/AmbiguousOperator:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/password.rb'
-    - 'lib/authlogic/session/callbacks.rb'
-
-# Configuration parameters: AllowSafeAssignment.
-Lint/AssignmentInCondition:
-  Exclude:
-    - 'lib/authlogic/test_case/mock_cookie_jar.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: AlignWith, SupportedStyles.
-# SupportedStyles: either, start_of_block, start_of_line
-Lint/BlockAlignment:
-  Exclude:
-    - 'lib/authlogic.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
-# SupportedStyles: keyword, variable, start_of_line
-Lint/EndAlignment:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/login.rb'
-    - 'lib/authlogic/session/scopes.rb'
-
-Lint/Loop:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/persistence_token.rb'
-
-Lint/ShadowingOuterLocalVariable:
-  Exclude:
-    - 'lib/authlogic/session/cookies.rb'
-    - 'lib/authlogic/session/password.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
-Lint/UnusedBlockArgument:
-  Exclude:
-    - 'lib/authlogic/crypto_providers/wordpress.rb'
-    - 'lib/authlogic/random.rb'
-    - 'lib/authlogic/session/callbacks.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
-Lint/UnusedMethodArgument:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/base.rb'
-    - 'lib/authlogic/acts_as_authentic/password.rb'
-    - 'lib/authlogic/session/activation.rb'
-    - 'lib/authlogic/session/active_record_trickery.rb'
-    - 'lib/authlogic/session/existence.rb'
-    - 'lib/authlogic/session/scopes.rb'
-    - 'lib/authlogic/test_case/mock_controller.rb'
-    - 'lib/authlogic/test_case/mock_cookie_jar.rb'
-    - 'test/i18n_test.rb'
-    - 'test/test_helper.rb'
-
-Lint/UselessAccessModifier:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/password.rb'
-
+# Offense count: 58
 Metrics/AbcSize:
-  Max: 82
-
-Metrics/ClassLength:
-  Enabled: false
+  Max: 43
 
+# Offense count: 4
 Metrics/CyclomaticComplexity:
-  Max: 12
+  Max: 8
 
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# Offense count: 579
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
-  Max: 130
-
-Metrics/ModuleLength:
-  Enabled: false
+  Max: 110
 
+# Offense count: 3
 Metrics/PerceivedComplexity:
-  Max: 13
-
-# Cop supports --auto-correct.
-Performance/RedundantBlockCall:
-  Exclude:
-    - 'lib/authlogic/controller_adapters/abstract_adapter.rb'
-
-Style/AccessorMethodName:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/session_maintenance.rb'
-    - 'test/test_helper.rb'
+  Max: 8
 
+# Offense count: 60
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: prefer_alias, prefer_alias_method
 Style/Alias:
   Enabled: false
 
-# Cop supports --auto-correct.
-Style/AlignArray:
-  Exclude:
-    - 'test/acts_as_authentic_test/email_test.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: always, conditionals
-Style/AndOr:
-  Exclude:
-    - 'lib/authlogic/controller_adapters/abstract_adapter.rb'
-    - 'test/acts_as_authentic_test/password_test.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
-# SupportedStyles: line_count_based, semantic, braces_for_chaining
-# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
-# FunctionalMethods: let, let!, subject, watch
-# IgnoredMethods: lambda, proc, it
-Style/BlockDelimiters:
-  Exclude:
-    - 'test/config_test.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: braces, no_braces, context_dependent
-Style/BracesAroundHashParameters:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/email.rb'
-    - 'lib/authlogic/acts_as_authentic/login.rb'
-    - 'lib/authlogic/acts_as_authentic/password.rb'
-    - 'lib/authlogic/session/active_record_trickery.rb'
-    - 'test/acts_as_authentic_test/email_test.rb'
-    - 'test/acts_as_authentic_test/login_test.rb'
-
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: nested, compact
-Style/ClassAndModuleChildren:
-  Exclude:
-    - 'test/test_helper.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: is_a?, kind_of?
-Style/ClassCheck:
-  Exclude:
-    - 'test/acts_as_authentic_test/email_test.rb'
-
+# Offense count: 5
 Style/ClassVars:
   Exclude:
     - 'lib/authlogic/i18n.rb'
 
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
-# SupportedStyles: assign_to_condition, assign_inside_condition
-Style/ConditionalAssignment:
-  Enabled: false
-
-Style/ConstantName:
-  Exclude:
-    - 'lib/authlogic/random.rb'
-
+# Offense count: 31
 Style/Documentation:
   Enabled: false
 
-# Cop supports --auto-correct.
-Style/ElseAlignment:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/login.rb'
-    - 'lib/authlogic/session/scopes.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: empty, nil, both
-Style/EmptyElse:
-  Exclude:
-    - 'lib/authlogic/session/persistence.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
-Style/ExtraSpacing:
-  Exclude:
-    - 'test/acts_as_authentic_test/email_test.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
-# SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
-Style/FirstParameterIndentation:
-  Exclude:
-    - 'lib/authlogic/session/brute_force_protection.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: when_needed, always
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, ruby19_no_mixed_keys, hash_rockets
-Style/HashSyntax:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: MaxLineLength.
-Style/IfUnlessModifier:
+# Offense count: 4
+Style/MethodMissing:
   Exclude:
-    - 'test/test_helper.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_brackets
-Style/IndentArray:
-  Exclude:
-    - 'lib/authlogic.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: IndentationWidth.
-Style/IndentAssignment:
-  Exclude:
-    - 'lib/authlogic/session/password.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: normal, rails
-Style/IndentationConsistency:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: Width.
-Style/IndentationWidth:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/login.rb'
-    - 'lib/authlogic/session/scopes.rb'
-    - 'test/session_test/callbacks_test.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: line_count_dependent, lambda, literal
-Style/Lambda:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/logged_in_status.rb'
-
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: module_function, extend_self
-Style/ModuleFunction:
-  Exclude:
-    - 'lib/authlogic/random.rb'
-
-Style/MultilineOperationIndentation:
-  Enabled: false
-
-Style/MultilineTernaryOperator:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/password.rb'
-    - 'lib/authlogic/session/password.rb'
-    - 'lib/authlogic/session/session.rb'
-
-# Cop supports --auto-correct.
-Style/MutableConstant:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/password.rb'
-    - 'lib/authlogic/crypto_providers/scrypt.rb'
-    - 'lib/authlogic/crypto_providers/wordpress.rb'
-    - 'lib/authlogic/session/callbacks.rb'
-    - 'test/acts_as_authentic_test/email_test.rb'
-    - 'test/acts_as_authentic_test/logged_in_status_test.rb'
+    - 'lib/authlogic/controller_adapters/abstract_adapter.rb'
+    - 'lib/authlogic/controller_adapters/sinatra_adapter.rb'
+    - 'lib/authlogic/test_case/mock_request.rb'
 
-# Cop supports --auto-correct.
-Style/NegatedIf:
+# Offense count: 1
+Style/MixinUsage:
   Exclude:
     - 'lib/authlogic/acts_as_authentic/base.rb'
-    - 'lib/authlogic/acts_as_authentic/logged_in_status.rb'
-    - 'lib/authlogic/acts_as_authentic/perishable_token.rb'
-    - 'lib/authlogic/acts_as_authentic/restful_authentication.rb'
-    - 'lib/authlogic/acts_as_authentic/single_access_token.rb'
-    - 'lib/authlogic/session/active_record_trickery.rb'
-    - 'lib/authlogic/session/cookies.rb'
-    - 'lib/authlogic/session/klass.rb'
-    - 'lib/authlogic/session/params.rb'
-    - 'lib/authlogic/session/password.rb'
-    - 'lib/authlogic/session/persistence.rb'
 
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
 # SupportedStyles: skip_modifier_ifs, always
 Style/Next:
-  Enabled: false
+  Exclude:
+    - 'lib/authlogic/acts_as_authentic/password.rb'
+    - 'lib/authlogic/session/magic_states.rb'
 
+# Offense count: 1
 # Cop supports --auto-correct.
 Style/Not:
   Exclude:
     - 'lib/authlogic/acts_as_authentic/login.rb'
 
+# Offense count: 2
 # Cop supports --auto-correct.
-Style/ParallelAssignment:
+# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
   Exclude:
-    - 'test/random_test.rb'
+    - 'spec/**/*'
+    - 'lib/authlogic/acts_as_authentic/password.rb'
+    - 'lib/authlogic/session/brute_force_protection.rb'
 
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: AllowSafeAssignment.
 Style/ParenthesesAroundCondition:
   Exclude:
     - 'test/test_helper.rb'
 
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'authlogic.gemspec'
-
+# Offense count: 3
 # Cop supports --auto-correct.
 Style/Proc:
   Exclude:
@@ -325,12 +92,14 @@ Style/Proc:
     - 'lib/authlogic/session/http_auth.rb'
     - 'test/acts_as_authentic_test/email_test.rb'
 
+# Offense count: 7
 # Cop supports --auto-correct.
 # Configuration parameters: SupportedStyles.
 # SupportedStyles: compact, exploded
 Style/RaiseArgs:
   EnforcedStyle: compact
 
+# Offense count: 3
 # Cop supports --auto-correct.
 Style/RedundantBegin:
   Exclude:
@@ -338,6 +107,7 @@ Style/RedundantBegin:
     - 'lib/authlogic/crypto_providers/bcrypt.rb'
     - 'lib/authlogic/crypto_providers/scrypt.rb'
 
+# Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleReturnValues.
 Style/RedundantReturn:
@@ -345,6 +115,7 @@ Style/RedundantReturn:
     - 'lib/authlogic/acts_as_authentic/session_maintenance.rb'
     - 'test/libs/user_session.rb'
 
+# Offense count: 3
 # Cop supports --auto-correct.
 Style/RedundantSelf:
   Exclude:
@@ -352,23 +123,27 @@ Style/RedundantSelf:
     - 'lib/authlogic/acts_as_authentic/restful_authentication.rb'
     - 'lib/authlogic/controller_adapters/rack_adapter.rb'
 
+# Offense count: 1
 # Cop supports --auto-correct.
 Style/RescueModifier:
   Exclude:
     - 'lib/authlogic/acts_as_authentic/session_maintenance.rb'
 
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: SupportedStyles.
 # SupportedStyles: use_perl_names, use_english_names
 Style/SpecialGlobalVars:
   EnforcedStyle: use_perl_names
 
+# Offense count: 507
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Enabled: false
 
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: single_quotes, double_quotes
@@ -377,6 +152,14 @@ Style/StringLiteralsInInterpolation:
     - 'lib/authlogic/authenticates_many/base.rb'
     - 'lib/authlogic/session/foundation.rb'
 
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: MinSize, SupportedStyles.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoredMethods.
 # IgnoredMethods: respond_to, define_method
@@ -384,6 +167,7 @@ Style/SymbolProc:
   Exclude:
     - 'lib/authlogic/acts_as_authentic/persistence_token.rb'
 
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: SupportedStyles, MinSize, WordRegex.
 # SupportedStyles: percent, brackets