authenticate 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 880f3ddf3bf73620d2ad00b9fa97961e0b9572cb
-  data.tar.gz: 6f8552c11692b6ed41b86bc11d9ad325c54a3b63
+  metadata.gz: e7228f6e2ad7a6120f39b3a4af880c800bbed56b
+  data.tar.gz: 777e5b64fbd3ce703579d50c69283c0d661596ae
 SHA512:
-  metadata.gz: f8ed33e95016c51092e3b082d51d04c8ab0787cf1f4d98d03a3aafe9f70aaef320beb5acc2653932053970c55c14db0b2d0cacd6deb7f6d26ec882564b113ed6
-  data.tar.gz: 401d92cb7b48b1ce32c961c42901ff20ae586648d1e266b9d0f954a76fb6449a057d12a34fdb52a6e5e9f590297f39cf7a9a93d0b1eca340f6adfb1a57192cba
+  metadata.gz: 61e7ac6c14efb4722861c3cc95bdb49d09732dd674bec1a44dd8070a1a4dbe6bb7aae1f93dcc0034c78ad62369b508b38e96b0ca8d7549aa70cebc30bd3e90fc
+  data.tar.gz: c4ec2869d1c4aa5b108655533d6151ed5539d72a1a7efd8d4cc6213aa58f2c0a17af04e5c4f1b97cc2d2fe569c4149419f2d3973af10220c87ccc415c0c8d997

data/.codeclimate.yml

@@ -0,0 +1,38 @@
+---
+engines:
+  brakeman:
+    enabled: true
+  bundler-audit:
+    enabled: true
+  duplication:
+    enabled: true
+    exclude_fingerprints:
+    - 120bdc2114c46391e7ad73ea4a10b314
+    - 339cd5bbb9922a29a82aaf5f3d727deb
+    config:
+      languages:
+      - ruby
+      - javascript
+      - python
+      - php
+  fixme:
+    enabled: true
+  rubocop:
+    enabled: true
+ratings:
+  paths:
+  - Gemfile.lock
+  - "**.erb"
+  - "**.haml"
+  - "**.rb"
+  - "**.rhtml"
+  - "**.slim"
+  - "**.inc"
+  - "**.js"
+  - "**.jsx"
+  - "**.module"
+  - "**.php"
+  - "**.py"
+exclude_paths:
+- config/
+- spec/

data/CHANGELOG.md

@@ -1,10 +1,24 @@
 # Authenticate Changelog
 
+## [0.3.3] - April 29, 2016
+
+Password change uses active record's dirty bit to detect that password was updated. 
+password_updated attribute removed.
+spec_helper now calls ActiveRecord::Migration.maintain_test_schema! (or check_pending!) to handle dummy test db.
+Added CodeClimate config.
+
+[0.3.3]: https://github.com/tomichj/authenticate/compare/v0.3.2...v0.3.3
+
+
+
 ## [0.3.2] - April 28, 2016
 
 Error now raised if User model is missing required attributes.
 All code now conforms to a rubocode profile.
 
+[0.3.2]: https://github.com/tomichj/authenticate/compare/v0.3.1...v0.3.2
+
+
 
 ## [0.3.1] - March 10, 2016
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    authenticate (0.3.1)
+    authenticate (0.3.2)
       bcrypt (~> 3.1)
       email_validator (~> 1.6)
       rails (>= 4.0, < 5.1)
@@ -9,36 +9,36 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actionmailer (4.2.5)
-      actionpack (= 4.2.5)
-      actionview (= 4.2.5)
-      activejob (= 4.2.5)
+    actionmailer (4.2.6)
+      actionpack (= 4.2.6)
+      actionview (= 4.2.6)
+      activejob (= 4.2.6)
       mail (~> 2.5, >= 2.5.4)
       rails-dom-testing (~> 1.0, >= 1.0.5)
-    actionpack (4.2.5)
-      actionview (= 4.2.5)
-      activesupport (= 4.2.5)
+    actionpack (4.2.6)
+      actionview (= 4.2.6)
+      activesupport (= 4.2.6)
       rack (~> 1.6)
       rack-test (~> 0.6.2)
       rails-dom-testing (~> 1.0, >= 1.0.5)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (4.2.5)
-      activesupport (= 4.2.5)
+    actionview (4.2.6)
+      activesupport (= 4.2.6)
       builder (~> 3.1)
       erubis (~> 2.7.0)
       rails-dom-testing (~> 1.0, >= 1.0.5)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    activejob (4.2.5)
-      activesupport (= 4.2.5)
+    activejob (4.2.6)
+      activesupport (= 4.2.6)
       globalid (>= 0.3.0)
-    activemodel (4.2.5)
-      activesupport (= 4.2.5)
+    activemodel (4.2.6)
+      activesupport (= 4.2.6)
       builder (~> 3.1)
-    activerecord (4.2.5)
-      activemodel (= 4.2.5)
-      activesupport (= 4.2.5)
+    activerecord (4.2.6)
+      activemodel (= 4.2.6)
+      activesupport (= 4.2.6)
       arel (~> 6.0)
-    activesupport (4.2.5)
+    activesupport (4.2.6)
       i18n (~> 0.7)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
@@ -46,23 +46,23 @@ GEM
       tzinfo (~> 1.1)
     addressable (2.4.0)
     arel (6.0.3)
-    bcrypt (3.1.10)
+    bcrypt (3.1.11)
     builder (3.2.2)
-    capybara (2.6.2)
+    capybara (2.7.0)
       addressable
       mime-types (>= 1.16)
       nokogiri (>= 1.3.3)
       rack (>= 1.0.0)
       rack-test (>= 0.5.4)
       xpath (~> 2.0)
-    coderay (1.1.0)
+    coderay (1.1.1)
     concurrent-ruby (1.0.1)
-    database_cleaner (1.5.1)
+    database_cleaner (1.5.3)
     diff-lcs (1.2.5)
     email_validator (1.6.0)
       activemodel
     erubis (2.7.0)
-    factory_girl (4.4.0)
+    factory_girl (4.7.0)
       activesupport (>= 3.0.0)
     globalid (0.3.6)
       activesupport (>= 4.1.0)
@@ -70,13 +70,15 @@ GEM
     json (1.8.3)
     loofah (2.0.3)
       nokogiri (>= 1.5.9)
-    mail (2.6.3)
-      mime-types (>= 1.16, < 3)
+    mail (2.6.4)
+      mime-types (>= 1.16, < 4)
     method_source (0.8.2)
-    mime-types (2.99)
+    mime-types (3.0)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2016.0221)
     mini_portile2 (2.0.0)
-    minitest (5.8.3)
-    nokogiri (1.6.7.1)
+    minitest (5.8.4)
+    nokogiri (1.6.7.2)
       mini_portile2 (~> 2.0.0.rc2)
     pry (0.10.3)
       coderay (~> 1.1.0)
@@ -85,16 +87,16 @@ GEM
     rack (1.6.4)
     rack-test (0.6.3)
       rack (>= 1.0)
-    rails (4.2.5)
-      actionmailer (= 4.2.5)
-      actionpack (= 4.2.5)
-      actionview (= 4.2.5)
-      activejob (= 4.2.5)
-      activemodel (= 4.2.5)
-      activerecord (= 4.2.5)
-      activesupport (= 4.2.5)
+    rails (4.2.6)
+      actionmailer (= 4.2.6)
+      actionpack (= 4.2.6)
+      actionview (= 4.2.6)
+      activejob (= 4.2.6)
+      activemodel (= 4.2.6)
+      activerecord (= 4.2.6)
+      activesupport (= 4.2.6)
       bundler (>= 1.3.0, < 2.0)
-      railties (= 4.2.5)
+      railties (= 4.2.6)
       sprockets-rails
     rails-deprecated_sanitizer (1.0.3)
       activesupport (>= 4.2.0.alpha)
@@ -102,34 +104,35 @@ GEM
       activesupport (>= 4.2.0.beta, < 5.0)
       nokogiri (~> 1.6.0)
       rails-deprecated_sanitizer (>= 1.0.1)
-    rails-html-sanitizer (1.0.2)
+    rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
-    railties (4.2.5)
-      actionpack (= 4.2.5)
-      activesupport (= 4.2.5)
+    railties (4.2.6)
+      actionpack (= 4.2.6)
+      activesupport (= 4.2.6)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
-    rake (10.4.2)
-    rspec-core (3.1.7)
-      rspec-support (~> 3.1.0)
-    rspec-expectations (3.1.2)
+    rake (11.1.2)
+    rspec-core (3.4.4)
+      rspec-support (~> 3.4.0)
+    rspec-expectations (3.4.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.1.0)
-    rspec-mocks (3.1.3)
-      rspec-support (~> 3.1.0)
-    rspec-rails (3.1.0)
-      actionpack (>= 3.0)
-      activesupport (>= 3.0)
-      railties (>= 3.0)
-      rspec-core (~> 3.1.0)
-      rspec-expectations (~> 3.1.0)
-      rspec-mocks (~> 3.1.0)
-      rspec-support (~> 3.1.0)
-    rspec-support (3.1.2)
+      rspec-support (~> 3.4.0)
+    rspec-mocks (3.4.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-rails (3.4.2)
+      actionpack (>= 3.0, < 4.3)
+      activesupport (>= 3.0, < 4.3)
+      railties (>= 3.0, < 4.3)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+      rspec-support (~> 3.4.0)
+    rspec-support (3.4.1)
     shoulda-matchers (2.8.0)
       activesupport (>= 3.0.0)
     slop (3.6.0)
-    sprockets (3.5.2)
+    sprockets (3.6.0)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
     sprockets-rails (3.0.4)
@@ -139,7 +142,7 @@ GEM
     sqlite3 (1.3.11)
     thor (0.19.1)
     thread_safe (0.3.5)
-    timecop (0.8.0)
+    timecop (0.8.1)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
     xpath (2.0.0)

data/lib/authenticate/model/db_password.rb

@@ -33,7 +33,6 @@ module Authenticate
         private_class_method :crypto_provider
         include crypto_provider
         attr_reader :password
-        attr_accessor :password_changing
         validates :password,
                   presence: true,
                   length: { in: password_length },
@@ -46,7 +45,7 @@ module Authenticate
 
       def password=(new_password)
         @password = new_password
-        self.encrypted_password = encrypt(new_password) if new_password.present?
+        self.encrypted_password = encrypt(new_password) unless new_password.nil?
       end
 
       private
@@ -65,7 +64,7 @@ module Authenticate
 
       # If we already have an encrypted password and it's not changing, skip the validation.
       def skip_password_validation?
-        encrypted_password.present? && !password_changing
+        encrypted_password.present? && !encrypted_password_changed?
       end
     end
   end

data/lib/authenticate/model/password_reset.rb

@@ -31,15 +31,11 @@ module Authenticate
       # @return [Boolean] Was the save successful?
       def update_password(new_password)
         return false unless reset_password_period_valid?
-
-        self.password_changing = true
         self.password = new_password
-
         if valid?
           clear_reset_password_token
           generate_session_token
         end
-
         save
       end
 

data/lib/authenticate/session.rb

@@ -46,7 +46,7 @@ module Authenticate
     # @return [User]
     def current_user
       debug 'session.current_user'
-      @current_user ||= load_user if @session_token.present?
+      @current_user ||= load_user_from_session_token if @session_token.present?
       @current_user
     end
 
@@ -97,7 +97,7 @@ module Authenticate
       Authenticate.configuration.cookie_name.freeze.to_sym
     end
 
-    def load_user
+    def load_user_from_session_token
       Authenticate.configuration.user_model_class.where(session_token: @session_token).first
     end
   end

data/lib/authenticate/version.rb

@@ -1,3 +1,3 @@
 module Authenticate
-  VERSION = '0.3.2'.freeze
+  VERSION = '0.3.3'.freeze
 end

data/spec/model/db_password_spec.rb

@@ -33,14 +33,12 @@ describe Authenticate::Model::DbPassword do
         it 'should be not be valid with a short password' do
           user = build(:user)
           user.password = 'short'
-          user.password_changing = true
           expect(user).to_not be_valid
         end
 
         it 'is valid with a long password' do
           user = build(:user)
           user.password = 'thisisalongpassword'
-          user.password_changing = true
           expect(user).to be_valid
         end
       end
@@ -52,13 +50,11 @@ describe Authenticate::Model::DbPassword do
 
         it 'should not be valid with an empty password' do
           subject.password = ''
-          subject.password_changing = true
           expect(subject).to_not be_valid
         end
 
         it 'should be valid with a new (valid) password' do
           subject.password = 'new password'
-          subject.password_changing = true
           expect(subject).to be_valid
         end
       end

data/spec/spec_helper.rb

@@ -20,6 +20,13 @@ DatabaseCleaner.strategy = :truncation
 # Load factory girl factories.
 Dir[File.join(File.dirname(__FILE__), 'factories/**/*.rb')].each { |f| require f }
 
+# Build test database in spec/dummy/db/
+if defined?(ActiveRecord::Migration.maintain_test_schema!)
+  ActiveRecord::Migration.maintain_test_schema! # rails 4.1+
+else
+  ActiveRecord::Migration.check_pending! # rails 4.0
+end
+
 RSpec.configure do |config|
   config.include FactoryGirl::Syntax::Methods
   config.infer_spec_type_from_file_location!

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: authenticate
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Justin Tomich
@@ -180,6 +180,7 @@ extra_rdoc_files:
 - README.md
 - CHANGELOG.md
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -296,13 +297,11 @@ files:
 - spec/dummy/config/locales/en.yml
 - spec/dummy/config/routes.rb
 - spec/dummy/config/secrets.yml
-- spec/dummy/db/development.sqlite3
 - spec/dummy/db/migrate/20160130192728_create_users.rb
 - spec/dummy/db/migrate/20160130192729_add_authenticate_brute_force_to_users.rb
 - spec/dummy/db/migrate/20160130192730_add_authenticate_timeoutable_to_users.rb
 - spec/dummy/db/migrate/20160130192731_add_authenticate_password_reset_to_users.rb
 - spec/dummy/db/schema.rb
-- spec/dummy/db/test.sqlite3
 - spec/dummy/lib/assets/.keep
 - spec/dummy/log/.keep
 - spec/dummy/public/404.html