auth_strategist 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 07d66deb03bf384671d5622aee616fd13adb2897
-  data.tar.gz: e3f3e66267fbf073375ed49bd396636c692826b9
+SHA256:
+  metadata.gz: 5618d9f7fb8c6c8992f89206742c72649013a408ea63fc0b7a8dad63f1726f9c
+  data.tar.gz: 994ab4e70f2f184b163e6082553bfa88da26de82ffb7bce4800733fab5b8e35c
 SHA512:
-  metadata.gz: 51d781f1d8e9e8e464f33b0961316f161aba8872da8b9955d512db56daaa5f1910729260356f586d50c34f14b99d3fd48fc1655a687b5d874be9d242cbde8080
-  data.tar.gz: 6bed7d0bd697858927e38bd1ae1eae45ef154d2b59fe13ee0cd1cda44745e5b85a9a5a0b0e632dadb293713996b1e57c893a44e64bf861ea4dd2593ef4458857
+  metadata.gz: db8966f7cc51e57fc573528f3b99a260b0b61cbddfe79a07f64316c865e5a11a2c393b3bdc74b05d85f7bfbf09361f5e5914722ce8a5d020bd89f936a93094c4
+  data.tar.gz: a5220e01c51d35a7c89efa402f8923a6936e3befe2fd3e3d07be9a7beaddf82d5f9fbd8fa4179be5715cc738a33432f0865364262cbacc79b4a99f3e7459d45d

data/.rubocop.yml

@@ -1,17 +1,20 @@
-Metrics/AbcSize:
+Metrics/BlockLength:
   Exclude:
-    - './lib/auth_strategist/strategy_interface.rb'
+    - spec/**/*
 
 Metrics/MethodLength:
   Max: 15
-  Exclude:
-    - './lib/auth_strategist/strategy_interface.rb'
 
 Metrics/LineLength:
   Max: 100
+  Exclude:
+    - spec/**/*
 
 Style/Documentation:
   Enabled: false
 
 Style/SignalException:
   EnforcedStyle: only_raise
+
+Style/DoubleNegation:
+  Enabled: false

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in auth_strategist.gemspec

data/README.md

@@ -1,9 +1,7 @@
 [gem]: https://github.com/buszu/auth_strategist
-[codeclimate]: https://codeclimate.com/github/buszu/auth_strategist/
 
 AuthStrategist
 ======
-[![Code Climate](https://codeclimate.com/github/buszu/auth_strategist/badges/gpa.svg)](https://codeclimate.com/github/buszu/auth_strategist)
 [![Gem Version](https://badge.fury.io/rb/auth_strategist.svg)](http://badge.fury.io/rb/auth_strategist)
 
 AuthStrategist is a simple gem to define and use authorization strategies.
@@ -22,28 +20,14 @@ Generate initializer if using Rails:
 
     $ rails g auth_strategist:install
 
-Or install it yourself as:
-
-    $ gem install auth_strategist
-
 ## Configuration
 
 ```ruby
 AuthStrategist.configure do |c|
-  # Set default strategy components (its attributes).
-  # Optional and empty by default.
-  c.default_strategy_components = [:application, :ref]
-
-  # Set strategies directory
+  # Set strategies directory and load them
   # Required if strategies files are not already loaded
   c.strategies_path = 'lib/auth_strategist/strategies'
-
-  # Register your strategies
-  # Required for each strategy you have defined
-  c.strategies do |s|
-    # E.g. OwnershipAuthStrategy will be available under :ownership key
-    s.ownership = OwnershipAuthStrategy
-  end
+  c.load_strategies!
 end
 ```
 
@@ -57,32 +41,19 @@ class OwnershipAuthStrategy
 
   define_components :user, :item
 
-  def authorize!
-    raise unauthorized if item.user_id != user.id
+  def authorized?
+    item.user_id != user.id
   end
 end
 ```
 * Register it
 ```ruby
   AuthStrategist.strategies do |s|
-    s.ownership = OwnershipAuthStrategy
+    s.register :ownership, OwnershipAuthStrategy
   end
 ```
-or
-```ruby
-AuthStrategist.configure do |c|
-  c.strategies do |s|
-    s.ownership = OwnershipAuthStrategy
-  end
-end
-```
+
 ### Using strategies
-* Using strategy by calling authorization Service Object
-```ruby
-AuthStrategist::Authorize.call strategy: :ownership,
-                               user: current_user,
-                               item: book
-```
 * Using strategy with authorize! method
 ```ruby
 class SomethingsController < ApplicationController

data/Rakefile

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'

data/auth_strategist.gemspec

@@ -1,6 +1,6 @@
-# coding: utf-8
+# frozen_string_literal: true
 
-$LOAD_PATH.push File.expand_path('../lib', __FILE__)
+$LOAD_PATH.push File.expand_path('lib', __dir__)
 
 require 'auth_strategist/version'
 
@@ -18,8 +18,12 @@ Gem::Specification.new do |s|
   s.test_files    = `git ls-files -- spec/*`.split("\n")
   s.require_paths = ['lib']
 
-  s.add_development_dependency 'bundler', '~> 1.9'
-  s.add_development_dependency 'factory_girl'
-  s.add_development_dependency 'rake', '~> 10.0'
+  s.add_dependency 'dry-container', '~> 0.7'
+  s.add_dependency 'dry-initializer', '~> 3.0'
+
+  s.add_development_dependency 'bundler'
+  s.add_development_dependency 'rake'
+  s.add_development_dependency 'rspec'
   s.add_development_dependency 'rspec-its'
+  s.add_development_dependency 'rubocop'
 end

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'auth_strategist'

data/lib/auth_strategist.rb

@@ -1,9 +1,15 @@
+# frozen_string_literal: true
+
+require 'dry-initializer'
+require 'dry-container'
+
 require 'auth_strategist/version'
 require 'auth_strategist/configuration'
-require 'auth_strategist/configuration/strategies_registry'
+require 'auth_strategist/registry'
 require 'auth_strategist/errors/unauthorized'
+require 'auth_strategist/errors/authorized_not_implemented'
 require 'auth_strategist/strategy_interface'
-require 'auth_strategist/authorize'
+require 'auth_strategist/build_strategy'
 require 'auth_strategist/authorization'
 
 module AuthStrategist
@@ -18,8 +24,8 @@ module AuthStrategist
     end
 
     def strategies
-      return configuration.strategies unless block_given?
-      yield(configuration.strategies)
+      yield(Registry) if block_given?
+      Registry
     end
   end
 end

data/lib/auth_strategist/authorization.rb

@@ -1,17 +1,15 @@
+# frozen_string_literal: true
+
 module AuthStrategist
   module Authorization
-    def self.included(base)
-      base.class_eval do
-        def authorize!(options = {})
-          authorization_service.call(options)
-        end
-
-        private
+    def authorize!(options = {})
+      strategy = AuthStrategist::BuildStrategy.call(options)
+      strategy.authorize!
+    end
 
-        def authorization_service
-          AuthStrategist::Authorize
-        end
-      end
+    def can?(options = {})
+      strategy = AuthStrategist::BuildStrategy.call(options)
+      strategy.authorized?
     end
   end
 end

data/lib/auth_strategist/build_strategy.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module AuthStrategist
+  class BuildStrategy
+    def self.call(params = {})
+      new.call(params)
+    end
+
+    def call(params = {})
+      choose_strategy(params)
+    end
+
+    private
+
+    attr_reader :strategy
+
+    def choose_strategy(params = {})
+      strategy_key = params[:strategy]
+      raise(strategy_key_nil) if strategy_key.nil?
+
+      strategy_class = begin
+                         strategies.resolve(strategy_key)
+                       rescue StandardError
+                         nil
+                       end
+
+      raise(strategy_not_found(strategy_key)) if strategy_class.nil?
+
+      strategy_params = params.dup.tap { |h| h.delete(:strategy) }
+      strategy_class.new(strategy_params)
+    end
+
+    def strategies
+      AuthStrategist.strategies
+    end
+
+    def strategy_not_found(strategy_key)
+      StandardError.new("Strategy '#{strategy_key}' was not found.")
+    end
+
+    def strategy_key_nil
+      StandardError.new(':strategy option must not be nil.')
+    end
+  end
+end

data/lib/auth_strategist/configuration.rb

@@ -1,27 +1,11 @@
+# frozen_string_literal: true
+
 module AuthStrategist
   class Configuration
-    attr_accessor :default_strategy_components, :strategies_path
-
-    def initialize
-      @default_strategy_components = []
-      @strategies = strategies_registry_class.new
-    end
-
-    def strategies
-      return @strategies unless block_given?
-
-      load_strategies
-      yield(@strategies)
-    end
-
-    private
-
-    def load_strategies
-      Dir["./#{strategies_path}/*.rb"].each { |file| require file } if strategies_path
-    end
+    attr_accessor :strategies_path
 
-    def strategies_registry_class
-      self.class::StrategiesRegistry
+    def load_strategies!
+      Dir["./#{strategies_path}/**/*.rb"].each { |file| require(file) } if strategies_path
     end
   end
 end

data/lib/auth_strategist/errors/authorized_not_implemented.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module AuthStrategist
+  module Errors
+    class AuthorizedNotImplemented < StandardError
+      def initialize(message)
+        super
+      end
+    end
+  end
+end

data/lib/auth_strategist/errors/unauthorized.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AuthStrategist
   module Errors
     class Unauthorized < StandardError

data/lib/auth_strategist/registry.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module AuthStrategist
+  class Registry
+    extend Dry::Container::Mixin
+  end
+end

data/lib/auth_strategist/strategy_interface.rb

@@ -1,50 +1,36 @@
+# frozen_string_literal: true
+
 module AuthStrategist
   module StrategyInterface
     def self.included(base)
       base.class_eval do
-        class << self
-          def define_components(*defined_components)
-            defined_components.delete_if { |c| default_components.include?(c) }
-            defined_components.uniq!
-            attr_accessor(*defined_components)
-            @components = defined_components
-          end
-
-          def components
-            [*default_components, *@components]
-          end
-
-          def default_components
-            AuthStrategist.configuration.default_strategy_components.uniq
-          end
-        end
-
-        attr_accessor(*components)
-
-        def initialize(attributes = {})
-          assign_component_values(attributes)
-        end
+        extend Dry::Initializer
+      end
 
-        def components
-          self.class.components
+      def base.define_components(*components)
+        components.each do |component|
+          option component, optional: true
         end
+      end
 
-        def authorize!
-          warn("#{self.class}#authorize! was not implemented.")
-        end
+      def base.components
+        dry_initializer.definitions.keys
+      end
+    end
 
-        def unauthorized
-          AuthStrategist::Errors::Unauthorized
-        end
+    def authorized?
+      raise(
+        AuthStrategist::Errors::AuthorizedNotImplemented,
+        "#{self.class}#authorized? was not implemented."
+      )
+    end
 
-        private
+    def authorize!
+      raise unauthorized unless authorized?
+    end
 
-        def assign_component_values(attributes = {})
-          components.each do |c|
-            instance_variable_set("@#{c}", attributes[c])
-          end
-        end
-      end
+    def unauthorized
+      AuthStrategist::Errors::Unauthorized
     end
   end
 end

data/lib/auth_strategist/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AuthStrategist
-  VERSION = '0.6.0'
+  VERSION = '0.7.0'
 end

data/lib/generators/auth_strategist/install_generator.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'rails/generators'
 
 module AuthStrategist
   class InstallGenerator < ::Rails::Generators::Base
-    source_root File.expand_path('../templates', __FILE__)
+    source_root File.expand_path('templates', __dir__)
     desc 'Installs AuthStrategist.'
 
     def install

data/lib/generators/auth_strategist/templates/initializer.rb

@@ -1,13 +1,14 @@
-AuthStrategist.configure do |c|
-  # Set default strategy components
-  c.default_strategy_components = []
+# frozen_string_literal: true
 
-  # Set strategies directory path if they are not autoloaded
+AuthStrategist.configure do |c|
+  # Set strategies directory path and load if they are not autoloaded
   # c.strategies_path = 'lib/auth_strategist/strategies'
+  # c.load_strategies!
+end
 
-  # Register your strategies
-  # c.strategies do |s|
-  #   # Example strategy - will be available under :password key
-  #   s.password = PasswordStrategy
-  # end
+# Register your strategies
+AuthStrategist.strategies do |s|
+  # E.g.
+  # s.register :ownership, OwnershipAuthStrategy
+  # s.register 'ownership.book', BookOwnershipAuthStrategy
 end

data/spec/auth_strategist_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe AuthStrategist do
@@ -9,8 +11,8 @@ describe AuthStrategist do
     expect(described_class::Configuration).to be_kind_of(Class)
   end
 
-  it 'includes Authorize service object' do
-    expect(described_class::Authorize).to be_kind_of(Class)
+  it 'includes BuildStrategy service object' do
+    expect(described_class::BuildStrategy).to be_kind_of(Class)
   end
 
   it 'includes StrategyInterface module' do
@@ -31,37 +33,11 @@ describe AuthStrategist do
 
   describe '.configure' do
     context 'called with block' do
-      let(:default_strategy_components) { [:custom_component] }
       let(:strategies_path) { 'spec/dummy/strategies' }
-      let(:test_strategy_class) { NotRegistered }
-
-      before(:each) do
-        described_class.configure do |c|
-          c.default_strategy_components = default_strategy_components
-          c.strategies_path = strategies_path
-          c.strategies do |s|
-            s.test = test_strategy_class
-          end
-        end
-      end
-
-      after(:each) do
-        described_class.configuration.strategies.delete(:test)
-      end
-
-      it 'sets up configuration (default_strategy_components)' do
-        expect(described_class.configuration.default_strategy_components).to(
-          eq(default_strategy_components)
-        )
-      end
 
       it 'sets up configuration (strategies_path)' do
         expect(described_class.configuration.strategies_path).to eq(strategies_path)
       end
-
-      it 'sets up configuration (strategies)' do
-        expect(described_class.configuration.strategies.test).to eq(test_strategy_class)
-      end
     end
 
     context 'called without block' do
@@ -72,25 +48,9 @@ describe AuthStrategist do
   end
 
   describe '.strategies' do
-    context 'called with block' do
-      let(:test_strategy_class) { NotRegistered }
-
-      before(:each) do
-        described_class.strategies { |s| s.test = test_strategy_class }
-      end
-
-      after(:each) do
-        described_class.strategies.delete(:test)
-      end
-
-      it 'sets up configuration (strategies)' do
-        expect(described_class.configuration.strategies.test).to eq(test_strategy_class)
-      end
-    end
-
     context 'called without block' do
-      it 'returns registered strategies' do
-        expect(described_class.strategies).to eq(described_class.configuration.strategies)
+      it 'returns strategies registry' do
+        expect(described_class.strategies).to eq(described_class::Registry)
       end
     end
   end

data/spec/authorization_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe AuthStrategist::Authorization do
@@ -8,12 +10,39 @@ describe AuthStrategist::Authorization do
       expect(dummy_controller).to respond_to(:authorize!)
     end
 
+    it 'adds #can? method to base' do
+      expect(dummy_controller).to respond_to(:can?)
+    end
+
     describe '#authorize!' do
-      let(:options) { Hash[:strategy, :dummy_strategy] }
+      context 'when authorization fails' do
+        it 'raises an error (AuthStrategist::Errors::Unauthorized)' do
+          expect { dummy_controller.authorize!(strategy: :dummy_strategy) }
+            .to raise_error(AuthStrategist::Errors::Unauthorized)
+        end
+      end
+
+      context 'when authorization succeeds' do
+        it 'returns nil' do
+          expect(dummy_controller.authorize!(strategy: :dummy_strategy, dummy_component: :ok))
+            .to be_nil
+        end
+      end
+    end
+
+    describe '#can?' do
+      context 'when authorization fails' do
+        it 'returns false' do
+          expect(dummy_controller.can?(strategy: :dummy_strategy))
+            .to eq(false)
+        end
+      end
 
-      it 'calls authorization service with given options' do
-        allow(AuthStrategist::Authorize).to receive(:call).with(options).and_return(:ok)
-        expect(dummy_controller.authorize!(options)).to eq(:ok)
+      context 'when authorization succeeds' do
+        it 'returns nil' do
+          expect(dummy_controller.can?(strategy: :dummy_strategy, dummy_component: :ok))
+            .to eq(true)
+        end
       end
     end
   end

data/spec/build_strategy_spec.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe AuthStrategist::BuildStrategy do
+  describe '#call' do
+    let(:builder) { described_class.new }
+
+    context 'when :strategy key was absent in given options' do
+      it 'raises an error' do
+        expect { builder.call }.to raise_error(StandardError, ':strategy option must not be nil.')
+      end
+    end
+
+    context 'when strategy registered under :strategy key was not found' do
+      it 'raises an error' do
+        expect { builder.call(strategy: :missing_strategy) }
+          .to raise_error(StandardError, 'Strategy \'missing_strategy\' was not found.')
+      end
+    end
+
+    context 'when strategy was found' do
+      it 'builds new service object and sends #call to it' do
+        expect(builder.call(strategy: :dummy_strategy)).to be_a(DummyStrategy)
+      end
+    end
+  end
+end

data/spec/configuration_spec.rb

@@ -1,21 +1,11 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe AuthStrategist::Configuration do
   context 'by default for specs environment' do
-    let(:default_strategy_components) { [:default_component] }
-    let(:strategies_path) { 'spec/dummy/strategies' }
-    let(:strategies_registry) do
-      described_class::StrategiesRegistry.new(dummy_strategy: DummyStrategy,
-                                              missing_authorize: MissingAuthorize)
-    end
-
     let(:subject) { AuthStrategist.configuration }
 
-    its(:default_strategy_components) do
-      is_expected.to eq(default_strategy_components)
-    end
-
-    its(:strategies_path) { is_expected.to eq(strategies_path) }
-    its(:strategies) { is_expected.to eq(strategies_registry) }
+    its(:strategies_path) { is_expected.to eq('spec/dummy/strategies') }
   end
 end

data/spec/dummy/controllers/dummy_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DummyController
   include AuthStrategist::Authorization
 end

data/spec/dummy/strategies/dummy_strategy.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 class DummyStrategy
   include AuthStrategist::StrategyInterface
 
   define_components :dummy_component
 
-  def authorize!
-    dummy_component
+  def authorized?
+    dummy_component == :ok
   end
 end

data/spec/dummy/strategies/missing_authorized.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+class MissingAuthorized
+  include AuthStrategist::StrategyInterface
+end

data/spec/dummy/strategies/not_registered.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class NotRegistered
   include AuthStrategist::StrategyInterface
 end

data/spec/spec_helper.rb

@@ -1,23 +1,19 @@
-$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+# frozen_string_literal: true
 
-require 'auth_strategist'
+$LOAD_PATH.unshift File.expand_path('../lib', __dir__)
 
-require 'factory_girl'
-require 'factories/authorize'
+require 'auth_strategist'
 
 require 'rspec/its'
 
 require 'dummy/controllers/dummy_controller'
 
-RSpec.configure do |c|
-  c.before(:each) do
-    AuthStrategist.configure do |g|
-      g.default_strategy_components = [:default_component]
-      g.strategies_path = 'spec/dummy/strategies'
-      g.strategies do |s|
-        s.dummy_strategy = DummyStrategy
-        s.missing_authorize = MissingAuthorize
-      end
-    end
-  end
+AuthStrategist.configure do |g|
+  g.strategies_path = 'spec/dummy/strategies'
+  g.load_strategies!
+end
+
+AuthStrategist.strategies do |s|
+  s.register :dummy_strategy, DummyStrategy
+  s.register :missing_authorized, MissingAuthorized
 end

data/spec/strategy_interface_spec.rb

@@ -1,18 +1,15 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe AuthStrategist::StrategyInterface do
-  let(:default_components) { AuthStrategist.configuration.default_strategy_components }
-  let(:strategy_class) { MissingAuthorize }
+  let(:strategy_class) { MissingAuthorized }
 
   context 'included' do
     it 'adds .define_components method to base' do
       expect(strategy_class).to respond_to(:define_components)
     end
 
-    it 'adds .default_components method to base' do
-      expect(strategy_class).to respond_to(:default_components)
-    end
-
     it 'adds .components method to base' do
       expect(strategy_class).to respond_to(:components)
     end
@@ -21,10 +18,6 @@ describe AuthStrategist::StrategyInterface do
       expect(strategy_class).to respond_to(:new)
     end
 
-    it 'adds #components method to base' do
-      expect(strategy_class.new).to respond_to(:components)
-    end
-
     it 'adds #authorize! method to base' do
       expect(strategy_class.new).to respond_to(:authorize!)
     end
@@ -33,96 +26,10 @@ describe AuthStrategist::StrategyInterface do
       expect(strategy_class.new).to respond_to(:unauthorized)
     end
 
-    it 'adds getters for default components to base' do
-      default_components.each do |c|
-        expect(strategy_class.new).to respond_to(c)
-      end
-    end
-
-    it 'adds setters for default components to base' do
-      default_components.each do |c|
-        expect(strategy_class.new).to respond_to("#{c}=")
-      end
-    end
-
-    describe '.define_components' do
-      before(:each) do
-        strategy_class.define_components(*components)
-      end
-
-      context 'when component names are not the same as default' do
-        let(:components) { [:user, :password] }
-
-        it 'adds components getters' do
-          components.each { |c| expect(strategy_class.new).to respond_to(c) }
-        end
-
-        it 'adds components setters' do
-          components.each { |c| expect(strategy_class.new).to respond_to("#{c}=") }
-        end
-
-        it 'adds components to components list' do
-          expect(strategy_class.components & components).to eq(components)
-        end
-      end
-
-      context 'when component names are the same as default' do
-        let(:components) { default_components }
-
-        it 'is not being added to components list' do
-          expect(strategy_class.components).to eq(strategy_class.components.uniq)
-        end
-      end
-
-      context 'when no components provided' do
-        let(:components) {}
-
-        it 'is equal to .default_components' do
-          expect(strategy_class.components).to eq(strategy_class.default_components)
-        end
-      end
-    end
-
-    describe '.default_components' do
-      context 'for default specs environment configuration' do
-        subject { strategy_class }
-
-        its(:default_components) do
-          is_expected.to eq(default_components)
-        end
-      end
-
-      context 'for any configuration' do
-        let(:components) { [:application, :requestor] }
-
-        before(:each) do
-          AuthStrategist.configure do |c|
-            c.default_strategy_components = components
-          end
-        end
-
-        it 'returns components configured as default' do
-          expect(strategy_class.default_components).to eq(components)
-        end
-      end
-    end
-
-    describe '.components' do
-      let(:components) { [*default_components, :dup, :dup] }
-
-      before(:each) do
-        strategy_class.define_components(*components)
-      end
-
-      it 'returns default and stratagy specific components without duplicates' do
-        expect(strategy_class.components).to eq(components.uniq)
-      end
-    end
-
     describe '.new' do
-      let(:options) { Hash[:user, 'john', :password, 'rambo'] }
+      let(:options) { { user: 'john', password: 'rambo' } }
 
-      before(:each) do
+      before do
         strategy_class.define_components(*options.keys)
         options[:missing_component] = :missing_component
       end
@@ -136,24 +43,13 @@ describe AuthStrategist::StrategyInterface do
       end
     end
 
-    describe '#components' do
-      subject { strategy_class.new }
-
-      before(:each) do
-        allow(strategy_class).to receive(:components).and_return([:ok])
-      end
-
-      it 'calls .components on strategy class' do
-        expect(subject.components).to eq([:ok])
-      end
-    end
-
     describe '#authorize!' do
       subject { strategy_class.new }
 
       context 'when not implemented within base' do
-        it 'returns nil' do
-          expect(subject.authorize!).to be_nil
+        it 'raises error (AuthStrategist::Errors::AuthorizedNotImplemented)' do
+          expect { subject.authorize! }
+            .to raise_error(AuthStrategist::Errors::AuthorizedNotImplemented, 'MissingAuthorized#authorized? was not implemented.')
         end
       end
 
@@ -162,7 +58,7 @@ describe AuthStrategist::StrategyInterface do
         subject { strategy_class.new(dummy_component: :ok) }
 
         it 'executes like defined' do
-          expect(subject.authorize!).to eq(:ok)
+          expect(subject.authorize!).to be_nil
         end
       end
     end

metadata

@@ -1,31 +1,45 @@
 --- !ruby/object:Gem::Specification
 name: auth_strategist
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Krzysztof Buszewicz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-27 00:00:00.000000000 Z
+date: 2019-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: dry-container
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.9'
-  type: :development
+        version: '0.7'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '0.7'
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: dry-initializer
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -42,16 +56,30 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - krzysztof.buszewicz@gmail.com
@@ -86,23 +128,23 @@ files:
 - bin/setup
 - lib/auth_strategist.rb
 - lib/auth_strategist/authorization.rb
-- lib/auth_strategist/authorize.rb
+- lib/auth_strategist/build_strategy.rb
 - lib/auth_strategist/configuration.rb
-- lib/auth_strategist/configuration/strategies_registry.rb
+- lib/auth_strategist/errors/authorized_not_implemented.rb
 - lib/auth_strategist/errors/unauthorized.rb
+- lib/auth_strategist/registry.rb
 - lib/auth_strategist/strategy_interface.rb
 - lib/auth_strategist/version.rb
 - lib/generators/auth_strategist/install_generator.rb
 - lib/generators/auth_strategist/templates/initializer.rb
 - spec/auth_strategist_spec.rb
 - spec/authorization_spec.rb
-- spec/authorize_spec.rb
+- spec/build_strategy_spec.rb
 - spec/configuration_spec.rb
 - spec/dummy/controllers/dummy_controller.rb
 - spec/dummy/strategies/dummy_strategy.rb
-- spec/dummy/strategies/missing_authorize.rb
+- spec/dummy/strategies/missing_authorized.rb
 - spec/dummy/strategies/not_registered.rb
-- spec/factories/authorize.rb
 - spec/spec_helper.rb
 - spec/strategy_interface_spec.rb
 homepage: https://github.com/buszu/auth_strategist
@@ -125,19 +167,18 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Simple gem to realize API actions authorization with different strategies.
 test_files:
 - spec/auth_strategist_spec.rb
 - spec/authorization_spec.rb
-- spec/authorize_spec.rb
+- spec/build_strategy_spec.rb
 - spec/configuration_spec.rb
 - spec/dummy/controllers/dummy_controller.rb
 - spec/dummy/strategies/dummy_strategy.rb
-- spec/dummy/strategies/missing_authorize.rb
+- spec/dummy/strategies/missing_authorized.rb
 - spec/dummy/strategies/not_registered.rb
-- spec/factories/authorize.rb
 - spec/spec_helper.rb
 - spec/strategy_interface_spec.rb

data/lib/auth_strategist/authorize.rb

@@ -1,41 +0,0 @@
-module AuthStrategist
-  class Authorize
-    attr_reader :strategy
-
-    def self.call(options = {})
-      new(options).call
-    end
-
-    def initialize(options = {})
-      @strategy = choose_strategy(options)
-    end
-
-    def call
-      strategy.authorize!
-    end
-
-    private
-
-    def choose_strategy(options = {})
-      strategy_name = options.delete(:strategy)
-      raise(strategy_name_blank) if strategy_name.nil?
-
-      strategy_class = strategies[strategy_name]
-      raise(strategy_not_found(strategy_name)) if strategy_class.nil?
-
-      strategy_class.new(options)
-    end
-
-    def strategies
-      AuthStrategist.strategies.to_h
-    end
-
-    def strategy_not_found(strategy_name)
-      StandardError.new("Strategy :#{strategy_name} was not found.")
-    end
-
-    def strategy_name_blank
-      StandardError.new(':strategy option must not be blank.')
-    end
-  end
-end

data/lib/auth_strategist/configuration/strategies_registry.rb

@@ -1,11 +0,0 @@
-require 'ostruct'
-
-module AuthStrategist
-  class Configuration
-    class StrategiesRegistry < OpenStruct
-      def delete(strategy_key)
-        delete_field(strategy_key)
-      end
-    end
-  end
-end

data/spec/authorize_spec.rb

@@ -1,74 +0,0 @@
-require 'spec_helper'
-
-describe AuthStrategist::Authorize do
-  let(:authorize) { FactoryGirl.build(:authorize, dummy_component: :ok) }
-  let(:authorize_blank_strategy) { FactoryGirl.build(:authorize_blank_strategy) }
-  let(:authorize_missing_strategy) { FactoryGirl.build(:authorize_missing_strategy) }
-
-  describe '.call' do
-    context 'when :strategy key was absent in given options' do
-      it 'raises an error' do
-        expect { described_class.call }.to raise_error(StandardError)
-      end
-    end
-
-    context 'when strategy registered under :strategy key was not found' do
-      let(:missing_strategy) { :missing_strategy }
-
-      it 'raises an error' do
-        expect { described_class.call(strategy: missing_strategy) }.to raise_error(StandardError)
-      end
-    end
-
-    context 'when strategy was found' do
-      let(:options) { Hash[:strategy, :dummy_strategy] }
-
-      before(:each) do
-        allow_any_instance_of(described_class).to receive(:call).and_return(:ok)
-      end
-
-      it 'builds new service object and sends #call to it' do
-        expect(described_class.call(options)).to eq(:ok)
-      end
-    end
-  end
-
-  describe '.new' do
-    context 'when :strategy key was absent in given options' do
-      it 'raises an error' do
-        expect { authorize_blank_strategy }.to raise_error(StandardError)
-      end
-    end
-
-    context 'when strategy registered under :strategy key was not found' do
-      it 'raises an error' do
-        expect { authorize_missing_strategy }.to raise_error(StandardError)
-      end
-    end
-
-    context 'when strategy was found' do
-      let(:strategy_class) { DummyStrategy }
-
-      it 'sets strategy up' do
-        expect(authorize.strategy).to be_kind_of(strategy_class)
-        expect(authorize.strategy.dummy_component).to eq(:ok)
-      end
-
-      it 'returns service object instance' do
-        expect(authorize).to be_kind_of(AuthStrategist::Authorize)
-      end
-    end
-  end
-
-  describe '#call' do
-    let(:strategy_class) { DummyStrategy }
-
-    before(:each) do
-      allow_any_instance_of(strategy_class).to receive(:authorize!).and_return(:ok)
-    end
-
-    it 'sends #authorize! to strategy' do
-      expect(authorize.call).to eq(:ok)
-    end
-  end
-end

data/spec/dummy/strategies/missing_authorize.rb

@@ -1,3 +0,0 @@
-class MissingAuthorize
-  include AuthStrategist::StrategyInterface
-end

data/spec/factories/authorize.rb

@@ -1,15 +0,0 @@
-FactoryGirl.define do
-  factory :authorize_blank_strategy, class: AuthStrategist::Authorize do
-    initialize_with do
-      new(attributes)
-    end
-  end
-
-  factory :authorize_missing_strategy, parent: :authorize_blank_strategy do
-    strategy :missing_strategy
-  end
-
-  factory :authorize, parent: :authorize_blank_strategy do
-    strategy :dummy_strategy
-  end
-end