auth_manager 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4c23c797e945286960d9bbbe5d636a0d76af01a6
-  data.tar.gz: 59e984d5d11a2ea53bb1a49c46121cf62681bc5a
+  metadata.gz: e7465dfb956e67e5f1603a7e1242a10854942b68
+  data.tar.gz: 7f168f106e4ee1816b774c70e613b83587a2782b
 SHA512:
-  metadata.gz: 18ce94bb4ff84988ff3baf0ac275a3dac962b1772115f2c8a137a2528ea8e384f24e2914f6c75333589836a4f158c1c412746a8ae53fc1b381f96ed3bb8e71a2
-  data.tar.gz: 85c911b5d08de7eb1c7b6abe5e3a26bb5034146b30694eb70c69fc1bdfa52a4c429deb558eadc3abfeab350641de7173b8a4fa694ebbc04c97a5bcfc91dbcd3a
+  metadata.gz: a429104d31a2d6122192d7914450c88fbdb5954f682a7e8e0daf4eaaf37015caa1fa40814af14f3efa100c2eac0abed24a6789df305695b671a9147d57987fb7
+  data.tar.gz: faf321f3be3f4ba07a65262bf3af6d9ce3e9f84b8ef9abdbf9b3a9d7226a97919c3668b24564c7edb76de2a6911f2e637f4a27c329eb9a78d2c71494945e051d

data/lib/auth_manager/{add/add.rb → adder/adder.rb}

@@ -2,7 +2,7 @@
 require 'redis'
 require_relative '../base.rb'
 
-class Add < AuthManager::Validation
+class Adder < AuthManager::Validation
 
   def save?(given_user, option={user: true, app: false})
     user = option.fetch(:user) || false
@@ -11,7 +11,7 @@ class Add < AuthManager::Validation
     save(user, given_user) if available_login?(given_user, user)
   end
 
-  private
+  private ###################################
 
   def available_login?(given_user, user)
     login_ok = true

data/lib/auth_manager/{delete/delete.rb → deleter/deleter.rb}

@@ -2,7 +2,7 @@
 require 'redis'
 require_relative '../base'
 
-class Delete < AuthManager::Base
+class Deleter < AuthManager::Base
 
   def delete?(obj_to_del, option)
     new_obj = format_new_obj(obj_to_del)
@@ -12,8 +12,8 @@ class Delete < AuthManager::Base
   private
 
   def fake_delete?(obj_to_del, new_obj, option)
-    update = Update.new
-    update.update(obj_to_del, new_obj, option)
+    updater = Updater.new
+    updater.update(obj_to_del, new_obj, option)
   end
 
   def format_new_obj(obj_to_del)

data/lib/auth_manager/{find/find.rb → finder/finder.rb}

@@ -1,7 +1,7 @@
 require 'redis'
 require_relative '../base.rb'
 
-class Find < AuthManager::Validation
+class Finder < AuthManager::Validation
 
   def find_object?( param, option )
     user = option.fetch(:user) || false

data/lib/auth_manager/{update/update.rb → updater/updater.rb}

@@ -2,7 +2,7 @@
 require 'redis'
 require_relative '../base'
 
-class Update < AuthManager::Base
+class Updater < AuthManager::Base
 
   def update(old_obj, new_obj, option)
     existing_obj?(old_obj, option)
@@ -10,11 +10,11 @@ class Update < AuthManager::Base
     delete_obj?(old_obj, option)
   end
 
-  private
+  private ###########################
 
   def existing_obj?(old_obj, option)
-    find = Find.new
-    find.find_object?(old_obj, option)
+    finder = Finder.new
+    finder.find_object?(old_obj, option)
   end
 
   def delete_obj?(old_obj, option)
@@ -24,8 +24,8 @@ class Update < AuthManager::Base
   end
 
   def write_new_info?(new_obj, option)
-    add = Add.new
-    add.save?(new_obj, option)
+    adder = Adder.new
+    adder.save?(new_obj, option)
   end
 
 end

data/lib/auth_manager/version.rb

@@ -1,3 +1,3 @@
 module AuthManager
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/auth_manager.rb

@@ -1,8 +1,8 @@
 require 'auth_manager/version'
-require 'auth_manager/add/add'
-require 'auth_manager/find/find'
-require 'auth_manager/update/update'
-require 'auth_manager/delete/delete'
+require 'auth_manager/adder/adder'
+require 'auth_manager/finder/finder'
+require 'auth_manager/updater/updater'
+require 'auth_manager/deleter/deleter'
 
 module AuthManager
   # Your code goes here...

data/specs/adder_spec.rb

@@ -0,0 +1,44 @@
+require_relative 'spec_helper'
+
+describe  Adder do
+  let(:adder) {  Adder.new }
+  let(:user) { { login: 'nano', password: 'password' } }
+  let(:app) { { api_key: 'api_key' } }
+  let(:opt) { {user: false, app: false} }
+
+  describe '.initialize' do
+    context 'When created' do
+      it { expect( adder.redis).to_not be_nil  }
+    end
+  end
+
+  describe '#save?' do
+    #cleaning valid_user and or valid app before new save
+    before(:each) do
+       adder.redis.del('users', user)
+       adder.redis.del('applications', app)
+    end
+    #normal cases
+    context 'When saved a valid user' do
+      it {
+        swap_option_to('user')
+        expect( adder.save?(user.to_json, opt)).to be_true
+      }
+    end
+    context 'When saved a valid app' do
+      it {
+        swap_option_to('app')
+        expect( adder.save?(app.to_json, opt)).to be_true
+      }
+    end
+    context 'When saved with an existing login' do
+      it {
+        expect( adder.save?(user.to_json, opt) ).to be_true
+        expect( adder.save?(user.to_json, opt)).to be_false
+        user['password'] = 'another password'
+        expect( adder.save?(user.to_json, opt)).to be_false
+      }
+    end
+  end
+
+end

data/specs/deleter_spec.rb

@@ -0,0 +1,47 @@
+require_relative 'spec_helper'
+
+describe  Deleter do
+  let(:deleter) {  Deleter.new  }
+  let(:user) { {login: 'login', password: 'password'} }
+  let(:app) { {api_key: 'api_key'} }
+  let(:opt) { { user: false, app: true }  }
+  describe '#delete' do
+    before(:each) do
+       deleter.redis.del('users')
+       deleter.redis.del('applications')
+       deleter.redis.sadd('users', user.to_json)
+       deleter.redis.sadd('applications', app.to_json)
+    end
+
+    context 'When  deleted a user' do
+      it {
+        swap_option_to('user')
+        user[:login] = 'login'
+        expect( deleter.delete?(user.to_json, opt)).to be_true
+      }
+    end
+
+    context 'When user is not  deleted' do
+      it {
+        swap_option_to('user')
+        user[:login] = 'not a login'
+        expect( deleter.delete?(user.to_json, opt)).to be_false
+      }
+    end
+    context 'When  deleted an app' do
+      it {
+        swap_option_to('app')
+        app[:api_key] = 'api_key'
+        expect( deleter.delete?(app.to_json, opt)).to be_true
+      }
+    end
+
+    context 'When app is not deleted' do
+      it {
+        swap_option_to('app')
+        app[:api_key] = 'not an api_key'
+        expect( deleter.delete?(app.to_json, opt)).to be_false
+      }
+    end
+  end
+end

data/specs/finder_spec.rb

@@ -0,0 +1,43 @@
+require_relative 'spec_helper'
+
+describe Finder do
+  let(:finder) { Finder.new }
+  let(:user) { { login: 'login', password: 'password' }}
+  let(:app) { { api_key: 'api_key'  } }
+  let(:opt) { { user: true, app: false }  }
+  describe '#find_object?' do
+    before(:each) do
+      finder.redis.del('users')
+      finder.redis.del('applications')
+      finder.redis.sadd('users', user.to_json)
+      finder.redis.sadd('applications', app.to_json)
+    end
+    context 'When user is found' do
+      it {
+        swap_option_to('user')
+        expect( finder.find_object?(user.to_json, opt ) ).to be_true
+      }
+    end
+    context 'When user is not found' do
+      it {
+        swap_option_to('user')
+        user[:login] = 'not a login'
+        expect( finder.find_object?( user.to_json, opt )  ).to be_false
+      }
+    end
+
+    context 'When app is found' do
+      it {
+        swap_option_to('app')
+        expect( finder.find_object?(app.to_json, opt ) ).to be_true
+      }
+    end
+    context 'When app is not found' do
+      it {
+        swap_option_to('app')
+        app[:api_key] = 'not an api_key'
+        expect( finder.find_object?( app.to_json, opt )  ).to be_false
+      }
+    end
+  end
+end

data/specs/spec_helper.rb

@@ -1 +1,23 @@
 require_relative './fixtures/environment'
+
+
+def swap_option_to(list)
+  case list
+  when 'user'
+    opt[:user] = true
+    opt[:app] = false
+  else
+    opt[:user] = false
+    opt[:app] = true
+  end
+end
+
+def new_object_from(object)
+  case object
+  when object.include?(:login)
+    object[:password] = 'new password'
+  else
+    object[:api_key] = 'new api_key'
+  end
+  object
+end

data/specs/updater_spec.rb

@@ -0,0 +1,43 @@
+# coding: utf-8
+require_relative  'spec_helper'
+
+describe Updater do
+  let(:updater) { Updater.new }
+  let(:app) { { api_key: 'api_key' } }
+  let(:user) { { login: 'login', password: 'password' }}
+  let(:opt) { { user: true, app: false } }
+  describe '#update' do
+    before(:each) do
+      updater.redis.del('users')
+      updater.redis.del('applications')
+      updater.redis.sadd('users', user.to_json)
+      updater.redis.sadd('applications', app.to_json)
+    end
+    context 'When user object is updated' do
+      it {
+        swap_option_to('user')
+        expect(updater.update(user.to_json, new_object_from(user).to_json, opt)).to be_true
+      }
+    end
+    context 'When app object is updated' do
+      it {
+        swap_option_to('app')
+        expect(updater.update(app.to_json, new_object_from(app).to_json, opt)).to be_true
+      }
+    end
+    context 'When user object is not updated' do
+      it {
+        swap_option_to('user')
+        user[:login] = 'not a login'
+        expect(updater.update(user.to_json, new_object_from(user).to_json, opt)).to be_false
+      }
+    end
+    context 'When app object is not updated' do
+      it {
+        swap_option_to('app')
+        app[:api_key] = 'not an api_key'
+        expect(updater.update(app.to_json, new_object_from(app).to_json, opt)).to be_false
+      }
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: auth_manager
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - atacraft && fabira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-07 00:00:00.000000000 Z
+date: 2014-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -87,19 +87,19 @@ files:
 - auth_manager.gemspec
 - dump.rdb
 - lib/auth_manager.rb
-- lib/auth_manager/add/add.rb
+- lib/auth_manager/adder/adder.rb
 - lib/auth_manager/base.rb
-- lib/auth_manager/delete/delete.rb
-- lib/auth_manager/find/find.rb
-- lib/auth_manager/update/update.rb
+- lib/auth_manager/deleter/deleter.rb
+- lib/auth_manager/finder/finder.rb
+- lib/auth_manager/updater/updater.rb
 - lib/auth_manager/version.rb
-- specs/add_spec.rb
-- specs/delete_spec.rb
+- specs/adder_spec.rb
+- specs/deleter_spec.rb
 - specs/feed/populate.rb
-- specs/find_spec.rb
+- specs/finder_spec.rb
 - specs/fixtures/environment.rb
 - specs/spec_helper.rb
-- specs/update_spec.rb
+- specs/updater_spec.rb
 homepage: ''
 licenses:
 - MIT

data/specs/add_spec.rb

@@ -1,41 +0,0 @@
-require_relative 'spec_helper'
-
-describe Add do
-  let(:add) { Add.new }
-  #valid variables
-  let(:valid_user) { { login: 'nano', password: 'password' }.to_json }
-  let(:stored_user) { {login: 'login', password: 'password'}.to_json }
-  let(:user_used_login) { {login: 'login', password: 'a password'}.to_json }
-  let(:valid_app) { { api_key: 'api_key' }.to_json }
-  let(:valid_user_opt) { {user: true, app: false} }
-  let(:valid_app_opt) { { user: false, app: true } }
-
-  describe '.initialize' do
-    context 'When created' do
-      it { expect(add.redis).to_not be_nil  }
-    end
-  end
-
-  describe '#save?' do
-    #cleaning valid_user and or valid app before new save
-    before(:each) do
-      add.redis.del('users', valid_user)
-      add.redis.del('applications', valid_app)
-      add.redis.sadd('users', stored_user)
-    end
-    #normal cases
-    context 'When saved a valid user' do
-      it { expect(add.save?(valid_user, valid_user_opt)).to be_true }
-    end
-    context 'When saved a valid user with default option' do
-      it { expect(add.save?(valid_user)).to be_true }
-    end
-    context 'When saved a valid app' do
-      it { expect(add.save?(valid_app, valid_app_opt)).to be_true }
-    end
-    context 'When saved with an existing login' do
-      it { expect(add.save?(user_used_login, valid_user_opt)).to be_false }
-    end
-  end
-
-end

data/specs/delete_spec.rb

@@ -1,24 +0,0 @@
-require_relative 'spec_helper'
-
-describe Delete do
-  let(:delete) { Delete.new  }
-  let(:user_to_del) { {login: 'login', password: 'password'}.to_json  }
-  let(:app_to_del) { {api_key: 'api_key'}.to_json }
-  let(:user_option) { { user: true, app: false }  }
-  let(:app_option) { { user: false, app: true }  }
-  describe '#delete' do
-    before(:each) do
-      delete.redis.del('users')
-      delete.redis.del('applications')
-      delete.redis.sadd('users', user_to_del)
-      delete.redis.sadd('applications', app_to_del)
-    end
-
-    context 'When deleted a user' do
-      it { expect(delete.delete?(user_to_del, user_option)).to be_true }
-    end
-    context 'When deleted an app' do
-      it { expect(delete.delete?(app_to_del, app_option)).to be_true  }
-    end
-  end
-end

data/specs/find_spec.rb

@@ -1,32 +0,0 @@
-require_relative 'spec_helper'
-
-describe Find do
-  let(:find) { Find.new }
-  let(:invalid_user) { { login: 'login', password: 'password' }.to_json }
-  let(:valid_user){ { login: 'tata', password: 'toto' }.to_json }
-  let(:valid_app) { { api_key: 'api_key'  }.to_json }
-  let(:invalid_app) { { api_key: 'not_api_key'  }.to_json }
-  let(:user_opt) { { user: true, app: false }  }
-  let(:app_opt) { { user: false, app: true }  }
-  describe '#find_object?' do
-    context 'When user is found' do
-      before(:each) do
-        find.redis.del('users')
-        find.redis.del('applications')
-        find.redis.sadd('users', valid_user)
-        find.redis.sadd('applications', valid_app)
-      end
-      it { expect( find.find_object?(valid_user, user_opt ) ).to be_true }
-    end
-    context 'When user is not found' do
-      it { expect( find.find_object?( invalid_user, user_opt )  ).to be_false  }
-    end
-
-    context 'When app is found' do
-      it { expect( find.find_object?(valid_app, app_opt ) ).to be_true }
-    end
-    context 'When app is not found' do
-      it { expect( find.find_object?( invalid_app, app_opt )  ).to be_false  }
-    end
-  end
-end

data/specs/update_spec.rb

@@ -1,34 +0,0 @@
-# coding: utf-8
-require_relative  'spec_helper'
-
-describe Update do
-  let(:update) { Update.new }
-  let(:new_user_info) { {login: 'new login', password: 'new password'}.to_json }
-  let(:new_app_info) { { api_key: 'new api key' }.to_json }
-  let(:valid_old_app) { { api_key: 'api_key' }.to_json }
-  let(:invalid_old_app) { { api_key: 'bad_key' }.to_json }
-  let(:valid_old_user) { { login: 'login', password: 'password' }.to_json}
-  let(:invalid_old_user) { {login: 'not a login', password: 'not a password'}.to_json }
-  let(:user_option) { { user: true, app: false } }
-  let(:app_option) { { user: false, app: true } }
-  describe '#update' do
-    before(:each) do
-      update.redis.del('users')
-      update.redis.del('applications')
-      update.redis.sadd('users', valid_old_user)
-      update.redis.sadd('applications', valid_old_app)
-    end
-    context 'When user object is updated' do
-      it { expect(update.update(valid_old_user, new_user_info, user_option)).to be_true }
-    end
-    context 'When app object is updated' do
-      it { expect(update.update(valid_old_app, new_app_info, app_option)).to be_true }
-    end
-    context 'When user object is not updated' do
-      it { expect(update.update(invalid_old_user, new_user_info, user_option)).to be_false }
-    end
-    context 'When app object is not updated' do
-      it { expect(update.update(invalid_old_app, new_app_info, app_option)).to be_false }
-    end
-  end
-end