auth_manager 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d82e648bc36a09ed97c642107200d61274fcdcaf
-  data.tar.gz: 667d2179e19911d1a7912fd3e519b4e217539375
+  metadata.gz: 4c23c797e945286960d9bbbe5d636a0d76af01a6
+  data.tar.gz: 59e984d5d11a2ea53bb1a49c46121cf62681bc5a
 SHA512:
-  metadata.gz: c1905bb61805123c4fc156b81bca20d8d884341eb69210ac4d5b450bf239574520d73e879d8a27406ee4e7bffe21e6740de6c0706195ba630ff16f297c3ddd81
-  data.tar.gz: 10dc82a07b862085be82c8c8b17df89d3fff79b99e4ee058091816a4febaf7029f5746b89feee88332b3ecc5be02a0f3924f8259db454f44984ce14682fb9101
+  metadata.gz: 18ce94bb4ff84988ff3baf0ac275a3dac962b1772115f2c8a137a2528ea8e384f24e2914f6c75333589836a4f158c1c412746a8ae53fc1b381f96ed3bb8e71a2
+  data.tar.gz: 85c911b5d08de7eb1c7b6abe5e3a26bb5034146b30694eb70c69fc1bdfa52a4c429deb558eadc3abfeab350641de7173b8a4fa694ebbc04c97a5bcfc91dbcd3a

data/lib/auth_manager/add/add.rb

@@ -8,22 +8,31 @@ class Add < AuthManager::Validation
     user = option.fetch(:user) || false
     app  = option.fetch(:app) || false
     validate_param( given_user, option, user, app )
-    save(user, given_user)
+    save(user, given_user) if available_login?(given_user, user)
   end
 
   private
 
-  def available_login?(param, liste)
+  def available_login?(given_user, user)
+    login_ok = true
+    liste = user ? USERS : APPS
     all = @redis.smembers(liste)
     all.each do |member|
       member_json = JSON.parse(member)
-      param_json = JSON.parse(param)
-      member_json['login'] == param_json['login'] ? false : true
+      param_json = JSON.parse(given_user)
+      if param_json['login'] && login_exist?(member_json['login'], param_json['login'])
+        login_ok = false
+        break
+      end
     end
+    login_ok
+  end
+
+  def login_exist?(wanted_login, login)
+    wanted_login == login
   end
 
   def save_this(liste, params)
-    available_login?(params, liste)
     @redis.sadd(liste, params)
   end
 

data/lib/auth_manager/version.rb

@@ -1,3 +1,3 @@
 module AuthManager
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/specs/add_spec.rb

@@ -4,6 +4,8 @@ describe Add do
   let(:add) { Add.new }
   #valid variables
   let(:valid_user) { { login: 'nano', password: 'password' }.to_json }
+  let(:stored_user) { {login: 'login', password: 'password'}.to_json }
+  let(:user_used_login) { {login: 'login', password: 'a password'}.to_json }
   let(:valid_app) { { api_key: 'api_key' }.to_json }
   let(:valid_user_opt) { {user: true, app: false} }
   let(:valid_app_opt) { { user: false, app: true } }
@@ -19,6 +21,7 @@ describe Add do
     before(:each) do
       add.redis.del('users', valid_user)
       add.redis.del('applications', valid_app)
+      add.redis.sadd('users', stored_user)
     end
     #normal cases
     context 'When saved a valid user' do
@@ -30,7 +33,9 @@ describe Add do
     context 'When saved a valid app' do
       it { expect(add.save?(valid_app, valid_app_opt)).to be_true }
     end
-
+    context 'When saved with an existing login' do
+      it { expect(add.save?(user_used_login, valid_user_opt)).to be_false }
+    end
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: auth_manager
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - atacraft && fabira