auditable 0.1.2 → 0.1.3

data/CHANGELOG.md

@@ -1,4 +1,9 @@
-### 0.1.2 (2012-05-24
+### 0.1.3 (2012-05-24)
+#### Fixes
+* Fix a silly bug not loading the audits under the same `auditable_id`
+* Get the latest audit via `id DESC` instead of `created_at DESC`
+
+### 0.1.2 (2012-05-24)
 #### Fixes
 * Fix bug creating duplicate audits despite no change in a record's subsequent saves, due to using `.build`. See this comment on ![issue #7](https://github.com/harleyttd/auditable/issues/7#issuecomment-5520894)
 * Fix bug not finding the right audit in rare cases when there are many audits with the same `created_at` timestamp

data/Gemfile

@@ -2,6 +2,3 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in auditable.gemspec
 gemspec
-
-gem 'debugger', :platform => :ruby_19
-gem 'ruby-debug', :platform => :ruby_18

data/auditable.gemspec

@@ -4,7 +4,7 @@ require File.expand_path('../lib/auditable/version', __FILE__)
 Gem::Specification.new do |gem|
   gem.authors       = ["Harley Trung"]
   gem.email         = ["harley@socialsci.com"]
-  gem.description   = %q{A simple gem that audit models' attributes or methods by taking snapshots and diff them for you. Starting from scratch to work with Rails 3.2.2 onwards}
+  gem.description   = %q{A simple gem that audit ActiveRecord models' attributes or methods by taking snapshots and diff them for you. Starting from scratch to work with Rails 3.2.2 onwards}
   gem.summary       = %q{A simple gem to audit attributes and methods in ActiveRecord models.}
   gem.homepage      = "https://github.com/harleyttd/auditable"
 
@@ -19,10 +19,15 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rspec', '>= 2'
   gem.add_development_dependency 'watchr'
   gem.add_development_dependency 'sqlite3'
+  gem.add_development_dependency 'timecop'
   # documetation stuff
   gem.add_development_dependency 'yard'
   gem.add_development_dependency 'rdiscount'
-  gem.add_development_dependency 'timecop'
+
+  # debugger. only included if one sets DEBUGGER env variable
+  if ENV['DEBUGGER']
+    gem.add_development_dependency 'debugger'
+  end
 
   gem.add_runtime_dependency 'activesupport', '>= 3.0'
   gem.add_runtime_dependency 'activerecord', '>= 3.0'

data/lib/auditable/audit.rb

@@ -41,7 +41,7 @@ module Auditable
     # See #diff for more details
     def latest_diff(options = {})
       if options.present?
-        scoped = auditable.audits.order("created_at DESC")
+        scoped = auditable.audits.order("id DESC")
         if tag = options.delete(:tag)
           scoped = scoped.where(:tag => tag)
         end
@@ -59,9 +59,9 @@ module Auditable
 
     # Diff this audit with the latest audit created before the `time` variable passed
     def diff_since(time)
-      other_audit = self.class.where("created_at <= ? AND id != ?", time, id).order("created_at DESC").limit(1).first
+      other_audit = auditable.audits.where("created_at <= ? AND id != ?", time, id).order("id DESC").limit(1).first
       diff(other_audit)
-    end
+   end
 
     # Returns user object
     #

data/lib/auditable/version.rb

@@ -1,3 +1,3 @@
 module Auditable
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/spec/lib/auditable_spec.rb

@@ -43,16 +43,25 @@ describe Auditable do
 
     it "should work after first update" do
       survey.update_attributes :title => "new title"
-      survey.audited_changes.should == {"title" => ["test survey", "new title"]}
+      survey.audited_changes.should == {"title" => [nil, "new title"]}
       survey.audited_changes(:tag => "something").should == {"title" => [nil, "new title"]}
       survey.audits.count.should == 1
     end
 
-    it "should create a new audit when calling audit_tag_with without existing audits" do
-      survey.audits.count.should == 0
-      survey.audit_tag_with("something") # no audit to tag but should be ok with it
-      survey.audits.count.should == 1
-      survey.audits.last.tag.should == "something"
+    describe ".audit_tag_with" do
+      it "should create a new audit when calling audit_tag_with without existing audits" do
+        expect do
+          survey.audit_tag_with("something") # no audit to tag but should be ok with it
+        end.to change { survey.audits.count }.from(0).to(1)
+        survey.audits.last.tag.should == "something"
+      end
+
+      it "should not create new audits when only tag changes" do
+        survey.audit_tag_with "one"
+        survey.audit_tag_with "two"
+        survey.audit_tag_with "three"
+        survey.audits.map(&:tag).should == ["three"]
+      end
     end
   end
 
@@ -170,6 +179,16 @@ describe Auditable do
       survey.save
       expect { 3.times { survey.save } }.to_not change { survey.audits.count }
     end
+
+    # TODO this behaviour is up for further debates: https://github.com/harleyttd/auditable/issues/7
+    it "should still store when only tag changes" do
+      survey.audits.delete_all
+      survey.update_attributes!(:audit_tag => 'one')
+      survey.update_attributes!(:audit_tag => 'two')
+      survey.update_attributes!(:audit_tag => 'three')
+      survey.update_attributes!(:audit_tag => 'four')
+      survey.audits.map(&:tag).should == %w[one two three four]
+    end
   end
 
   context "last change of a given attribute from past audits" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: auditable
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2156001580 !ruby/object:Gem::Requirement
+  requirement: &2152531980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156001580
+  version_requirements: *2152531980
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2155999120 !ruby/object:Gem::Requirement
+  requirement: &2152531400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '2'
   type: :development
   prerelease: false
-  version_requirements: *2155999120
+  version_requirements: *2152531400
 - !ruby/object:Gem::Dependency
   name: watchr
-  requirement: &2155994600 !ruby/object:Gem::Requirement
+  requirement: &2152530780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2155994600
+  version_requirements: *2152530780
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &2155992820 !ruby/object:Gem::Requirement
+  requirement: &2152530080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2155992820
+  version_requirements: *2152530080
 - !ruby/object:Gem::Dependency
-  name: yard
-  requirement: &2155991880 !ruby/object:Gem::Requirement
+  name: timecop
+  requirement: &2152529180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2155991880
+  version_requirements: *2152529180
 - !ruby/object:Gem::Dependency
-  name: rdiscount
-  requirement: &2155990760 !ruby/object:Gem::Requirement
+  name: yard
+  requirement: &2152528200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2155990760
+  version_requirements: *2152528200
 - !ruby/object:Gem::Dependency
-  name: timecop
-  requirement: &2155989640 !ruby/object:Gem::Requirement
+  name: rdiscount
+  requirement: &2152527680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2155989640
+  version_requirements: *2152527680
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &2155987940 !ruby/object:Gem::Requirement
+  requirement: &2152527140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,10 +98,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *2155987940
+  version_requirements: *2152527140
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &2155986140 !ruby/object:Gem::Requirement
+  requirement: &2152526620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -109,9 +109,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *2155986140
-description: A simple gem that audit models' attributes or methods by taking snapshots
-  and diff them for you. Starting from scratch to work with Rails 3.2.2 onwards
+  version_requirements: *2152526620
+description: A simple gem that audit ActiveRecord models' attributes or methods by
+  taking snapshots and diff them for you. Starting from scratch to work with Rails
+  3.2.2 onwards
 email:
 - harley@socialsci.com
 executables: []