auditable 0.1.1 → 0.1.2

data/.rvmrc

@@ -1 +1 @@
-rvm --create use 1.9.3@auditable
+rvm --create use 1.9.3-p194@auditable

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+### 0.1.2 (2012-05-24
+#### Fixes
+* Fix bug creating duplicate audits despite no change in a record's subsequent saves, due to using `.build`. See this comment on ![issue #7](https://github.com/harleyttd/auditable/issues/7#issuecomment-5520894)
+* Fix bug not finding the right audit in rare cases when there are many audits with the same `created_at` timestamp
+
 ### 0.1.1 (2012-04-11)
 #### Fixes
 * Fix bug/inconsistency between `user` and `changed_by`, now with `alias_attribute :changed_by, :user`

data/auditable.gemspec

@@ -22,6 +22,7 @@ Gem::Specification.new do |gem|
   # documetation stuff
   gem.add_development_dependency 'yard'
   gem.add_development_dependency 'rdiscount'
+  gem.add_development_dependency 'timecop'
 
   gem.add_runtime_dependency 'activesupport', '>= 3.0'
   gem.add_runtime_dependency 'activerecord', '>= 3.0'

data/lib/auditable/audit.rb

@@ -59,7 +59,7 @@ module Auditable
 
     # Diff this audit with the latest audit created before the `time` variable passed
     def diff_since(time)
-      other_audit = self.class.where("created_at < ?", time).order("created_at DESC").limit(1).first
+      other_audit = self.class.where("created_at <= ? AND id != ?", time, id).order("created_at DESC").limit(1).first
       diff(other_audit)
     end
 

data/lib/auditable/auditing.rb

@@ -72,6 +72,8 @@ module Auditable
       # only save if it's different from before
       if !audit.same_audited_content?(last_saved_audit)
         audit.save
+      else
+        audits.delete(audit)
       end
     end
 

data/lib/auditable/version.rb

@@ -1,3 +1,3 @@
 module Auditable
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/lib/auditable_spec.rb

@@ -8,8 +8,8 @@ end
 
 describe Auditable do
   let(:survey) { Survey.create :title => "test survey" }
-  let(:user) { User.create(:name => "test user") }
-  let(:another_user) { User.create(:name => "another user") }
+  let(:user) { User.create :name => "test user" }
+  let(:another_user) { User.create :name => "another user" }
 
   it "should have a valid audit to start with" do
     survey.title.should == "test survey"
@@ -17,6 +17,19 @@ describe Auditable do
     survey.audits.last.action.should == "create"
   end
 
+  it "should work when we have multiple audits created per second (same created_at timestamps)" do
+    require 'timecop'
+    Timecop.freeze do
+      survey.update_attributes :title => "new title 1"
+      survey.update_attributes :title => "new title 2"
+      survey.audited_changes.should == {"title" => ["new title 1", "new title 2"]}
+      survey.update_attributes :title => "new title 3"
+      survey.update_attributes :title => "new title 4"
+      survey.update_attributes :title => "new title 5"
+      survey.audited_changes.should == {"title" => ["new title 4", "new title 5"]}
+    end
+  end
+
   context "for existing records without existing audits" do
     before do
       survey.audits.delete_all
@@ -155,7 +168,7 @@ describe Auditable do
   context "no changes on audited attributes" do
     it "should not create new audits" do
       survey.save
-      expect { survey.save }.to_not change { survey.audits.count }
+      expect { 3.times { survey.save } }.to_not change { survey.audits.count }
     end
   end
 

metadata

@@ -1,146 +1,123 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: auditable
-version: !ruby/object:Gem::Version 
-  hash: 25
+version: !ruby/object:Gem::Version
+  version: 0.1.2
   prerelease: 
-  segments: 
-  - 0
-  - 1
-  - 1
-  version: 0.1.1
 platform: ruby
-authors: 
+authors:
 - Harley Trung
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-04-11 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-05-24 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: rake
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &2156001580 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: rspec
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *2156001580
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: &2155999120 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 2
-        version: "2"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '2'
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: watchr
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: *2155999120
+- !ruby/object:Gem::Dependency
+  name: watchr
+  requirement: &2155994600 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: sqlite3
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: *2155994600
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: &2155992820 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: yard
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  version_requirements: *2155992820
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: &2155991880 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id005
-- !ruby/object:Gem::Dependency 
+  prerelease: false
+  version_requirements: *2155991880
+- !ruby/object:Gem::Dependency
   name: rdiscount
+  requirement: &2155990760 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
   prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  version_requirements: *2155990760
+- !ruby/object:Gem::Dependency
+  name: timecop
+  requirement: &2155989640 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id006
-- !ruby/object:Gem::Dependency 
-  name: activesupport
   prerelease: false
-  requirement: &id007 !ruby/object:Gem::Requirement 
+  version_requirements: *2155989640
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: &2155987940 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
-        - 0
-        version: "3.0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :runtime
-  version_requirements: *id007
-- !ruby/object:Gem::Dependency 
-  name: activerecord
   prerelease: false
-  requirement: &id008 !ruby/object:Gem::Requirement 
+  version_requirements: *2155987940
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: &2155986140 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
-        - 0
-        version: "3.0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :runtime
-  version_requirements: *id008
-description: A simple gem that audit models' attributes or methods by taking snapshots and diff them for you. Starting from scratch to work with Rails 3.2.2 onwards
-email: 
+  prerelease: false
+  version_requirements: *2155986140
+description: A simple gem that audit models' attributes or methods by taking snapshots
+  and diff them for you. Starting from scratch to work with Rails 3.2.2 onwards
+email:
 - harley@socialsci.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .rspec
 - .rvmrc
@@ -165,38 +142,29 @@ files:
 - specs.watchr
 homepage: https://github.com/harleyttd/auditable
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
 rubygems_version: 1.8.17
 signing_key: 
 specification_version: 3
 summary: A simple gem to audit attributes and methods in ActiveRecord models.
-test_files: 
+test_files:
 - spec/lib/auditable_spec.rb
 - spec/spec_helper.rb
 - spec/support/models.rb